Trading with non-villager mobs (specifically vanilla mobs) | The Fabric Project | Page 1

jagged torrent Dec 30, 2024, 5:44 AM

#

Or just open up a custom gui with an evoker is right clicked

modest matrix Dec 30, 2024, 6:04 AM

#

Yes, it would be possible. I would recommend using the UseEntityCallback or whatever fapi calls it

jagged torrent Dec 30, 2024, 7:49 AM

#

modest matrix Yes, it would be possible. I would recommend using the UseEntityCallback or what...

all implementations of createScreenHandlerFactory online seem to be for blocks is there any page on doing for whatever?

#

public static void registerEvokerInteractions() {
        UseEntityCallback.EVENT.register((player, world, hand, entity, hitResult) -> {
            if (
                    !player.isSpectator()
                    && entity.getType().equals(EntityType.EVOKER)
                    && player.hasStatusEffect(ModEffects.HERO_OF_THE_PILLAGE)
            ) {
                if (!world.isClient) {
                    NamedScreenHandlerFactory screenHandlerFactory = //createScreenHandlerFactoryImplementation();
                }
            }
            return ActionResult.SUCCESS;
        });
    }

#

this is what i have so far

vital nova Dec 30, 2024, 12:39 PM

#

there is MerchantScreenHandler, which you can turn into a NamedScreenHandlerFactory using SimpleNamedScreenHandlerFactory, this is how vanilla does it.

vanilla example for villager:

player.openHandledScreen(
            new SimpleNamedScreenHandlerFactory((syncId, playerInventory, playerx) -> new MerchantScreenHandler(syncId, playerInventory, this), name)
        );

(this is at Merchant#sendOffers(), if you want to see more of how vanilla does it)

jagged torrent Dec 30, 2024, 8:47 PM

#

vital nova there is MerchantScreenHandler, which you can turn into a NamedScreenHandlerFact...

can I use the screenhandlercontext to get the recipemanager

candid warren Dec 30, 2024, 9:39 PM

#

@jagged torrent What version are you working with? Because I'm making something similar for 1.21.4 and already have everything but the actual trades working (it had the trading screen before but I changed it, it should be pretty easy to add trades back tho)

jagged torrent Dec 30, 2024, 10:04 PM

#

candid warren <@400983997188014080> What version are you working with? Because I'm making some...

1.20.1

jagged torrent Dec 30, 2024, 10:04 PM

#

jagged torrent can I use the screenhandlercontext to get the recipemanager

so far this is what I came up with

#

but it returns an Optional<Optional<EnchantmentConversionRecipe>

#

should I just use a series of .get()'s to extract the recipe from the optional?

#

that seems risky

#

but I dont see another way with my setup

#

Optional<Optional<EnchantmentConversionRecipe>> recipe = context.get((world, pos) -> world.getRecipeManager().getFirstMatch(EnchantmentConversionRecipe.Type.INSTANCE, this.input, world));

this.result.setStack(0, new ItemStack(recipe.get().get().getOutput()));
``` this seems cursed

jagged torrent Dec 31, 2024, 12:04 AM

#

can you not use enchanted books in recipes?

#

does it have to be hardcoded

modest matrix Dec 31, 2024, 12:12 AM

#

context.get(
  (world, pos) -> world.getRecipeManager()
      .getFirstMatch(
        RecipeType.BLASTING, 
        this.input, 
        world
      )
)
.flatMap(Function.identity())
.map(recipe -> recipe.getOutput())
.ifPresentOrElse(
        stack -> this.result.setStack(0, stack),
        () -> this.result.setStack(0, ItemStack.EMPTY)
);
``` try something like this?

jagged torrent Dec 31, 2024, 12:14 AM

#

modest matrix ```java context.get( (world, pos) -> world.getRecipeManager() .getFirstM...

is this for the message above the message above?

#

ok

jagged torrent Dec 31, 2024, 12:18 AM

#

modest matrix ```java context.get( (world, pos) -> world.getRecipeManager() .getFirstM...

im getting red for the setStack method

modest matrix Dec 31, 2024, 12:18 AM

#

jagged torrent im getting red for the `setStack` method

oops

#

fixed 👍

#

had to shim it to get the compiler to stop screaming at me

jagged torrent Dec 31, 2024, 12:18 AM

#

oh

#

ok

modest matrix Dec 31, 2024, 12:20 AM

#

var stack = context.get(
  (world, pos) -> world.getRecipeManager()
      .getFirstMatch(
        RecipeType.BLASTING, 
        this.input, 
        world
      )
)
.flatMap(Function.identity())
.map(recipe -> recipe.getOutput())
.orElse(ItemStack.EMPTY);

this.result.setStack(0, stack);
``` something like this might also work, if you like it better?

jagged torrent Dec 31, 2024, 12:21 AM

#

it looks nice but im still not sure how to use enchanted books in recipes

modest matrix Dec 31, 2024, 12:21 AM

#

ah

#

you said 1.20.1?

jagged torrent Dec 31, 2024, 12:21 AM

#

yes

modest matrix Dec 31, 2024, 12:21 AM

#

hmm.

#

rough.

jagged torrent Dec 31, 2024, 12:21 AM

#

im converting a vanilla enchant to a modded enchant

#

with the recipe

#

or recipes

modest matrix Dec 31, 2024, 12:21 AM

#

so both result and input?

jagged torrent Dec 31, 2024, 12:21 AM

#

yes

modest matrix Dec 31, 2024, 12:21 AM

#

concerning 🙂

jagged torrent Dec 31, 2024, 12:22 AM

#

:)! ! !! !

modest matrix Dec 31, 2024, 12:22 AM

#

I haven't done this in a minute.

jagged torrent Dec 31, 2024, 12:22 AM

#

o

modest matrix Dec 31, 2024, 12:24 AM

#

what does your matcher look like rn?

jagged torrent Dec 31, 2024, 12:25 AM

#

?

#

the match function in recipemanager for 1.20.1?

modest matrix Dec 31, 2024, 12:25 AM

#

👍

jagged torrent Dec 31, 2024, 12:25 AM

#

#

not sure why its red

#

but this is vanilla

modest matrix Dec 31, 2024, 12:26 AM

#

it's okay

#

I meant the one in your recipe?

#

if there is one in that version?

#

Recipe#matches

jagged torrent Dec 31, 2024, 12:27 AM

#

modest matrix I meant the one in your recipe?

I dont have a matcher in my recipe class

modest matrix Dec 31, 2024, 12:27 AM

#

okay

#

describe a recipe to me? EnchantedBook{SHARPNESS:5} -> EnchantedBook{CUSTOM:5}?

jagged torrent Dec 31, 2024, 12:28 AM

#

something like that

modest matrix Dec 31, 2024, 12:28 AM

#

jagged torrent something like that

okay

jagged torrent Dec 31, 2024, 12:28 AM

#

exactly liek that

modest matrix Dec 31, 2024, 12:30 AM

#

var enchantment =  Enchantments.AQUA_AFFINITY;
var enchantmentResult = Enchantments.BINDING_CURSE;
var stack = Items.DIAMOND_HELMET.getDefaultStack();
int level = EnchantmentHelper.getLevel(enchantment, stack);
if (level > 0) {
    var map = EnchantmentHelper.get(stack);
    map.remove(enchantment);
    map.put(enchantmentResult, 1);
    EnchantmentHelper.set(map, stack);
}

#

something like that?

#

or what is something else the problem?

jagged torrent Dec 31, 2024, 12:32 AM

#

modest matrix ```java var enchantment = Enchantments.AQUA_AFFINITY; var enchantmentResult = E...

what does that do

modest matrix Dec 31, 2024, 12:33 AM

#

if the stack has AQUA_AFFINITY, it replaces AQUA_AFFINITY with BINDING_CURSE on the stack

jagged torrent Dec 31, 2024, 12:34 AM

#

sorry that is not what I am trying to do

#

well it could work

#

but the input can only accept singular enchantment enchanted books

#

so it could replace the enchantment with the modded one

#

on a book

#

does that work

modest matrix Dec 31, 2024, 12:35 AM

#

I'm not sure I understand what the poblem is?

#

the code I've provided is an example

#

it should work with all items

#

?

jagged torrent Dec 31, 2024, 12:36 AM

#

but isnt that hardcoded

modest matrix Dec 31, 2024, 12:36 AM

#

it doesn't have to be though

#

it's up to you to un hardcode it

#

it's hardcoded to make it easy to understand

#

if there is something you don't understand about how, I'd be glad to help with that

jagged torrent Dec 31, 2024, 12:37 AM

#

so I am using slots and an update function in a screenhandler to handle the crafting

#

in the update function is where the recipe would go

#

how would I create a list of enchantments match another list of enchantments without using traditional recipes

#

because you cant use a normal json file right

#

and I dont want it to replace what is in the input

#

I want a new book in the output

#

so I already cleared the input in my code

#

using slots

jagged torrent Dec 31, 2024, 12:40 AM

#

modest matrix ```java context.get( (world, pos) -> world.getRecipeManager() .getFirstM...

I am just missing a version of this that works for enchantments

#

so I can make a list of "recipes"

#

without having to use a switch statement 💀

#

for each enchantment pair

#

that is my problem

modest matrix Dec 31, 2024, 12:41 AM

#

a Map from Enchantment to Enchantment

#

with a get Default method

jagged torrent Dec 31, 2024, 12:42 AM

#

where do I store the map

#

I have never used them before

modest matrix Dec 31, 2024, 12:42 AM

#

idk

jagged torrent Dec 31, 2024, 12:43 AM

#

can I use a json file

lyric heath Dec 31, 2024, 2:39 AM

#

If you want to

#

Maps are a basic programming concept, there's plenty of info on them.

jagged torrent Dec 31, 2024, 6:07 AM

#

lyric heath Maps are a basic programming concept, there's plenty of info on them.

this is my solution to the problem

private void updateResult() {
        ItemStack inputStack = this.input.getStack(0);
        ItemStack outputStack = new ItemStack(Items.ENCHANTED_BOOK);

        if (inputStack.isEmpty()) {
            this.result.setStack(0, ItemStack.EMPTY);
        } else {
            NbtList nbtList = inputStack.getEnchantments();

            for (int i = 0; i < nbtList.size(); i++) {

                NbtCompound nbtCompound = nbtList.getCompound(i);

                Identifier inputEnchantment = EnchantmentHelper.getIdFromNbt(nbtCompound);
                int level = EnchantmentHelper.getLevelFromNbt(nbtCompound);

                Enchantment outputEnchantment;
                if (inputEnchantment != null && inputEnchantment.equals(Registries.ENCHANTMENT.getId(Enchantments.SHARPNESS))) {

                    float chance = random.nextFloat();
                    if (chance < 0.1) {

                        outputEnchantment = ModEnchants.BLEEDING;

                    } else {

                        outputEnchantment = ModEnchants.DULLNESS;

                    }

                } else {

                    outputEnchantment = this.alternativeEnchantMap.get(inputEnchantment);

                }

                EnchantedBookItem.addEnchantment(outputStack, new EnchantmentLevelEntry(outputEnchantment, level));
            }

            this.result.setStack(0, outputStack);
        }

        this.sendContentUpdates();
    }

#

I just iterate over the enchantments and apply them to a map

#

then apply the new enchants to a book

#

sharpness gets special treatment with randomness

#

but I think im done

#

here is my above definition of the map

jagged torrent Dec 31, 2024, 6:09 AM

#

jagged torrent here is my above definition of the map

of course I do not like this solution because this looks longer than it needs to be
but im forced to use identifiers with "getStuffFromNbt"

jagged torrent Jan 5, 2025, 1:18 AM

#

vital nova there is MerchantScreenHandler, which you can turn into a NamedScreenHandlerFact...

so this is valid?

player.openHandledScreen(
  new SimpleNamedScreenHandlerFactory((syncId, playerInventory, playerx) ->
    new EvokerScreenHandler(
      syncId,
      playerInventory,
      ScreenHandlerContext.create(world, entity.getBlockPos())
    ), entity.getDisplayName())
);

#

inside of useEntityCallback implementation event register

#

btw my screen does not appear when this is called

#

no crashing just no response

lyric heath Jan 5, 2025, 1:50 AM

#

jagged torrent no crashing just no response

You've made the screen, but you haven't set the screen for the player

jagged torrent Jan 5, 2025, 2:08 AM

#

lyric heath You've made the screen, but you haven't set the screen for the player

oh

#

I thought that's what openScreenHandler did

#

I looked on the documentation for what I need to do

#

how do I set the screen aswell?

lyric heath Jan 5, 2025, 2:11 AM

#

Oh I'm blind I didn't see the first line

modest matrix Jan 5, 2025, 2:12 AM

#

jagged torrent so this is valid? ```java player.openHandledScreen( new SimpleNamedScreenHandl...

Are you checking logical side properly?

jagged torrent Jan 5, 2025, 2:16 AM

#

modest matrix Are you checking logical side properly?

like checking for client

jagged torrent Jan 5, 2025, 3:25 AM

#

modest matrix Are you checking logical side properly?

I check if the world is not client before openHandledScreen

#

still no screen

jagged torrent Jan 5, 2025, 4:27 AM

#

is there a problem with my screenhandler?

#

or how I register the screenhandler

jagged torrent Jan 5, 2025, 7:09 AM

#

lol...

#

I never registered the actual handled screen.....

#

only the screenhandler....

#

lol i never implemented quickmove so i crashed my game

#

thats not a problem for here tho

#Trading with non-villager mobs (specifically vanilla mobs)