Loot Table generation with drop conditions | The Fabric Project | Page 1

steel raptor Dec 12, 2024, 7:42 PM

#

[1.21] I have a 3 wide multi-block, which I only want the middle block to drop the item. I want the json file to look similar to this:

  "type": "minecraft:block",
  "pools": [
    {
      "rolls": 1,
      "entries": [
        {
          "type": "minecraft:item",
          "name": "turingcomplete:full_adder"
        }
      ],
      "conditions": [
        {
          "condition": "minecraft:survives_explosion"
        },
        {
          "block": "turingcomplete:full_adder",
          "condition": "minecraft:block_state_property",
          "properties": {
            "part": "middle"
          }
        }
      ]
    }
  ]
}```
Specifically, I want the 
```{
          "block": "turingcomplete:full_adder",
          "condition": "minecraft:block_state_property",
          "properties": {
            "part": "middle"
          }```

How do I make that happen with datagen? 
```@Override
    public void generate() {
        ...
        addDrop(blockInit.FULL_ADDER, drops(blockInit.FULL_ADDER));
        ...
    }```
I have this, but this doesn't add the condition that I want. What do I change/add to this?

spark raptor Dec 12, 2024, 8:21 PM

#

You will probably get the pleasure of pooling it yourself

steel raptor Dec 13, 2024, 8:56 AM

#

What do you mean?

steel raptor Dec 13, 2024, 10:01 AM

#

I've found dropsWithProperty(Block drop, Property<T> property, T value), seems like that would be helpful? I can't figure out how to use the parameters though. Is that even the right function? I figured I'd use it in place of the addDrop() function

ebon birch Dec 13, 2024, 1:45 PM

#

Does the full adder block have any properties? what is the condition you want to change the block drops with?

steel raptor Dec 13, 2024, 6:31 PM

#

It's got the BLOCKPART property, a property I made to keep track of what part of the block it represents. I want it to drop if it is the MIDDLE part, which is shown in the json code I sent

#

I just want the data gen to generate that, so I don't have to go in manually and replace that file with my manually written one

spark raptor Dec 13, 2024, 6:35 PM

#

it can, look into LootPool and LootCondition

ebon birch Dec 13, 2024, 9:48 PM

#

steel raptor It's got the BLOCKPART property, a property I made to keep track of what part of...

So you should call the mentioned function dropsWithProperty give it the alternative drop, then the property that can be with the value MIDDLE, than the MIDDLE value, if you send where you create the block (with its class code) and where you coded your property I can tell you exacly what you should call that method with

steel raptor Jan 20, 2025, 9:15 PM

#

ebon birch So you should call the mentioned function `dropsWithProperty` give it the altern...

Been a while, I'm sorry for bringing this up again... I'm trying to do it like this, but it doesn't seem to be correct: addDrop(blockInit.FULL_ADDER, dropsWithProperty(blockInit.FULL_ADDER,BLOCK_PART,MIDDLE));
The problem lies with BLOCK_PART apparently: "Expression expected".

How do I properly syntax this function?

gleaming linden Jan 20, 2025, 9:22 PM

#

what is BLOCK_PART?

steel raptor Jan 20, 2025, 9:34 PM

#

That's my property that can have the value MIDDLE

#

But I can't use that, the syntax is wrong apparently

#

No idea how to make it work :,)

steel raptor Jan 20, 2025, 9:55 PM

#

steel raptor That's my property that can have the value `MIDDLE`

it defines what part of the 3 wide multi-block it is, middle, top or bottom. I want the block only to drop for the middle block

steel raptor Jan 22, 2025, 9:26 AM

#


import net.minecraft.util.StringIdentifiable;

public enum BLOCK_PART implements StringIdentifiable {
    TOP("top"),
    MIDDLE("middle"),
    BOTTOM("bottom");

    private final String name;

    BLOCK_PART(String name) {
        this.name = name;

    }
    public String toString() {
            return this.name;
    }

    @Override
    public String asString() {
            return this.name;
    }
}

This is how I had defined BLOCK_PART

gleaming linden Jan 22, 2025, 1:20 PM

#

so this one is done without helper methods:

        this.lootTables.put(RegistryKey.of(RegistryKeys.LOOT_TABLE, Identifier.of("mymod","someblock")),
                LootTable.builder().type(LootContextTypes.BLOCK)
                    .pool(
                            LootPool.builder()
                                .rolls(ConstantLootNumberProvider.create(1.0f))
                                .conditionally(SurvivesExplosionLootCondition.builder())
                                .conditionally(
                                    BlockStatePropertyLootCondition.builder(Blocks.OAK_LOG)
                                        .properties(StatePredicate.Builder.create().exactMatch(Properties.AXIS, Direction.Axis.X))
                                )
                                .with(ItemEntry.builder(Items.OAK_LOG))
                    )
        );

#

it uses a manually generated registrykey, which means its not inside the block folder of loot table, but you can change that. in fact, you can pick apart most of this to use with helpers

steel raptor Jan 22, 2025, 5:46 PM

#

I'm confused, where would I put this piece of code?

#

What is "this"?

#

I have a data generation file that points to a loot table generating file, where I have a generate() function, in which I have addDrop() for all the item recipes I want, and then I was trying addDrop(blockInit.FULL_ADDER, dropsWithProperty(blockInit.FULL_ADDER,BLOCK_PART,MIDDLE)); which evidently doesn't work :,)

gleaming linden Jan 23, 2025, 12:00 AM

#

that code is inside the generate method

#

have you checked the way vanilla uses the addDrop method?

#Loot Table generation with drop conditions