Can't port 2 mods from 1.20.4 to 1.21

[indigo quail]

I already did that, so I thought it will be easy because these mods are client-side and just for visuals.
I tried to change versions in all files (including jars inside) but that didn't work. I tried manually replace cores inside to updated one, but didn't find any of them online.
What can I do to port them?

Old potions - mod that replaces new potion colors and glint to old one;
Bedrock waters - replaces visual water mechanics from bedrock to java

Resource packs aren't suitable for me, so please don't suggest them.

https://modrinth.com/mod/bedrockwaters
https://modrinth.com/mod/oldpotions
(if you don't like jar files don't download them)

[little needle]

don't post random jar files

[reef garnet]

decompile the mods, fix any issues with the code and recompile them form 1.21

[little needle]

https://github.com/2Retr0/BedrockWaters

https://github.com/Abbie5/oldpotions

both are open source, you don't need to decompile anything

you'll have to go through the code and what's changed

[reef garnet]

oh lol

[little needle]

fair warning, both deal with rendering which did change a bit

[indigo quail]

I already did, but I don't know what specific issues are there. I tried to search in logs but didn't find anything

[reef garnet]

do they compile?

[indigo quail]

yep ig

[reef garnet]

can you send the logs... let's see if i can guess what is wrong

[indigo quail]

ok, one sec

https://mclo.gs/gL3scDO

[16:40:46] [main/WARN]: Found 2 non-fabric mods:
- Old Potions-fabric-1.21-2.5.jar
- bedrockwaters-1.8.0+1.21.jar

this is the only thing it shows

[reef garnet]

those are not compiled for fabric

try them with forge

or quilt ig

wait this shit doesn't make sense... see if the gradle config of the mod is right

here... did you change theese

[indigo quail]

i am dumass and uploaded jars without changes

[reef garnet]

lol

[indigo quail]

i think I can't try both of them at the same time, cuz bedrock waters is only for fabric/quilt, and old potions is only for fabric/forge/neoforge

Maybe I just skipped some versions because there was just * instead of version

maybe that's the reason

And I just changed version in MANIFEST.MF which i successfully forgot about

[little needle]

you should not be changing those...

[indigo quail]

Which one? With *?

[little needle]

none of those. those are loader level dependency checks.

you seem to be missing the important part. did you do any code changes?

[indigo quail]

I can’t start with that cuz logs don’t show anything yet. Fabric loader doesn’t recognise them as fabric mods for some reason.
I only changed versions from 1.20.4 to 1.21.

[little needle]

how are you testing these? it's extremely unlikely the run configuration is doing something wrong

[indigo quail]

I just load in game and open latest.log.
Ig I’m doing it wrong

[little needle]

you are. you should be running it from your IDE

[indigo quail]

Can you please explain to me what it is? I am new to Java moding (only bedrock Addons bruh) so I can miss a lot of stuff

[little needle]

sorry but if you don't know what an IDE is, you have a lot to learn

do you know java?

[indigo quail]

Partially, I coded specifically in json