need help making a cloak item | The Fabric Project | Page 1

visual mountain Dec 1, 2024, 11:02 AM

#

simply put it, i'm trying to make a cloak item where if the user wears it they become fully invis, no fire damage visible, no armor/item (if possible) and the playername/player itself too. lastly i'd want to make it so when someone else sleeps in a bed, the invis player is visible and the sleeping player is in a spectator type pov untill they wake up

forest bone Dec 1, 2024, 1:53 PM

#

ok, so thats your goal, what blocker are you running into? what are you stuck on and unable to figure out? we may be able to help guide you through whatever it is

visual mountain Dec 1, 2024, 1:55 PM

#

the mixin process to make the player invisible

forest bone Dec 1, 2024, 1:59 PM

#

EntityRendererDispatcher#shouldRender calls the renderer's shouldRender method. EntityRenderer#shouldRender calls the entity's shouldrender method. OtherClientPlayerEntity does do some overriding here but Entity can be used to return false conditionally

PlayerEntityRenderer has shouldRenderFeatures which shouldnt be an issue but if you find that armor is rendering and such, thats why

visual mountain Dec 1, 2024, 2:02 PM

#

now to translate that into code lmao

forest bone Dec 1, 2024, 2:03 PM

#

good luck. if you run into any more blockers let me know

visual mountain Dec 1, 2024, 2:26 PM

#

i've heard something about a multibugger or something (im working in 1.19.2)

forest bone Dec 1, 2024, 2:29 PM

#

no idea what a multibugger is. can you describe it?

visual mountain Dec 1, 2024, 2:29 PM

#

*multiBufferSource

forest bone Dec 1, 2024, 2:31 PM

#

in what context do you need that

visual mountain Dec 1, 2024, 2:33 PM

#

ngl got no idea what i'm doin ```java
@Mixin({PlayerEntity.class})
public abstract class LivingEntityRendererMixin<T extends LivingEntity, M extends EntityModel<T>> {
@Shadow public abstract Iterable<ItemStack> getArmorItems();

private void render(T livingEntity, float yaw, float tickDelta, EntityPose poseStack, int light, CallbackInfo ci) {
    if (livingEntity instanceof PlayerEntity player) {
        ArrayList<ItemStack> items = Lists.newArrayList(this.getArmorItems());
        if (items.contains(ModItems.CLOAK)) {
            ci.cancel();
        }
    }
}

}```

forest bone Dec 1, 2024, 2:35 PM

#

all methods you put into a mixin class are copied into the target class[es]

@Mixin({PlayerEntity.class})
the mixin annotation indicates what class your changes are being made to

@Shadow lets you declare a field or method that exists in the target class so you can call it from your mixin code

looks like you are a bit confused so lets break it down into pieces

#

what class are you trying to change?

visual mountain Dec 1, 2024, 2:36 PM

#

i guess just the general renderer that is supposed to show the player, if player is on fire, and the shadow of the player

forest bone Dec 1, 2024, 2:39 PM

#

ok, so lets start with the first thing, preventing the player from rendering.

for this, i have said that Entity#shouldRender is called. so lets say you want to modify the Entity class. your @Mixin annotation should have Entity.class in it

visual mountain Dec 1, 2024, 2:40 PM

#

right,

forest bone Dec 1, 2024, 2:41 PM

#

next, lets fix the name and such of your class. for this, i would recommend either the target class name with Mixin suffix, or a purposeful name.
examples:
EntityMixin
InvisibilityCloakEntityMixin

#

since Entity is the base class (no parents), you dont need to extend anything

visual mountain Dec 1, 2024, 2:43 PM

#

@Mixin({Entity.class})
public abstract class InvisibilityCloakEntityMixin { <-?

forest bone Dec 1, 2024, 2:43 PM

#

yep

#

now, the next step is to figure out what method you want to change.

inside of a Mixin class you can annotate your methods to tell the mixin processor how and where you want to call that method.

#

which method do you want your code to interact with/be called from/modify

visual mountain Dec 1, 2024, 2:45 PM

#

i assume the default render class?

forest bone Dec 1, 2024, 2:47 PM

#

nope, not class

#

we are within the Entity class

#

what method in the Entity class

visual mountain Dec 1, 2024, 2:49 PM

#

(side note) playStepSound sounds like it'd be cool to overwrite with it aswell

#

i found should render

#

public boolean shouldRender(double cameraX, double cameraY, double cameraZ) {
        double d = this.getX() - cameraX;
        double e = this.getY() - cameraY;
        double f = this.getZ() - cameraZ;
        double g = d * d + e * e + f * f;
        return this.shouldRender(g);
    }

    public boolean shouldRender(double distance) {
        double d = this.getBoundingBox().getAverageSideLength();
        if (Double.isNaN(d)) {
            d = (double)1.0F;
        }

        d *= (double)64.0F * renderDistanceMultiplier;
        return distance < d * d;
    } ```

forest bone Dec 1, 2024, 2:55 PM

#

ok, so the first one is called from the render dispatcher, the 2nd is called from the first. the 2nd is overridden in a child class so the first is probably what you want to change.

#

so, method will be shouldRender with the proper arguments. are you using IntelliJ with the MinecraftDevelopment plugin?

visual mountain Dec 1, 2024, 2:56 PM

#

i should yeah

forest bone Dec 1, 2024, 2:56 PM

#

ok good

visual mountain Dec 1, 2024, 2:57 PM

#

forest bone Dec 1, 2024, 2:57 PM

#

so now its time to figure out how you want to modify the method. that will determine which annotation you use

#

so with the following information, how would you modify the method?
your running code is running inside the entity that it wants to render
you can modify variables, method calls, return values, arguments, etc

public boolean shouldRender(double cameraX, double cameraY, double cameraZ) {
        double d = this.getX() - cameraX;
        double e = this.getY() - cameraY;
        double f = this.getZ() - cameraZ;
        double g = d * d + e * e + f * f;
        return this.shouldRender(g);
}

visual mountain Dec 1, 2024, 3:00 PM

#

i want to (while the entity is wearing the cloak) make it invisible (and if possible) only visible at like the corner of someone's screen

forest bone Dec 1, 2024, 3:02 PM

#

ok, lets do the "no render" part first, and deal with the FoV and frustum thing later

#

so, you are wanting to tell the game that it should not render conditionally, so you want to change the return value of the method based on some if statement(s) ?

visual mountain Dec 1, 2024, 3:05 PM

#

gotta check that the chestplate slot (or helmet not quite sure which one to pick yet, i was thinking of maybe using trinkets for this) holds the cloak item

forest bone Dec 1, 2024, 3:08 PM

#

alright, so i would use a @ModifyReturnValue annotation here.
that tells Mixin that you want to change the return value of the method (really just describes itself)

each mixin method annotation has at a minimum a method parameter, telling it which method to put code in and an at parameter, telling it where to put code inside the method

#

so an example might be
@ModifyReturnValue(method="getName", at=@At("RETURN")) which would modify the return value of the getName method for every place that method returns something

#

the @At("RETURN") there is shorthand for @At(value="RETURN")
the longer form is used when you need to tell the @At more info such as when you want to put code anytime the method invokes (calls) a specific method

visual mountain Dec 1, 2024, 3:12 PM

#

alright

#

so it kinda looks like this rn? ```java
@Mixin({Entity.class})
public abstract class InvisibilityCloakEntityMixin {

@ModifyReturnValue(method="shouldRender", at=@At("RETURN"))

@Shadow public abstract double getX();

@Shadow public abstract double getY();

@Shadow public abstract double getZ();

@Shadow
public static double getRenderDistanceMultiplier() {
    return 0;
}

@Shadow public abstract Box getBoundingBox();

public boolean shouldRender(double cameraX, double cameraY, double cameraZ) {
    double d = this.getX() - cameraX;
    double e = this.getY() - cameraY;
    double f = this.getZ() - cameraZ;
    double g = d * d + e * e + f * f;
    return this.shouldRender(g);
}

private boolean shouldRender(double distance) {
    double d = this.getBoundingBox().getAverageSideLength();
    if (Double.isNaN(d)) {
        d = (double)1.0F;
    }

    d *= (double)64.0F * getRenderDistanceMultiplier();
    return distance < d * d;
}

}```

forest bone Dec 1, 2024, 3:15 PM

#

alright, you dont need to put those methods in the mixin, but since you are going to modify them you need to know what they are, thats all. you can remove everything after @ModifyReturnValue(method="shouldRender", at=@At("RETURN")) before the last }

#

you should also let mcdev autocomplete the shouldRender in the method to select the one that takes 3 doubles

visual mountain Dec 1, 2024, 3:16 PM

#

turns into this

forest bone Dec 1, 2024, 3:16 PM

#

yep good

#

the next step is to make the method that does the checking and returns the new return value. Mixin methods are primarily private (with some special exceptions for interfaces and parent mixin classes)

the @ModifyReturnValue expects to annotate a method that returns the same type as the method you are modifying. it also expects that method to take the original return value as a parameter.

so you need a method that:
is private
returns a boolean
takes in the original boolean as an argument

your method should fallback on returning the original boolean if you are not handling it (such as if they are not wearing the cloak)

visual mountain Dec 1, 2024, 3:24 PM

#

i brought back the shadow, because i find it easier if i can just get the armor items and loop through that. ```java
@Shadow
public abstract Iterable<ItemStack> getArmorItems();

ArrayList<ItemStack> items = Lists.newArrayList(this.getArmorItems());
private boolean shouldRender(boolean og) {

    return items.contains(ModItems.CLOAK);
}```

#

this is the cloak item class btw, it's literally nothign

forest bone Dec 1, 2024, 3:35 PM

#

so, Entity doesnt have a getArmorItems method, so you cant shadow it
you also should not just add a list of items to the class

visual mountain Dec 1, 2024, 3:37 PM

#

this is in the entity class

#

but i hear what ya sayin

forest bone Dec 1, 2024, 3:37 PM

#

hm, thats in Entity?

visual mountain Dec 1, 2024, 3:38 PM

#

ye

forest bone Dec 1, 2024, 3:38 PM

#

interesting, must have been removed later

visual mountain Dec 1, 2024, 3:39 PM

#

they prob thought, let's make it more annoying!

#

or it got name changed/redundant

forest bone Dec 1, 2024, 3:39 PM

#

lol, more like "Entity is a base class and not all entities have equipment, fireballs for example have no equipment"

visual mountain Dec 1, 2024, 3:40 PM

#

welp; it makes it easier in this instance ig

forest bone Dec 1, 2024, 3:42 PM

#

your code should look something like

  Iterator<ItemStack> itemIterator = getArmorItems().iterator();
  while (itemIterator.hasNext()) {
    ItemStack stack = itemIterator.next();
    // YOUR CHECK HERE
  }

#

you dont want to be building a list object every render frame

visual mountain Dec 1, 2024, 3:44 PM

#

error, hasNext shouldn't be there for some reason

forest bone Dec 1, 2024, 3:45 PM

#

did you get the first line?

visual mountain Dec 1, 2024, 3:46 PM

#

yes

forest bone Dec 1, 2024, 3:46 PM

#

can you show the whole method

#

(that should all be in your annotated method

#

    private boolean shouldRender(boolean og) {
      Iterator<ItemStack> itemIterator = getArmorItems().iterator();
      while (itemIterator.hasNext()) {
...

visual mountain Dec 1, 2024, 3:49 PM

#

well now it works lmfao

#

    @Shadow public abstract Iterable<ItemStack> getArmorItems();
    private boolean shouldRender(boolean og) {
        Iterator<ItemStack> itemIterator = getArmorItems().iterator();
        while (itemIterator.hasNext()) {
            if (itemIterator.equals(ModItems.CLOAK)) {
                return false;
            }
        }
        return true;
    }```

#

that's it kinda looks rn

forest bone Dec 1, 2024, 3:51 PM

#

instead of return true besure to return the original return value

visual mountain Dec 1, 2024, 3:52 PM

#

coz og can also be false?

forest bone Dec 1, 2024, 3:52 PM

#

yep

visual mountain Dec 1, 2024, 3:52 PM

#

right, that's now done

forest bone Dec 1, 2024, 3:52 PM

#

and other mods might be doing the same thing and you want to return their value if so

#

alright, now to make your item equippable 😛

#

i guess holding it in your hand should still work for testing

visual mountain Dec 1, 2024, 3:53 PM

#

@ModifyReturnValue(method="shouldRender(DDD)Z", at=@At("RETURN")); this line still gives me an error of sorts

#

forest bone Dec 1, 2024, 3:55 PM

#

show the whole class. i expect that annotation is not right above the method

#

@ModifyReturnValue(...)
private boolean shouldRender(boolean og) {
...

visual mountain Dec 1, 2024, 3:56 PM

#


import com.llamalad7.mixinextras.injector.ModifyReturnValue;
import com.zrollus.bd.item.ModItems;
import net.minecraft.entity.Entity;
import net.minecraft.item.ItemStack;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.Shadow;
import org.spongepowered.asm.mixin.injection.At;
import java.util.Iterator;

@Mixin({Entity.class})
public abstract class InvisibilityCloakEntityMixin {

    @ModifyReturnValue(method="shouldRender(DDD)Z", at=@At("RETURN"));

    @Shadow public abstract Iterable<ItemStack> getArmorItems();
    private boolean shouldRender(boolean og) {
        Iterator<ItemStack> itemIterator = getArmorItems().iterator();
        while (itemIterator.hasNext()) {
            if (itemIterator.equals(ModItems.CLOAK)) {
                return false;
            }
        }
        return og;
    }
}

forest bone Dec 1, 2024, 3:56 PM

#

the annotation is annotating the method to tell mixin that your "shouldRender" method is to be interacted with a specific way

#

the shadow can go above that

visual mountain Dec 1, 2024, 3:57 PM

#

shadow is above it rn

forest bone Dec 1, 2024, 3:57 PM

#

yeah, swap the locationsof the @ModifyReturnValue line and the @Shadow line

visual mountain Dec 1, 2024, 3:57 PM

#

forest bone Dec 1, 2024, 3:58 PM

#

no ;

visual mountain Dec 1, 2024, 3:58 PM

#

that'd be it lol

#

used to always having a ;

#

public static final Item CLOAK = registerItem("cloak", new ArmorItem(cloakMaterial, EquipmentSlot.HEAD, new Item.Settings().group(ModItemGroup.BuildersDelight).fireproof())); <- this is btw how i'm registering the item

forest bone Dec 1, 2024, 3:59 PM

#

ah ok, so you arent using your cloak class at all anyway

visual mountain Dec 1, 2024, 4:00 PM

#

not yet because i haven't (till now) found a reason to use it

#

since technically it doesn't seem required for what i'm trying to achieve

#

btw do i have to call the mixin at all or does it sorta start automatically

forest bone Dec 1, 2024, 4:11 PM

#

the mixin class needs to be pointed to in the mixin json file

mixin itself will read the json, load your mixin class, read the annotations and modify the target class according to the annotations you wrote

visual mountain Dec 1, 2024, 4:19 PM

#

why do i have the slight feeling the game is not able to load into a world now?

#

coz its trying but crashing

forest bone Dec 1, 2024, 4:19 PM

#

whats the crash message

visual mountain Dec 1, 2024, 4:20 PM

#

not a crash message, more just it's frozen

forest bone Dec 1, 2024, 4:20 PM

#

oh...just to check, did you update your mixin json to remove the old name and make sure the new name was there?

also the console should be showing what its doing

visual mountain Dec 1, 2024, 4:20 PM

#

#

it said failed after force closing the game

forest bone Dec 1, 2024, 4:21 PM

#

i would suggest once you get it tested you move that to the client section rather than the mixins section

visual mountain Dec 1, 2024, 4:26 PM

#

if it does end up crashing again i shall say, (Example mixin got broke for some reason)

#

it repeats to just freeze when entering a world

#

aka when the client is supposed to see the world

#

[17:26:21] [Server thread/INFO] (Minecraft) Player698[local:E:7709087c] logged in with entity id 69 at (43.0886720511649, 56.0, -77.80153982327381)
[17:26:21] [Server thread/INFO] (Minecraft) Player698 joined the game
[17:26:21] [Render thread/INFO] (Minecraft) Loaded 0 advancements

#

last msgs in logs

forest bone Dec 1, 2024, 4:27 PM

#

i have a feeling i know whats going on. did you move the mixin to client?

visual mountain Dec 1, 2024, 4:27 PM

#

yes

forest bone Dec 1, 2024, 4:27 PM

#

cool

visual mountain Dec 1, 2024, 4:27 PM

#

forest bone Dec 1, 2024, 4:29 PM

#

in the shouldRender mixin method, at the top, add the following check:

if (!((Entity)(Object)this instanceof OtherClientPlayerEntity)) return og;

#

basically, only check inventories of other players

visual mountain Dec 1, 2024, 4:29 PM

#

like so?

forest bone Dec 1, 2024, 4:29 PM

#

yeah

visual mountain Dec 1, 2024, 4:30 PM

#

it was probably constantly looping over all inventories of all entities

forest bone Dec 1, 2024, 4:30 PM

#

you could alternatively set it to PlayerEntity instead of OtherClientPlayerEntity to test third person if you dont have another player to test with lol

#

(personally, i would probably handle it via status effect, but i dont know if those are synced to other clients without checking)

visual mountain Dec 1, 2024, 4:30 PM

#

i'll try playerEntity coz it's faster

#

i won't try it because issue returns

forest bone Dec 1, 2024, 4:33 PM

#

what is the yellow its giving for itemIterator?

visual mountain Dec 1, 2024, 4:33 PM

#

freeze happens for both players once they're close to eachother

forest bone Dec 1, 2024, 4:42 PM

#

oh, you didnt set the itemstack

visual mountain Dec 1, 2024, 4:43 PM

#

...

forest bone Dec 1, 2024, 4:43 PM

#

ItemStack stack = itemIterator.next();

#

so the iterator never progresses so the while loop is infinite

visual mountain Dec 1, 2024, 4:44 PM

#

i put that in the loop but not in the if right?

forest bone Dec 1, 2024, 4:44 PM

#

  Iterator<ItemStack> itemIterator = getArmorItems().iterator();
  while (itemIterator.hasNext()) {
    ItemStack stack = itemIterator.next();
    // YOUR CHECK HERE
  }

the stack is what you should be checking against your item

#

stack.getItem().equals or stack.isOf

visual mountain Dec 1, 2024, 4:46 PM

#

alr, testin

#

that works!

forest bone Dec 1, 2024, 4:47 PM

#

woo!

visual mountain Dec 1, 2024, 4:47 PM

#

i have to eat dinner, but now im curious how either A trinkets could be involved and/or B, the vision thing would work.

#

the only dependancy i've used ever is gecko

forest bone Dec 1, 2024, 4:51 PM

#

move the check into some helper method that can check tinkers and inventory slots. the trinket slot would need to be synced to other players, not sure if they are.

move the mixin into EntityRenderer
target EntityRenderer#shouldRender
there should be a check in there for leashed or visible entities. you can use WrapOperation on the frustum.isVisible call to adjust some things there if needed, too

#

the Frustum is used to determine if something is in the FoV of the player.
some of the methods in Frustum are private, but you can do your own check there with intersectAab. it should return FrustumIntersection.INTERSECT (-1) if the entity is only partiall in "view" but not fully encompassed in the visible space

#

if you want to do that, you can use an invoker mixin in the Frustum class to let you call the method by casting

visual mountain Dec 1, 2024, 5:15 PM

#

you can assume i'm probably gonna need that step by step like a kaupenjoe tutorial

visual mountain Dec 1, 2024, 5:49 PM

#

(currently just trying to check for the item)

strong notch Dec 1, 2024, 6:18 PM

#

forest bone 1. move the check into some helper method that can check tinkers and inventory s...

-# Lin is goat

visual mountain Dec 1, 2024, 6:35 PM

#

having trouble with checking for the trinket slot

forest bone Dec 1, 2024, 6:36 PM

#

you added trinket as a dependency in your build.gradle?

visual mountain Dec 1, 2024, 6:40 PM

#

yes, i have trinkets in the game, the issue is checking for the item,

forest bone Dec 1, 2024, 6:40 PM

#

remind me again what mc version you are using

visual mountain Dec 1, 2024, 6:40 PM

#

current attempt

#

1.19.2

#

private boolean isEquipped = false;


    private void IsEquipped(Iterator<ItemStack> itemIterator) {
        while (itemIterator.hasNext()) {
            ItemStack stack = itemIterator.next();
            if (stack.getItem().equals(ModItems.CLOAK)) {
                this.isEquipped = true;
            } else {
                isEquipped = false;
            }
        }
    }``` i did add this

forest bone Dec 1, 2024, 6:42 PM

#

first thing to be careful of is the casting.

#

instead of the iterator, you should take in the entity

visual mountain Dec 1, 2024, 6:44 PM

#

in the IsEquipped?

forest bone Dec 1, 2024, 6:44 PM

#

yeah

visual mountain Dec 1, 2024, 6:44 PM

#

ok? brings me to ask why

forest bone Dec 1, 2024, 6:45 PM

#

your isEquipped method should check if the item is equipped, right?
you dont need to iterate the trinket slots manually

visual mountain Dec 1, 2024, 6:46 PM

#

aight, so like this?

forest bone Dec 1, 2024, 6:50 PM

#

boolean hasTrinketEquipped = TrinketsApi.getTrinketComponent()
  .map(component->component.isEquipped(stack->stack.isOf(YOURITEM)))
  .orElse(false);

something like that should work for the trinkets

it gets the Optional from trinkets
then it uses Optional's map (which will map the contained value if its not null/empty) to check if one of the trinket slots has it equipped
then it gets the value if it has one or returns false

visual mountain Dec 1, 2024, 6:51 PM

#

put that in the if or is it literally just another bool that we can return

forest bone Dec 1, 2024, 6:51 PM

#

if you want to check player equipment slots also, you can do that if trinkets returns false, for example

visual mountain Dec 1, 2024, 6:51 PM

#

forest bone Dec 1, 2024, 6:53 PM

#

where is that?

#

(in the code i posted)

visual mountain Dec 1, 2024, 6:53 PM

#

forest bone Dec 1, 2024, 6:54 PM

#

you didnt pass it an entity

#

and that should be inside a method

visual mountain Dec 1, 2024, 6:55 PM

#

error persists

#

(has to be living entity)

forest bone Dec 1, 2024, 6:57 PM

#

ugh ok, 1 sec that should be an easy fix but i want to make sure trinkets didnt account for it

visual mountain Dec 1, 2024, 7:01 PM

#

thing is, the thing you said is in their docs, but somewhat they said nuh uh

forest bone Dec 1, 2024, 7:01 PM

#

you may need to add cardinal components to your build.gradle, as well

visual mountain Dec 1, 2024, 7:01 PM

#

oh yeh, that's a mod i know from doctor4t's mods

#

gotta make sure that's version 5.1.0

forest bone Dec 1, 2024, 7:02 PM

#

5.1.0 is for 1.19.3

visual mountain Dec 1, 2024, 7:02 PM

#

it works on 1.19.2

#

for some reason

forest bone Dec 1, 2024, 7:03 PM

#

i would not develop against something that says its not for the version you are developing on

visual mountain Dec 1, 2024, 7:03 PM

#

ok, would 5.2.2 work?

forest bone Dec 1, 2024, 7:03 PM

#

nope

#

(thats even higher...)

visual mountain Dec 1, 2024, 7:04 PM

#

then how tf do the mods (quilted fabric api) work with them

#

that are on 1.19.2

#

eg, befoul

forest bone Dec 1, 2024, 7:04 PM

#

again, not saying it wont work, i am saying that issues may come up because they didnt release that version for 1.19.2 so players wont be using the newer versions

#

develop against what players will be using

visual mountain Dec 1, 2024, 7:04 PM

#

5.0.2 also exists in one of the mods

#

that would work right?

forest bone Dec 1, 2024, 7:08 PM

#

it should

visual mountain Dec 1, 2024, 7:11 PM

#

i added it

#

and the error just despawned coz of it

#

@Mixin({Entity.class})
public abstract class InvisibilityCloakEntityMixin {
    private boolean isEquipped = false;
    private void IsEquipped(Entity entity) {
        boolean hasTrinketEquipped = TrinketsApi.getTrinketComponent((LivingEntity)entity)
                .map(component->component.isEquipped(stack->stack.isOf(ModItems.CLOAK)))
                .orElse(false);
        if (!hasTrinketEquipped) {
            Iterator<ItemStack> itemIterator = getArmorItems().iterator();
            while (itemIterator.hasNext()) {
                ItemStack stack = itemIterator.next();
                if (stack.getItem().equals(ModItems.CLOAK)) {
                    this.isEquipped = true;
                } else {
                    isEquipped = false;
                }
            }
        }
        else {
            isEquipped = true;
        }
    }

    @Shadow public abstract Iterable<ItemStack> getArmorItems();

    @ModifyReturnValue(method="shouldRender(DDD)Z", at=@At("RETURN"))

    private boolean shouldRender(boolean og) {
        if (!((Entity)(Object)this instanceof PlayerEntity)) return og;
        Iterator<ItemStack> itemIterator = getArmorItems().iterator();
        return !isEquipped;
    }
}```

#

this is what it looks like

forest bone Dec 1, 2024, 7:14 PM

#

you can make IsEquipped take in a LivingEntity and do the cast from the mixin

#

@Mixin({Entity.class})
public abstract class InvisibilityCloakEntityMixin {
    private boolean IsEquipped(PlayerEntity entity) {
        boolean hasTrinketEquipped = TrinketsApi.getTrinketComponent(entity)
                .map(component->component.isEquipped(stack->stack.isOf(ModItems.CLOAK)))
                .orElse(false);
        if (hasTrinketEquipped) return true;
        Iterator<ItemStack> itemIterator = getArmorItems().iterator();
        while (itemIterator.hasNext()) {
            ItemStack stack = itemIterator.next();
            if (stack.getItem().equals(ModItems.CLOAK)) {
                return true;
            }
        }
        return false;
    }

    @Shadow public abstract Iterable<ItemStack> getArmorItems();

    @ModifyReturnValue(method="shouldRender(DDD)Z", at=@At("RETURN"))

    private boolean shouldRender(boolean og) {
        if (!((Entity)(Object)this instanceof PlayerEntity playerEntity)) return og;
        return isEquipped(playerEntity)?false:og;
    }
}

something like this

visual mountain Dec 1, 2024, 7:18 PM

#

last line IsEquipped but yes

#

trust?

forest bone Dec 1, 2024, 7:20 PM

#

you can check the logic and see if it makes sense

visual mountain Dec 1, 2024, 7:20 PM

#

doesn't make sense imo

#

but it does

forest bone Dec 1, 2024, 7:21 PM

#

!isEquipped && og means:
if it is not equipped, and it was originally supposed to render, then render
if it was not equipped and original supposed to not render, dont render
if it was equipped, do not render

#

true && true = true
false && false = false
false && true = false

visual mountain Dec 1, 2024, 7:22 PM

#

so simplify good

#

error

#

forest bone Dec 1, 2024, 7:27 PM

#

that seems to be saying that the wrong fabric api is being pulled in

visual mountain Dec 1, 2024, 7:28 PM

#

huh...

#

might be in mixture with cardinal components

#

even tho it's just doing this, i might have to downgrade the loader

forest bone Dec 1, 2024, 7:29 PM

#

cardinal components is doing it

#

you need to filter fabric stuff from them

#

modImplementation(cardinalcomponentsstuff) {
    exclude group: "net.fabricmc.fabric-api"
})

#

you might also need to exclude the group net.fabricmc since they are doing the same thing for loader concern

visual mountain Dec 1, 2024, 7:37 PM

#

forest bone Dec 1, 2024, 7:37 PM

#

can you show the rest of the error?

#

(or the latest.log from the run/logs folder)

visual mountain Dec 1, 2024, 7:38 PM

#

📎 latest.log

forest bone Dec 1, 2024, 7:39 PM

#

fabric 0.58.0+1.19

is that the right fabric api for your version of mc?

visual mountain Dec 1, 2024, 7:39 PM

#

it's the one it auto selects

forest bone Dec 1, 2024, 7:39 PM

#

what autoselects?

visual mountain Dec 1, 2024, 7:39 PM

#

forest bone Dec 1, 2024, 7:39 PM

#

oh, you are developing for 1.19 not 1.19.2?

visual mountain Dec 1, 2024, 7:40 PM

#

well

#

lets say i forgot to update api

#

lmao

forest bone Dec 1, 2024, 7:40 PM

#

mc is also running 1.19....

visual mountain Dec 1, 2024, 7:40 PM

#

and somehow it works in a 1.19.2 modpack

forest bone Dec 1, 2024, 7:40 PM

#

minecraft_version=1.19.2
yarn_mappings=1.19.2+build.28
loader_version=0.16.9

# Fabric API
fabric_version=0.77.0+1.19.2

vs

minecraft_version=1.19
yarn_mappings=1.19+build.4
loader_version=0.16.9

# Fabric API
fabric_version=0.58.0+1.19

#

the problem is when you start trying to mix and match versions of things you run into issues

#

some stuff works, some doesnt, and its a toss up whether your mod will even compile let alone run

visual mountain Dec 1, 2024, 7:42 PM

#

true

#

cardinal is very dependant on correct version

forest bone Dec 1, 2024, 7:43 PM

#

the problem is that cardinal components is pulling in a specific version of a submodule of fabric api and its newer than yours

visual mountain Dec 1, 2024, 7:43 PM

#

welp, that works now

visual mountain Dec 1, 2024, 7:44 PM

#

forest bone the Frustum is used to determine if something is in the FoV of the player. some...

im afraid of how difficult the ^^ is gonna be

forest bone Dec 1, 2024, 7:44 PM

#

lol

visual mountain Dec 1, 2024, 7:45 PM

#

coz idek what the heck frustum is

#

and how the hecc to implement

forest bone Dec 1, 2024, 7:53 PM

#

in this instances its basically "the visible area of the camera"

strong notch Dec 1, 2024, 7:53 PM

#

There is a debug renderer that visualizes frustum pretty well

visual mountain Dec 1, 2024, 7:57 PM

#

still dunno the how, but i assume there's docs for it

#

https://maven.fabricmc.net/docs/yarn-21w05b+build.8/net/minecraft/client/render/Frustum.html oh wow

Frustum (yarn API)

declaration: package: net.minecraft.client.render, class: Frustum

#

don't close this yet, it's like 9pm, been working on this stuff since the morning and i've got school tomorrow, so will prob ask help tomorrow evenin

visual mountain Dec 1, 2024, 8:16 PM

#

resending as a note move the mixin into EntityRenderer target EntityRenderer#shouldRender there should be a check in there for leashed or visible entities. you can use WrapOperation on the frustum.isVisible call to adjust some things there if needed, too the Frustum is used to determine if something is in the FoV of the player. some of the methods in Frustum are private, but you can do your own check there with intersectAab. it should return FrustumIntersection.INTERSECT (-1) if the entity is only partiall in "view" but not fully encompassed in the visible space if you want to do that, you can use an invoker mixin in the Frustum class to let you call the method by casting

#

why does it need to be entityrenderer actually, we're technically only checking the player

forest bone Dec 1, 2024, 8:45 PM

#

inside the renderer's check is where the frustum is checked for entity culling. we can use the frustum passed into that check for our own (reverse) culling check

visual mountain Dec 2, 2024, 3:57 PM

#

will i need to use this? or the actual frustum doc

#

#

im assuming the actual doc coz of IsVisible

#

or this

visual mountain Dec 2, 2024, 5:53 PM

#

ngl shi makes no sense at all, even with the docs

forest bone Dec 2, 2024, 9:37 PM

#

thinking about it, it might just make more sense to calculate the difference in rotation angle from the camera and angle to the player and depending on FOV make them visible

#

(if you dont want to deal with an accessor to get the frustum's intersects to calculate the intersection with the player bounding box

visual mountain Dec 3, 2024, 6:55 PM

#

would you mind, like quickly, (like before) helping with the code

#

reaction the realest thing ever

visual mountain Dec 4, 2024, 5:30 PM

#

kind reminder as even if you say that stuff im just mouth gaping wide open atm

harsh panther Dec 4, 2024, 6:29 PM

#

visual mountain resending as a note ```move the mixin into EntityRenderer target EntityRenderer#...

i assume you were inspired by charter by arathain

visual mountain Dec 4, 2024, 6:30 PM

#

yes

harsh panther Dec 4, 2024, 6:30 PM

#

and im pretty sure the version thats public is open source

#

so go ahead and take a look

#

i dont know if they had that feature pre rewrite

visual mountain Dec 4, 2024, 6:30 PM

#

i checked, doesn't have those items

harsh panther Dec 4, 2024, 6:30 PM

#

ah

visual mountain Dec 4, 2024, 6:30 PM

#

it's the 0.0.1 beta hence i wanted to make it for myself, (privatised mod not to upset the csmp peeps)

#

at first i thought it'd be fairly easy, up until i realised it aint

harsh panther Dec 4, 2024, 6:50 PM

#

from what i know most the csmp mods are pretty unoptimized

#

so they probably just reversed the culling render effect with some slighty inaccurate values

visual mountain Dec 4, 2024, 6:56 PM

#

advice from the fabric gods tells me to use enderman logic

#

boolean isPlayerStaring(PlayerEntity player) {
        ItemStack itemStack = (ItemStack)player.getInventory().armor.get(3);
        if (itemStack.isOf(Blocks.CARVED_PUMPKIN.asItem())) {
            return false;
        } else {
            Vec3d vec3d = player.getRotationVec(1.0F).normalize();
            Vec3d vec3d2 = new Vec3d(this.getX() - player.getX(), this.getEyeY() - player.getEyeY(), this.getZ() - player.getZ());
            double d = vec3d2.length();
            vec3d2 = vec3d2.normalize();
            double e = vec3d.dotProduct(vec3d2);
            return e > (double)1.0F - 0.025 / d ? player.canSee(this) : false;
        }
    }```

strong notch Dec 4, 2024, 7:09 PM

#

Player#canSee was just mentioned in another channel

visual mountain Dec 4, 2024, 7:09 PM

#

indeed, but im in rendering channel for this atm

strong notch Dec 4, 2024, 7:10 PM

#

visual mountain indeed, but im in rendering channel for this atm

Oops lol

visual mountain Dec 4, 2024, 7:15 PM

#

ngl, i launched 2 mc clients at once nearly killed my pc lmao

#

so euhm, i kinda accidentally made everyone invis, (oopsies)

#

quick problem check? ```java
@Mixin({Entity.class})
public abstract class InvisibilityCloakEntityMixin {
private boolean IsEquipped(PlayerEntity entity) {
boolean hasTrinketEquipped = TrinketsApi.getTrinketComponent(entity)
.map(component->component.isEquipped(stack->stack.isOf(ModItems.CLOAK)))
.orElse(false);
if (hasTrinketEquipped) return true;
Iterator<ItemStack> itemIterator = getArmorItems().iterator();
while (itemIterator.hasNext()) {
ItemStack stack = itemIterator.next();
if (stack.getItem().equals(ModItems.CLOAK)) {
return true;
}
}
return false;
}
boolean isPlayerStaring(PlayerEntity player) {
Vec3d vec3d = player.getRotationVec(1.0F).normalize();
Vec3d vec3d2 = new Vec3d(this.getX() - player.getX(), this.getEyeY() - player.getEyeY(), this.getZ() - player.getZ());
double d = vec3d2.length();
vec3d2 = vec3d2.normalize();
double e = vec3d.dotProduct(vec3d2);
return e > (double)1.0F - 0.025 / d ? player.canSee((Entity)(Object)this) : false;
}
@Shadow public abstract Iterable<ItemStack> getArmorItems();

@Shadow public abstract double getX();

@Shadow public abstract double getEyeY();

@Shadow public abstract double getZ();

@ModifyReturnValue(method="shouldRender(DDD)Z", at=@At("RETURN"))

private boolean shouldRender(boolean og) {
    if (!((Entity)(Object)this instanceof OtherClientPlayerEntity playerEntity)) return og;
    return !IsEquipped(playerEntity) && isPlayerStaring(playerEntity) && og;
}

}```

strong notch Dec 4, 2024, 7:19 PM

#

visual mountain quick problem check? ```java @Mixin({Entity.class}) public abstract class Invisi...

That would make sense

visual mountain Dec 4, 2024, 7:19 PM

#

i had !isPlayerStaring, maybe i should make it an or stateent or smth?

#

or add an if

strong notch Dec 4, 2024, 7:21 PM

#

visual mountain i had !isPlayerStaring, maybe i should make it an or stateent or smth?

Currently, you only render if the player is looking exactly at the entity

visual mountain Dec 4, 2024, 7:21 PM

#

yes, i am trying to make it so it's not onscreen, so isseen is prob better

strong notch Dec 4, 2024, 7:21 PM

#

strong notch Currently, you only render if the player is looking exactly at the entity

Later on, you may want to look into submixin or instance of checks to ensure you only affect things that can wear your cloak

visual mountain Dec 4, 2024, 7:21 PM

#

could you link to the msg you saw it in

strong notch Dec 4, 2024, 7:22 PM

#

visual mountain could you link to the msg you saw it in

I'm not sure I understand

visual mountain Dec 4, 2024, 7:23 PM

#

strong notch Player#canSee was just mentioned in another channel

this

#

the thing is, i think i'll need a different class because it needs to check it from every (other player) pov

#

unless that already does it here

strong notch Dec 4, 2024, 7:38 PM

#

visual mountain the thing is, i think i'll need a different class because it needs to check it f...

Wouldn't you be doing it only for the clients player?

visual mountain Dec 4, 2024, 7:38 PM

#

the thing already gets from other pov

#

OtherClientPlayerEntity

#

this means it gets it from other clients and only renders on other clients

visual mountain Dec 5, 2024, 12:10 PM

#

so i just need to calculate if it sees another player, and you can say frustum all you want, idk how to use it

harsh panther Dec 5, 2024, 1:30 PM

#

frustum is the culling method minecraft uses to hide entities outside of players fov

#

thats as far as my knowledge goes tho

#

i assume it uses like an fov variable

#

so you could probably make a mixin with the reverse effect of the culling

#

but like minus the fov by a bit

#need help making a cloak item