Handling chunk concurrency CME | The Fabric Project | Page 1

azure storm · 2024-11-09T13:18:38.658Z

Continuation from https://discord.com/channels/507304429255393322/507982478276034570/1304789252307157012

azure storm Nov 9, 2024, 1:18 PM

#

Continuation from #mod-dev-1 message

#

so the server thread calls https://media.discordapp.net/attachments/507982478276034570/1304796483513749605/image.png?ex=6730b1eb&is=672f606b&hm=afe7ba42969b5ffdf1f99d861795c487ffdf35a63591626e5f23208780288e4f&=&format=webp&quality=lossless&width=533&height=357

#

and the worker thread called

#

!ym NoiseChunkGenerator.method_38332

dull stagBOT Nov 9, 2024, 1:21 PM

#

1.21.3 matches

Class Names

Official: edt
Intermediary: net/minecraft/class_3754
Yarn: net/minecraft/world/gen/chunk/NoiseChunkGenerator

Method Names

Official: a
Intermediary: method_38332
Yarn: method_38332

Yarn Method Descriptor

(Lnet/minecraft/world/chunk/Chunk;ILnet/minecraft/world/gen/chunk/GenerationShapeConfig;ILnet/minecraft/world/gen/chunk/Blender;Lnet/minecraft/world/gen/StructureAccessor;Lnet/minecraft/world/gen/noise/NoiseConfig;I)Lnet/minecraft/world/chunk/Chunk;
Yarn Access Widener

accessible method net/minecraft/world/gen/chunk/NoiseChunkGenerator method_38332 (Lnet/minecraft/world/chunk/Chunk;ILnet/minecraft/world/gen/chunk/GenerationShapeConfig;ILnet/minecraft/world/gen/chunk/Blender;Lnet/minecraft/world/gen/StructureAccessor;Lnet/minecraft/world/gen/noise/NoiseConfig;I)Lnet/minecraft/world/chunk/Chunk;
Yarn Mixin Target

Lnet/minecraft/world/gen/chunk/NoiseChunkGenerator;method_38332(Lnet/minecraft/world/chunk/Chunk;ILnet/minecraft/world/gen/chunk/GenerationShapeConfig;ILnet/minecraft/world/gen/chunk/Blender;Lnet/minecraft/world/gen/StructureAccessor;Lnet/minecraft/world/gen/noise/NoiseConfig;I)Lnet/minecraft/world/chunk/Chunk;
Javadoc

azure storm Nov 9, 2024, 1:21 PM

#

oh great it's a lambda

azure storm Nov 9, 2024, 1:22 PM

#

azure storm so the server thread calls https://media.discordapp.net/attachments/507982478276...

Now, question is, can I skip a packet

azure storm Nov 9, 2024, 1:41 PM

#

welp, I think I found a suprisingly not cursed solution

#

I wrapped sending the chunk with a try

#

and a counter of fails

#

then modified the chunk count packet to show the correct number

#

ah wait this wouldn't work

#

I mean it would partially work

#

the unlock happens on the work thread

#

this LockHelper is kinda stupid

#Handling chunk concurrency CME