I don`t know how to add a note to minecraft 1 20 1. | The Fabric Project | Page 1

sand depot Sep 3, 2024, 4:24 PM

#

I wanna do item, that shows a picture on the screen, when I click RMB. It must look like on pinned picture.

cunning otter Sep 3, 2024, 4:31 PM

#

https://docs.fabricmc.net/develop/rendering/gui/custom-screens

Custom Screens | Fabric Documentation

Learn how to create custom screens for your mod.

sand depot Sep 3, 2024, 4:34 PM

#

Ok, thanks. How I can do background transparent?

cunning otter Sep 3, 2024, 4:34 PM

#

...you don't draw a background?

sand depot Sep 3, 2024, 4:37 PM

#

Thnx

sand depot Sep 3, 2024, 7:10 PM

#

Okay, @cunning otter, I don`t know why it isnt works and how it must works. Maybe you can tell me how works use() event? Sorry if I too dumb, I m just beginner.

cunning otter Sep 3, 2024, 7:11 PM

#

What doesn't work?

sand depot Sep 3, 2024, 7:12 PM

#

I have this code

    public StrangeNote (Settings settings) {
        super(settings);
    }

    @Override
    public TypedActionResult<ItemStack> use(World world, PlayerEntity user, Hand hand) {
        if (world.isClient) {
            return TypedActionResult.pass(user.getStackInHand(hand));
    }
        MinecraftClient.getInstance().setScreen(
                new NoteInterface(Text.empty())
        );
        return TypedActionResult.success(user.getStackInHand(hand));
    }
}```

#

But "StrangeNote" in class and constructor is grey

#

cunning otter Sep 3, 2024, 7:14 PM

#

When you are registrering the item, replace Item with StrangeNote

sand depot Sep 3, 2024, 7:16 PM

#

There or where?

cunning otter Sep 3, 2024, 7:16 PM

#

new Item

sand depot Sep 3, 2024, 7:17 PM

#

new Item where?

cunning otter Sep 3, 2024, 7:18 PM

#

new Item

sand depot Sep 3, 2024, 7:21 PM

#

public static final Item STRANGE_NOTE = regItem("strange_note",** new StrangeNote**(new FabricItemSettings().maxCount(1)));

#

Like this?

#

I open menu (cursor been on the screen center), close on ESC, open again and game crashes with this error

#

@cunning otter
I see this
Caused by: java.lang.IllegalStateException: [fabric-screen-api-v1] The current screen (danilon4ig.infcraft.NoteInterface) has not been correctly initialised, please send this crash log to the mod author. This is usually caused by calling setScreen on the wrong thread.
I open menu (cursor been on the screen center), close on ESC, open again and game crashes with this error

cunning otter Sep 3, 2024, 7:32 PM

#

That is becuase you are opening the screen on the logical server, which is invalid. Only open screens if world.isClient == true

#

Why simply calling setScreen in use is not allowed: https://discord.com/channels/507304429255393322/1280577890299416730

sand depot Sep 3, 2024, 7:42 PM

#

Ok, i must use this, right?
#1280577890299416730 message

cunning otter Sep 3, 2024, 7:42 PM

#

yes

#

do you know why?

sand depot Sep 3, 2024, 7:43 PM

#

No...

cunning otter Sep 3, 2024, 7:44 PM

#

it's because Screen, MinecraftClient and more classes are only present on the client

#

if you try using them on the server, the server will crash

#

This way, all the code that uses those classes, are running only on the client thread

sand depot Sep 3, 2024, 7:45 PM

#

Ok, maybe I not that much dumb

#

I understood this

#

But where I must place this
somewhere during client initialization:
NoteOpener.setNoteOpener(() -> MinecraftClient.getInstance().setScreen(...));
then call as NoteOpener.getNoteOpener().openNoteScreen()

#

?

cunning otter Sep 3, 2024, 7:48 PM

#

Call NoteOpener.setNoteOpener(() -> MinecraftClient.getInstance().setScreen(...)); in ClientModInitializer.
Call NoteOpener.getNoteOpener().openNoteScreen() to open the screen.

sand depot Sep 3, 2024, 7:49 PM

#

Ok, one minute

#

I have few problems more

cunning otter Sep 3, 2024, 7:51 PM

#

yeah I posted psuedo code, you should be able to figure out the types

#

I think you will have to make it a class instead of an interface

sand depot Sep 3, 2024, 7:55 PM

#

I think too

cunning otter Sep 3, 2024, 7:56 PM

#

The idea is that you write the openNoteScreen code on the client, using MinecraftClient, Screen etc and tell a common class, class that exists on logical server and client, to use that code.

sand depot Sep 3, 2024, 7:57 PM

#

And it isn`t broke if I join to dedicated server or join to other peoples with mod?

cunning otter Sep 3, 2024, 7:57 PM

#

simpler version:

public class NoteOpener {
  public static Runnable openNoteScreen;
}```
then on client:
```java
NoteOpener.openNoteScreen = () -> MinecraftClient.getInstance().openScreen(...);

then to open screen:

NoteOpener.openNoteScreen.run();

cunning otter Sep 3, 2024, 7:58 PM

#

sand depot And it isn`t broke if I join to dedicated server or join to other peoples with m...

as long as you don't import client-only classes from non-client-only-classes it will work

sand depot Sep 3, 2024, 8:01 PM

#

Ok, there is only one problem right now

cunning otter Sep 3, 2024, 8:01 PM

#

it's probably setScreen

sand depot Sep 3, 2024, 8:02 PM

#

So my guess was correct. Perfect

#

Oh, and in parameter of setScreen must be NoteInterface, NoteOpener or something else?

cunning otter Sep 3, 2024, 8:06 PM

#

your screen

sand depot Sep 3, 2024, 8:08 PM

#

Ummm...

#

I tried to give parameter to constructor, but it still not work

cunning otter Sep 3, 2024, 8:09 PM

#

remember new when calling the constructor

sand depot Sep 3, 2024, 8:11 PM

#

I starting minecraft. Maybe now it was works

#

On 0.11 am

#

Mmm.

#

Crash on first RMB click

cunning otter Sep 3, 2024, 8:13 PM

#

interesting

sand depot Sep 3, 2024, 8:13 PM

#

Maybe problem in this&

cunning otter Sep 3, 2024, 8:13 PM

#

lol

sand depot Sep 3, 2024, 8:13 PM

#

What is Text.java?

#

In second line on screenshot

cunning otter Sep 3, 2024, 8:14 PM

#

Any text you see in the game is represented with a Text. It's like a String but with color and such.

#

Text.literal("Your Title") or Text.translatable("title.translation.key")

sand depot Sep 3, 2024, 8:16 PM

#

translation.key is like en_us, ru_ru?

cunning otter Sep 3, 2024, 8:16 PM

#

it's the key to look for in en_us.json or ru_ru.json, depending on which language you set in game

#

this way you can translate the text without writing any code

sand depot Sep 3, 2024, 8:17 PM

#

I understood... Yeah, i think yeah

#

On key I must write new key or key of my item?

#

I got crashes for

second
first
second
first
and more...

Opens of note

cunning otter Sep 3, 2024, 8:27 PM

#

It can be whatever lowercase letters separated with dot. There are some best-practices tho. I would put "screen.yourmodname.title": "The title"

sand depot Sep 3, 2024, 8:27 PM

#

I tried with literal(), It`s not help

cunning otter Sep 3, 2024, 8:27 PM

#

can you post the log file?

sand depot Sep 3, 2024, 8:28 PM

#

How I can get it from IDEA?

cunning otter Sep 3, 2024, 8:28 PM

#

run/logs/latest.log

sand depot Sep 3, 2024, 8:29 PM

#

📎 message.txt

cunning otter Sep 3, 2024, 8:30 PM

#

You are calling the openNoteScreen function from the server thread. Remember, you must check if world.isClient == true before trying to open the screen.

sand depot Sep 3, 2024, 8:34 PM

#

I do this and note not working now. Not work - no crash

cunning otter Sep 3, 2024, 8:35 PM

#

you are returning early if world.isClient

sand depot Sep 3, 2024, 8:36 PM

#

In NoteOpener?

cunning otter Sep 3, 2024, 8:36 PM

#

in the image you sent

sand depot Sep 3, 2024, 8:38 PM

#

cunning otter you are returning early if world.isClient

Upper? yes, when i copy this code from guide it`s been here. bottom - i tested a minute ago

cunning otter Sep 3, 2024, 8:39 PM

#

if (world.isClient) {
  return ...;
}

#

why?

sand depot Sep 3, 2024, 8:39 PM

#

I dont know

cunning otter Sep 3, 2024, 8:40 PM

#

don't copy code if you don't know why

sand depot Sep 3, 2024, 8:41 PM

#

I tried to read this on fabric wiki, but dont understood too

#

maybe we can try tomorrow? Because my timezone is GMT+4. What about ur timezone?

#

Just I wanna sleep in 1:00am

#

And I deleted this strange code

cunning otter Sep 3, 2024, 8:46 PM

#

no problem, I'll answer when I can

#

Remember, you must check if world.isClient == true before trying to open the screen.

sand depot Sep 3, 2024, 8:48 PM

#

Ok, thank you very much. Even my teachers couldn't stand me in this situation.

sand depot Sep 4, 2024, 2:36 PM

#

Hello, @cunning otter, now I try this and minecraft crashes, but it was not Immediately, world save and only after this game crashes (about 3sec)

cunning otter Sep 4, 2024, 2:37 PM

#

you can't just return null

sand depot Sep 4, 2024, 3:10 PM

#

But what I gonna return, and where?

cunning otter Sep 4, 2024, 3:36 PM

#

It looked good before with TypedActionResult.success(...)

sand depot Sep 4, 2024, 4:56 PM

#

Ok, I add return TypedActionResult.success(user.getStackInHand(hand));

#

It returns completed action&

#

?

#

IT WORKS!!!

#

And I close it on esc

#

Okay, @cunning otter, can you say me how add a picture and text to the note, please?

cunning otter Sep 4, 2024, 5:03 PM

#

Make a constant in your screen class holding the location of the texture. Then draw it in render

#

the location is in the form of an Identifier("<namepace>", "<location>") which means the texture is in assets/<namespace>/<location>, for example new Identifier(MOD_ID, "textures/gui/note.png")

sand depot Sep 4, 2024, 5:24 PM

#

new Identifier(MOD_ID, "textures/gui/note.png") must be there? (bottom of screenshot) and what type of constant?

#

@cunning otter or I gonna do two double constants?

cunning otter Sep 4, 2024, 5:27 PM

#

the constant is the location/identifier

sand depot Sep 4, 2024, 5:56 PM

#

And I gonna put them into new Identifier path parameter?

#

@cunning otter how I can render picture in render class?

cunning otter Sep 4, 2024, 6:11 PM

#

DrawContext#drawTexture

sand depot Sep 4, 2024, 6:16 PM

#

@cunning otter Maybe this?

cunning otter Sep 4, 2024, 6:17 PM

#

no, is there not a drawTexture?

sand depot Sep 4, 2024, 6:21 PM

#

Alright, is there

#

@cunning otter But what I gonna give to drawContext?

cunning otter Sep 4, 2024, 6:23 PM

#

you are given a drawContext in render

sand depot Sep 4, 2024, 6:24 PM

#

@Override
public void render(DrawContext context, int mouseX, int mouseY, float delta) {
    super.render(context, mouseX, mouseY, delta);
    new Identifier(MOD_ID, NOTE_BACKGROUND_CORDS);
    //DrawContext
}

It looks of my render method

sand depot Sep 4, 2024, 6:24 PM

#

cunning otter you are given a drawContext in render

Because I think, yes

#

@cunning otter What are you say about my butiful code)

cunning otter Sep 4, 2024, 6:27 PM

#

what?

sand depot Sep 4, 2024, 6:28 PM

#

sand depot > @Override > public void render(DrawContext context, int mouseX, int mo...

.

cunning otter Sep 4, 2024, 6:28 PM

#

DrawContext context

sand depot Sep 4, 2024, 6:28 PM

#

yes, is there

#

But what I can do with this?

cunning otter Sep 4, 2024, 6:29 PM

#

draw things

sand depot Sep 4, 2024, 6:30 PM

#

I mean, I began to understand

#

But for now I dont understand

#

@cunning otter how I can realize that? I think in another method, but can`t guess how

cunning otter Sep 4, 2024, 6:34 PM

#

context.drawTexture?

sand depot Sep 4, 2024, 6:35 PM

#

Oh Jesus... I`m too dumb for this world

#

How I don`t guess for this

#

Ooookayy... @cunning otter What`s Identifier texture, int u and int v in this method?

public void drawTexture(Identifier texture, int x, int y, int u, int v, int width, int height) {
this.drawTexture(texture, x, y, 0, (float)u, (float)v, width, height, 256, 256);
}

cunning otter Sep 4, 2024, 6:40 PM

#

texture is the path of the png, u v is where from the texture to draw from, u=x, v=y

sand depot Sep 4, 2024, 6:43 PM

#

Like there?

cunning otter Sep 4, 2024, 6:44 PM

#

the u,v in the image is correct

sand depot Sep 4, 2024, 6:44 PM

#

Or uv - is point on texture, and x, y - is point on canvas*

cunning otter Sep 4, 2024, 6:45 PM

#

exactly

sand depot Sep 4, 2024, 6:45 PM

#

Yey!

#

I dont know... Why is red!?

cunning otter Sep 4, 2024, 6:48 PM

#

cunning otter the location is in the form of an `Identifier("<namepace>", "<location>")` which...

this

sand depot Sep 4, 2024, 6:48 PM

#

@cunning otter What format of pass I gonna use?

#

Oh

#

It looks like something not too bad?

#

It`s not work(

cunning otter Sep 4, 2024, 6:52 PM

#

cunning otter Make a constant in your screen class holding the location of the texture. Then d...

this, to not instantiate a new Identifier every frame

#

width, height 1???

#

it's 1 px wide

sand depot Sep 4, 2024, 6:53 PM

#

It`s in px?

#

Oh...

#

I think it`s in % like 0.95 it 95%

#

And I understand now, its integer

#

If I press f3+T I reload mod?

cunning otter Sep 4, 2024, 6:56 PM

#

no

#

press build

sand depot Sep 4, 2024, 6:57 PM

#

This build?

#

@cunning otter and I can no restart the game, right?

cunning otter Sep 4, 2024, 7:00 PM

#

here

#

or right click in the file you edited

sand depot Sep 4, 2024, 7:01 PM

#

cunning otter Sep 4, 2024, 7:03 PM

#

are you debugging and not running?

sand depot Sep 4, 2024, 7:03 PM

#

Whats wrong with my IDE?

cunning otter Sep 4, 2024, 7:04 PM

#

I think you must be debugging

sand depot Sep 4, 2024, 7:04 PM

#

cunning otter are you debugging and not running?

Oh, yeah

#

I think too now

#

No

#

It isnt works

cunning otter Sep 4, 2024, 7:06 PM

#

🤷‍♂️

sand depot Sep 4, 2024, 7:07 PM

#

Maybe this is my problem?

#

@cunning otter What do u think?

cunning otter Sep 4, 2024, 7:13 PM

#

idk, just restart the game, no big deal

sand depot Sep 4, 2024, 7:13 PM

#

Its true

#

mixin make possible no restart game? If yes - problem with mixin

#

Today I found this interesting thing, look. I think you like it

#

https://github.com/TheCymaera/minecraft-spider

GitHub

GitHub - TheCymaera/minecraft-spider

Contribute to TheCymaera/minecraft-spider development by creating an account on GitHub.

#

@cunning otter It works, And I need only setting up resolution

#

#

Ok

#

@cunning otter resolution is 3840, 1080

cunning otter Sep 4, 2024, 7:26 PM

#

there is a method with x, y, u, v, width, height, i, j, where x y width height is where on the screen to draw, u v i j is where to sample the texture, i j = width height

sand depot Sep 4, 2024, 7:27 PM

#

ok, one minute

#

now there not texture

#

context.drawTexture(new Identifier(MOD_ID, "textures/gui/notebg.png"), 1, 1, 1, 1, 1920, 1080, 1920, 1080);

#

@cunning otter Or it`s not in px?

#

@cunning otter Are u here?

cunning otter Sep 4, 2024, 7:40 PM

#

no

sand depot Sep 4, 2024, 7:41 PM

#

: (

sand depot Sep 4, 2024, 7:42 PM

#

cunning otter no

It was magic discord thelepathy?

cunning otter Sep 4, 2024, 7:42 PM

#

stop pinging me

sand depot Sep 4, 2024, 7:43 PM

#

Ok, sorry. I wasn`t ping you anymore

sand depot Sep 4, 2024, 8:34 PM

#

I have one good news and one bad
good - I found what I gonna do to no restart mincraft client
bad - message.txt

📎 message.txt

#

when i tried to start vm

#

Vm options:

-Dfabric.dli.config=D:\InfCraft@@0020b@@0020f4nS.gradle\loom-cache\launch.cfg
-Dfabric.dli.env=client
-Dfabric.dli.main=net.fabricmc.loader.impl.launch.knot.KnotClient
-javaagent:"C:\Users\Админ.gradle\caches\modules-2\files-2.1\net.fabricmc\dev-launch-injector\0.2.1+build.8\da8bef7e6e2f952da707f282bdb46882a0fce5e3\dev-launch-injector-0.2.1+build.8.jar!\net\fabricmc\devlaunchinjector\Main.class"

#

I got this error

sand depot Sep 6, 2024, 6:56 AM

#

Hello, Nate, can u help me? I can’t setting my drawTexture, because i see texture, but always it’s not resolution, what I need

#

I use drawTexture with u, v parameters

#

And I tried big count of combinations of parameters

cunning otter Sep 6, 2024, 7:04 AM

#

cunning otter there is a method with x, y, u, v, width, height, i, j, where x y width height i...

Do you use this method?

sand depot Sep 6, 2024, 8:31 AM

#

yes

cunning otter Sep 6, 2024, 8:33 AM

#

What did you pass in?

sand depot Sep 6, 2024, 8:35 AM

#

I tried big count of params

#

I made my texture resolution 703, 861

#

context.drawTexture(new Identifier(MOD_ID, "textures/gui/notebg.png"), 1, 1, 1, 1, 703, 861, 50, 50);

#

cunning otter Sep 6, 2024, 8:39 AM

#

lemme draw in paint

cunning otter Sep 6, 2024, 9:04 AM

#

sand depot Sep 13, 2024, 6:17 PM

#

Hello again, I take small rest from small project and I can do this now

#

But it`s not enough, because it still looks rough

#

I have this result. P.s. I know how to fix y-axis

sand depot Sep 14, 2024, 10:03 AM

#

@cunning otter I have the next idea! I wanna make fog from alpha minecraft event. Do you have ideas how to make it?
P.s. Sorry for pinging👉 👈

#I don`t know how to add a note to minecraft 1 20 1.