Trying to mixin to ClientPacketListener | The Fabric Project | Page 1

nova spear Apr 4, 2024, 11:44 PM

#

hello - beginnner problem
posted earlier and got a solution that ended up not working. i can find net.minecraft.client.multiplayer.ClientPacketListener in my decompiled 1.20.4 code, but when i try to import it to a mixin class it can't find it. Advice/solutions?

daring lily Apr 4, 2024, 11:48 PM

#

That is for Minecraft and the packets the vanilla game listens to. If you are trying to send your own packets between the client and server, what you want to be looking at is ClientPlayNetworking and ServerPlayNetworking from FAPI. This allows you to register and listen to your own packets

nova spear Apr 4, 2024, 11:49 PM

#

i'm looking to intercept ClientboundSystemChatPacket s

#

and process them before the game does things with them

daring lily Apr 4, 2024, 11:51 PM

#

Ah, makes sense now.

#

Let me take a quick look at the code

nova spear Apr 4, 2024, 11:51 PM

#

thx <3

daring lily Apr 4, 2024, 11:54 PM

#

Hmm, I can't find anything named ClientBoundSystemChatPacket. Is that the correct name for the class or are you using Mojmap for mappings?

karmic swallow Apr 4, 2024, 11:55 PM

#

I found in Mojmaps ClientboundSystemChatPacket

daring lily Apr 4, 2024, 11:55 PM

#

I guess that would be ChatMessageS2CPacket in yarn?

karmic swallow Apr 4, 2024, 11:55 PM

#

In yarn it's GameMessage

daring lily Apr 4, 2024, 11:55 PM

#

Ah, ok

karmic swallow Apr 4, 2024, 11:55 PM

#

GameMessageS2CPacket

daring lily Apr 4, 2024, 11:56 PM

#

My guess, and correct me if I am wrong Sky, would Fred want to mixin where this data is being set on the client (I don't remember what class it's done in)

#

ClientPlayNetworkHandler#onGameMessage, yarn mapping?

nova spear Apr 4, 2024, 11:58 PM

#

uhhhhh ill look

#

im using the mappings you can find on the mc wiki

#

are there seperate ones for fabric?

daring lily Apr 4, 2024, 11:58 PM

#

Probably would be better to do it in MessageHandler#onGameMessage because that is where the actual logic is taking place. And ClientPlayNetworkHandler#onGameMessage calls that, yarn mappings

daring lily Apr 4, 2024, 11:59 PM

#

nova spear are there seperate ones for fabric?

Mojmap is provided by Mojang itself whereas Yarn is open source and maintained by Fabric https://github.com/FabricMC/yarn?tab=readme-ov-file#yarn

nova spear Apr 5, 2024, 12:00 AM

#

k

#

ty much love

karmic swallow Apr 5, 2024, 12:00 AM

#

daring lily My guess, and correct me if I am wrong Sky, would Fred want to mixin where this ...

~~Honestly I have no idea~~

nova spear Apr 5, 2024, 1:16 AM

#

daring lily Probably would be better to do it in `MessageHandler#onGameMessage` because that...

hey, sorry to bother again, but i've done all the troubleshooting and can confirm that's where I want to mixin. The issue that I get is that for some reason it tells me that the poackage doesnt exist error: package net.minecraft.client.network.message does not exist import net.minecraft.client.network.message.MessageHandler;

daring lily Apr 5, 2024, 1:17 AM

#

Can you post your mixin class?

nova spear Apr 5, 2024, 1:18 AM

#


import net.minecraft.client.network.message.MessageHandler;
import net.minecraft.text.Text;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;

@Mixin(MessageHandler.class)
public class PacketReaderMixin {

    @Inject(method = "onGameMessage", at = @At("HEAD"))
    private void init(Text message, boolean overlay, CallbackInfo ci) {
        System.out.println("test");
    }
}```

daring lily Apr 5, 2024, 1:19 AM

#

And the stacktrace of the error?

#

Are you using Yarn mappings?

nova spear Apr 5, 2024, 1:24 AM

#

yes

#

daring lily Apr 5, 2024, 1:26 AM

#

Hmm

#

Are you using split sources?

#

My guess would be no you are not because you are experiencing this error.

nova spear Apr 5, 2024, 1:31 AM

#

idk

daring lily Apr 5, 2024, 1:32 AM

#

Make sure you have this in your build.gradle:

loom {
    splitEnvironmentSourceSets()

    mods {
        "your-modid" {
            sourceSet sourceSets.main
            sourceSet sourceSets.client
        }
    }

}

nova spear Apr 5, 2024, 1:32 AM

#

yes

#

daring lily Apr 5, 2024, 1:33 AM

#

And your code is in src/client/...?

nova spear Apr 5, 2024, 1:33 AM

#

no its in src/main

#

ahhh i see

#

the main cant see client only shit

daring lily Apr 5, 2024, 1:33 AM

#

pretty much 🙂

nova spear Apr 5, 2024, 1:34 AM

#

i failed the idiot proofing

#Trying to mixin to ClientPacketListener