I want to use Charmonium on my 1.19.3 fabric instance but i have little knowledge on porting a mod. Anyone who knows please try to help me understand so I can try and do it on my fork of Charmonium
#Help me Build 1.19.3 Charmonium please
graceful mist
The source code for charmonium hasnt been updated since 1.18.1 so i am changing the title
Port Charmonium mod from 1.18.1 to 19.3
Port Charmonium mod source from 1.18.1 to 19.3
The curseforge page has jars for 1.19.2 but im not sure if its possible to un build them into source code
dusk yacht
@graceful mist I found the 1.19.3/4 branch on the GitHub.
graceful mist
THANKS that makes it soooo much easier
dusk yacht
You should be able to build it from source
graceful mist
yup and i thankfully know how to do that lol
you dont realise how helpful you have been
dusk yacht
No problem
graceful mist
godamn it it was just in the branches? I'm an idiot.
dusk yacht
Yeah, it’s fine we have all been there
graceful mist
I NEVER look at the branch lol
the dropdown blends in with the rest of the stuff lol
dusk yacht
Yeah sometimes it’s there for certain projects
I don’t know how branches work so I have never used them
graceful mist
same
wait that repo looks different
wheres all the gradle files
oh i found them
they are split fabric/forge
oh what it said it built but i cant find the jar
ok i built it again getting the error
"Could not find svenhjol.charm:charm_api-fabric-1.19.3:5.0.0."
Build 1.19.3 Charmonium
graceful mist
Help me Build 1.19.3 Charmonium please
dusk yacht
@graceful mist when I get home I could attempt to build it
graceful mist
k thanks
you have been such a big help to me
The source code does not seem complete
graceful mist
when i tried to build in the fabric folder it said it needed that common file so i put that in the fabric folder it said that it could not find what i mentioned before
The build.sh file tries to remove and then move a file that doesnt exist
setup_symlinks.sh mentions that it is required for GIT bash on windows
Oh hang on the build.sh file executes gradlew build
if i try and do that manually i could probably build it
oh wait i have a mac
i will try and build it now
graceful mist
running setup_symlinks and then build.sh i still get the error ""Could not find svenhjol.charm:charm_api-fabric-1.19.3:5.0.0.""
dusk yacht
I tried building it using Ubuntu on wsl, it didn’t build
graceful mist
ah
did it say it was missing charm core or whatever
i tried to add all of the missing files from 1.19.2 but it didnt fix it, and i can actually build 1.19.2
i also tried replacing the build files with the .2 ones but just edited them for 1.19.3 and it still didnt work
Although in the github i found an issue for 1.19.3 which means someone has built it
lucid viper
i would love to see a 1.19.4 build of charm and/or charmonium as well
hidden imp
i would love to see a 1.19.4 build of charm and/or charmonium as well
i found you
lucid viper
just saw your comment haha
hidden imp
i could not build the 1.19.4 branch
lucid viper
yeah, seems like both mods arent buildable yet
graceful mist
yeah
i got close buts its missing charm core
what i did was put the common folder into the fabric folder and build from there
hidden imp
I think we need to uptate from 1.19.2
I will try tomorrow
I am seeing tutorials of modding
graceful mist
ok
i tried to change the loom version and dependencies using that fabric mod helper in the gradle files but it wouldnt build
on the 1.19.2 versions
btw 1.19.2 is written as 1.19.x in the repo
ill put the dependencies here to make it easier(1.19.3)(fabric)
In gradle.properties
yarn_mappings=1.19.3+build.5
loader_version=0.14.19
#Fabric api
fabric_version=0.76.1+1.19.3```In build.gradle
Loom version 1.1-SNAPSHOT
In gradle.properties
Cloth config version: 9.0.94
Mod menu version 5.1.0-beta.4
Rei version 10.0.596
put them into the 1.19.2 files
Whats this meant to mean
lucid viper
i think you would need to ask in either #mod-dev-1 or #mod-dev-2 about this error
graceful mist
i think you would need to ask in either <#507982478276034570> or <#7211007859367...
everyones ignoring me
graceful mist
heres my repo btw https://github.com/Meelee35/Charmonium19.3
graceful mist
Like the loom-cache in .gradle folder, or the entire folder.
Deleted it and it didnt work sadly
mortal jolt
I searched thru this discord and found a fix.
You need to replace
mappings loom.layered {
officialMojangMappings()
signatureFix("net.fabricmc:yarn:${project.yarn_mappings}:v2")
}
with
mappings loom.officialMojangMappings()
in your build.gradle
To my understanding the signatureFix() was a temporary fix, that isn't needed now, In newer versions.
Here's how I found that in short:
- The error said something about signatures, so I started searching.
Found signatureFix() in build.gradle, weired, what's that?
Let's search "signatureFix" on discord.
Found this:
#toolchain-other message
#mod-dev-1 message
Tried removing signatureFix().
Succes
graceful mist
Thank you so much
does that also mean i can remove the exclusions for mod menu?
wait what line is signaturefix on?
@mortal jolt (You said ping me on reply)
oh wait i am really sorry i didnt see that it was in the line of code i replaced
i am blind
oh wait im getting this error now
> Task :compileJava
C:\Users\Me\Downloads\Charmonium19.3-main\Charmonium19.3-main\src\main\java\svenhjol\charmonium\helper\BiomeHelper.java:24: error: cannot find symbol
return level.registryAccess().registryOrThrow(Registry.BIOME_REGISTRY).getResourceKey(biome).orElse(null);
^
symbol: variable BIOME_REGISTRY
location: interface Registry
C:\Users\Me\Downloads\Charmonium19.3-main\Charmonium19.3-main\src\main\java\svenhjol\charmonium\registry\ClientRegistry.java:16: error: cannot find symbol
return Registry.register(Registry.SOUND_EVENT, res, new SoundEvent(res));
^
symbol: variable SOUND_EVENT
location: interface Registry
C:\Users\Me\Downloads\Charmonium19.3-main\Charmonium19.3-main\src\main\java\svenhjol\charmonium\registry\ClientRegistry.java:16: error: constructor SoundEvent in class SoundEvent cannot be applied to given types;
return Registry.register(Registry.SOUND_EVENT, res, new SoundEvent(res));
^
required: ResourceLocation,float,boolean
found: ResourceLocation
reason: actual and formal argument lists differ in length
3 errors
> Task :compileJava FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':compileJava'.
> Compilation failed; see the compiler error output for details.
i know limited java so i will try and fix it
mortal jolt
Minecraft 1.19.3 had some registry changes. I'm not on my pc now, but this might help you (take look at the Registry section).
https://fabricmc.net/2022/11/24/1193.html
graceful mist
thanks
graceful mist
i updated the code but i still get the same error @mortal jolt , I still cant thank you enough for helping me. I will wait for you to be ready. I dont mind at all how long it takes even if it takes a year
and by that i mean i changed Registry.(...) to Registries.
mortal jolt
So you have two errors.
The first one is in BiomeHelper.getBiomeKey()
You tried changing Registry.BIOME_REGISTRY to Registries.BIOME_REGISTRY.
Good try, but actually the name was changed to just Registries.BIOME.
You need to learn how to fix these types of error's, this one was really simple.
Tip: If you are using Intellij Idea you can Ctrl + click a class to see it's content.
The second one is in ClientRegistry.sound() method:
there are two issues here, the first one is that you are using a wrong class.
Mappings are basically names for minecraft's classes, methods, etc.
Fabric by default uses Yarn mapping's, developed by it's community.
Charmonium is using official Mojang mappings, that are different.
Yarn's Registries translate's to Mojmap's BuiltInRegistries.
So you need to use BuiltInRegistries.SOUND_EVENT.
The second issue here is that Mojang changed how SoundEvent is created.
After looking at the source code (ctrl + click), I found that instead of using new SoundEvent(res) you need to use a static method SoundEvent.createVariableRangeEvent(res).
Success again.
One thing I can recommend is taking look at this channel:
https://www.youtube.com/@ModdingByKaupenjoe
It has many useful tutorials for many versions, and other usefull stuff.
Like this playlist with different tips: https://youtube.com/playlist?list=PLKGarocXCE1Ee8FFFTS569ABY9V2Uod5D
granite fiber