Mod that removes the "Out of order chat" kick from server | The Fabric Project | Page 1

queen sparrow Apr 7, 2023, 6:46 PM

#

I attempted to do this once just by overriding the boolean to make it always true, but even then I was still getting kick.
The error is as follows on the server (client has no error):

[19:10:54] [Netty Epoll Play IO Thread #1/WARN]: QPCrummer sent out-of-order chat: 'fill -896 103 -140 -895 104 -140 minecraft:cyan_terracotta replace air'
[19:10:54] [Server thread/INFO]: QPCrummer lost connection: Out-of-order chat packet received. Did your system time change?
[19:10:54] [Server thread/INFO]: QPCrummer left the game

You can easily reproduce this when pasting something into a multiplayer world with litematica. Thanks to anyone who can find a fix for this, it is really annoying tater

hollow tendon Apr 7, 2023, 6:47 PM

#

have you tried using no chat reports?

#

if the chat verification system isnt active, it probably wont kick you

queen sparrow Apr 7, 2023, 6:48 PM

#

hollow tendon have you tried using no chat reports?

yep, still doesn't work

#

I have it on the client and server

#

although I no longer have NoChatReports because it breaks Polymer

hollow tendon Apr 7, 2023, 6:48 PM

#

huh

#

dunno then

queen sparrow Apr 7, 2023, 6:49 PM

#

There is a method that checks if chat packets are in order

#

I would've thought just overriding it would be fine... but I guess not :P

nova elk Apr 8, 2023, 2:42 AM

#

Did you use @Override or @ Overwrite?

#

Damn it Discord

#

Sorry for ping

queen sparrow Apr 8, 2023, 3:31 AM

#

nova elk Did you use @Override or @ Overwrite?

@Mixin(ServerPlayNetworkHandler.class)
public class ServerLoginNetworkHandler_IgnoreMessageOrder {
    @Inject(method = "isInProperOrder", at = @At("HEAD"), cancellable = true)
    private void isInProperOrder(Instant timestamp, CallbackInfoReturnable<Boolean> cir) {
        cir.setReturnValue(true);
    }
}

I did implement

#

but made it always return true

patent cloak Apr 8, 2023, 5:49 AM

#

should probably use an overwrite for that

hushed juniper Apr 8, 2023, 6:04 AM

#

queen sparrow although I no longer have NoChatReports because it breaks Polymer

Thats a new one lol

queen sparrow Apr 8, 2023, 7:48 PM

#

hushed juniper Thats a new one lol

you literally said it did widetater ~~(then I never reported to them)~~

queen sparrow Apr 8, 2023, 7:49 PM

#

patent cloak should probably use an overwrite for that

ok, let me try and see

hushed juniper Apr 8, 2023, 7:54 PM

#

Do you think I remember that stuff?

queen sparrow Apr 8, 2023, 7:56 PM

#

Well, it wasn't a very big issue

#

it only spammed the console a lot, but both mods still worked

#

I finally removed NCR because it was breaking Geyser

#

    @Overwrite
    private boolean isInProperOrder(Instant timestamp) {
        return true;
    }
}

This also didn't work

#

I'm actually now wonder if it is Velocity being a pain

#

You were kicked from lobby: multiplayer.disconnect.out_of_order_chat
It is mentioned in Velocity's logs

#

but I'd assume that the server would be sending that to the client, not Velocity

#

what in the world... I removed the disconnect message from the code entirely and it still disconnected me

#

I really think Velocity is behind this

hushed juniper Apr 8, 2023, 8:11 PM

#

Or client

queen sparrow Apr 8, 2023, 8:11 PM

#

nope

#

it is Velocity

#

just used my "backdoor" method to my test server without Velocity and it worked fine

#

I was able to do 64 commands per tick

#

great...

hollow tendon Apr 8, 2023, 8:12 PM

#

can you somehow use mixin on velocity?

#

thocc

queen sparrow Apr 8, 2023, 8:12 PM

#

I don't think it supports mixin

#

would be extraordinarily nice if it did

hollow tendon Apr 8, 2023, 8:13 PM

#

well you see

#

cant fabric in theory mod any java program?

queen sparrow Apr 8, 2023, 8:13 PM

#

conc

hollow tendon Apr 8, 2023, 8:13 PM

#

this would mean you could potentially use fabric to mod velocity

#

it'd be exceedingly cursed, but possible

patent cloak Apr 8, 2023, 8:14 PM

#

it’s pretty easy to do that actually

hollow tendon Apr 8, 2023, 8:14 PM

#

yeefuckinhaw

queen sparrow Apr 8, 2023, 8:14 PM

#

I um... should 100% not be responsible for this idea

hollow tendon Apr 8, 2023, 8:15 PM

#

its the perfect solution

#

what do you mean

queen sparrow Apr 8, 2023, 8:15 PM

#

I shouldn't be coding that lol

#

it would be a disaster :P

patent cloak Apr 8, 2023, 8:16 PM

#

since velocity doesn’t operate with vanilla code and you have the actual source, that could be neat flaminking

#

I wonder why there isn’t a fabric proxy already

queen sparrow Apr 8, 2023, 8:16 PM

#

um

#

dunno

hollow tendon Apr 8, 2023, 8:16 PM

#

cause making a proxy is a pain i'd imagine

queen sparrow Apr 8, 2023, 8:16 PM

#

well there is a rust proxy

patent cloak Apr 8, 2023, 8:17 PM

#

hollow tendon cause making a proxy is a pain i'd imagine

I mean, most of it is just receiving and sending the same packets, which are quite well documented
you just have to add some api to intercept and modify those packets

hollow tendon Apr 8, 2023, 8:18 PM

#

most proxies also handle auth though

#

and seamless switching between servers

patent cloak Apr 8, 2023, 8:19 PM

#

documented, but still pain, yeah

#

but it’s easier than custom clients or servers

hollow tendon Apr 8, 2023, 8:19 PM

#

oh yea definitely

#

there's a reason everyone is modding the vanilla server jar instead of just making one from scratch

queen sparrow Apr 8, 2023, 8:27 PM

#

heh, found the chat time control code in Velocity

#

ChatTimeKeeper is the name of the class

#

I will say, it would be super nice to have Velocity's plugin system to be able to modify its own code

#

then I wouldn't have to keep a fork updated 24/7 with the main project

hollow tendon Apr 8, 2023, 8:38 PM

#

i'm telling you

#

mixin is the way to go

queen sparrow Apr 8, 2023, 8:38 PM

#

yeah...

potent rock Apr 8, 2023, 11:16 PM

#

wait.. did modern versions of the game KICK players if it determines that messages are "out of order"?

#

wtf

queen sparrow Apr 9, 2023, 12:19 AM

#

potent rock wait.. did modern versions of the game KICK players if it determines that messag...

yes. thanks 1.19.2

#

mojank

#

Also, it turns out is wasn't Velocity at all

potent rock Apr 9, 2023, 12:19 AM

#

that kind of thing really turns me down to update

#

i mean

#

i agree the need of moderation, even more considering children play this game

queen sparrow Apr 9, 2023, 12:20 AM

#

It just so happened to be that my mixin just wasn't working. I literally had to move it to another class name in order for it to work mixinthonk

potent rock Apr 9, 2023, 12:20 AM

#

but breaking things internally or making things difficult for modders should not be done

queen sparrow Apr 9, 2023, 12:21 AM

#

yep, I think it should've had a toggle and maybe a thing that required parent's approval or something if a kid was under a certain age

#

idk

#

but yeah, it's all good now

#Mod that removes the "Out of order chat" kick from server