Minecraft Crafting | Official Unity Discord | Page 1

rich field Jun 16, 2022, 2:54 PM

#

hi guys! I am planning to replicate minecraft Crafting. do you have an idea how to implement it in general? i was thinking about just checking every slot if it has an item. but i am also planning to let the player input the items everywhere as long as it matches the general pattern (you can input any two planks in a crafting grid as long as they are vertical)
i am also storing all these recipes in json like minecraft does:

{
    "Recipes":[
        {
            "shapeless":false,
            "recipe":[
                "XXX",
                " Y ",
                " Y "
            ],
            "keys":[
                {
                    "key":"X",
                    "item":"diamond"
                },
                {
                    "key":"Y",
                    "item":"stick"
                }
            ],
            "result":"diamond_pickaxe"
        },
        {
            "shapeless":false,
            "recipe":[
                "X",
                "X",
                "Y"
            ],
            "keys":[
                {
                    "key":"X",
                    "item":"diamond"
                },
                {
                    "key":"Y",
                    "item":"stick"
                }
            ],
            "result":"diamond_sword"
        },
        {
            "shapeless":false,
            "recipe":[
                "X",
                "X"   
            ],
            "keys":[
                {
                    "key":"X",
                    "item":"diamond"
                }
            ],
            "result":"stick"
        }
    ]
}

this shows how the recipe for the diamond sword can be shifted left to right, the stick recipe can be shifted up, down, left and right and the pickaxe must be crafted exactly like it says. Unfortunatly i dont have a single clue how to implement that. any ideas?

#

im gonna be afk for a moment, so please feel free to input your ideas (:

chrome knot Jun 16, 2022, 4:21 PM

#

Alright, so the gist of it is to first separate the two types of crafting, shaped and shapeless (btw the last two recipes in that JSON are incorrect, its shapeless key should be set to true, as you can put the ingredients anywhere).
Next would be to "preload" the recipe in a C# class, and then have some code make the different links between the json element (namely the letter-to-item-and-quantity link), so in the end you have yet another C# class, CraftingRecipe, abstract with the required methods (to check if the recipe matches what's in the slots of the table, to process the crafting, etc).
Then you have two subclasses, ShapedRecipe and ShapelessRecipe that override the methods, so you can both handle shaped and shapeless recipes.

chrome knot Jun 16, 2022, 4:44 PM

#

To check whether a recipe matches what's in the slots, for a shaped recipe you would simply iterate through the slots.
For shapeless it's a bit more complicated, you need to determine the size of the recipe, and march the slots to see if the slots at that position match the recipe

rich field Jun 16, 2022, 4:46 PM

#

hmm

chrome knot Jun 16, 2022, 5:03 PM

#

Actually, I'm mixing up stuff here. The JSON is right, shapeless crafting is something else, it doesn't have a recipe key, or it's empty. That one is even easier to implement, just count if the required items are present in the crafting grid.

#

You need to march the grid when the recipe list isn't composed of 3 strings of 3 chars each

rich field Jun 16, 2022, 5:06 PM

#

yes, i am still trying to figure out how to do the shifting thing. when the

string[3] recipe
contains for instance at recipe[0] not 3 but 1 letter ("X")
it can be shifted. if it contains a blank space, it cannot, the space is reserved by a blank item (" X ")

#

also, when theres just one blank field, it can still be shifted:
recipe: " Y"
possible combinations:
" Y "
" Y"

chrome knot Jun 16, 2022, 5:11 PM

#

Two if statements, that check whether the pattern can be shifted in that direction. If the width is 3, it can't be shifted horizontally. If the height is 3, it can't be shifted vertically

rich field Jun 16, 2022, 5:12 PM

#

i could just get (pseudo) List.Length to determain wether it can be shifted up and down, and List[i].length to check if it can be shifted right/left

chrome knot Jun 16, 2022, 5:12 PM

#

Exactly

rich field Jun 16, 2022, 5:13 PM

#

i would have to generate a list for all other possible recipes (shaped)

#

based on that two checks

#

idk if thats inefficient, e.g. a stick has 6 possible recipes, and searching a list takes O(n) irrc

chrome knot Jun 16, 2022, 5:16 PM

#

Nah, you would march through the grid to see if a recipe matches at any position. Taking your example X (empty, X), it would do that

rich field Jun 16, 2022, 5:17 PM

#

minecraft has 379 craftable items, and thats not even taking note of he sub recepies

chrome knot Jun 16, 2022, 5:18 PM

#

blue square being the "origin of the search", and the red arrows where it moves the whole recipe to, to match

rich field Jun 16, 2022, 5:19 PM

#

i dont understand---

#

like some sort of offset?

chrome knot Jun 16, 2022, 5:20 PM

#

Yeah, let me make some more images - the first one is the first "iteration", the top-left 2 slots are checked

#

2nd iteration

#

3rd iteration

#

etc.

rich field Jun 16, 2022, 5:22 PM

#

i see

chrome knot Jun 16, 2022, 5:22 PM

#

You should be able to pull that (the marching movement) off with two nested for loops

#

And inside another loop that matches the actual items in the slots being checked

#

Yes, that is up to 4 nested loops

#

Not even "up to", 4 nested loops that's it

rich field Jun 16, 2022, 5:26 PM

#

wait a second

#

#

maybe (for efficiency stuff) first check if the required items for the list matches the items in the grid

chrome knot Jun 16, 2022, 5:32 PM

#

I was about to say that

#

But your flowchart is correct

rich field Jun 16, 2022, 5:34 PM

#

how would i actually shift the items ? like code

chrome knot Jun 16, 2022, 5:34 PM

#

chrome knot You should be able to pull that (the marching movement) off with two nested for ...

Refer to this

#

I'm not going to give you the full code that works out of the box evidently

rich field Jun 16, 2022, 5:36 PM

#

yea no prob lol

chrome knot Jun 16, 2022, 5:37 PM

#

Start with the loop that marches right, note down the bounds of the for loop depending on the width of the recipe, and you'll be able to deduct a simple formula to automagically calculate that, depending on the width and the crafting grid size

#

Repeat the same process for the loop that marches down

#

Actually, down first, then right if you want to follow the images I posted

#

Marching right first would give a sweep like that. It's the same number of moves though, so implement any

#

(by "first" I meant "the outer loop first")

rich field Jun 16, 2022, 5:45 PM

#

wtf

#

did my message just get deleted

#

s.dknbf,km.hjsdn

chrome knot Jun 16, 2022, 5:46 PM

#

I think yeah, I have nothing on my side

#

Bot removes messages for various reasons, especially unformatted code

rich field Jun 16, 2022, 5:46 PM

#

i was summing up the process 😐

chrome knot Jun 16, 2022, 5:46 PM

#

If you're on PC you can CTRL+Z a few times

rich field Jun 16, 2022, 5:47 PM

#

so, to sum it up:
0. iterate over all recipes:

check if the amount and type of items required matches the items in grid
create two ints, returning how much i can shift in x and y direction, Example:
"X",
"Y",
"Y"
returns 2 for horizontalShift, 0 for verticalShift

in a double nested for loop i do the following:

    .2 y=0; y < verticalShift (0)
        checkBoard(shiftBoard(recipe,board, x, y))```

craft 🙂

#

if checkBoard returns true, craft

#

oh i need the current board

chrome knot Jun 16, 2022, 5:49 PM

#

That sounds good to me

rich field Jun 16, 2022, 5:49 PM

#

it isnt

#

the y loop wouldnt do anything if verticalShift is zero

#

would it?

chrome knot Jun 16, 2022, 5:50 PM

#

And that's exactly what you want to do

rich field Jun 16, 2022, 5:50 PM

#

would checkBoard still execute?

chrome knot Jun 16, 2022, 5:50 PM

#

Ah, no

rich field Jun 16, 2022, 5:50 PM

#

thats the prob

#

<= isnt an option either

#

it is

#

yes it is

chrome knot Jun 16, 2022, 5:52 PM

#

Yeah that works

rich field Jun 16, 2022, 5:52 PM

#

#

xd

chrome knot Jun 16, 2022, 5:53 PM

#

A sort of state machine could have worked here, where the positions would be stored in the class, and an Advance method would move it to the next position, but <= definitely works here

rich field Jun 16, 2022, 5:56 PM

#

gonna deserialize the json first xD

chrome knot Jun 16, 2022, 5:56 PM

#

And map the letters in the recipe to real item instances

#

For each char in the recipe -> find the corresponding item name in the list aside it -> load the item -> put it in an array

#

In the end you could have a Slot[,] that represents your recipe (item + qty), but high-level

#

Basically, for peak performance™️ recipes should be only deserialized once, afterwards they're in a collection of Recipe, that contains info about said recipe

rich field Jun 16, 2022, 6:01 PM

#

chrome knot In the end you could have a `Slot[,]` that represents your recipe (item + qty), ...

qty?

chrome knot Jun 16, 2022, 6:01 PM

#

Quantity

rich field Jun 16, 2022, 6:01 PM

#

oh

#

i have a recipe index where all recipes go, they are deserialized on awake

#

i did that to my item class (i dont like scriptable objects, also modding support) and Drops

#

what should the key list be type of? List<Dictionary<string,Item>> ?

chrome knot Jun 16, 2022, 6:06 PM

#

Key, as in the letters you can find in the recipe string array?

#

this thing

#

It would involve a bit of data transformation on load, but the best (and most efficient) would be a Dictionary<char, Item>

rich field Jun 16, 2022, 6:08 PM

#

#

i could also use a class for that.. should i? probably not

chrome knot Jun 16, 2022, 6:11 PM

#

Yeah, so in the end you can do

for (int row = 0; row < recipe.Length; row++)
{
  for (int col = 0; col < recipe[row].Length; col++)
  {
    char k = recipe[row][col];
    if (k == ' ') continue; // skip spaces
    
    slots[row, col] = keyDictionary[k];
  }
}

#

That maps the chars in the recipe to an Item instance present in the dictionary

#

(Item[,] slots = new Item[gridWidth, gridHeight]) <- if one day you make bigger crafting tables, or non-square ones, your code will adapt without any issue, even for marching the grid

rich field Jun 16, 2022, 6:24 PM

#

nah, i am just gonna hardcode 2x2 and 3x3

#

uhm

#

how do i get the key name of an JObject?

foreach (JObject key in (JArray)Recipes["keys"])
{
   _keys.Add(new Dictionary<char, Item> { key."here"})
}

#

i need key.name or smth lol

#

wait no forget it, what am i doing

#

i thought it was "X":"diamond_shovel"

chrome knot Jun 16, 2022, 6:34 PM

#

Couldn't tell anyway lol, haven't used the dynamic JSON parsing thingy

rich field Jun 16, 2022, 6:36 PM

#

_keys.Add(new Dictionary<char, Item> { [(char)key["key"]] = returnItem((string)key["item"]) });
i love programming 💀

chrome knot Jun 16, 2022, 6:37 PM

#

What? Why do you have an unknown collection of Dictionary

#

Just Dictionary<char, Item>, otherwise you lose the performance benefits when accessing

#

dict.Add((char)key["key"], returnItem((string)key["item"]))

rich field Jun 16, 2022, 6:39 PM

#

i didnt know that, i am not familliar with dicts

#

so what exactly should i do now 😅

chrome knot Jun 16, 2022, 6:43 PM

#

chrome knot Yeah, so in the end you can do ```cs for (int row = 0; row < recipe.Length; row+...

So you convert the JSON keys into your dictionary. Dictionary that you can use to loop through the recipe and form a Item[,] like above

rich field Jun 16, 2022, 6:44 PM

#

no i mean with the dictionary

#

to add to it

chrome knot Jun 16, 2022, 6:44 PM

#

chrome knot `dict.Add((char)key["key"], returnItem((string)key["item"]))`

^

#

where dict is your Dictionary<char, Item>

rich field Jun 16, 2022, 6:45 PM

#

ohhh

chrome knot Jun 16, 2022, 6:46 PM

#

The advantage in using a Dictionary (other than it's fast) is that you cannot have duplicate keys

rich field Jun 16, 2022, 6:46 PM

#

i thought a dict is only one thing, i thought its:
"foo": 1

not
"foo1":1,
"foo2":2
.
.
.

rich field Jun 16, 2022, 6:46 PM

#

chrome knot The advantage in using a Dictionary (other than it's fast) is that you cannot ha...

ooo nice

chrome knot Jun 16, 2022, 6:46 PM

#

So you can encounter 5 X and 2 Y, the dictionary will only have two elements

rich field Jun 16, 2022, 6:47 PM

#

thats some cool stuff

#

i like Dictionaries

#

i will test the deserialization now

#

wait, gonna write a Log thing

#

huh

#

foreach (Recipe recipe in RecipeIndex.Recipes)
doesnt work at all

#

oh its not static

rich field Jun 16, 2022, 7:08 PM

#

deserialization works perfec

#

now the hard part

rich field Jun 16, 2022, 7:59 PM

#

ima break for today, i just came to implementig the crafting grid and the custom mechanic for the locked slot (where the result sits)

#

thank you very much for your help. i really appreciate it man. mind if i ping you tomorrow when i need help?

chrome knot Jun 16, 2022, 8:01 PM

#

Sure no problem

rich field Jun 16, 2022, 8:01 PM

#

thanks! goodnight! (:

rich field Jun 23, 2022, 9:49 PM

#

joooooooo @chrome knot guess what

#

it worked!!!!

chrome knot Jun 23, 2022, 9:59 PM

#

Looks really nice congrats

rich field Jun 24, 2022, 4:06 PM

#

Thanks! Just fixing bugs atm

#

Also shapeless has to be worked over UnityChanFrustrated

rich field Jul 7, 2022, 9:24 PM

#

@chrome knot sorry for ping but Massive progress!
Crafting is working perfectly. i implemented a crafting Table to test if your system also works on 3x3 grids. it did with a bit of tweaks here and there. also added the shift system, the double click to fill the dragged item slot (with priorities!) and the right click to add to each slot you're hovering over mechanic from minecraft. Thank you very much for your Help!

chrome knot Jul 7, 2022, 9:29 PM

#

Nice, thanks for the update!

rich field Jul 17, 2022, 11:09 PM

#

hi @chrome knot sorry again. i am really frustrated because i cant solve this issue and i wondered if you can give me any help

so in a function, i am checking if(inv.DragSlot.item.name == slot.slot.item.name)
on the normal slots, its working fine, but for the crafting slots, i am getting NullReference on slot.slot.item.name i thought weird, maybe didnt initialize item correctly. But that aint it. when i check manually, the string is there and i even did a Debug.Log() with the context arg checking slot.slot.item since slot.slot.item.name gives Null like i said. can you PLEASE help me, this is really getting frustrating

rich field Jul 17, 2022, 11:32 PM

#

forget it, fixed this piece of crao

#Minecraft Crafting