Heart system | Official Unity Discord | Page 1

dusk drift May 30, 2022, 5:40 AM

#

@muted citrus so what’s the issue then

#

Making a thread in case other people want to use the coding channel 😅

muted citrus May 30, 2022, 5:40 AM

#

the hearts when i press the play button aint apearing

#

thats no problem thank you for wanting to help

dusk drift May 30, 2022, 5:41 AM

#

dusk drift Making a thread in case other people want to use the coding channel 😅

Ahh perfect timing anyways

dusk drift May 30, 2022, 5:41 AM

#

muted citrus the hearts when i press the play button aint apearing

Do you have them assigned as the prefab?

muted citrus May 30, 2022, 5:41 AM

#

yes

#

#

#

dusk drift May 30, 2022, 5:42 AM

#

Can you resend the script that’s supposed to spawn in the hearts

muted citrus May 30, 2022, 5:42 AM

#

sure there is 2

#

wrong button

#

sorry

#

public class HealthManager : MonoBehaviour
{
    public Health heartPrefab;
    public playerHealth playerHealth;
    List<Health> hearts = new List<Health>();

    public void Start()
    {
        drawHearts();
    }

    public void drawHearts ()
    {
        clearHearts();

        float MaxHealthRemainder = playerHealth.MaxHealth % 2;
       
        int heartsToMake = (int)(playerHealth.MaxHealth / 2 + MaxHealthRemainder);
     
        for (int i = 0; i < heartsToMake; i++)
        {
            createEmptyHeart();
        }

    }

    public void createEmptyHeart()
    {
        Health newHeart = Instantiate(heartPrefab);
        newHeart.transform.SetParent(transform);
        

        Health heartcomponant = newHeart.GetComponent<Health>();
        heartcomponant.setHeartImage(heartStatus.Empty);
        hearts.Add(heartcomponant);

        
    }


    public void clearHearts()
    {
        foreach(Transform t in transform)
        {
            Destroy(t.gameObject);
        }
        hearts = new List<Health>();
    }

}

#

public class Health : MonoBehaviour
{
    public Sprite fullHeart, emptyHeart;
    Image heartimage;

    public void Awake()
    {
        heartimage = GetComponent<Image>();
    }

    public void setHeartImage(heartStatus status)
    {
        switch (status)
        {
            case heartStatus.Empty:
                heartimage.sprite = emptyHeart;
                break;

            case heartStatus.full:
                heartimage.sprite = fullHeart;
                break;
        }
    }
   

}

public enum heartStatus
{
    Empty = 0,
    full = 1
}

dusk drift May 30, 2022, 5:44 AM

#

And the hearts aren’t being spawned in the hierarchy?

#

Look in the hierarchy when the game starts

muted citrus May 30, 2022, 5:45 AM

#

nope

#

nothing in the hierarchy

dusk drift May 30, 2022, 5:46 AM

#

muted citrus nothing in the hierarchy

Inside the for loop we just fixed put print(“hearts: ” + i);

#

That’ll let us know if the code is running

muted citrus May 30, 2022, 5:46 AM

#

after the i++

dusk drift May 30, 2022, 5:46 AM

#

muted citrus after the i++

No inside the for loop

#

With the create new heart method

muted citrus May 30, 2022, 5:47 AM

#

where in the for loop .

dusk drift May 30, 2022, 5:47 AM

#

muted citrus where in the for loop .

under creatEmptyHeart()

muted citrus May 30, 2022, 5:48 AM

#

its caused errors

dusk drift May 30, 2022, 5:48 AM

#

Show it

muted citrus May 30, 2022, 5:50 AM

#

never mind i fixed them sorry it was my dyslexia

dusk drift May 30, 2022, 5:50 AM

#

That’s fine

#

Do the messages print?

muted citrus May 30, 2022, 5:50 AM

#

dusk drift May 30, 2022, 5:52 AM

#

Weird

dusk drift May 30, 2022, 5:52 AM

#

muted citrus

Can you show me where you put the logged message?

#

In the script

muted citrus May 30, 2022, 5:53 AM

#

  public void drawHearts ()
    {
        clearHearts();

        float MaxHealthRemainder = playerHealth.MaxHealth % 2;
       
        int heartsToMake = (int)(playerHealth.MaxHealth / 2 + MaxHealthRemainder);
     
        for (int i = 0; i < heartsToMake; i++)
        {
            createEmptyHeart();
            print("hearts"  );
        }

    }

#

when i put the +i it came u with red under print so i left that bit out

dusk drift May 30, 2022, 5:54 AM

#

That’s fine, it still shows that the code didn’t execute

muted citrus May 30, 2022, 5:55 AM

#

for some strange reason

dusk drift May 30, 2022, 5:55 AM

#

muted citrus ```cs public void drawHearts () { clearHearts(); float Ma...

print the value of heartsToMake

#

if it return 0, then the for loop won’t run

muted citrus May 30, 2022, 5:56 AM

#

print heartsToMake = (int)(playerHealth.MaxHealth / 2 + MaxHealthRemainder);

#

like that

dusk drift May 30, 2022, 5:57 AM

#

no

#

print(heartsToMake);

#

Just add that before the for loop

muted citrus May 30, 2022, 5:59 AM

#

dusk drift May 30, 2022, 5:59 AM

#

muted citrus

Make sure you didn’t make it a string

muted citrus May 30, 2022, 6:00 AM

#

public void drawHearts ()
    {
        print("heartsToMake");
        clearHearts();

        float MaxHealthRemainder = playerHealth.MaxHealth % 2;
       
        int heartsToMake = (int)(playerHealth.MaxHealth / 2 + MaxHealthRemainder);
     
        for (int i = 0; i < heartsToMake; i++)
        {
            createEmptyHeart();
            print("hearts" );
        }

#

how do i check that

dusk drift May 30, 2022, 6:01 AM

#

put print(heartsToMake); before the for loop but after the math calculation

#

Don’t wrap it in “quotations” otherwise it’ll be a string literal

muted citrus May 30, 2022, 6:02 AM

#

so in between int and for

dusk drift May 30, 2022, 6:02 AM

#

Yes

muted citrus May 30, 2022, 6:03 AM

#

#

coming back as 0

#

so im asuming thats the issue it shouldnt be coming back as 0

dusk drift May 30, 2022, 6:06 AM

#

muted citrus so im asuming thats the issue it shouldnt be coming back as 0

Yes it should be a number that’s greater than 0

#

Otherwise the for loop doesn’t run

muted citrus May 30, 2022, 6:07 AM

#

ok so how would i fix that

dusk drift May 30, 2022, 6:08 AM

#

muted citrus ok so how would i fix that

What number is it printing?

muted citrus May 30, 2022, 6:08 AM

#

0

#

exactly 0

dusk drift May 30, 2022, 6:09 AM

#

What’s the value of MaxHealth?

muted citrus May 30, 2022, 6:10 AM

#

playerHealth.MaxHealth % 2;

#

i think

dusk drift May 30, 2022, 6:13 AM

#

muted citrus playerHealth.MaxHealth % 2;

What is the value of MaxHealth

#

It’s a variable of playerHeath

muted citrus May 30, 2022, 6:14 AM

#

max health is only mentioned twice and its on these 2 lines

dusk drift May 30, 2022, 6:14 AM

#

muted citrus max health is only mentioned twice and its on these 2 lines

Look at your player health script

#

And look for the value of MaxHealth

muted citrus May 30, 2022, 6:15 AM

#

   float MaxHealthRemainder = playerHealth.MaxHealth % 2;
       
        int heartsToMake = (int)(playerHealth.MaxHealth / 2 + MaxHealthRemainder);
``` ok doing that now

#

{
public float health, MaxHealth;
}

dusk drift May 30, 2022, 6:15 AM

#

Look in the inspector then

#

Of the script

muted citrus May 30, 2022, 6:16 AM

#

i dont know how to do that

dusk drift May 30, 2022, 6:16 AM

#

muted citrus ```cs float MaxHealthRemainder = playerHealth.MaxHealth % 2; ...

Oh actually that’s probably why

dusk drift May 30, 2022, 6:16 AM

#

muted citrus ```cs float MaxHealthRemainder = playerHealth.MaxHealth % 2; ...

You’re doing 0/2

#

Which is 0

muted citrus May 30, 2022, 6:16 AM

#

should i put like max health =

#

then what i want the max health to =

dusk drift May 30, 2022, 6:16 AM

#

muted citrus should i put like max health =

You attached the player health script to an object. Look at the inspector of that object

muted citrus May 30, 2022, 6:17 AM

#

dusk drift May 30, 2022, 6:17 AM

#

hmm max health is 6

#

Actually wait

dusk drift May 30, 2022, 6:18 AM

#

muted citrus

It’s a prefab. Make sure you assigned the right script

muted citrus May 30, 2022, 6:19 AM

#

i only have 2 heart prefabs

#

heart and black heart

dusk drift May 30, 2022, 6:20 AM

#

I mean for taco

muted citrus May 30, 2022, 6:20 AM

#

yes

dusk drift May 30, 2022, 6:20 AM

#

taco is also a prefab

muted citrus May 30, 2022, 6:20 AM

#

yes but not asigned to the scrips

#

as those are for the hearts

#

the health script needs the heart prefabs

dusk drift May 30, 2022, 6:21 AM

#

Make sure your HealthManager script has a reference to the right player health script

muted citrus May 30, 2022, 6:21 AM

#

it only lets me select one script

#

#

so they have to be right ?

dusk drift May 30, 2022, 6:23 AM

#

muted citrus

On this image, did you drag in Taco in the Asset Folder, or Taco in the hierarchy

#

That’s what I mean

muted citrus May 30, 2022, 6:24 AM

#

taco from the hierarchy

#

but the prefab has the exact same scripts

#

im so anoed i cant get this to work

dusk drift May 30, 2022, 6:27 AM

#

muted citrus but the prefab has the exact same scripts

Replace the print that printed hearts to make with:

#

Debug.Log($”Value of: {playerHealth.MaxHealth} divided by 2, is {heartsToMake}”);

#

Just copy and paste that in

#

Then screenshot the message for me

muted citrus May 30, 2022, 6:29 AM

#

#

loads of red underlines

dusk drift May 30, 2022, 6:30 AM

#

muted citrus

Replace the “ with quotation marks

#

My phone just types them differently

muted citrus May 30, 2022, 6:32 AM

#

#

it says 0 divided by 2 is 0

dusk drift May 30, 2022, 6:34 AM

#

Well playerHealth.MaxHealth is somehow 0

#

¯_(ツ)_/¯

#

Idk how you assigned it

muted citrus May 30, 2022, 6:34 AM

#

ok so i need to somehow set the max health to 6

#

any idea how i would do that in code

dusk drift May 30, 2022, 6:35 AM

#

will it always be 6?

muted citrus May 30, 2022, 6:35 AM

#

i trives public float maxhealth but that didnt work

#

and yes the max is always 6

dusk drift May 30, 2022, 6:36 AM

#

laziest way to fix it:
playerHealth.MaxHealth = 6;
in void Start()

muted citrus May 30, 2022, 6:37 AM

#

#

its underlined red

dusk drift May 30, 2022, 6:37 AM

#

Wait screenshot healthManager for me

muted citrus May 30, 2022, 6:38 AM

#

#

dusk drift May 30, 2022, 6:40 AM

#

muted citrus

in the playerHealth script just remove the playerHealth.

#

just have MaxHealth = 6;

muted citrus May 30, 2022, 6:42 AM

#

player health is the name of the script tho

#

deleeting that will ruin the script wont it

dusk drift May 30, 2022, 6:42 AM

#

Line 11

muted citrus May 30, 2022, 6:42 AM

#

public class playerHealth : MonoBehaviour
{
public float health, MaxHealth;

public void Start()
{
    MaxHealth = 6;
}

}

dusk drift May 30, 2022, 6:42 AM

#

yes that’s what I mean

muted citrus May 30, 2022, 6:43 AM

#

ahh ok

#

well its still not working

dusk drift May 30, 2022, 6:43 AM

#

Is the log still showing 0 divided by 2 is 0?

#

And you saved the scripts right?

muted citrus May 30, 2022, 6:44 AM

#

#

no 6 devided by 2 is 3

#

but still no hearts

dusk drift May 30, 2022, 6:46 AM

#

You don’t have a health prefab

#

Assign the health prefab

muted citrus May 30, 2022, 6:46 AM

#

what would i asign the prefab to

#

the heart . the taco . the manager ?

#

wait i do have a health script . its on the heart

dusk drift May 30, 2022, 6:49 AM

#

Screenshot line 21 of the health script

muted citrus May 30, 2022, 6:49 AM

#

heartimage.sprite = emptyHeart;

dusk drift May 30, 2022, 6:50 AM

#

Also

muted citrus May 30, 2022, 6:50 AM

#

yes i fixed that

#

dusk drift May 30, 2022, 6:52 AM

#

One of your objects with a health script has an unassigned reference

#

Sometimes double clicking it will lead you to the culprit or it’ll open the script so try double clicking it and see where it takes you

muted citrus May 30, 2022, 6:54 AM

#

it just took me to the script

#

idk honestly

#

its saying i have unasigned things when i dont

#

only thing i can think to do is deleet the scripts from the items then re add them

#

i un added them and got no error re added them and re asigned eveeerything and the error came back

#

NullReferenceException: Object reference not set to an instance of an object
Health.setHeartImage (heartStatus status) (at Assets/Scripts/Health.cs:21)
HealthManager.createEmptyHeart () (at Assets/Scripts/HealthManager.cs:41)
HealthManager.drawHearts () (at Assets/Scripts/HealthManager.cs:28)
HealthManager.Start () (at Assets/Scripts/HealthManager.cs:13)

#Heart system