Grounding | Official Unity Discord | Page 1

somber kernel Dec 20, 2021, 9:30 AM

#

ah, you had it the other way around. Let me explain in a thread.

devout pulsar Dec 20, 2021, 9:30 AM

#

ok

somber kernel Dec 20, 2021, 9:31 AM

#

you keep your original script

#

and attach this script to the same object
**Edit: **I mean the Ground Check script I linked, not the one you modified

#

and in your original script, you need to add some lines

#

Your original code - https://gdl.space/dukodobuju.cs

#

add a private variable with Type as the script's name

in Awake, set it with GetComponent<ScriptName>();

#

Once that's done. You can reference the isGrounded bool by variableName.isGrounded

#

---- Alternatively you can bake my original script into your own, but it's much more clean this way

devout pulsar Dec 20, 2021, 9:37 AM

#

Like this?

        {
            //Gives a Player object velocity on +Y axis.
            rb.velocity += new Vector2(0, jumpForce);
        }```

somber kernel Dec 20, 2021, 9:37 AM

#

Yes, precisely

devout pulsar Dec 20, 2021, 9:37 AM

#

ok I will try this but first I have to fix something because now I can't jump at all xd

#

Fixed, the value was set at 1

#

But should I remove the if (!bc.IsTouchingLayers(LayerMask.GetMask("Ground"))) { return; }

#

from my OnJump

#

?

somber kernel Dec 20, 2021, 9:42 AM

#

yes

#

this replaces that

devout pulsar Dec 20, 2021, 9:43 AM

#

Well now my player can jump in the air

somber kernel Dec 20, 2021, 9:43 AM

#

post code?

#

is the Ground Script attached to the object?

devout pulsar Dec 20, 2021, 9:44 AM

#

ye

#

It tells me there is error with this line

#

ArgumentOutOfRangeException: Specified argument was out of the range of valid values.
Parameter name: Cannot get contact at index 0. There are 0 contact(s).

somber kernel Dec 20, 2021, 9:46 AM

#

Post code for that entire script

#

https://gdl.space

devout pulsar Dec 20, 2021, 9:46 AM

#

https://gdl.space/lamapuxede.cs

#

Player code

somber kernel Dec 20, 2021, 9:47 AM

#

devout pulsar It tells me there is error with this line ```Vector2 contact = collision.GetCont...

the script with this line

devout pulsar Dec 20, 2021, 9:47 AM

#

https://gdl.space/isumobiwem.cs

#

here

somber kernel Dec 20, 2021, 9:48 AM

#

are you certain that is 100% the code you're running?

#

'cause if it is, then you either have a special case (maybe Restart Unity)
or I've been sharing Wrong Code for months

#

but no one else have complained about errors

devout pulsar Dec 20, 2021, 9:50 AM

#

Ye I have both scripts in the Player object

somber kernel Dec 20, 2021, 9:50 AM

#

and they are the correct scripts?

devout pulsar Dec 20, 2021, 9:50 AM

#

The 2 I just sent

#

I will try restarting

somber kernel Dec 20, 2021, 9:51 AM

#

Ok

#

Btw, I see that I misread the first code link you sent in this thread

#

//And then on my OnJump script

#

it was correct, just needed to remove the other GetMask Ground thing

devout pulsar Dec 20, 2021, 9:52 AM

#

but where

#

In my or your script

somber kernel Dec 20, 2021, 9:53 AM

#

the script I linked stays the way it is - you just read the Public Bool

#

from your player script

#

wait a minute

#

the player script you just posted

#

it doesn't contain any reference to the ground check
and you've added a

if (!Physics2D.OverlapBox((Vector2)transform.position + groundCheckPosition, groundCheckSize, 0, groundLayers))
        {
            return;
        }

devout pulsar Dec 20, 2021, 9:55 AM

#

Do I add this?

somber kernel Dec 20, 2021, 9:55 AM

#

No, read what I'm typing out.

#

You're doing multiple things. I'm not sure you've got your head around this.

devout pulsar Dec 20, 2021, 9:55 AM

#

probably not

#

I had this line before ``` if (bc.IsTouchingLayers(LayerMask.GetMask("Ground")))
{
return;
}

#

But I thought that would mess with the script you gave me

somber kernel Dec 20, 2021, 9:58 AM

#

From the code you posted, and the instructions I gave, the path is simple.
You add the GroundCheck script to the same GameObject as the PlayerScript is attached.
Then you make a variable in your Player script to hold a reference to the GroundCheck

and use GetComponent in Awake
And then you remove your original Jump's internal ground check

if (!bc.IsTouchingLayers(LayerMask.GetMask("Ground")))
        {
            return;
        }

and implement the new one by only allowing jump if isGrounded == true

#

Have you referenced values between scripts before?

devout pulsar Dec 20, 2021, 10:00 AM

#

Wait

#

I sent you wrong player script

#

https://gdl.space/wujivoxoje.cs

#

this is the one

somber kernel Dec 20, 2021, 10:01 AM

#

private MyScriptName variableName;

void Awake()
{
    variableName = GetComponent<MyScriptName>(); // Attached to the game object
}

void Jump()
{
    if(variableName.isGrounded == true) // jump
}

devout pulsar Dec 20, 2021, 10:01 AM

#

is there a difference if I do it with void Awake or void Start?

somber kernel Dec 20, 2021, 10:02 AM

#

where do you call OnJump() ?

devout pulsar Dec 20, 2021, 10:03 AM

#

I dont. The class OnJump is called when certain input is used

#

In my case its Space

somber kernel Dec 20, 2021, 10:04 AM

#

devout pulsar is there a difference if I do it with void Awake or void Start?

Awake and OnEnable are called on all Game Objects, before Start is ever called

#

and when do you get the aforementioned error?

somber kernel Dec 20, 2021, 10:06 AM

#

devout pulsar I dont. The class OnJump is called when certain input is used

function/method, not class. Player is the class. (details)

devout pulsar Dec 20, 2021, 10:06 AM

#

Whenever I jump I get ```ArgumentOutOfRangeException: Specified argument was out of the range of valid values.
Parameter name: Cannot get contact at index 0. There are 0 contact(s).
UnityEngine.Collision2D.GetContact (System.Int32 index) (at <b0e795e48cf04d7a9193ea9447af406a>:0)
GroundCheck.OnCollisionExit2D (UnityEngine.Collision2D collision) (at Assets/Scripts/GroundCheck.cs:42)

devout pulsar Dec 20, 2021, 10:06 AM

#

somber kernel function/method, not class. Player is the class. (details)

oh sorry

somber kernel Dec 20, 2021, 10:06 AM

#

words shape reality
it's important to use the right words, so you can think clearly

#

nothing to be sorry about

#

can't know what you haven't learned

devout pulsar Dec 20, 2021, 10:07 AM

#

Ye I just started not even a half year ago

#

Vector2 contact = collision.GetContact(0).normal; but this is the line with an error

#

according to the console

somber kernel Dec 20, 2021, 10:09 AM

#

is your collider enabled in the inspector?

#

is it ever disabled during code?

devout pulsar Dec 20, 2021, 10:11 AM

#

I don't think so

#

    {   
       
        if (!notDead)
        {
            return;
        }
        if (gc.isGrounded == true)
        {
            //Gives a Player object velocity on +Y axis.
            rb.velocity += new Vector2(0, jumpForce);
        }```

somber kernel Dec 20, 2021, 10:11 AM

#

collapse all the components of the player object, and screenshot so I can see all the components

#

Are you mixing 2D and 3D colliders in the game project?

devout pulsar Dec 20, 2021, 10:13 AM

#

#

I hope not, but let me check

#

no, everything is in 2D

somber kernel Dec 20, 2021, 10:14 AM

#

go to your tilemap and show me the type of collider its using

devout pulsar Dec 20, 2021, 10:15 AM

#

somber kernel Dec 20, 2021, 10:16 AM

#

Have you enabled this ?

Used by Composite

devout pulsar Dec 20, 2021, 10:17 AM

#

yes

somber kernel Dec 20, 2021, 10:20 AM

#

hmm

#

there is one thing that is weird

#

You say the error comes when you Press the Jump button

devout pulsar Dec 20, 2021, 10:21 AM

#

    {
        Vector2 contact = collision.GetContact(0).normal;

        if (collision.collider.gameObject.layer == groundLayer)
        {
            if (contact.y > 0)
            {
                isGrounded = true;
            }
        }
    }```
when  the value of contact.y > 0 I can always jump but when I change it to 1 I can't jump at all

somber kernel Dec 20, 2021, 10:21 AM

#

why would you change it to 1 ?

devout pulsar Dec 20, 2021, 10:22 AM

#

just to check if its even working

#

bc you wasn't sure if I connected it to the object corretly

somber kernel Dec 20, 2021, 10:22 AM

#

kk

#

Add a Debug.Log("Enter") and Exit to the Collision events

devout pulsar Dec 20, 2021, 10:23 AM

#

Now I get 2 errors acutally

#

UnityEditor.GameObjectInspector.ClearPreviewCache () (at <ef3b6bf002d8435a97b4e938f6c49b02>:0)
UnityEditor.GameObjectInspector.OnDisable () (at <ef3b6bf002d8435a97b4e938f6c49b02>:0)
UnityEditor.Tilemaps.GridPaintPaletteClipboard:OnDisable() (at C:/Users/joel.gylden/Desktop/Elevprojekt Examination #1/Sidescroller - SU21a/Library/PackageCache/com.unity.2d.tilemap@1.0.0/Editor/GridPaintPaletteClipboard.cs:347)

somber kernel Dec 20, 2021, 10:25 AM

#

then you've changed something I know nothing about, or Unity is derping

devout pulsar Dec 20, 2021, 10:25 AM

#

Ok

#

so

#

I get the Debug.Log on the first part of the code

#

    {
        Vector2 contact = collision.GetContact(0).normal;

        if (collision.collider.gameObject.layer == groundLayer)
        {
            if (contact.y > 0)
            {
                Debug.Log("ON");
                isGrounded = true;
            }
        }
    }

somber kernel Dec 20, 2021, 10:26 AM

#

and the exit?

devout pulsar Dec 20, 2021, 10:26 AM

#

nothing from the exit

somber kernel Dec 20, 2021, 10:26 AM

#

is the player able to Jump?

devout pulsar Dec 20, 2021, 10:26 AM

#

Ye

#

but infinitly

somber kernel Dec 20, 2021, 10:27 AM

#

and when it leaves ground, the error displays?

devout pulsar Dec 20, 2021, 10:27 AM

#

Ye

somber kernel Dec 20, 2021, 10:27 AM

#

or every time you press Jump?

devout pulsar Dec 20, 2021, 10:28 AM

#

when it leaves ground

somber kernel Dec 20, 2021, 10:30 AM

#

huh, try this

#

instead of making GroundCheck a separate script

#

add the code to the main script
make isGrounded private

#

see if that works

devout pulsar Dec 20, 2021, 10:31 AM

#

but havent I done it before?

somber kernel Dec 20, 2021, 10:31 AM

#

I haven't told you to do that before.

#

so idk

devout pulsar Dec 20, 2021, 10:32 AM

#

Ye but I did that by mistake

somber kernel Dec 20, 2021, 10:32 AM

#

was it correctly implemented?

devout pulsar Dec 20, 2021, 10:33 AM

#

probably not let me do it again

somber kernel Dec 20, 2021, 10:33 AM

#

Actually, show me your PlayerInput component. Is it a script or an asset?

devout pulsar Dec 20, 2021, 10:34 AM

#

somber kernel Dec 20, 2021, 10:36 AM

#

Where did you get this?

devout pulsar Dec 20, 2021, 10:36 AM

#

my teacher

somber kernel Dec 20, 2021, 10:36 AM

#

is it the new input system?

devout pulsar Dec 20, 2021, 10:37 AM

#

I have no idea

somber kernel Dec 20, 2021, 10:37 AM

#

Has he hinted at which approach to use for grounding?

#

were you supposed to use the one you previously had?

devout pulsar Dec 20, 2021, 10:37 AM

#

What we did in our orginall project, we used separete boxCollider2D

#

as a groundCheck

somber kernel Dec 20, 2021, 10:39 AM

#

and now you were told to do it in a scriptable way?

devout pulsar Dec 20, 2021, 10:40 AM

#

yes

#

I mean

#

I wasn't told to do that but to do similar player properties using only script

somber kernel Dec 20, 2021, 10:43 AM

#

Well. I'm not sure why OnCollisionExit2D is not working

#

so just go with a Cast

#

like the other guy suggested

#

https://www.youtube.com/watch?v=c3iEl5AwUF8&ab_channel=CodeMonkey

YouTube

Code Monkey

3 ways to do a Ground Check in Unity

✅ Get the Project files and Utilities at https://unitycodemonkey.com/video.php?v=c3iEl5AwUF8
Let's look at 3 different methods for doing a Ground Check which is a necessity if you're making a Platformer.

If you have any questions post them in the comments and I'll do my best to answer them.

🔔 Subscribe for more Unity Tutorials https://www.yout...

▶ Play video

#

BoxCast is good for BoxColliders, unless you want special quirks, then go with multiple Raycasts

#

you should be able to get the surface normal (a directional vector) from the point of contact

#

but you can also just shape it to only work with ground

devout pulsar Dec 20, 2021, 10:47 AM

#

I would but the problem with this, is that I can't add any more components to the player

#

I guess I will have to skip it

#

But thank you for your effort

somber kernel Dec 20, 2021, 10:50 AM

#

a BoxCast isn't a component

#

it is code

#

you can visualize it with Gizmos or Debug.Draw something

#

Good luck o/

#Grounding