button working different after pressed... please help | Official Unity Discord | Page 1

daring dune Nov 7, 2021, 1:57 PM

#

i have a button to add more to a fill image (progress bar). after i hold the button it progresses just fine, with one add every update(). but when i have pressed it, let go, and presses it again, it increments the bar with 10 steps (???). why does it do that?

dense pulsar Nov 7, 2021, 1:59 PM

#

Show the code of the button click handler

daring dune Nov 7, 2021, 1:59 PM

#

using System.Collections;
using System.Collections.Generic;
using UnityEngine;
using UnityEngine.EventSystems;

public class FillButtonPressed : MonoBehaviour, IPointerUpHandler, IPointerDownHandler {

    private bool pressed = false;

    private void Update() {
        if(pressed) {
            transform.parent.GetComponentInChildren<DrinkBar>().Add(1);
        }
    }

    public void OnPointerDown(PointerEventData data) {
        pressed = true;
    }

    public void OnPointerUp(PointerEventData data) {
        pressed = false;
    }

}

#

and the fill bar code:

using System.Collections;
using System.Collections.Generic;
using UnityEngine;
using UnityEngine.UI;

public class DrinkBar : MonoBehaviour {

    public int maximum;
    public int current;
    public Image mask;

    private void Start() {
        
    }

    private void Update() {
        GetCurrentFill();
        if(current > maximum) current = maximum;
    }

    private void GetCurrentFill() {
        float fillAmount = (float)current / (float)maximum;
        mask.fillAmount = fillAmount;
    }

    public void Add(int amount) {
        current += amount;
    }

    public void Empty() {
        current = 0;
    }

}

#

i mean it should work the same after letting go and pressing again...?

dense pulsar Nov 7, 2021, 2:04 PM

#

I would say the error comes from GetCurrentFill, that sets the fill amount before checking if current > maximum

daring dune Nov 7, 2021, 2:04 PM

#

so i should set it before?

#

or inside the function

dense pulsar Nov 7, 2021, 2:05 PM

#

Check before setting, yes

#

(Swap the statements in Update)

daring dune Nov 7, 2021, 2:05 PM

#

nope, still not working

dense pulsar Nov 7, 2021, 2:07 PM

#

Debug it is, then
In both OnPointer* methods, and in the Add(int) method

#

Make sure that they're getting called as expected.

#

Ie. One log per OnPointer* per click/release, two or more will indicate duplicate scripts

daring dune Nov 7, 2021, 2:10 PM

#

huh? it works now, but i didnt change anything..?

dense pulsar Nov 7, 2021, 2:11 PM

#

We'll blame it on unsaved scripts, or cursed project then

daring dune Nov 7, 2021, 2:11 PM

#

wait

#

now it dont work?

#

what?

#

ok so it doesent work

#

my fault

#

but it isnt duplicated scripts...

#

its filling smooth on first press, after that it just "lags"

dense pulsar Nov 7, 2021, 2:15 PM

#

Okay, so try moving the whole code that's in DrinkBar:Update inside of DrinkBar:Add

fresh glacier Nov 7, 2021, 2:15 PM

#

By lag you mean it's adding inconsistently?

dense pulsar Nov 7, 2021, 2:16 PM

#

It should be doing the same thing as Add is called each frame when holding the click down

dense pulsar Nov 7, 2021, 2:17 PM

#

fresh glacier By lag you mean it's adding inconsistently?

Works fine for the first time, adds inconsistently (not smoothly) afterwards

daring dune Nov 7, 2021, 2:18 PM

#

really strange

daring dune Nov 7, 2021, 2:19 PM

#

dense pulsar Okay, so try moving the whole code that's in `DrinkBar:Update` inside of `DrinkB...

thats not working either

dense pulsar Nov 7, 2021, 2:20 PM

#

Okay, so now move the GetComponent call that calls Add in OnPointerDown, remove it from Update

daring dune Nov 7, 2021, 2:20 PM

#

k

dense pulsar Nov 7, 2021, 2:20 PM

#

See if clicking repeatedly on it increases it one by one

daring dune Nov 7, 2021, 2:21 PM

#

no it doesnt

#

i removed the add call

dense pulsar Nov 7, 2021, 2:22 PM

#

Removed from Update and added it in OnPointerDown, right?

daring dune Nov 7, 2021, 2:22 PM

#

oh

#

sec

#

yes, it increments per click now

dense pulsar Nov 7, 2021, 2:23 PM

#

And it's consistent.
So the problem comes from calling that in Update

#

Which adds 1 each frame, so 60 per second at 60fps

daring dune Nov 7, 2021, 2:24 PM

#

so like Time.deltaTime?

#

but it works first time without that...

dense pulsar Nov 7, 2021, 2:25 PM

#

Before that, does the OnPointerUp log as expected? Never used them too much so I have no idea if they're consistent

daring dune Nov 7, 2021, 2:26 PM

#

yeah

fresh glacier Nov 7, 2021, 2:26 PM

#

dense pulsar Which adds 1 each frame, so 60 per second at 60fps

Even if its that the problem, i find it weird that it increments inconsistently after the 2nd button press, it should have been the case for the 1st press too

daring dune Nov 7, 2021, 2:26 PM

#

yea thats the thing

fresh glacier Nov 7, 2021, 2:26 PM

#

Unless your fps is changing drastically after the 2nd button press somehow

dense pulsar Nov 7, 2021, 2:27 PM

#

Yep there's definitely some weirdness going on here

#

Try caching the result of your GetComponent call in Awake or Start, that will lighten up the load on that script

daring dune Nov 7, 2021, 2:28 PM

#

fresh glacier Even if its that the problem, i find it weird that it increments inconsistently ...

it isnt "inconsistent" after the second press, just not the same consistent as the first press

daring dune Nov 7, 2021, 2:28 PM

#

dense pulsar Try caching the result of your GetComponent call in Awake or Start, that will li...

how would i do that

#

oh i see

dense pulsar Nov 7, 2021, 2:29 PM

#

Store it in a field, as it's seemingly constant, you're getting the same script over and over

daring dune Nov 7, 2021, 2:30 PM

#

still the same!?

fresh glacier Nov 7, 2021, 2:33 PM

#

Change Update to FixedUpdate in the button class so it would increment by 1 consistently regardless of fps

#button working different after pressed... please help