A dumb C# Beginner Requiring Help | Official Unity Discord | Page 1

pastel flax Oct 22, 2023, 2:13 AM

#

Just moving here to de-clutter and cause I'm worried I'm getting on peoples nerves lol. So I now know it isn't IDE'd crorrectly I think? Because the assembly thing isn't there, all I see is the miscelanious thing. But how do I change that? The IDE links didn't really help

#

#

Also why is it yellow, does that mean theres an error?

#

I also noticed where it says "public class FindAnimationClips" is supposed to be the name of the .cs file. I changed the name of the file to that but still nothing

#

unborn lion Oct 22, 2023, 2:16 AM

#

Can you go to your console window in Unity and make sure that there are no errors

pastel flax Oct 22, 2023, 2:17 AM

#

There are PrecompiledAssemblyException errors but for a different script

unborn lion Oct 22, 2023, 2:17 AM

#

Any compiler errors will stop all scripts from compiling

#

Why do you have two versions of Harmony?

pastel flax Oct 22, 2023, 2:18 AM

#

I have no clue what it is, it just came with two different packages, the VRchat one and the CEditor thng I bought. Ill delete one of them now

#

#

So I deleted it and it spat out 68 new errors

#

But their not compilor errors right?

unborn lion Oct 22, 2023, 2:23 AM

#

Yes, they are

#

Perhaps restart Unity, and then you will need start at the top of the errors if they're still there

pastel flax Oct 22, 2023, 2:24 AM

#

Good news is it isn't miscelanoius anymore?

pastel flax Oct 22, 2023, 2:24 AM

#

unborn lion Perhaps restart Unity, and then you will need start at the top of the errors if ...

Sure!

#

Is there a dumbass role? I think I need it 😂

unborn lion Oct 22, 2023, 2:24 AM

#

You should be able to remove the underlined = new() in the above script and it should hopefully still work; if not you'll need to do new List<AnimationClip>().

somber cape Oct 22, 2023, 2:25 AM

#

ahh right .. old Unity

#

was about to say why would new() error xD

#

new c# flex

unborn lion Oct 22, 2023, 2:25 AM

#

"new" C#

somber cape Oct 22, 2023, 2:25 AM

#

*unity standards xD

pastel flax Oct 22, 2023, 2:26 AM

#

Closed and re-opened the project but the errors are all still there

#

Its nearly 4am here I'm gonna sleep and come back tomorrow lmao, Im sorry for being so dumb guys 😅

unborn lion Oct 22, 2023, 2:27 AM

#

🤷 you're learning, and listening, which is much better than many others 😄

pastel flax Oct 22, 2023, 2:28 AM

#

Haha thank you 😊

somber cape Oct 22, 2023, 2:30 AM

#

Im thinking you had 2 assets or something, using the same library and probably had 2 copies

#

not sure though, you might have some asemdef references to fix

pastel flax Oct 23, 2023, 9:23 PM

#

Hai! I'm sorry for not trying yesterday, some personal reasons. But yeah! I cleared all the Poiomi compilor errors, and now am just facing these two with the script

#

#

I also noticed this if it helps?

#

For anyone new looking here, here is the full script:

using System.Collections.Generic;
using UnityEditor;
using UnityEditor.UIElements;
using UnityEngine;
using UnityEngine.UIElements;

public class FindAnimationClips : EditorWindow
{
    [SerializeField]
    private List<AnimationClip> _clips = new();

    private void OnEnable()
    {
        var serializedObject = new SerializedObject(this);
        rootVisualElement.Add(new Button(GetAllClips) { text = "Get all clips" });
        rootVisualElement.Add(new Button(SetToLoop) { text = "Get clips set to loop" });
        rootVisualElement.Add(new Button(Unloop) { text = "Get clips set to not loop" });
        rootVisualElement.Add(new PropertyField { bindingPath = nameof(_clips) });
        rootVisualElement.Bind(serializedObject);
    }

    [MenuItem("Tools/Find Animation Clips")]
    private static void Open() => GetWindow<FindAnimationClips>().Show();

    private void GetAllClips()
    {
        string[] guids1 = AssetDatabase.FindAssets("t:AnimationClip", null);

        foreach (string guid1 in guids1)
        {
            Debug.Log(AssetDatabase.GUIDToAssetPath(guid1));

            AnimationClip animClip = AssetDatabase.LoadAssetAtPath<AnimationClip>(AssetDatabase.GUIDToAssetPath(guid1));

            if (!_clips.Contains(animClip))
            {
                _clips.Add(animClip);
            }
        }
    }

    private void SetToLoop() => CanLoop(true);

    private void Unloop() => CanLoop(false);

    private void CanLoop(bool canLoop)
    {
        foreach (AnimationClip clip in _clips)
        {
            var settings = AnimationUtility.GetAnimationClipSettings(clip);
            settings.loopTime = canLoop;
            AnimationUtility.SetAnimationClipSettings(clip, settings);
        }
    }
}

static rose Oct 23, 2023, 9:30 PM

#

You cannot use new() because the C# version coming with your Unity project isn't recent enough. You have C# 7.3, using new() requires C# 9 or newer.
Use = new List<AnimationClip>();, the long form that was there sonce the beginning of C#

#

Or none at all actually, since you serialize the field, Unity will create it for you for displaying in the Inspector

pastel flax Oct 23, 2023, 9:31 PM

#

Okay! Doesn't seem to be any compilor errors there now!

#

Also it won't be in inspector, its a tools dropdown

#

Ayy it shows up now!!

static rose Oct 23, 2023, 9:32 PM

#

If it shows up, it's in the Inspector

somber cape Oct 23, 2023, 9:33 PM

#

sweet so its working?

static rose Oct 23, 2023, 9:33 PM

#

Little to no knowledge of coding, and programming an Editor window on what seems like a VRChat addon? Seems a bit audacious

somber cape Oct 23, 2023, 9:33 PM

#

pastel flax Okay! Doesn't seem to be any compilor errors there now!

also they did tell you last time 😛

Screen_Shot_2023-10-23_at_5.33.29_PM.png

static rose Oct 23, 2023, 9:34 PM

#

lol

pastel flax Oct 23, 2023, 9:34 PM

#

somber cape also they did tell you last time 😛

Oh god hahaha

somber cape Oct 23, 2023, 9:34 PM

#

static rose Little to no knowledge of coding, and programming an Editor window on what seems...

its more of a quickfix for shortcoming of unity editor

#

i started the script, vertx ofc made it like much cleaner

pastel flax Oct 23, 2023, 9:35 PM

#

It did work but it sets every animation in the whole project to loop or not loop. Would it be possible to be able to drag in specific clips to change?

somber cape Oct 23, 2023, 9:35 PM

#

static rose Little to no knowledge of coding, and programming an Editor window on what seems...

apparently unity cant multi-edit fields when multiple animation clips are selected

#

weird af

somber cape Oct 23, 2023, 9:36 PM

#

pastel flax It did work but it sets every animation in the whole project to loop or not loop...

yes just remove the ones you dont want in the list

#

or just dont do Get All and put inside the clips hyou want

pastel flax Oct 23, 2023, 9:36 PM

#

static rose Little to no knowledge of coding, and programming an Editor window on what seems...

VRChat Addon? no just an addon to help working with unity a little less painfull lol

somber cape Oct 23, 2023, 9:36 PM

#

you have to drag the clips inside the Label

pastel flax Oct 23, 2023, 9:37 PM

#

somber cape yes just remove the ones you dont want in the list

Ohh it broke before and showed like a black box when I clicked get all lol

somber cape Oct 23, 2023, 9:37 PM

#

strange..

somber cape Oct 23, 2023, 9:38 PM

#

pastel flax Ohh it broke before and showed like a black box when I clicked get all lol

did you completely remove the new part ?

static rose Oct 23, 2023, 9:38 PM

#

pastel flax VRChat Addon? no just an addon to help working with unity a little less painfull...

Saw various VR toolbar items on a screenshot, so assumed it was a mod or plugin. I guess this is installed machine-wide and not per project

somber cape Oct 23, 2023, 9:39 PM

#

pastel flax Ohh it broke before and showed like a black box when I clicked get all lol

can you try again and screenshot

pastel flax Oct 23, 2023, 9:39 PM

#

pastel flax Oct 23, 2023, 9:39 PM

#

static rose Saw various VR toolbar items on a screenshot, so assumed it was a mod or plugin....

Nah, for avatars you can't have any scripts whatsoever. Only worlds can have custom scripts

somber cape Oct 23, 2023, 9:40 PM

#

pastel flax

thats weird

pastel flax Oct 23, 2023, 9:40 PM

#

Then again, I have somany animations it could be too much to handle?

somber cape Oct 23, 2023, 9:40 PM

#

did you completely remove new() or did you ptu new List<AnimationClips>

somber cape Oct 23, 2023, 9:41 PM

#

pastel flax Then again, I have somany animations it could be too much to handle?

also you can multiple select them and drag them inside the array

pastel flax Oct 23, 2023, 9:41 PM

#

1,007 to be exact

somber cape Oct 23, 2023, 9:41 PM

#

you dont have to do 1 at a time

#

you can drag all clips in here

Screen_Shot_2023-10-23_at_5.41.33_PM.png

#

and it will fill it for u

pastel flax Oct 23, 2023, 9:42 PM

#

somber cape did you completely remove `new()` or did you ptu `new List<AnimationClips>`

Removed

private List<AnimationClip> _clips = new();

to

private List<AnimationClip> _clips = new List<AnimationClip>();

somber cape Oct 23, 2023, 9:42 PM

#

okie

pastel flax Oct 23, 2023, 9:43 PM

#

somber cape you can drag all clips in here

Hiding and unhiding that little menu just hides and unhides the black box (I'm assuming that black is the size 1,007?)

somber cape Oct 23, 2023, 9:44 PM

#

No i meant remove them all and drag the clips inside without pressing GetAll

#

im going to try something real quick

pastel flax Oct 23, 2023, 9:44 PM

#

Sure!

#

Heres the script again:

using System.Collections.Generic;
using UnityEditor;
using UnityEditor.UIElements;
using UnityEngine;
using UnityEngine.UIElements;

public class FindAnimationClips : EditorWindow
{
    [SerializeField]
    private List<AnimationClip> _clips = new List<AnimationClip>();

    private void OnEnable()
    {
        var serializedObject = new SerializedObject(this);
        rootVisualElement.Add(new Button(GetAllClips) { text = "Get all clips" });
        rootVisualElement.Add(new Button(SetToLoop) { text = "Get clips set to loop" });
        rootVisualElement.Add(new Button(Unloop) { text = "Get clips set to not loop" });
        rootVisualElement.Add(new PropertyField { bindingPath = nameof(_clips) });
        rootVisualElement.Bind(serializedObject);
    }

    [MenuItem("Tools/Find Animation Clips")]
    private static void Open() => GetWindow<FindAnimationClips>().Show();

    private void GetAllClips()
    {
        string[] guids1 = AssetDatabase.FindAssets("t:AnimationClip", null);

        foreach (string guid1 in guids1)
        {
            Debug.Log(AssetDatabase.GUIDToAssetPath(guid1));

            AnimationClip animClip = AssetDatabase.LoadAssetAtPath<AnimationClip>(AssetDatabase.GUIDToAssetPath(guid1));

            if (!_clips.Contains(animClip))
            {
                _clips.Add(animClip);
            }
        }
    }

    private void SetToLoop() => CanLoop(true);

    private void Unloop() => CanLoop(false);

    private void CanLoop(bool canLoop)
    {
        foreach (AnimationClip clip in _clips)
        {
            var settings = AnimationUtility.GetAnimationClipSettings(clip);
            settings.loopTime = canLoop;
            AnimationUtility.SetAnimationClipSettings(clip, settings);
        }
    }
}

somber cape Oct 23, 2023, 9:45 PM

#

no worries I have it 😛

#

it could also be possible that its a lot of clips and it freaks out the editor lol

pastel flax Oct 23, 2023, 9:45 PM

#

somber cape it could also be possible that its a lot of clips and it freaks out the editor l...

True lol

#

I was thinking. if getting all animations is a case of doing "AssetDatabase.FindAssets("t:AnimationClip", null)" couldn't I have a search box and have it do this AssetDatabase.FindAssets("t:AnimationClip", [search], null)

#

Or soemthing

#

I'm assuming I would also need to do var Search = typebox or something, idk the script for an input box lol

somber cape Oct 23, 2023, 9:53 PM

#

FindAssets has no such thing

#

the first field is the searchname

#

it can probably be combined with a name possibly, i have to look into the search string format

pastel flax Oct 23, 2023, 9:56 PM

#

somber cape the first field is the searchname

Ah nvm then. Was just looking through the code to see how exactly it works to see what changes I could make

#

Its my stupid way of learning lmao

somber cape Oct 23, 2023, 9:58 PM

#

haha yeah starting from editor scripting wouldn't be the easiest

pastel flax Oct 23, 2023, 9:59 PM

#

LMAO probably not, but I changed the name of it in tools!

#

Anyway, Ill stop bugging you wheil you look at the black box thing

somber cape Oct 23, 2023, 10:08 PM

#

hmm yea not seeing any black boxes on this end

#

try just doing it in batches maybe ?

#

or did you try manually dragging them in the list

#

all at once

pastel flax Oct 23, 2023, 10:16 PM

#

So clicking get all, it does get all and I can actually toggle all on or off, however it displays a black box. Its a visual big not a functional bug

somber cape Oct 23, 2023, 10:19 PM

#

not sure if it has to do with something 2019 specific or too many elements for an editor array

#

I dont have that many clips to test anyway

#

You can try adding this line under rootVisualElement.Bind(serializedObject);
serializedObject.ApplyModifiedProperties();

#

but doubt it, it just fixes some other error i found

#

if it works though functionally nothing you should worry about

pastel flax Oct 23, 2023, 10:28 PM

#

Sure! Will try now

#

Nope

#

If you want to, I am happy to export the whole project as .unitypackage file and send it to you so you can see?

somber cape Oct 23, 2023, 11:15 PM

#

pastel flax If you want to, I am happy to export the whole project as .unitypackage file and...

hmm sure or maybe just the animations ?
won't be able to test till in the am tomorrow though

pastel flax Nov 5, 2023, 9:09 PM

#

@unborn lion @somber cape Hai! Do you mind if I put this up for free on Gumroad? Happy to credit any websites or pages of yours in it too, will already credit your discords

unborn lion Nov 5, 2023, 9:10 PM

#

Do whatever you want with it UnityChanThumbsUp

#A dumb C# Beginner Requiring Help