Custom editor drawer(s) | Official Unity Discord | Page 1

wind swan Mar 13, 2023, 8:53 PM

#

So, I am a bit confused, what is the point of ItemStatistics? Could you say once more exactly what the end result is that you are wanting?

#

@hollow needle if I am understanding this right, you want to show different fields based on what ItemStatistics there are? If so, then you cannot use a PropertyDrawer for this, instead you use a Editor for the Item MonoBehaviour

hollow needle Mar 13, 2023, 8:57 PM

#

let me get on my pc and i’ll explain

#

so what im trying to do, is that when you for example add two elements to the array, one for durability, and one for example for damage, there is an enum where you can pick a item statistic you want

#

and in the specific element

#

when you for example pick durability, i want it to show some specific fields in the inspector

#

below the enum

#

let me show you with screenshots

#

#

this is the axe item

#

and i want it to use durability and damage

#

so i just add them two

#

and now i need the specific fields in both elements

#

#

below the Statistic Type

wind swan Mar 13, 2023, 9:05 PM

#

Hmm, it might be more complicated than what you want. But I would probably change how you are doing this. I would have something like a ItemStat class that you inherit from, and each one has your stats like a HungerItemStats and DurabilityItemStats etc. Then in your Item class have a [SerializeReference] List<ItemStat> itemStats;. Then write a custom editor that has a list that lets you select the item stat you want to add to the list.

#

That way you don't have a bunch of fields on the class that cannot be used.

#

It would probably be about the same or less even editor scripting

hollow needle Mar 13, 2023, 9:07 PM

#

this is what the code looks like at the moment

#

https://paste.ofcode.org/3aRwcz6pwd2iwUPfUPTVYw9

#

if u need to take a look

#

hasnt changed much

#

i have no idea what this is

#

wind swan Mar 13, 2023, 9:09 PM

#

In for runtime use you could do things like

public T GetStat<T>() where T : ItemStat
{
  return itemStats.FirstOrDefault(i => i.GetType() == typeof(T));
}

// Usage
item.GetStat<DurabilityItemStat>().currentDurability = 5;

wind swan Mar 13, 2023, 9:09 PM

#

hollow needle

You don't need that at all.

#

For what you are saying you want to do, you want a custom editor not a property drawer

hollow needle Mar 13, 2023, 9:10 PM

#

you sure?

wind swan Mar 13, 2023, 9:10 PM

#

100%

hollow needle Mar 13, 2023, 9:10 PM

#

so what do i do

wind swan Mar 13, 2023, 9:10 PM

#

It isn't 'even possible' with PropertyDrawer

#

(it is, but you would be abusing the system and not how it is meant to be used at all)

wind swan Mar 13, 2023, 9:11 PM

#

wind swan Hmm, it might be more complicated than what you want. But I would probably chang...

@hollow needle this is what I recommend doing instead of what you are doing currently

hollow needle Mar 13, 2023, 9:11 PM

#

alright can we try that then?

#

im just gonna make a copy project

wind swan Mar 13, 2023, 9:12 PM

#

Sure! Let me know when you have gotten as far as you can on your own 🙂

#

(@ or reply to me)

hollow needle Mar 13, 2023, 9:13 PM

#

Okay

hollow needle Mar 13, 2023, 9:25 PM

#

wind swan Hmm, it might be more complicated than what you want. But I would probably chang...

make an ItemStat class inside the Item script?

#

at the bottom

#

or make a new script

wind swan Mar 13, 2023, 9:25 PM

#

New script

#

That is just a normal C# class

hollow needle Mar 13, 2023, 9:26 PM

#

Okie

#

what should the itemstat inherit from?

#

or nothing

#

just monobehaviour?

#

oh wait will the Item be inheriting from the ItemStat?

wind swan Mar 13, 2023, 9:28 PM

#

ItemStat should inherit from nothing

#

Item should have a list of ItemStat. Classes that inherit from ItemStat should implement a set of fields. Like you should inherit from it and have one class have all of the durability related fields

#

And another with all of the damage related fields

hollow needle Mar 13, 2023, 9:29 PM

#

im starting to think though, are all these still going to be found in the Item class?

#

#

because i need them there

#

because in my scripts for example

#

i check if item.damageUsed

wind swan Mar 13, 2023, 9:30 PM

#

No, that is what I am saying, you move them out to their own classes. Then you just add them to the items that need them.

wind swan Mar 13, 2023, 9:30 PM

#

wind swan In for runtime use you could do things like ```cs public T GetStat<T>() where T ...

You could do something like this

hollow needle Mar 13, 2023, 9:31 PM

#

wind swan Mar 13, 2023, 9:31 PM

#

It does add a bit more code, but also separates it out better and makes it more modular. If you want to keep it as is, that is okay too! This is just my suggestion 🙂

hollow needle Mar 13, 2023, 9:32 PM

#

hollow needle

whats wrong here

wind swan Mar 13, 2023, 9:32 PM

#

Idk, what does the error say? 😛

hollow needle Mar 13, 2023, 9:32 PM

#

#

oh is it because there isnt a list here

#

#

wait no

wind swan Mar 13, 2023, 9:33 PM

#

hollow needle

Forgot to add the using System.Collections.Generics at the top

wind swan Mar 13, 2023, 9:33 PM

#

hollow needle

ItemStat should not inherit from anything btw

hollow needle Mar 13, 2023, 9:33 PM

#

wind swan `ItemStat` should *not* inherit from anything btw

okay

#

so now what would i do inside of ItemStat

wind swan Mar 13, 2023, 9:34 PM

#

Nothing inside of ItemStat, you just inherit from it

hollow needle Mar 13, 2023, 9:35 PM

#

oh

#

okay

#

so whats next

wind swan Mar 13, 2023, 9:35 PM

#

Create some classes that inherit from ItemStat that have the fields that you need

wind swan Mar 13, 2023, 9:35 PM

#

wind swan `Item` should have a list of `ItemStat`. Classes that inherit from `ItemStat` sh...

^

hollow needle Mar 13, 2023, 9:36 PM

#

do i need to make new scripts?

#

or just below

#

ItemStat

wind swan Mar 13, 2023, 9:36 PM

#

Up to you. Personally I like to follow the rule of one class per file as it makes it easier to find things

hollow needle Mar 13, 2023, 9:37 PM

#

what would be the good name

#

DurabilityStat?

#

DamageStat?

#

just have Stat at the end

wind swan Mar 13, 2023, 9:37 PM

#

Sure! Or you could do DamageItemStat if you think you might have other places you would use similarly named stats

#

Like if you might have enemies, it would be good to specify that these are ItemStats and not just DamageStats. But for naming, it is what ever you feel like you would understand the easiest

hollow needle Mar 13, 2023, 9:39 PM

#

true

hollow needle Mar 13, 2023, 9:39 PM

#

wind swan Sure! Or you could do `DamageItemStat` if you think you might have other places ...

i name them like that

#

this is the Item script now

#

#

ItemStat

#

#

and durability stat

#

correct so far?

wind swan Mar 13, 2023, 9:40 PM

#

Yup!

hollow needle Mar 13, 2023, 9:41 PM

#

do i just put these in the DurabilityItemStat?

#

or do i need something else

wind swan Mar 13, 2023, 9:41 PM

#

Nope, just put those in. And remove the attribute

hollow needle Mar 13, 2023, 9:41 PM

#

Okie

wind swan Mar 13, 2023, 9:41 PM

#

We don't need it any more since we do want to see them now

hollow needle Mar 13, 2023, 9:41 PM

#

yeah cause i dont need the HideInInspector anymore

#

alright let me just create all the classes

#

for different stats

#

now that Item inherits from ItemStat

#

im getting errors

#

#

in my other scripts

#

a lot of errors

wind swan Mar 13, 2023, 9:43 PM

#

No, item should not inherit from ItemStat

#

Item is a container for a set of ItemStats

hollow needle Mar 13, 2023, 9:44 PM

#

so just mono behaviour

#

as it was

#

?

wind swan Mar 13, 2023, 9:46 PM

#

Think of it like modules. An item is like an empty container, it just contains the basic info that all items contain like ID. Then you add modules (ItemStat) for different items. So if you have an axe you add the Damage(DamangeItemStat) and durability(DurabilityItemStat) modules to the item to give it that sort of functionality

hollow needle Mar 13, 2023, 9:47 PM

#

thats cool

#

thats better than what i was going for

#

cleaner

wind swan Mar 13, 2023, 9:48 PM

#

It is kind of like the component system in Unity, where the Item acts like the gameobject and the ItemStat is like the components

#

If that makes it more confusing than just ignore it 😛

hollow needle Mar 13, 2023, 9:48 PM

#

i get it

#

just need to make the recoil one

#

give me a sec

#

#

i have all of these now

#

#

Item looks a lot cleaner

wind swan Mar 13, 2023, 9:51 PM

#

Nice!

hollow needle Mar 13, 2023, 9:51 PM

#

so what would i do now

wind swan Mar 13, 2023, 9:52 PM

#

Now we move on to the actual editor part. Create a new script in the Editor folder for the Item component and make it a custom editor (you can google setting up the very basics of a custom editor if you don't know)

hollow needle Mar 13, 2023, 9:53 PM

#

yeah i know how

#

give me a second

#

#

got that

wind swan Mar 13, 2023, 9:56 PM

#

Question, what version are you on, and do you want to use IMGUI or UIToolkit?

hollow needle Mar 13, 2023, 9:56 PM

#

2020.3.13f1

hollow needle Mar 13, 2023, 9:56 PM

#

wind swan Question, what version are you on, and do you want to use IMGUI or UIToolkit?

what is IMGUI?

#

let me google

wind swan Mar 13, 2023, 9:56 PM

#

That is the OnGUI and GUILayout etc

hollow needle Mar 13, 2023, 9:57 PM

#

#

is it this?

wind swan Mar 13, 2023, 9:57 PM

#

yeah

hollow needle Mar 13, 2023, 9:57 PM

#

would it be harder to not use it?

wind swan Mar 13, 2023, 9:58 PM

#

Uhh, in 2020.3, probably a bit harder?

#

I mean it would be harder to use UIToolkit

hollow needle Mar 13, 2023, 9:58 PM

#

is this what youre talking about?

#

wind swan Mar 13, 2023, 9:59 PM

#

That is IMGUI yes

hollow needle Mar 13, 2023, 9:59 PM

#

cause i did this before

#

yes

#

then lets use it

wind swan Mar 13, 2023, 9:59 PM

#

yeah

hollow needle Mar 13, 2023, 9:59 PM

#

i thought you were talking about something different 😅

#

like there would be a button on my scene window or something

#

wind swan Mar 13, 2023, 10:01 PM

#

So, at a high level, you will want to create a ReorderableList. And in the drawCallback you would just use a EditorGUI.PropertyField and in the addCallback you will populate the generic menu using the TypeChache class.

#

It will make more sense when you look up how to use ReorderableList

hollow needle Mar 13, 2023, 10:02 PM

#

alright let me look it up

#

#

is it this?

#

wait thats a property drawer

wind swan Mar 13, 2023, 10:04 PM

#

A little old but this looks like a decent source https://blog.terresquall.com/2020/03/creating-reorderable-lists-in-the-unity-inspector/

hollow needle Mar 13, 2023, 10:05 PM

#

this is litterly what i was watching just now

#

#

😅

#

so what function will i need?

#

wind swan Mar 13, 2023, 10:12 PM

#

Start with making the ReorderableList

hollow needle Mar 13, 2023, 10:14 PM

#

#

why is it in red

#

im following the tutorial

#

#

and on his it aint

wind swan Mar 13, 2023, 10:15 PM

#

using UnityEditorInternal

hollow needle Mar 13, 2023, 10:15 PM

#

ohhh

#

i did

#

UnityEngineInternal

hollow needle Mar 13, 2023, 10:24 PM

#

wind swan `using UnityEditorInternal`

do i keep going?

#

#

because im not sure where i should stop

#

or follow it to the end?

wind swan Mar 13, 2023, 10:25 PM

#

That should be good I guess

#

So, in the DrawElement method, use the SerializedObject and get the serializedproperty for the stats list, and then the serializedproperty element at index in that list

#

Then we draw it with EditorGUIPropertyField

hollow needle Mar 13, 2023, 10:29 PM

#

wind swan So, in the DrawElement method, use the SerializedObject and get the serializedpr...

#

i dont really know what you mean 😅

wind swan Mar 13, 2023, 10:30 PM

#

Yeah! Now you do itemStats.GetArrayElementAtIndex(index) to get whatever is at that index in ItemStats

hollow needle Mar 13, 2023, 10:30 PM

#

alright

wind swan Mar 13, 2023, 10:31 PM

#

Then just plop the result of that in to a EditorGUI.PropertyField(rect, itemStat);

hollow needle Mar 13, 2023, 10:31 PM

#

okie

#

#

is that what its supposed to look like?

unkempt kiln Mar 13, 2023, 10:32 PM

#

Oh hey, still at it? 😄

wind swan Mar 13, 2023, 10:32 PM

#

Use the result of GetArray... in the PropertyField

hollow needle Mar 13, 2023, 10:35 PM

#

so it goes in here?

#

wind swan Mar 13, 2023, 10:35 PM

#

No, in DrawElement

#

We first get the property of all of the item stats (FindProperty(..)), we then get the item stat at the specific index (GetArratElementAtIndex(..)), and then we draw that item stat (PropertyField(..))

hollow needle Mar 13, 2023, 10:41 PM

#

i have no idea what i just did

#

#

lmao

wind swan Mar 13, 2023, 10:42 PM

#

lol

#

Where are we at?

hollow needle Mar 13, 2023, 10:42 PM

#

wind swan We first get the property of all of the item stats (`FindProperty(..)`), we then...

still trying to figure this out

#

its difficult when i have never touched reorderable lists

wind swan Mar 13, 2023, 10:44 PM

#

the drawElementCallback is called for every item in the bound SerializedProperty (the one given in the constructor). In this case you gave it itemStats so it is every item in itemStats.

hollow needle Mar 13, 2023, 10:47 PM

#

so i have to do something similar to what he did?

#

wind swan Mar 13, 2023, 10:48 PM

#

var itemStatsProperty = serializedObject.FindProperty("itemStats");
var itemStatProperty = itemStatsProperty.GetArrayElementAtIndex(index);
EditorGUI.PropertyField(rect, itemStatProperty);

#

That is all ya need to do inside of the DrawElement callback method

hollow needle Mar 13, 2023, 10:49 PM

#

thats is?

#

alright

#

https://paste.ofcode.org/Cmsx5LwbDFGm6AXad36Xhr

#

this is what i now have

wind swan Mar 13, 2023, 10:51 PM

#

What does the inspector look like right now

hollow needle Mar 13, 2023, 10:51 PM

#

a mess

#

lmao

#

let me show u

wind swan Mar 13, 2023, 10:51 PM

#

use DrawDefaultInspector instead of base.OnInspectorGUI

hollow needle Mar 13, 2023, 10:51 PM

#

#

wind swan Mar 13, 2023, 10:52 PM

#

No need for base.

hollow needle Mar 13, 2023, 10:52 PM

#

oh okay

#

wind swan Mar 13, 2023, 10:53 PM

#

hmm, those errors do be funky

hollow needle Mar 13, 2023, 10:53 PM

#

#

its the list.DoLayoutList();

wind swan Mar 13, 2023, 10:54 PM

#

Debug.log itemStats to make sure it is being found

hollow needle Mar 13, 2023, 10:54 PM

#

where do i put the debug

#

because is theres no update

#

😅

wind swan Mar 13, 2023, 10:55 PM

#

Just in OnEnable is fine

hollow needle Mar 13, 2023, 10:55 PM

#

Null

#

do i have to change something here?

#

wind swan Mar 13, 2023, 10:56 PM

#

Make sure that the string is the same as the name of the field

hollow needle Mar 13, 2023, 10:57 PM

#

it is

wind swan Mar 13, 2023, 10:58 PM

#

slap a public on it too just to be sure (the itemStats field)

hollow needle Mar 13, 2023, 10:58 PM

#

still null

wind swan Mar 13, 2023, 10:58 PM

#

coolio

hollow needle Mar 13, 2023, 10:58 PM

#

?

wind swan Mar 13, 2023, 11:00 PM

#

OOh I know lol

#

Ya need to add [Serializable] to the ItemStat class and all derived classes

hollow needle Mar 13, 2023, 11:02 PM

#

#

what am i doing wrong

wind swan Mar 13, 2023, 11:02 PM

#

System namespace

hollow needle Mar 13, 2023, 11:02 PM

#

oh

#

alright

#

so to all these as well?

wind swan Mar 13, 2023, 11:02 PM

#

yeah

hollow needle Mar 13, 2023, 11:02 PM

#

what about Item?

#

no?

wind swan Mar 13, 2023, 11:03 PM

#

no

hollow needle Mar 13, 2023, 11:03 PM

#

done it

wind swan Mar 13, 2023, 11:03 PM

#

now try

hollow needle Mar 13, 2023, 11:03 PM

#

no more error

#

wow

#

works

#

wind swan Mar 13, 2023, 11:03 PM

#

Do you know what we just did?

hollow needle Mar 13, 2023, 11:03 PM

#

no

#

can u explain?

wind swan Mar 13, 2023, 11:04 PM

#

Yup!

#

so Serializedobject gives us a representation of the serialized (savable to disk) data of a UnityEngine.Object. Normal C# classes and structs need to have the Serializable attribute on them though so that Unity knows that it should serialize them at all even. So the reason it was returning null was because the field was not being serialized at all so the SerializedObject could not find it

#

Does that make sense? Any questions?

hollow needle Mar 13, 2023, 11:06 PM

#

ohh

#

yeah

#

wait so would you use serialize for like saving and loading

#

if it can save data to disk

wind swan Mar 13, 2023, 11:08 PM

#

No, SerializedObject is only for the editor. However things like unity's JsonUtility do use the Serializable attribute...iirc

hollow needle Mar 13, 2023, 11:08 PM

#

alright

#

also why when i change the name from itemStats

#

to itemStatistics

#

#

here

#

and also change it in the editor script

#

#

#

its seperate

wind swan Mar 13, 2023, 11:12 PM

#

It wasn't because you changed the name, you just didn't see it since adding the Serializable attribute

#

That is expected, you can add the HideInInspector attribute to the field since we are handling drawing it our selves

hollow needle Mar 13, 2023, 11:13 PM

#

just like that?

#

that worked

#

how can i move it down a bit?

#

#

its touching the itemID

wind swan Mar 13, 2023, 11:14 PM

#

GUILayout.Sacpe(200);

hollow needle Mar 13, 2023, 11:15 PM

#

#

here right?

wind swan Mar 13, 2023, 11:15 PM

#

yup

hollow needle Mar 13, 2023, 11:15 PM

#

alright works

#

so whats next?

#

have we done the hard part?

#

😅 🤣

wind swan Mar 13, 2023, 11:15 PM

#

LOL

#

Sort of... not xD

#

Almost done though! 😄

#

So ReorderableList has 2 callbacks for adding, one of them has like "menu" or "multi" or something in the name, we want to add a callback to that one

hollow needle Mar 13, 2023, 11:18 PM

#

alright

#

so

wind swan Mar 13, 2023, 11:18 PM

#

Did ya do that?

hollow needle Mar 13, 2023, 11:18 PM

#

#

which one is it

wind swan Mar 13, 2023, 11:18 PM

#

yeah the dropdown one

#

onAddDropdownCallback

hollow needle Mar 13, 2023, 11:18 PM

#

yup

#

let me make a function

#

for it

#

what should i name it

#

AddElement?

wind swan Mar 13, 2023, 11:20 PM

#

Name it what makes sense for what it is used for. OnAddItemStatDropdown or something

hollow needle Mar 13, 2023, 11:20 PM

#

#

got it

wind swan Mar 13, 2023, 11:21 PM

#

Nice, now we have two important glass we will use. The first is GenericMenu

hollow needle Mar 13, 2023, 11:21 PM

#

okay

wind swan Mar 13, 2023, 11:21 PM

#

https://docs.unity3d.com/ScriptReference/GenericMenu.html

hollow needle Mar 13, 2023, 11:23 PM

#

wind swan Mar 13, 2023, 11:23 PM

#

We create a instance of it and show it in that method. See if you can get a generic menu to show with a couple of dumby items that just Debug.Log when clicked

hollow needle Mar 13, 2023, 11:23 PM

#

okay

#

oh

#

it has to be in a seperate class?

#

because here it uses EditorWindow

wind swan Mar 13, 2023, 11:30 PM

#

No, no it is just an example of how to use it

#

you can use it anywhere

hollow needle Mar 13, 2023, 11:30 PM

#

oh

#

alright

#

wind swan Mar 13, 2023, 11:30 PM

#

Don't just copy paste the example, that won't be helpful

hollow needle Mar 13, 2023, 11:30 PM

#

i wanna just copy and paste it

#

to see what it looks like

#

and then change it

wind swan Mar 13, 2023, 11:31 PM

#

Well it wasn't made to be copy pasted so you are going to have lots of issues

hollow needle Mar 13, 2023, 11:32 PM

#

im gonna watch a tutorial on it

#

gimme some time

wind swan Mar 13, 2023, 11:32 PM

#

Sounds good @ me when ya are ready for some more help! 🙂

hollow needle Mar 13, 2023, 11:32 PM

#

okay

hollow needle Mar 13, 2023, 11:33 PM

#

wind swan Sounds good @ me when ya are ready for some more help! 🙂

we're inherating from Editor

#

#

#

but brackeys for example is inherating from EditorWindow

#

does that make a difference?

wind swan Mar 13, 2023, 11:35 PM

#

No, again you can use it anywhere. It is just easy for examples and tutorials to use an editor window because they are standalone and don't require other things like components.

hollow needle Mar 13, 2023, 11:35 PM

#

also why are we making a window? what is it going to do

wind swan Mar 13, 2023, 11:35 PM

#

We are not making an editor window

#

You now, nvm here lets do this instead. It will be easier for you.

#

// inside of the dropdown callback method we made...

var menu = new GenericMenu();

var entryXName = new GUIContent("X");
bool isEntryXSelected = false;

GenericMenu.MenuFunction onEntryXClicked = () => {
  Debug.Log("X has been clicked!");
};

menu.AddItem(entryXName, isEntryXSelected, onEntryXClicked);

menu.ShowAsContext();

#

Try that and see if it makes more sense to you @hollow needle

hollow needle Mar 13, 2023, 11:41 PM

#

#

why is Action giving an error

wind swan Mar 13, 2023, 11:41 PM

#

You need the System namespace

hollow needle Mar 13, 2023, 11:41 PM

#

wind swan Mar 13, 2023, 11:42 PM

#

Ehh, I thought it would convert my bad

#

Edited

hollow needle Mar 13, 2023, 11:43 PM

#

okay

#

#

what have i done wrong here

wind swan Mar 13, 2023, 11:45 PM

#

void MyMethod(Rect rect, ReordeableList list) is the signature of the method

hollow needle Mar 13, 2023, 11:46 PM

#

#

thats soo cool

#

and that'll be used to add the statistics?

wind swan Mar 13, 2023, 11:46 PM

#

Yeah!

hollow needle Mar 13, 2023, 11:46 PM

#

thats so cool

#

so how do we add multiple buttons?

#

i mean not buttons

#

like the X

#

because there is 1 at the moment

wind swan Mar 13, 2023, 11:48 PM

#

How do you think?

hollow needle Mar 13, 2023, 11:51 PM

#

#

like this?

#

it works

wind swan Mar 13, 2023, 11:51 PM

#

😄

hollow needle Mar 13, 2023, 11:51 PM

#

so should i make buttons for each of the item statistics now?

#

durability, damage etc

wind swan Mar 13, 2023, 11:52 PM

#

No need! That is were class number 2 comes in!

hollow needle Mar 13, 2023, 11:52 PM

#

alright

wind swan Mar 13, 2023, 11:52 PM

#

https://docs.unity3d.com/ScriptReference/TypeCache.GetTypesDerivedFrom.html

#

Read the documentation and look at the example. I think you might be able to figure out how to do it from here!

#

But its okay if you can't

hollow needle Mar 13, 2023, 11:55 PM

#

im not sure how it works

#

is it

#

nvm

wind swan Mar 13, 2023, 11:56 PM

#

Did you read the doc page?

hollow needle Mar 13, 2023, 11:57 PM

#

yeah

wind swan Mar 13, 2023, 11:57 PM

#

And you still are not sure what the method does?

#

It gives you a collection of all the types that inherit from the specified type

hollow needle Mar 13, 2023, 11:58 PM

#

so all these

#

wind swan Mar 13, 2023, 11:58 PM

#

var itemStatTypes = TypeCahche.GetTypesDerivedFrom<ItemStat>();

wind swan Mar 13, 2023, 11:59 PM

#

hollow needle so all these

Yeah

#

Then you loop over itemStatTypes and add an item to the generic menu for each one

hollow needle Mar 13, 2023, 11:59 PM

#

okay

#

so what would i do with the bool

#

wind swan Mar 14, 2023, 12:02 AM

#

Well that isn't going to work, since itemStatType is a System.Type and the first argument of AddItem takes a GUIContent

#


menu.AddItem(new GUIContent(itemStatType.Name), false, OnAddItem, (index, itemStatType));

// Add this method...
private void OnAddItem(object typeObject)
{

  (int index, Type type) = ((int, Type))typeObject;
  
   var itemStatsProperty = serializedObject.FindProperty("itemStatistics");
  // Add an item to the array.
  itemStatsProperty.arraySize++;

  var itemStatProperty = itemStatsProperty.GetArrayElementAt(index);

  var itemStat = Activator.CreateInstance(type);

  itemStatProperty.managedReferenceValue = itemStat;
  serializedObject.ApplyModifiesProperties();
}

#

Okay @hollow needle I gtg for an hour or so. But I think this should do it for you

hollow needle Mar 14, 2023, 12:13 AM

#

alright

#

thanks so much for everything

wind swan Mar 14, 2023, 12:14 AM

#

Replace the contents of the foreach loop you have now with the menu.AddItem that is in that code block

hollow needle Mar 14, 2023, 12:14 AM

#

you're the only person that actually understood what i wanted to do for like a week

#

lmao

wind swan Mar 14, 2023, 12:14 AM

#

lol

hollow needle Mar 14, 2023, 12:14 AM

#

i couldnt get any progress for a week because i couldnt get help

hollow needle Mar 14, 2023, 12:14 AM

#

wind swan In for runtime use you could do things like ```cs public T GetStat<T>() where T ...

also this

#

is exactly what i needed

wind swan Mar 14, 2023, 12:15 AM

#

Sorry it ended up being such a rabbit whole but I hope it will end up working well for you and you are able to learn some stuff! 😄

hollow needle Mar 14, 2023, 12:15 AM

#

thanks

#

i'll message you here tmr if i have any problems

hollow needle Mar 14, 2023, 12:38 AM

#

this doesnt work

#

#

if you could help

#

let me show you the error

#

#

its when i try and add a statistic

#

#

when you press on one of them

hollow needle Mar 14, 2023, 12:39 AM

#

hollow needle

#

line 67 is this

#

wind swan Mar 14, 2023, 1:57 AM

#

hollow needle

In AddItem you did (statisticType, statisticType) instead of (index, statisticType)

hollow needle Mar 14, 2023, 1:23 PM

#

wind swan In `AddItem` you did `(statisticType, statisticType)` instead of `(index, statis...

alright im gonna try that now

#

im gettin on my pc

#

#

#

@wind swan

hollow needle Mar 14, 2023, 2:00 PM

#

https://paste.ofcode.org/TsvivAGKYphqdSuNpKfdsz

#

this is the code now

wind swan Mar 14, 2023, 2:57 PM

#

hollow needle

Yeah... im gonna bee honest idk what I was thinking. We don't need an index at all https://paste.ofcode.org/37ZNpPTSJFEw5S7YTThmxev

hollow needle Mar 14, 2023, 2:58 PM

#

im gonna try now

#

just gotta turn my pc on again 😅

hollow needle Mar 14, 2023, 3:04 PM

#

wind swan Yeah... im gonna bee honest idk what I was thinking. We don't need an index at a...

alright

#

so that works now

#

#

it adds elements

#

how would i display the values now?

#

#

these under the correct stat

wind swan Mar 14, 2023, 3:09 PM

#

hmmm it should be showing them...

hollow needle Mar 14, 2023, 3:13 PM

#

wind swan hmmm it should be showing them...

any idea why it isnt?

wind swan Mar 14, 2023, 3:14 PM

#

I could have gotten the code wrong for setting the managed reference so it is actually null still

#

Ah, you could change the inspector to debug mode to see if they are set properly

hollow needle Mar 14, 2023, 3:21 PM

#

#

its not showing in debug

wind swan Mar 14, 2023, 3:22 PM

#

That is odd...

hollow needle Mar 14, 2023, 3:27 PM

#

so what should i do?

#

#

i debuged

#

here

#

#

and it shows the right one

wind swan Mar 14, 2023, 3:36 PM

#

Sorry I'm not sure atm. And I gotta work so I can't help too much. I might be able to help later today. You could try debug.log other places. Another thing would be to create a simpler setup. Like, just a single field instead of a list so it is easier to debug what the issue might be. Start simple and make it more complicated as you go.

hollow needle Mar 14, 2023, 3:36 PM

#

could you help me later then?

wind swan Mar 14, 2023, 3:36 PM

#

Yeah, I will try to 🙂

hollow needle Mar 14, 2023, 3:37 PM

#

alright thanks

hollow needle Mar 14, 2023, 9:56 PM

#

I tried to debug everything btw

#

And it shows everything as it should

#

Everything gets set

hollow needle Mar 15, 2023, 6:00 PM

#

@wind swan i really dont wanna be annyoing

#

and i know u already helped me so much

#

if ur not busy later on today

#

could you help me?

wind swan Mar 15, 2023, 6:01 PM

#

hollow needle <@131292153300123648> i really dont wanna be annyoing

I will see if I can't take a look. If you could post the code you have now (the editor stuff and the needed runtime code) that way I can just copy paste it in to a project to test it out my self that would be great

hollow needle Mar 15, 2023, 6:03 PM

#

yeah sure

#

im at the gym atm

#

when i get back i’ll post it

hollow needle Mar 16, 2023, 5:55 PM

#

@wind swan

#

i found a way to make it work

#

its fine now

#

thanks for everything

#Custom editor drawer(s)