#Spiked whip in ClassicUO, code for setting up a weapon special ability has probably wrong graphic

1 messages · Page 1 of 1 (latest)

wicked bronze
#

Hello,

we play on shard UOAlive and we have a "Spiked whip" bugged in ClassicUO.
Bug is, that the whip gets a wrong special abilities.

I tracked it down to this line of code.
https://github.com/ClassicUO/ClassicUO/blob/cf2e73926b2e6d76f48ad08b996bd3c3720a7942/src/Game/GameObjects/PlayerMobile.cs#L1267

The CUO code checks for spiked whip, for itemID 0xA28A

Yet, when you check ingame, the Spiked whip has itemID 0xA292
So check in classicUO fails and it get wrong special weapon abilities assigned.

Now, I'm not 100% sure this is OSI accurate. Someone could have an ability to check graphic of Spiked whip on OSI?

But I checked ServUO code. And they also use 0xA292 for item "Spiked whip".
https://github.com/ServUO/ServUO/blob/9d743400c738c215817b9f5de0c8105ad7969983/Scripts/Services/Seasonal Events/KrampusEncounter/Items/SpikedWhip.cs#L10

Btw this is the github issue, which introduced whip items into CUO
https://github.com/ClassicUO/ClassicUO/issues/973

I don't have a Github account and not planning to create one, so this is the reason I'm writing here.

image.png
rain stratus
#

Hi everyone, I'm the person with the issue here on the shard mentioned. There were issues with the Barbed Whip and Bladed Whip too, but someone else responded to update weapons.xml with lines for them. It fixed the issue with the barbed and bladed whips, but not the spiked. I've tested in Enhanced Client and it works fine so it does seem to be a CUO thing and I'm not really willing to swap to another client just for one weapon 🙂

fresh vapor
#

i wonder if depends by the client version

wicked bronze
fresh vapor
#

🤔 ok

#

fixed

rain stratus
wicked bronze
#

other people confirmed it fixed.