Api Problem script doesn't seem to save for some reason... | Roblox Studio Community | Page 1

dull willow Mar 10, 2025, 7:59 PM

#

#

script is under server script service

#

Leaderstats script:
game.Players.PlayerAdded:Connect(function(player)

local leaderstats = Instance.new("Folder", player)
leaderstats.Name = "leaderstats"

local Cents = Instance.new("IntValue", leaderstats)
Cents.Name = "Cents"
Cents.Value = 0

local Dollars = Instance.new("IntValue", leaderstats)
Dollars.Name = "Dollars"
Dollars.Value = 0

local CentsInVault = Instance.new("IntValue", leaderstats)
CentsInVault.Name = "CentsInVault"
CentsInVault.Value = 0

local DollarsInVault = Instance.new("IntValue", leaderstats)
DollarsInVault.Name = "DollarsInVault"
CentsInVault.Value = 0

end)

#

Also under server script service

#

I'm pretty new to scripting and I wont be online since its getting pretty late but I would appreciate an answer which explains why it doesnt work :))

dull willow Mar 10, 2025, 8:02 PM

#

dull willow

Full script
local DataStoreService = game:GetService("DataStoreService")
local moneyDataStore = DataStoreService:GetDataStore("PlayerMoneyDataStore")
local centsDataStore = DataStoreService:GetDataStore("CentsDataStore")

game.Players.PlayerAdded:Connect(function(player)
local leaderstats = player:FindFirstChild("leaderstats")
if leaderstats then
local dollars = leaderstats:FindFirstChild("DollarsInVault")
local cents = leaderstats:FindFirstChild("CentsInVault")

    local storedCents
    local storedMoney
    local success, error = pcall(function()
        storedMoney = moneyDataStore:GetAsync(player.UserId) 
        storedCents = centsDataStore:GetAsync(player.UserId) 
    end)

    if not success then
        storedMoney = 0
        storedCents = 0
    end
    
    cents.Value = storedCents
    dollars.Value = storedMoney
end

end)

game.Players.PlayerRemoving:Connect(function(player)
local dollars = player.leaderstats and player.leaderstats.DollarsInVault
local cents = player.leaderstats and player.leaderstats.CentsInVault
if dollars and cents then
local success, error = pcall(function()
moneyDataStore:SetAsync(player.UserId, dollars.Value)
centsDataStore:SetAsync(player.UserId, cents.Value)

    end)

    if not success then
        warn("Failed to save data for " .. player.Name .. ": " .. error)
    end
end

end)

clever summit Mar 10, 2025, 8:07 PM

#

@dull willow did u change the settings of the game to allow saving?

dull willow Mar 10, 2025, 8:07 PM

#

yes

clever summit Mar 10, 2025, 8:07 PM

#

show error message

dull willow Mar 10, 2025, 8:07 PM

#

dull willow Mar 10, 2025, 8:08 PM

#

clever summit show error message

thats the problem, there is no error message

clever summit Mar 10, 2025, 8:08 PM

#

local DataStoreService = game:GetService("DataStoreService")
local moneyDataStore = DataStoreService:GetDataStore("PlayerMoneyDataStore")
local centsDataStore = DataStoreService:GetDataStore("CentsDataStore")

game.Players.PlayerAdded:Connect(function(player)
    local leaderstats = player:FindFirstChild("leaderstats")
    if leaderstats then
        local dollars = leaderstats:FindFirstChild("DollarsInVault")
        local cents = leaderstats:FindFirstChild("CentsInVault")

        local storedCents
        local storedMoney
        local success, error = pcall(function()
            storedMoney = moneyDataStore:GetAsync(player.UserId) 
            storedCents = centsDataStore:GetAsync(player.UserId) 
        end)

        if not success then
            storedMoney = 0
            storedCents = 0
        end

        cents.Value = storedCents
        dollars.Value = storedMoney
    end
end)

game.Players.PlayerRemoving:Connect(function(player)
    local dollars = player.leaderstats and player.leaderstats.DollarsInVault
    local cents = player.leaderstats and player.leaderstats.CentsInVault
    if dollars and cents then
        local success, error = pcall(function()
            moneyDataStore:SetAsync(player.UserId, dollars.Value) 
            centsDataStore:SetAsync(player.UserId, cents.Value)

        end)

        if not success then
            warn("Failed to save data for " .. player.Name .. ": " .. error)
        end
    end
end)

#

so like when u rejoin u don't have ur data?

dull willow Mar 10, 2025, 8:09 PM

#

yep

clever summit Mar 10, 2025, 8:09 PM

#

and ur testing this alone right?

dull willow Mar 10, 2025, 8:09 PM

#

yea

#

I tested it inside the game aswell

#

like outside of roblox studio

#

for some reason it doesnt seem to work

clever summit Mar 10, 2025, 8:10 PM

#

yeah doesn't matter where u test it just wanted to know if it was overloaded

#

why u using 2 seperate data stores?

dull willow Mar 10, 2025, 8:10 PM

#

I can use 1?

clever summit Mar 10, 2025, 8:10 PM

#

yeah u can save data in tables

dull willow Mar 10, 2025, 8:10 PM

#

like I said I'm pretty new to scripting

clever summit Mar 10, 2025, 8:10 PM

#

saving values seperately would only be useful in ordered data stores

dull willow Mar 10, 2025, 8:11 PM

#

and I know I can probably make a value inside the player instead of leaderstats but idk if that will change anything

dull willow Mar 10, 2025, 8:11 PM

#

clever summit saving values seperately would only be useful in ordered data stores

I mean would that work

faint graniteBOT Mar 10, 2025, 8:11 PM

#

studio ** You are now Level 8! ** studio

dull willow Mar 10, 2025, 8:11 PM

#

just using 1=

#

?

clever summit Mar 10, 2025, 8:11 PM

#

this seems wrong

local dollars = player.leaderstats and player.leaderstats.DollarsInVault
    local cents = player.leaderstats and player.leaderstats.CentsInVault

#

why "and" and not just +

#

or are you trying to save them seperately?

dull willow Mar 10, 2025, 8:12 PM

#

I dont know much about api scripting I'm pretty new to it so

#

idk

clever summit Mar 10, 2025, 8:12 PM

#

dull willow I dont know much about api scripting I'm pretty new to it so

script is server sided right?

dull willow Mar 10, 2025, 8:12 PM

#

yea

clever summit Mar 10, 2025, 8:12 PM

#

alr good

#

issue doesn't seem very obvious so far..

#

making these waitforchild is better

local dollars = leaderstats:FindFirstChild("DollarsInVault")
        local cents = leaderstats:FindFirstChild("CentsInVault")

cinder cloak Mar 10, 2025, 8:13 PM

#

Are you sure you're saving what you think youre saving? I'd confirm with some prints just before you save

dull willow Mar 10, 2025, 8:13 PM

#

cinder cloak Are you sure you're saving what you think youre saving? I'd confirm with some pr...

yea I'm pretty sure

clever summit Mar 10, 2025, 8:13 PM

#

cinder cloak Are you sure you're saving what you think youre saving? I'd confirm with some pr...

its a .value so its good

dull willow Mar 10, 2025, 8:14 PM

#

I sent the leaderstats script aswell

#

so you can look at that if you want

clever summit Mar 10, 2025, 8:14 PM

#

here is an issue

#

are you sure you want to have "player.leaderstats"?

#

not like player.leaderstats.dollars.value?

dull willow Mar 10, 2025, 8:14 PM

#

yea

clever summit Mar 10, 2025, 8:15 PM

#

might need a value behind this

dull willow Mar 10, 2025, 8:15 PM

#

if I just delete the and

#

and then just do player:findfirstchild("leaderstats") blah blah

clever summit Mar 10, 2025, 8:15 PM

#

woah

dull willow Mar 10, 2025, 8:15 PM

#

would that work?

clever summit Mar 10, 2025, 8:15 PM

#

i found an issue

#

pretty big one

dull willow Mar 10, 2025, 8:16 PM

#

what is it

clever summit Mar 10, 2025, 8:16 PM

#

actually

#

try the script but without the "player.leaderstats and"

#

cuz im not really sure what thats supposed to do here

dull willow Mar 10, 2025, 8:17 PM

#

I asked chat gpt to fix it and he did that so idk either

#

thats why I asked

#

alr I'm trying that now

clever summit Mar 10, 2025, 8:18 PM

#

dull willow I asked chat gpt to fix it and he did that so idk either

chatgpt doesn't know a thing thats the first thing u learn from using chatgpt

dull willow Mar 10, 2025, 8:19 PM

#

yea but when I need to do something I don't know about and I want it explained I generally go for chatgpt

clever summit Mar 10, 2025, 8:19 PM

#

dull willow yea but when I need to do something I don't know about and I want it explained I...

documentation explains stuff more clearly, chatgpt can be used to generate simple examples

#

change these to waitforchild because findforchild skips if there is none

dull willow Mar 10, 2025, 8:20 PM

#

idk what happened but my roblox studio is freaking out rn

cinder cloak Mar 10, 2025, 8:20 PM

#

Id say just confirm what youre saving via print statements before you save. Even if you think you know l

dull willow Mar 10, 2025, 8:21 PM

#

wait for child generally gives me an error so I tend not to use it anymore

#

it say's infinite yield on something

#

thats why I use if statements under most of my variables

clever summit Mar 10, 2025, 8:21 PM

#

cinder cloak Id say just confirm what youre saving via print statements before you save. Even...

this part is most likely the issue because in the saving hes doing dollars.value and the player.leaderstats has no value and with getting the data hes only getting 1 value not a table

clever summit Mar 10, 2025, 8:22 PM

#

dull willow wait for child generally gives me an error so I tend not to use it anymore

waitforchild gives an error "infinite yield" if the child doesn't exist for a long time, waitforchild is good to wait before stuff is loaded tho

#

and in ur situation that is good, because you're already ensuring it exists just waiting for it to load

#

try the script without the player.leaderstats and

dull willow Mar 10, 2025, 8:24 PM

#

yea I'm trying to try it lol

#

but I cant move my mouse in game for some reason rn

#

I have to restart my computer or something

#

wait I'll let you know I'm gonna restart the pc

clever summit Mar 10, 2025, 8:25 PM

#

alr

cinder cloak Mar 10, 2025, 8:28 PM

#

clever summit this part is most likely the issue because in the saving hes doing dollars.value...

Well if I do this:

local thing = Instance.new("Folder")
local otherThing = Instance.new("IntValue")
print(thing and otherThing.Value)

I do get 0, so I don't think that'd be a problem unless leaderstats is nil

#

and if I do without the .Value, I do get the value itself

clever summit Mar 10, 2025, 8:28 PM

#

cinder cloak Well if I do this: ```lua local thing = Instance.new("Folder") local otherThing ...

everything else looks fine so we'll wait to see what deleting it does

clever summit Mar 10, 2025, 8:30 PM

#

cinder cloak Well if I do this: ```lua local thing = Instance.new("Folder") local otherThing ...

also hes doing .value on "thing" aswell if u use that situation

cinder cloak Mar 10, 2025, 8:31 PM

#

clever summit also hes doing .value on "thing" aswell if u use that situation

What I'm saying is that, as long as there are leaderstats, using the and gets it fine

I do think not waiting for it may absolutely be leading to both dollars and cents being nil, which I think you mentioned in your messages about WaitForChild

clever summit Mar 10, 2025, 8:31 PM

#

cinder cloak What I'm saying is that, as long as there are leaderstats, using the `and` gets ...

waitforchild was just to make the script safer, i didn't say it was the issue

cinder cloak Mar 10, 2025, 8:33 PM

#

clever summit waitforchild was just to make the script safer, i didn't say it was the issue

Oh, well I'm saying it certainly could be. He doesn't confirm whether the save actually happened, just if it failed, so I think the save isn't happening at all.

dull willow Mar 10, 2025, 8:33 PM

#

my studio isn't working properly so I can't test it rn

#

I have to re download it or something Ig

clever summit Mar 10, 2025, 8:33 PM

#

wait

dull willow Mar 10, 2025, 8:33 PM

#

yes?

clever summit Mar 10, 2025, 8:34 PM

#

waitforchild may be the issue because you're using findfirstchild and you're not 100% sure it loaded yet because the script already fires when the player joins

#

so its just a race between the leaderstats setter and the saver

dull willow Mar 10, 2025, 8:34 PM

#

alr so I use waitforchild

clever summit Mar 10, 2025, 8:34 PM

#

after local leaderstats do print(leaderstats)

dull willow Mar 10, 2025, 8:35 PM

#

and I'll change the and thing that chatgpt made

clever summit Mar 10, 2025, 8:35 PM

#

dull willow and I'll change the and thing that chatgpt made

yeah i don't really know what chatgpt was doing but it doesn't seem right

dull willow Mar 10, 2025, 8:35 PM

#

yea

clever summit Mar 10, 2025, 8:35 PM

#

chatgpt outdated anyways if you're using the free version, copilot better

dull willow Mar 10, 2025, 8:35 PM

#

oh good to know

clever summit Mar 10, 2025, 8:36 PM

#

you can ask an ai when their knowledge was last updated to know if its useful for your situation or not

dull willow Mar 10, 2025, 8:37 PM

#

wait

#

studio opened I just need to figure out how to do the mouse thing

clever summit Mar 10, 2025, 8:41 PM

#

@dull willow stop

#

just got info that roblox studio is down

#

mine ain't work either

dull willow Mar 10, 2025, 8:45 PM

#

ohhh

#

alr

clever summit Mar 10, 2025, 8:45 PM

#

can you still open studio?

dull willow Mar 10, 2025, 8:45 PM

#

ye

clever summit Mar 10, 2025, 8:45 PM

#

only the camera is down, scripting is fine

dull willow Mar 10, 2025, 8:46 PM

#

btw how do you post something in a script format in discord lol

clever summit Mar 10, 2025, 8:46 PM

#

dull willow Mar 10, 2025, 8:46 PM

#

been trying to figure that out for a while

#

print("Hi")

#

oh

#

ty

#

I think it works

clever summit Mar 10, 2025, 8:50 PM

#

you added waitforchild and removed the leaderstats thingy?

dull willow Mar 10, 2025, 8:50 PM

#

it's a script where I have to use a vault gui to know if I can deposit or not but when I modify the leaderstats from directly the script it stays at 0 so it probably works

clever summit Mar 10, 2025, 8:50 PM

#

alr wait theres a way to test this

#

dang it i closed studio wait

dull willow Mar 10, 2025, 8:51 PM

#

wait

clever summit Mar 10, 2025, 8:51 PM

#

@dull willow make the script save a value you want to test to 4

dull willow Mar 10, 2025, 8:52 PM

#

there is something wrong

clever summit Mar 10, 2025, 8:52 PM

#

and then revert it back after its 4

dull willow Mar 10, 2025, 8:52 PM

#

final script is this

local DataStoreService = game:GetService("DataStoreService")
local moneyDataStore = DataStoreService:GetDataStore("PlayerMoneyDataStore")
local centsDataStore = DataStoreService:GetDataStore("CentsDataStore")

game.Players.PlayerAdded:Connect(function(player)
    local leaderstats = player:WaitForChild("leaderstats")
    local dollars = leaderstats:FindFirstChild("DollarsInVault")
    local cents = leaderstats:FindFirstChild("CentsInVault")
    local storedCents
    local storedMoney
        local success, error = pcall(function()
            storedMoney = moneyDataStore:GetAsync(player.UserId) 
            storedCents = centsDataStore:GetAsync(player.UserId) 
        end)

        if not success then
            storedMoney = 0
            storedCents = 0
        end
        
    cents.Value = storedCents
    dollars.Value = storedMoney
end)

game.Players.PlayerRemoving:Connect(function(player)
    local leaderstats = player:WaitForChild("leaderstats")
    local dollars = leaderstats:WaitForChild("DollarsInVault")
    local cents = leaderstats:WaitForChild("CentsInVault")
    if dollars and cents then
        local success, error = pcall(function()
            moneyDataStore:SetAsync(player.UserId, dollars.Value) 
            centsDataStore:SetAsync(player.UserId, cents.Value)
            
        end)

        if not success then
            warn("Failed to save data for " .. player.Name .. ": " .. error)
        end
    end
end)

clever summit Mar 10, 2025, 8:52 PM

#

?

dull willow Mar 10, 2025, 8:52 PM

#

I forgot to add an end Ig or maybe it was just on discord idk

clever summit Mar 10, 2025, 8:53 PM

#

prob ur language not detecting the word as an actual word causing red lines

cinder cloak Mar 10, 2025, 8:53 PM

#

dull willow final script is this ```lua local DataStoreService = game:GetService("DataStoreS...

This may not always work on the first player that joins.

It's possible the player joins before you connect to PlayerAdded

clever summit Mar 10, 2025, 8:54 PM

#

cinder cloak This may not always work on the first player that joins. It's possible the play...

wdym???

#

@dull willow try doing this to check if the data loads correctly

#

just set it to 4 for debugging

dull willow Mar 10, 2025, 8:54 PM

#

alr what if I use
local players = game:getservice("players")
if players then

cinder cloak Mar 10, 2025, 8:54 PM

#

clever summit wdym???

When this script runs, it's possible that the player is already in the game, so PlayerAdded wont fire since the player is already there. Happened to me before.

dull willow Mar 10, 2025, 8:55 PM

#

clever summit <@371158167494590464> try doing this to check if the data loads correctly

uh what should happen

#

the value should be 4 on leaderstats right?

clever summit Mar 10, 2025, 8:55 PM

#

cinder cloak When this script runs, it's possible that the player is already in the game, so ...

never happened to me

clever summit Mar 10, 2025, 8:55 PM

#

dull willow the value should be 4 on leaderstats right?

when you leave it sets it to 4

#

and when you join it should change the value to 4 if it works

#

just a quick way to double check

remote bear Mar 10, 2025, 8:56 PM

#

cinder cloak When this script runs, it's possible that the player is already in the game, so ...

pretty sure it should work

dull willow Mar 10, 2025, 8:56 PM

#

clever summit when you leave it sets it to 4

nah it doesnt work

#

damn

cinder cloak Mar 10, 2025, 8:56 PM

#

dull willow alr what if I use local players = game:getservice("players") if players then

I'd take out the function you connect to PlayerAdded so its on its own (like function initPlayer(player) or whatever), connect that to PlayerAdded, and then run through all players currently in the game and do that function on each of them

clever summit Mar 10, 2025, 8:56 PM

#

hmm

cinder cloak Mar 10, 2025, 8:56 PM

#

remote bear pretty sure it should work

I've had it happen to me before, I was joining too fast before the script could run.

clever summit Mar 10, 2025, 8:56 PM

#

cinder cloak I've had it happen to me before, I was joining too fast before the script could ...

if ur paranoid about that stuff u can just change it to this

cinder cloak Mar 10, 2025, 8:57 PM

#

clever summit if ur paranoid about that stuff u can just change it to this

What would that do

clever summit Mar 10, 2025, 8:57 PM

#

cinder cloak What would that do

get the player service faster

dull willow Mar 10, 2025, 8:58 PM

#

this prints works btw
local success, error = pcall(function()
storedMoney = moneyDataStore:GetAsync(player.UserId)
storedCents = centsDataStore:GetAsync(player.UserId)
print("works")
end)

#

and still no errors

remote bear Mar 10, 2025, 8:58 PM

#

sorry i haven't really looked at this post but have you tried putting a print statement to see if it runs

clever summit Mar 10, 2025, 8:58 PM

#

dull willow this prints works btw local success, error = pcall(function() stored...

print storedMoney and storedCents

cinder cloak Mar 10, 2025, 8:58 PM

#

clever summit get the player service faster

I don't think that addresses the concern though

dull willow Mar 10, 2025, 8:58 PM

#

yes I'll do that

clever summit Mar 10, 2025, 8:58 PM

#

cinder cloak I don't think that addresses the concern though

then what do you suggest to load player data?

#

playedadded is the best way

dull willow Mar 10, 2025, 8:58 PM

#

0 0

clever summit Mar 10, 2025, 8:59 PM

#

dull willow 0 0

ok now do print(typeof(storedMoney))

#

not needed for cents

cinder cloak Mar 10, 2025, 8:59 PM

#

clever summit then what do you suggest to load player data?

I never said not to use it, I just said to make sure to init all players currently in the game as well just in case PlayerAdded is connected to after someone joins

dull willow Mar 10, 2025, 9:00 PM

#

number

clever summit Mar 10, 2025, 9:00 PM

#

cinder cloak I never said not to use it, I just said to make sure to init all players current...

in the million of people who have joined my game that has literally never happened so i doubt its an issue

clever summit Mar 10, 2025, 9:00 PM

#

dull willow number

alr thats good, so the loading of data is safe

#

then the issue is in the saving or setting of the data

#

wait. where did u add the print?

cinder cloak Mar 10, 2025, 9:01 PM

#

clever summit in the million of people who have joined my game that has literally never happen...

local Players = game:GetService("Players")

local function initPlayer(player)
  -- do stuff
end

Players.PlayerAdded:Connect(initPlayer)
for _, player in ipairs(Players:GetPlayers()) do
  initPlayer(player)
end

Is all I mean. It has happened to me before so I was suggesting caution just in case it may happen.

clever summit Mar 10, 2025, 9:01 PM

#

before or after it checks if its a success

#

why is it so silent i thought it was just silent cuz my wifi cut out

#

did i crash?

dull willow Mar 10, 2025, 9:03 PM

#

clever summit wait. where did u add the print?

under here
local success, error = pcall(function()
storedMoney = moneyDataStore:GetAsync(player.UserId)
storedCents = centsDataStore:GetAsync(player.UserId)
end)

#

player added function

clever summit Mar 10, 2025, 9:03 PM

#

so you didn't put it under

dull willow Mar 10, 2025, 9:04 PM

#

no

clever summit Mar 10, 2025, 9:04 PM

#

right?

#

ok then the loading of data is fine

clever summit Mar 10, 2025, 9:04 PM

#

dull willow final script is this ```lua local DataStoreService = game:GetService("DataStoreS...

e

dull willow Mar 10, 2025, 9:04 PM

#

I put a warn there just to be sure

#

did warn(error)

#

nothing happened

#

so def no error

#

game.Players.PlayerAdded:Connect(function(player)

    local leaderstats = Instance.new("Folder", player)
    leaderstats.Name = "leaderstats"

    local Cents = Instance.new("IntValue", leaderstats)
    Cents.Name = "Cents"
    Cents.Value = 0

    local Dollars = Instance.new("IntValue", leaderstats)
    Dollars.Name = "Dollars"
    Dollars.Value = 0

    local CentsInVault = Instance.new("IntValue", leaderstats)
    CentsInVault.Name = "CentsInVault"
    CentsInVault.Value = 0

    local DollarsInVault = Instance.new("IntValue", leaderstats)
    DollarsInVault.Name = "DollarsInVault"
    CentsInVault.Value = 0

end)```

#

bro

#

it say's centsinvault.value

#

under dollarsinvault

#

but I doubt thats the issue

cinder cloak Mar 10, 2025, 9:06 PM

#

It defaults to 0 so I think you're fine

clever summit Mar 10, 2025, 9:06 PM

#

i see the issue

#

you're setting the value to 0

#

i had this issue too, the setting to 0 is slower than the script and its automatically 0

dull willow Mar 10, 2025, 9:06 PM

#

so what do I do

#

just set no value

clever summit Mar 10, 2025, 9:07 PM

#

you can add a verification that its fully loaded or combine the scripts

#

yeah combining the scripts here looks easier

dull willow Mar 10, 2025, 9:08 PM

#

hm

#

alr

clever summit Mar 10, 2025, 9:08 PM

#

will also remove the need for the waitforchild

dull willow Mar 10, 2025, 9:10 PM

#

how

#

bro I'm to tired to work on this rn

#

I'll keep working on it tomorrow

clever summit Mar 10, 2025, 9:11 PM

#

alr

dull willow Mar 10, 2025, 9:11 PM

#

thanks for all your help

#

205 messages lol

clever summit Mar 10, 2025, 9:11 PM

#

tomorrow try making the values in the saving script BEFORE you load the data

#

so you're 100% sure its correct

dull willow Mar 10, 2025, 9:11 PM

#

if I have 2 seperate player added functions in one script would that break it

clever summit Mar 10, 2025, 9:12 PM

#

you don't have to have 2 seperates

#

you can fit them in 1

dull willow Mar 10, 2025, 9:12 PM

#

yeah tought so

#Api Problem script doesn't seem to save for some reason...