Cant save leaderstats

[visual wigeon]

I tried to save leaderstats with multiple variants of code and even asked some friends to help, but nothing seems to work, api is turned on and everything should work beacuse i dont even get an error, but after i rejoining the leaderstats always shows the value of money and income as 0

[rain sage]

You have to do it this way:

local success, errorMsg = pcall(function()
  Save1:SetAsync(Player.UserId, Player.leaderstats.Money.Value)
  Save2:SetAsync(Player.UserId, Player.leaderstats.Income.Value)
end)

if not success then
  warn(errorMsg)
end

[visual wigeon]

ServerScriptService.leaderstats:21: attempt to index nil with 'UserId'

[visual wigeon]

.

[rain sage]

Did you remove game.Players.PlayerRemoving

[rain sage]

.

Line 20

[visual wigeon]

yeah

[rain sage]

Don't

[rain sage]

Repalce line 21 and 22 with this

[visual wigeon]

    local success, errorMsg = pcall(function()
        Save1:SetAsync(Player.UserId, Player.leaderstats.Money.Value)
        Save2:SetAsync(Player.UserId, Player.leaderstats.Income.Value)
    end)

    if not success then
        warn(errorMsg)
    end
end)

like this?

if yes that dosent seem to work

[rain sage]

Why not

Is there an error?

[visual wigeon]

idk

nop[e

just dosent save

[visual wigeon]

is there another way?

[minor adder]

** You are now Level 1! **

[rain sage]

Let me check rq.

[visual wigeon]

alr

[rain sage]

Everything works for me bro.

-- script.Parent = game.ServerScriptService
local DS = game:GetService("DataStoreService")
local save1 = DS:GetDataStore("Money")

game.Players.PlayerAdded:Connect(function(plr)
    local leadertats = Instance.new("Folder", plr)
    leadertats.Name = "leaderstats"
    
    local money = Instance.new("IntValue", leadertats)
    money.Name = "Money"
    money.Value = save1:GetAsync(plr.UserId) or 0
end)

game.Players.PlayerRemoving:Connect(function(plr)
    local success, errorMsg = pcall(function()
        save1:SetAsync(plr.UserId, plr.leaderstats.Money.Value)
    end)

    if not success then
        warn(errorMsg)
    end
end)

[visual wigeon]

strange very strange

[rain sage]

Oh wait I see now.

I see what I did wrong hold on.

[rain sage]

Okay I'm back.

I had to eat dinner.

Anyway it should've been done like this:

local DS = game:GetService("DataStoreService")
local dsStore = DS:GetDataStore("PlayerStats")

game.Players.PlayerAdded:Connect(function(plr)
    local leadertats = Instance.new("Folder", plr)
    leadertats.Name = "leaderstats"
    
    local money = Instance.new("IntValue", leadertats)
    money.Name = "Money"
    
    local income = Instance.new("IntValue", leadertats)
    income.Name = "Income"
    
    local data
    
    local success, errorMsg = pcall(function()
        data = dsStore:GetAsync("midata_"..plr.UserId)
    end)
    
    if not success then
        warn(errorMsg)
    end
    
    money.Value = data[1]
    income.Value = data[2]
end)

game.Players.PlayerRemoving:Connect(function(plr)
    local money = plr.leaderstats.Money
    local income = plr.leaderstats.Income
    local data = {money.Value, income.Value}
    
    local success, errorMsg = pcall(function()
        dsStore:SetAsync("midata_"..plr.UserId, data)
    end)

    if not success then
        warn(errorMsg)
    end
end)

[visual wigeon]

still dosent seem to work

[rain sage]

Are you changing the values here on the client or on the server

[visual wigeon]

server

[rain sage]

Why

[visual wigeon]

idk scripting gods seems to hate me

but first time i put the script i had an error

ServerScriptService.leaderstats:24: attempt to index nil with number

but at the second launch it dissapeard

[rain sage]

Oh right, we forgot to check if the data even exists.

local DS = game:GetService("DataStoreService")
local dsStore = DS:GetDataStore("PlayerStats")

game.Players.PlayerAdded:Connect(function(plr)
    local leadertats = Instance.new("Folder", plr)
    leadertats.Name = "leaderstats"
    
    local money = Instance.new("IntValue", leadertats)
    money.Name = "Money"
    
    local income = Instance.new("IntValue", leadertats)
    income.Name = "Income"
    
    local data
    
    local success, errorMsg = pcall(function()
        data = dsStore:GetAsync("midata_"..plr.UserId)
    end)
    
    if not success then
        warn(errorMsg)
    end
    
    if data then
        money.Value = data[1]
        income.Value = data[2]
    else
        money.Value = 0
        income.Value = 0
    end
end)

game.Players.PlayerRemoving:Connect(function(plr)
    local money = plr.leaderstats.Money
    local income = plr.leaderstats.Income
    local data = {money.Value, income.Value}
    
    local success, errorMsg = pcall(function()
        dsStore:SetAsync("midata_"..plr.UserId, data)
    end)

    if not success then
        warn(errorMsg)
    end
end)

Check

[visual wigeon]

i think its another script that dosent let the save data to be saved but idk what script

[finite stump]

does the script give any error now?

[rain sage]

Then check them all.

[visual wigeon]

no it dosent but the data never gets saved

[finite stump]

If this is the case then there are only 3 options why it doesnt work

1. roblox servers have broke (not this case)

2. You havent enabled API services (if not then go to settings or search a yt vid)

3. You are changing the Money and Income value through the client side

[finite stump]

This is probably what you re doing

When you open to test the game

you need to press Client on top right

[visual wigeon]

local Money = Player:WaitForChild("leaderstats"):WaitForChild("Money")
local MarketPlaceService = game:GetService("MarketplaceService")
local GamepassID = 170651464
local button = script.Parent
local obuchenie = true
local function clicked()
    if obuchenie == true then
        button.Parent:FindFirstChild("Tutorial"):Destroy()
        obuchenie = false
    end
    local sound = button:FindFirstChild("meow"):Clone()
    sound.Parent = workspace.Trash
    sound:Play()
    task.wait(1.35)
    sound:Destroy()
end
script.Parent.MouseButton1Click:Connect(function()
    if MarketPlaceService:UserOwnsGamePassAsync(Player.UserId, GamepassID) then
        Player.leaderstats.Money.Value = Player.leaderstats.Money.Value + 2
    else
        Player.leaderstats.Money.Value = Player.leaderstats.Money.Value + 1
    end
end)
script.Parent.MouseButton1Click:Connect(function()
    game.Workspace.Sound1:Play()
end)```

script for the click

[finite stump]

Try to change it without those first

[visual wigeon]

alr

[rain sage]

Is it on the client?

[finite stump]

Open the test, switch to server side and change value from there first

[finite stump]

Yes, tahts probably why it doesnt save

[visual wigeon]

probably

[minor adder]

** You are now Level 2! **

[rain sage]

Is the script icon blue or white?

[finite stump]

Because he stores values in the client but never replicates them to the server which cant save any data

[visual wigeon]

its local

[rain sage]

He said he tested it on the server.

[finite stump]

First line is:
local player = game.Players.LocalPlayer

[rain sage]

Can't read it right now.

[rain sage]

Then change it to server.

[finite stump]

He cant because its an UI

he would have to use a remote event

[visual wigeon]

i hate events

[rain sage]

Uh-huh.

[finite stump]

Sadly they re one of the only way to communicate between client and server

[rain sage]

They're fairly simple.

[finite stump]

I read the script, dont worry

[visual wigeon]

ill go learn them then learn how i can change from client to server

ill give an update if it works or dosent

[rain sage]

Sure.

[finite stump]

Scripting a UI through server isnt reccomended though

[visual wigeon]

isnt there a way to save the values that are changed from client?

[finite stump]

Server handles data, not the client

Because data is sent to roblox servers which store the data

[visual wigeon]

horray it works

i just have to change the income and the mega click stuff too and its done

thanks guys:)

[rain sage]

No.