Script is incrementing more to the Datastore than it should. | Roblox Studio Community | Page 1

bright star Aug 4, 2024, 5:15 PM

#

Serverside:

local Datastore = game:GetService("DataStoreService")
local PlayerValues = Datastore:GetDataStore("PlayerInventory")
local PlayerRestarts = Datastore:GetDataStore("Playerinventory", "Rebirths")


local Event = game.ReplicatedStorage.Text
local Event2 = game.ReplicatedStorage.ObsticalDeleter
local Event3 = game.ReplicatedStorage.NoText
local Restarter = game.ReplicatedStorage.RestartAdder

game.Players.PlayerAdded:Connect(function(plr)
    local leaderstats = Instance.new("Folder", plr)
    leaderstats.Name = "leaderstats"
    
    local Points = Instance.new("IntValue", leaderstats)
    Points.Name = "Points"
    Points.Value = 0
    local plrPoints = plr.leaderstats.Points
    
    local Restarts = Instance.new("IntValue", leaderstats)
    Restarts.Name = "Restarts"
    Restarts.Value = 0


    Points.Changed:Connect(function()
        if Points.Value >= 1 then
            Event:FireClient(plr)
        else 
            Event3:FireClient(plr)
        end
    end)

    
    local success, Error = pcall(function()
        PlayerRestarts:SetAsync(plr.UserId, 0)
    end)
    
    
    Restarter.OnServerEvent:Connect(function()
        local success, newRestartVal = pcall(function()
            return PlayerRestarts:IncrementAsync(plr.UserId, 1)
        end)
        if success then
            Restarts.Value += 1
            plrPoints.Value = 0
        end        
    end)

    

Event2.OnServerInvoke = function(plr)
    local fired = false
        if plrPoints.Value >= (5 - Restarts.Value) then
            plr.leaderstats.Points.Value -= (5 - Restarts.Value)
            fired = true
            return fired
        end
    end
end)

#

ClientSide:

local RepStorage = game:GetService("ReplicatedStorage")

local Event = RepStorage.Text
local Event2 = RepStorage.NoText
local Restarter = RepStorage.RestartAdder

local Players = game:GetService("Players")

local Button = script.Parent.TextButton



Event.OnClientEvent:Connect(function(plr)
    Button.Visible = true
    Button.MouseButton1Click:Connect(function()
        Restarter:FireServer()
    end)
    
end)

Event2.OnClientEvent:Connect(function(plr)
    Button.Visible = false
end)

bright star Aug 4, 2024, 5:17 PM

#

bright star Serverside: ```lua local Datastore = game:GetService("DataStoreService") local P...

I renamed the Value "Rebirths" Value to "Restarts in line 5.

cedar belfry Aug 4, 2024, 6:46 PM

#

Yo

#

Here i am to help

#

let me read rq

bright star Aug 4, 2024, 6:46 PM

#

thx

median crow Aug 4, 2024, 6:46 PM

#

right

cedar belfry Aug 4, 2024, 6:46 PM

#

From what i'm getting

#

it may be an event that's not being disconnected, i'm stupid though

median crow Aug 4, 2024, 6:47 PM

#

the button press is being viewed multiple times

cedar belfry Aug 4, 2024, 6:47 PM

#

let s2 handle this one

median crow Aug 4, 2024, 6:47 PM

#

cedar belfry it may be an event that's not being disconnected, i'm stupid though

yes this

#

Event.OnClientEvent:Connect(function(plr)
Button.Visible = true
Button.MouseButton1Click:Connect(function()
Restarter:FireServer()
end)

end)

#

here

bright star Aug 4, 2024, 6:47 PM

#

How can I prevent this?

median crow Aug 4, 2024, 6:47 PM

#

is the issue

#

remove the onclient event

#

just make it

cedar belfry Aug 4, 2024, 6:47 PM

#

¯_(ツ)_/¯

bright star Aug 4, 2024, 6:47 PM

#

median crow just make it

what

median crow Aug 4, 2024, 6:47 PM

#

local RepStorage = game:GetService("ReplicatedStorage")

local Event = RepStorage.Text
local Event2 = RepStorage.NoText
local Restarter = RepStorage.RestartAdder

local Players = game:GetService("Players")

local Button = script.Parent.TextButton

Button.MouseButton1Click:Connect(function()
    Restarter:FireServer()
end)

Event.OnClientEvent:Connect(function(plr)
    Button.Visible = true
end)

Event2.OnClientEvent:Connect(function(plr)
    Button.Visible = false
end)

bright star Aug 4, 2024, 6:47 PM

#

xD

#

Oh

#

But wait

cedar belfry Aug 4, 2024, 6:48 PM

#

Yes?

median crow Aug 4, 2024, 6:48 PM

#

yes

#

add

#

a var

bright star Aug 4, 2024, 6:48 PM

#

median crow ```lua local RepStorage = game:GetService("ReplicatedStorage") local Event = Re...

one sec

median crow Aug 4, 2024, 6:48 PM

#

i know what u mean

#

ill do it

cedar belfry Aug 4, 2024, 6:49 PM

#

You could possibly add a RBXScriptConnection variable and disconnect the event listener when it's ran

#

i suppose

median crow Aug 4, 2024, 6:49 PM

#

what he need

bright star Aug 4, 2024, 6:49 PM

#

The Button is visible when a certain amount of points is reached

#

And if it is reached, the button will be visable and Then you have the option to press the button

cedar belfry Aug 4, 2024, 6:50 PM

#

local Signal: RBXScriptSignal

Signal = Something.Changed:Connect(function()
    
    -- Logic here --
    
    Signal:Disconnect()
    
end)

#

I think that would work here

bright star Aug 4, 2024, 6:51 PM

#

cedar belfry ```lua local Signal: RBXScriptSignal Signal = Something.Changed:Connect(functio...

I would need to get the points value to the client

#

The info

cedar belfry Aug 4, 2024, 6:51 PM

#

then put le remote event where it says 'Logic here'

#

or smth

#

uhh

bright star Aug 4, 2024, 6:51 PM

#

xD

median crow Aug 4, 2024, 6:51 PM

#

game.Players.LocalPlayer.leaderstats.Points.Value

#

you can put that in the local

#

and everytime you do it

#

it will give the vallue

bright star Aug 4, 2024, 6:52 PM

#

median crow game.Players.LocalPlayer.leaderstats.Points.Value

It shows the value from the serverside right?

median crow Aug 4, 2024, 6:52 PM

#

yes

bright star Aug 4, 2024, 6:52 PM

#

Ok nice

median crow Aug 4, 2024, 6:52 PM

#

it will give the value of points or resets wahytcever

bright star Aug 4, 2024, 6:52 PM

#

Imma try that

hard moss Aug 4, 2024, 6:53 PM

#

@median crow brotha do u mind helping me rq it's a quick problem but i js cant find out whats causing it

#

sorry for the disturbance

median crow Aug 4, 2024, 6:53 PM

#

eyuah

hard moss Aug 4, 2024, 6:53 PM

#

humble saddleBOT Aug 4, 2024, 6:53 PM

#

studio ** You are now Level 4! ** studio

median crow Aug 4, 2024, 6:53 PM

#

eyah

#

yeah

hard moss Aug 4, 2024, 6:53 PM

#

#📜︱scripting-help-classic

bright star Aug 4, 2024, 6:53 PM

#

xD, I am gonna try doin it, I´ll update you

bright star Aug 4, 2024, 6:59 PM

#

median crow yeah

local RepStorage = game:GetService("ReplicatedStorage")

local Event = RepStorage.Text
local Event2 = RepStorage.NoText
local Restarter = RepStorage.RestartAdder

local Players = game:GetService("Players")

local Button = script.Parent.TextButton


local Signal: RBXScriptSignal

Signal = game.Players.LocalPlayer.leaderstats.Points.Value.Changed:Connect(function()
    if game.Players.LocalPlayer.leaderstats.Points.Value >= 25 then
        Button.MouseButton1Click:Connect(function()
            Restarter:FireServer()
        end)
    end
    Signal:Disconnect()

end)


Event2.OnClientEvent:Connect(function(plr)
    Button.Visible = false
end)

#

I am not familiar with the Signal value or whatever that is xD, I need to search it up yet.

#

Players.ChickenMacFrise.PlayerGui.ScreenGui.Textscript:21: attempt to index number with 'Changed' - Client - Textscript:21

median crow Aug 4, 2024, 7:00 PM

#

put

else
Signal:Disconnect()

#

instead of

#

i think

bright star Aug 4, 2024, 7:02 PM

#



local Signal: RBXScriptSignal

Signal = game.Players.LocalPlayer.leaderstats.Points.Value.Changed:Connect(function()
    if game.Players.LocalPlayer.leaderstats.Points.Value >= 25 then
        Button.MouseButton1Click:Connect(function()
            Restarter:FireServer()
        end)
    else
        Signal:Disconnect()
    end
    

end)

median crow Aug 4, 2024, 7:02 PM

#

yeah

bright star Aug 4, 2024, 7:02 PM

#

bright star Players.ChickenMacFrise.PlayerGui.ScreenGui.Textscript:21: attempt to index numb...

Same Error

median crow Aug 4, 2024, 7:02 PM

#

you changing thingy

#

do

#

where is that

#

Textscrot[

bright star Aug 4, 2024, 7:03 PM

#

Bro what

#

xD

median crow Aug 4, 2024, 7:03 PM

#

cuz you tloookiogn fopr a change in the script

#

but you cant do that

#

what r u tryna find change

bright star Aug 4, 2024, 7:04 PM

#

One sec

#

I am checking the points value of the player and if the value is >=25

median crow Aug 4, 2024, 7:05 PM

#

show both scripts

#

newly refurbished

bright star Aug 4, 2024, 7:05 PM

#

local Datastore = game:GetService("DataStoreService")
local PlayerValues = Datastore:GetDataStore("PlayerInventory")
local PlayerRestarts = Datastore:GetDataStore("Playerinventory", "Restarts")


local Event = game.ReplicatedStorage.Text
local Event2 = game.ReplicatedStorage.ObsticalDeleter
local Event3 = game.ReplicatedStorage.NoText
local Restarter = game.ReplicatedStorage.RestartAdder

game.Players.PlayerAdded:Connect(function(plr)
    local leaderstats = Instance.new("Folder", plr)
    leaderstats.Name = "leaderstats"
    
    local Points = Instance.new("IntValue", leaderstats)
    Points.Name = "Points"
    Points.Value = 0
    local plrPoints = plr.leaderstats.Points
    
    local Restarts = Instance.new("IntValue", leaderstats)
    Restarts.Name = "Restarts"
    Restarts.Value = 0


    Points.Changed:Connect(function()
        if Points.Value >= 1 then
            Event:FireClient(plr)
        else 
            Event3:FireClient(plr)
        end
    end)

    
    local success, Error = pcall(function()
        PlayerRestarts:SetAsync(plr.UserId, 0)
    end)
    
    
    Restarter.OnServerEvent:Connect(function()
        local success, newRestartVal = pcall(function()
            return PlayerRestarts:IncrementAsync(plr.UserId, 1)
        end)
        if success then
            Restarts.Value += 1
            plrPoints.Value = 0
        end        
    end)

    

Event2.OnServerInvoke = function(plr)
    local fired = false
        if plrPoints.Value >= (5 - Restarts.Value) then
            plr.leaderstats.Points.Value -= (5 - Restarts.Value)
            fired = true
            return fired
        end
    end
end)

#


local RepStorage = game:GetService("ReplicatedStorage")

local Event = RepStorage.Text
local Event2 = RepStorage.NoText
local Restarter = RepStorage.RestartAdder

local Players = game:GetService("Players")

local Button = script.Parent.TextButton


local Signal: RBXScriptSignal

Signal = game.Players.LocalPlayer.leaderstats.Points.Value.Changed:Connect(function()
    if game.Players.LocalPlayer.leaderstats.Points.Value >= 25 then
        Button.MouseButton1Click:Connect(function()
            Restarter:FireServer()
        end)
    else
        Signal:Disconnect()
    end
    

end)


Event2.OnClientEvent:Connect(function(plr)
    Button.Visible = false
end)

#

First is server, second is client

median crow Aug 4, 2024, 7:07 PM

#

thats my bad i read the error wrong

bright star Aug 4, 2024, 7:07 PM

#

no problem

median crow Aug 4, 2024, 7:07 PM

#

Signal = game.Players.LocalPlayer.leaderstats.Points.Value.Changed:Connect(function()

remove .Value here

bright star Aug 4, 2024, 7:07 PM

#

remove .Value?

median crow Aug 4, 2024, 7:07 PM

#

so its Points.Changed

#

thats how detect change

bright star Aug 4, 2024, 7:07 PM

#

Wait wait

#

I am sorry, what am I removing here?

median crow Aug 4, 2024, 7:08 PM

#

Signal = game.Players.LocalPlayer.leaderstats.Points.Changed:Connect(function()

#

replace it with that

#

copy paste

#

here

bright star Aug 4, 2024, 7:09 PM

#

Ok, Imma remove the game.Players... in the if statement with if remove game.Players....Value

#

?

median crow Aug 4, 2024, 7:10 PM

#

n

#

no

#

keep everything else the same

#

only change that one line

bright star Aug 4, 2024, 7:10 PM

#

That one with the "Signal = ..." ?

median crow Aug 4, 2024, 7:10 PM

#

yeah

#

remove .Value

#

in only that line

bright star Aug 4, 2024, 7:11 PM

#

remove game.Players.LocalPlayer.leaderstats.Points.Value

median crow Aug 4, 2024, 7:11 PM

#

no

#

only

#

the 6 character

#

.Value

bright star Aug 4, 2024, 7:11 PM

#

Man just type it pls

#

xD

#

My Monke brain cant handle that

median crow Aug 4, 2024, 7:11 PM

#

Signal = game.Players.LocalPlayer.leaderstats.Points.Changed:Connect(function()

bright star Aug 4, 2024, 7:12 PM

#

WHAT

#

THATS LITERALLY WHAT I WROTE

median crow Aug 4, 2024, 7:12 PM

#

run the script

bright star Aug 4, 2024, 7:12 PM

#

Players.ChickenMacFrise.PlayerGui.ScreenGui.Textscript:21: attempt to index number with 'Changed' - Client - Textscript:21

median crow Aug 4, 2024, 7:12 PM

#

show ur script

bright star Aug 4, 2024, 7:12 PM

#

local Signal: RBXScriptSignal

Signal = game.Players.LocalPlayer.leaderstats.Points.Value.Changed:Connect(function()
if game.Players.LocalPlayer.leaderstats.Points.Value >= 25 then
Button.MouseButton1Click:Connect(function()
Restarter:FireServer()
end)
else
Signal:Disconnect()
end

end)

median crow Aug 4, 2024, 7:13 PM

#

bright star Aug 4, 2024, 7:13 PM

#

OH

#

So game.Players.LocalPlayer.leaderstats.Points.remove.Value?

median crow Aug 4, 2024, 7:14 PM

#

local Signal: RBXScriptSignal

Signal = game.Players.LocalPlayer.leaderstats.Points.Changed:Connect(function()
if game.Players.LocalPlayer.leaderstats.Points.Value >= 25 then
Button.MouseButton1Click:Connect(function()
Restarter:FireServer()
end)
else
Signal:Disconnect()
end

end)

#

copy and paste that

bright star Aug 4, 2024, 7:14 PM

#

I dont get the error anymore

median crow Aug 4, 2024, 7:14 PM

#

🙂

bright star Aug 4, 2024, 7:14 PM

#

but now there is no more GUI

#

💀

#

OH wait I am dumb

#

I need to add that

#

The GUI doesnt pop up anymore, if The points value does get changed to 0 and it goes over the value of 25

#

I think I need to add a Event for that

median crow Aug 4, 2024, 7:18 PM

#

no

humble saddleBOT Aug 4, 2024, 7:18 PM

#

studio ** You are now Level 12! ** studio

bright star Aug 4, 2024, 7:18 PM

#

no?

median crow Aug 4, 2024, 7:19 PM

#

gimme 3 min

bright star Aug 4, 2024, 7:19 PM

#

np

median crow Aug 4, 2024, 7:24 PM

#

okay

#

si

#

so

bright star Aug 4, 2024, 7:25 PM

#

I did not got any further btw

#

I just noticed, that I got to many events

#

I dont even use all of them

median crow Aug 4, 2024, 7:25 PM

#

yeah

#

i rewrote some

bright star Aug 4, 2024, 7:26 PM

#

Thank you, I appreciate it really much. If the Code works, I am gonna be able to understand the concepts of Datastore too

bright star Aug 4, 2024, 7:26 PM

#

median crow i rewrote some

Wanna send it?

median crow Aug 4, 2024, 7:26 PM

#

just testing it

bright star Aug 4, 2024, 7:26 PM

#

ok

median crow Aug 4, 2024, 7:32 PM

#

local Datastore = game:GetService("DataStoreService")
local PlayerValues = Datastore:GetDataStore("PlayerInventory")
local PlayerRestarts = Datastore:GetDataStore("Playerinventory", "Restarts")

local Event = game.ReplicatedStorage.Text
local Event2 = game.ReplicatedStorage.ObsticalDeleter
local Restarter = game.ReplicatedStorage.RestartAdder

game.Players.PlayerAdded:Connect(function(plr)
    local leaderstats = Instance.new("Folder", plr)
    leaderstats.Name = "leaderstats"

    local Points = Instance.new("IntValue", leaderstats)
    Points.Name = "Points"
    Points.Value = 0
    local plrPoints = plr.leaderstats.Points

    local Restarts = Instance.new("IntValue", leaderstats)
    Restarts.Name = "Restarts"
    Restarts.Value = 0


    Points.Changed:Connect(function()
        if Points.Value >= 1 then
            Event:FireClient(plr, true)
        else 
            Event:FireClient(plr, false)
        end
    end)


    local success, Error = pcall(function()
        PlayerRestarts:SetAsync(plr.UserId, 0)
    end)


    Restarter.OnServerEvent:Connect(function()
        local success, newRestartVal = pcall(function()
            return PlayerRestarts:IncrementAsync(plr.UserId, 1)
        end)
        if success then
            Restarts.Value += 1
            plrPoints.Value = 0
        end
    end)



    Event2.OnServerInvoke = function(plr)
        local fired = false
        if plrPoints.Value >= (5 - Restarts.Value) then
            plr.leaderstats.Points.Value -= (5 - Restarts.Value)
            fired = true
            return fired
        end
    end
end)

#

local RepStorage = game:GetService("ReplicatedStorage")

local Event = RepStorage.Text
local Restarter = RepStorage.RestartAdder

local Players = game:GetService("Players")

local Button = script.Parent.TextButton


local Signal: RBXScriptSignal

Signal = game.Players.LocalPlayer.leaderstats.Points.Changed:Connect(function()
    if game.Players.LocalPlayer.leaderstats.Points.Value >= 25 then
        Button.MouseButton1Click:Connect(function()
            Restarter:FireServer()
        end)
    else
        Signal:Disconnect()
    end
end)

Event.OnClientEvent:Connect(function(value)
    Button.Visible = value
end)

#

try these

bright star Aug 4, 2024, 7:33 PM

#

ok

#

I copy pasted it

#

button does not fire

#

nothing happens

median crow Aug 4, 2024, 7:34 PM

#

change your points

#

if its above 25 then try

bright star Aug 4, 2024, 7:34 PM

#

OH

#

bruh one sec

median crow Aug 4, 2024, 7:34 PM

#

i can fix that

bright star Aug 4, 2024, 7:35 PM

#

I made it in my code, if I get over 1 point, the gui pops up, just for test xD

#

The Button comes up, but I get 2 Restarts everytime

#

Instead of one. The event is fired 2 times I dont know why tho

median crow Aug 4, 2024, 7:37 PM

#

i know why i think

#

local RepStorage = game:GetService("ReplicatedStorage")
local Event = RepStorage.Text
local Restarter = RepStorage.RestartAdder

local Players = game:GetService("Players")
local Button = script.Parent.TextButton

local restartDb = false

Button.MouseButton1Click:Connect(function()
    if game.Players.LocalPlayer.leaderstats.Points.Value >= 25 and not restartDb then
        restartDb = true
        Restarter:FireServer()
        task.delay(1, function()
            restartDb = false
        end)
    end
end)

Event.OnClientEvent:Connect(function(value)
    Button.Visible = value
end)

there

#

change ur local script to thaty

bright star Aug 4, 2024, 7:37 PM

#

ok

#

YES IT WORKES

#

THANK YOU SO MUCH

median crow Aug 4, 2024, 7:38 PM

#

👍 ur welcome

bright star Aug 4, 2024, 7:38 PM

#

I am gonna look now, why it workes xD

#

But then I am gonna know how it workes

median crow Aug 4, 2024, 7:38 PM

#

i added a debounce

#

and instead of detecting when the points change

#

it just checks how many points the player has when they click it

bright star Aug 4, 2024, 7:39 PM

#

Oh cool

median crow Aug 4, 2024, 7:39 PM

#

and restartDb is to just stop people from autoclicking it and getting more than 1 reset

bright star Aug 4, 2024, 7:39 PM

#

median crow and restartDb is to just stop people from autoclicking it and getting more than ...

Thats the Debounce right?

median crow Aug 4, 2024, 7:39 PM

#

yeah

bright star Aug 4, 2024, 7:39 PM

#

Ok, thank you man

#

I am gonna close this helping section

bright star Aug 4, 2024, 7:40 PM

#

median crow ```lua local RepStorage = game:GetService("ReplicatedStorage") local Event = Rep...

Thanks again

#

bye bye

#Script is incrementing more to the Datastore than it should.