GetAttribute returning nil | Roblox Studio Community | Page 1

wet wharf Dec 23, 2023, 12:28 AM

#

Working on a script for a part that deals damage to player if player possesses attribute "WaterDamage" I'm having the script print 'CurrentValue' when part is touched, but it's outputting CurrentValue = nil everytime, even though Humanoids WaterDamage Attribute is set to 1. I'll also paste the code in here

#






Part.Touched:Connect(function(TouchedPart)
    
    local Humanoid = TouchedPart.Parent:FindFirstChildWhichIsA("Humanoid")
    local CurrentValue = Humanoid:GetAttribute("WaterDamage")
    print(CurrentValue)
    if Humanoid and Humanoid:GetAttribute("WaterDamage") == 1 then
        
        Humanoid.Health -= 5
        
    end
end)

sterile glen Dec 23, 2023, 1:34 AM

#

wet wharf ```local Part = script.Parent Part.Touched:Connect(function(TouchedPart) ...

@wet wharf are you sure "WaterDamage" attribute is in the humanoid? i think you mean to find the attribute inside the part not the humanoid

#

oh wait

#

i read wrong

wet wharf Dec 23, 2023, 1:34 AM

#

WaterDamage is set to 1 for Humanoid

#

The part script checks PlayerWhoTouched for "WaterDamage"

sterile glen Dec 23, 2023, 1:36 AM

#

and if you dont mind me asking, how did you set the attribute to the humanoid? was it from a startercharacter? or a script

wet wharf Dec 23, 2023, 1:36 AM

#

A tool, would you like me to past that script?

#

Paste*

sterile glen Dec 23, 2023, 1:36 AM

#

sure

#

but did you set the attribute from a local script?

wet wharf Dec 23, 2023, 1:36 AM

#

I know it works because in playtest I'm able to observe the attribute being added to humanoid

#

Yeah from a local script

sterile glen Dec 23, 2023, 1:36 AM

#

thats why

wet wharf Dec 23, 2023, 1:37 AM

#

Oh. Hm, I'm new to scripting. Can you explain why that's relevant?

#

In my mind even though the attribute is set by a local script, the humanoid is still gaining the attribute the same way a server script would SetAttribute

sterile glen Dec 23, 2023, 1:38 AM

#

because a local script is client sided. and a normal script is for the entire server.

basically. local scripts are used when changing things for ui or something that you only want the player to see. a normal script is when you want the whole server to see it

wet wharf Dec 23, 2023, 1:38 AM

#

Understood. So in that case, do such things as "Local Attributes" and "Server Attributes" exist?

#

Just that it cannot be observed

#

And I can't simply copy and paste my local script into a server script, correct? There's more nuance to it

sterile glen Dec 23, 2023, 1:40 AM

#

paste your script here please

wet wharf Dec 23, 2023, 1:40 AM

#

Sure

whole berryBOT Dec 23, 2023, 1:40 AM

#

studio ** You are now Level 3! ** studio

wet wharf Dec 23, 2023, 1:41 AM

#

local Tool = ClickDetector.Parent
local Players = game:GetService("Players")
local LocalPlayer = Players.LocalPlayer
local Humanoid = LocalPlayer.Character.Humanoid



local function onClicked()
    print("Click event triggered")
    LocalPlayer:SetAttribute("PlaceHolder", true) 
    LocalPlayer:SetAttribute("PlaceHolder", true)
    Humanoid:SetAttribute("MeraUser", 1)
    Humanoid:SetAttribute("WaterDamage", 1)
    Tool:Destroy()
end


Tool.Activated:Connect(onClicked)
print("Script is running")

sterile glen Dec 23, 2023, 1:41 AM

#

as you see this is a local script setting the attribute to the humanoid. everything looks fine. but it still prints nil

#

because its client sided

wet wharf Dec 23, 2023, 1:41 AM

#

That makes a lot of sense

#

But it's not as simple as copy and pasting my local script into a server script, right? I'd have to change some things.

sterile glen Dec 23, 2023, 1:43 AM

#

you're not wrong

#

you cannot get the player by simply doing local player on a server script (normal script)

#

gimme a min i'll fix it and show you

wet wharf Dec 23, 2023, 1:44 AM

#

Thanks a ton, I appreciate all the help I can get

#

I'm trying hard to learn as I go, so any explanation is highly appreciated

sterile glen Dec 23, 2023, 1:45 AM

#

oh and why do you have the script parented to a click detector? and no worries

wet wharf Dec 23, 2023, 1:45 AM

#

That was before I realized all tools have a .Activated property

#

So it's not needed

sterile glen Dec 23, 2023, 1:45 AM

#

correct

#

you can remove the click detector and just parent the script to the tool

wet wharf Dec 23, 2023, 1:46 AM

#

Will do

sterile glen Dec 23, 2023, 1:46 AM

#

but in the script you will have to also remove the click detector reference

wet wharf Dec 23, 2023, 1:47 AM

#

Fixed

sterile glen Dec 23, 2023, 1:47 AM

#

okay so i will fix the code and then i will explain it to you

wet wharf Dec 23, 2023, 1:48 AM

#

That's awesome. Take your time.

sterile glen Dec 23, 2023, 1:52 AM

#


local Tool = script.Parent

local function onClicked()
    print("Click event triggered")
    local Character = Tool.Parent
    local Player = Players:GetPlayerFromCharacter(Character)
    local Humanoid = Character:WaitForChild("Humanoid")

    if Character then
        print("Yo")
        Player:SetAttribute("PlaceHolder", true) 
        Player:SetAttribute("PlaceHolder", true)
        Humanoid:SetAttribute("MeraUser", 1)
        Humanoid:SetAttribute("WaterDamage", 1)
    end
    Tool:Destroy()
end


Tool.Activated:Connect(onClicked)
print("Script is running")```

this would be a better way of doing the script. also see how the code is more structured and readable? you want to keep all your scripts like that. this will make debugging way more simple

and i recommend that you define your services like the game:getservice("Players") first because you might need them for a lot more things. and try to avoid using dots to get to a child of an object. try to use either "WaitForChild" or "FindFirstChild". this is called yielding

#

waitforchild and find first child are similar but have different use cases

#

wait for child is when you know something should be the parent of another object but you are waiting for the object to load to avoid any errors in your code. and find first child is mainly used when checking if an object exists

#

as you see everything works

wet wharf Dec 23, 2023, 1:55 AM

#

That's really interesting. Occasionally, when play testing my script. Upon first reviving and clicking tool, I would get an error. That error would be resolved upon second attempt of restarting character, and this time, waiting a second before clicking on tool. That's probably because I wasn't using WaitForChild?

sterile glen Dec 23, 2023, 1:55 AM

#

you are absolutely correct

#

its so useful because some it does exactly what its called

#

and it continues the code if it has found it or not

wet wharf Dec 23, 2023, 1:57 AM

#

Great information thank you. I'll try this now

sterile glen Dec 23, 2023, 1:57 AM

#

i hope you understood that well

#

no problem :)) if you need more help lmk

wet wharf Dec 23, 2023, 1:57 AM

#

I do have another small quick question

#

Sometimes I have trouble defining character in any given script. It helps to know what character is a parent of

#

But tools in a characters inventory ARE children of Character?

#

And Humanoid IS a child of Character, but roughly Humanoid and Character are synonymous? Like could I use them interchangably?

sterile glen Dec 23, 2023, 2:00 AM

#

yes so if you take a look at your explorer. you'll realise that every object exists just as you script it. for example:

you see when i have the tool equipped it parent to the character.

sterile glen Dec 23, 2023, 2:00 AM

#

wet wharf And Humanoid IS a child of Character, but roughly Humanoid and Character are syn...

no the humanoid you can think of it as the "controller" or basically the life of the character. it contains all the information such as health, jumppower, walkspeed etc

wet wharf Dec 23, 2023, 2:01 AM

#

Gotcha, but what if I have for example; tool in StarterPack. In that case, what would its parent be?

sterile glen Dec 23, 2023, 2:01 AM

#

the character is a model object which eveything like the bodyparts, humanoid, shirt pants are consited within the character

sterile glen Dec 23, 2023, 2:02 AM

#

wet wharf Gotcha, but what if I have for example; tool in StarterPack. In that case, what ...

it would be parented to the players backpack

#

you see now i have the tool unequipped

#

also. you see the other stuff there?

wet wharf Dec 23, 2023, 2:02 AM

#

Right

sterile glen Dec 23, 2023, 2:02 AM

#

playergui is basically the gui that you initially placed inside of startergui

#

playerscripts are script that you put in starterplayerscripts

#

and of course startercharacterscripts' scripts are parented to the character

wet wharf Dec 23, 2023, 2:03 AM

#

OKaay, this is helping me immensely. Thank you.

sterile glen Dec 23, 2023, 2:04 AM

#

these are all the services of the game. so when you do "game.players" or "game:getservice("")", thats bascially calling these services of the game

#

all of these services are parented to the game, hence why you do game."whatever"

wet wharf Dec 23, 2023, 2:05 AM

#

And you recommend, generally to use game:getservice("")

#

As opposed to .

sterile glen Dec 23, 2023, 2:05 AM

#

well with services you can use either but its just with objects that require to be rendered such as 3d objects

#

and with ui, i think that you can use the "." and not waitforchild, because its client sided

sterile glen Dec 23, 2023, 2:06 AM

#

sterile glen all of these services are parented to the game, hence why you do game."whatever"

and btw there are other hidden services such as tweenservice and more but they can be found on roblox's forums

wet wharf Dec 23, 2023, 2:07 AM

#

Okay cool, I'm kind of discovering things as I run into them, so I'm sure when I get to the point where I need more services I'll dive into that.

whole berryBOT Dec 23, 2023, 2:07 AM

#

studio ** You are now Level 4! ** studio

wet wharf Dec 23, 2023, 2:07 AM

#

I'm excited to try everything you've shown me, thank you again.

sterile glen Dec 23, 2023, 2:08 AM

#

no problem!

there was a really useful video that i saw and it explained when to use "." or when to use waitforchild.

#

i'll try find it

wet wharf Dec 23, 2023, 2:08 AM

#

Yeah send it here if you find it 👍

sterile glen Dec 23, 2023, 2:23 AM

#

@wet wharf
https://www.youtube.com/watch?v=HJy_vF_E2jw

i found it. that took forever lol

YouTube

Devin The Developer

Understanding Roblox's Replication Order

This is a video explaining the order in which instances are replicated to the client. Make sure you understand this concept, as you can find workarounds in your games to fix certain issues popping up in relation to timing.

Want to know more? https://devforum.roblox.com/t/when-to-wait-for-replication-to-the-client/135283

I hope you enjoy the vi...

▶ Play video

wet wharf Dec 23, 2023, 2:34 AM

#

Thanks, I'll watch it now :))

#

The code works perfectly by the way, thank you.

#

Are attributes lost on character death?

sterile glen Dec 23, 2023, 3:01 AM

#

wet wharf Are attributes lost on character death?

oh yes they are

#

since the characters model resets everytime it dies. theyre being activated by a tool so you need a tool each time to add attributes

#

if you want to always have an attribute, you can add a script in starter character scripts and add the attribute to the humanoid that way

#GetAttribute returning nil