Why doesn't this datastoring work? | Roblox Studio Community | Page 1

crisp thunder Jul 26, 2023, 3:00 PM

#

Would be nice if the solution was explained.

solid kettle Jul 26, 2023, 3:17 PM

#

solution:

#

keen cedar Jul 26, 2023, 3:23 PM

#

Omg.... You opened a function and never gave a fuck about it...

crisp thunder Jul 26, 2023, 3:27 PM

#

keen cedar Omg.... You opened a function and never gave a fuck about it...

And what can I do with it then? Put something in the ()? Cuz other than that, I've coded somthing below... oh wait, I need to call that function, ight?

austere elkBOT Jul 26, 2023, 3:27 PM

#

studio ** You are now Level 9! ** studio

keen cedar Jul 26, 2023, 3:30 PM

#

If we are seeing the entire bottom script then you should do:

game:BintToClose(function()
  for _,v in pairs(game.Players:GetChildren()) do
    savedata(v)
  end 
end)

savedata is a function you should make (just copy and paste everything you got under game.Players.PlayerRemoving till the first end of the 2nd if)

shrewd osprey Jul 26, 2023, 3:57 PM

#

mfw non-modular programming 😠

#

make a datastore save function, call it on every player on close, call it on players leaving, save yourself writing the same shit 3 times on different event listeners

crisp thunder Jul 26, 2023, 6:43 PM

#

keen cedar If we are seeing the entire bottom script then you should do: ```lua game:BintTo...

like this?

keen cedar Jul 26, 2023, 6:45 PM

#

Yea... But you still have some end-s there that should not be there

crisp thunder Jul 26, 2023, 6:45 PM

#

Is that so? Script analisys doesn't tell me anything

#

And when I try to delete some of those, error pops up (in the script analysis)

keen cedar Jul 26, 2023, 6:48 PM

#

Then your script is nesting sooo much

#

And I can't tell if you need these end by seing the screenshot of your script

#

Maybe send the script as a .lua file?

crisp thunder Jul 26, 2023, 6:49 PM

#

local DataStoreService = game:GetService("DataStoreService")

local experienceStore = DataStoreService:GetDataStore("PlayerExperience")

game.Players.PlayerAdded:Connect(function(player)
    local leaderstats = player:WaitForChild("leaderstats")
    local coins = leaderstats:WaitForChild("Coins")
    
    
    
    local success, currentExperience = pcall(function()
        return experienceStore:GetAsync(player.UserId.."coins")
        end)
        if success then
        coins.Value = currentExperience
        print(currentExperience)
        end
end)
local function savedata()
    game.Players.PlayerRemoving:Connect(function(player)
        local coins = player:WaitForChild("leaderstats"):WaitForChild("Coins")
        local success, errorMessage = pcall(function()
            experienceStore:SetAsync(player.UserId.."coins", coins.Value)

        end)

        local success2, errorMessage2 = pcall(function()
            experienceStore:UpdateAsync(player.UserId.."coins", coins.Value)
        end)
        if not success2 then
            error(errorMessage2)
        end
        if not success then
            error(errorMessage)

        end

game:BintToClose(function()
    for _,v in pairs(game.Players:GetChildren()) do
                savedata(v)
            end
        end)
    end)
    end

keen cedar Jul 26, 2023, 6:51 PM

#

Dude... Copy and re-paste the code in your script

#

This is so hard to understand

crisp thunder Jul 26, 2023, 6:52 PM

#

keen cedar Dude... Copy and re-paste the code in your script

What code? This one u sent me? I already did

keen cedar Jul 26, 2023, 6:52 PM

#

Omg...

#

The one you already have

#

Just copy and paste it back

#

IN YOUR SCRIPT

#

And then paste it here

#

like wtf... how should I understand where the function ends? Should I start counting the end?

crisp thunder Jul 26, 2023, 6:54 PM

#

I pasted it here, it is my code, from the serverScriptsservice

keen cedar Jul 26, 2023, 6:54 PM

#

agony

#

Jeez man

#

Read what I said again

crisp thunder Jul 26, 2023, 6:54 PM

#

Copy the code from the message, paste it into my script, and then paste it here

keen cedar Jul 26, 2023, 6:55 PM

#

Dude

crisp thunder Jul 26, 2023, 6:56 PM

#

So, you want me to copy YOUR code, paste it into my script, and paste the full script here?

keen cedar Jul 26, 2023, 6:56 PM

#

Open the script where you have the code
Press CTRL+A then CTRL+C then CTRL+V
Now, you can copy again the script
CTRL+A then CTRL+C
And paste it there
CTRL+V using format

crisp thunder Jul 26, 2023, 6:57 PM

#

local DataStoreService = game:GetService("DataStoreService")

local experienceStore = DataStoreService:GetDataStore("PlayerExperience")

game.Players.PlayerAdded:Connect(function(player)
local leaderstats = player:WaitForChild("leaderstats")
local coins = leaderstats:WaitForChild("Coins")

local success, currentExperience = pcall(function()
    return experienceStore:GetAsync(player.UserId.."coins")
    end)
    if success then
    coins.Value = currentExperience
    print(currentExperience)
    end

end)
local function savedata()
game.Players.PlayerRemoving:Connect(function(player)
local coins = player:WaitForChild("leaderstats"):WaitForChild("Coins")
local success, errorMessage = pcall(function()
experienceStore:SetAsync(player.UserId.."coins", coins.Value)

    end)

    local success2, errorMessage2 = pcall(function()
        experienceStore:UpdateAsync(player.UserId.."coins", coins.Value)
    end)
    if not success2 then
        error(errorMessage2)
    end
    if not success then
        error(errorMessage)

    end

game:BintToClose(function()
for _,v in pairs(game.Players:GetChildren()) do
savedata(v)
end
end)
end)
end

keen cedar Jul 26, 2023, 6:57 PM

#

Now use format

crisp thunder Jul 26, 2023, 6:57 PM

#

I opened the script, copy and pasted, and pasted here

keen cedar Jul 26, 2023, 6:57 PM

#

crisp thunder Jul 26, 2023, 6:57 PM

#

oh ok

#

local DataStoreService = game:GetService("DataStoreService")

local experienceStore = DataStoreService:GetDataStore("PlayerExperience")

game.Players.PlayerAdded:Connect(function(player)
    local leaderstats = player:WaitForChild("leaderstats")
    local coins = leaderstats:WaitForChild("Coins")
    
    
    
    local success, currentExperience = pcall(function()
        return experienceStore:GetAsync(player.UserId.."coins")
        end)
        if success then
        coins.Value = currentExperience
        print(currentExperience)
        end
end)
local function savedata()
    game.Players.PlayerRemoving:Connect(function(player)
        local coins = player:WaitForChild("leaderstats"):WaitForChild("Coins")
        local success, errorMessage = pcall(function()
            experienceStore:SetAsync(player.UserId.."coins", coins.Value)

        end)

        local success2, errorMessage2 = pcall(function()
            experienceStore:UpdateAsync(player.UserId.."coins", coins.Value)
        end)
        if not success2 then
            error(errorMessage2)
        end
        if not success then
            error(errorMessage)

        end

game:BintToClose(function()
    for _,v in pairs(game.Players:GetChildren()) do
                savedata(v)
            end
        end)
    end)
    end

#

isn't this the same?

keen cedar Jul 26, 2023, 6:58 PM

#

My God...

#

Hold the fuck up... Imma open Roblox Studio and do it for you...

#

local DataStoreService = game:GetService("DataStoreService")

local experienceStore = DataStoreService:GetDataStore("PlayerExperience")

game.Players.PlayerAdded:Connect(function(player)
    local leaderstats = player:WaitForChild("leaderstats")
    local coins = leaderstats:WaitForChild("Coins")



    local success, currentExperience = pcall(function()
        return experienceStore:GetAsync(player.UserId.."coins")
    end)
    if success then
        coins.Value = currentExperience
        print(currentExperience)
    end
end)
local function savedata()
    game.Players.PlayerRemoving:Connect(function(player)
        local coins = player:WaitForChild("leaderstats"):WaitForChild("Coins")
        local success, errorMessage = pcall(function()
            experienceStore:SetAsync(player.UserId.."coins", coins.Value)

        end)

        local success2, errorMessage2 = pcall(function()
            experienceStore:UpdateAsync(player.UserId.."coins", coins.Value)
        end)
        if not success2 then
            error(errorMessage2)
        end
        if not success then
            error(errorMessage)

        end

        game:BintToClose(function()
            for _,v in pairs(game.Players:GetChildren()) do
                savedata(v)
            end
        end)
    end)
end

Good, now is perfect

#

Also, this doest make sense....

#

Did you ever think why we created a function in the first place?

crisp thunder Jul 26, 2023, 7:00 PM

#

To call it?

#

And make the function, well, function?

keen cedar Jul 26, 2023, 7:01 PM

#

local DataStoreService = game:GetService("DataStoreService")

local experienceStore = DataStoreService:GetDataStore("PlayerExperience")

game.Players.PlayerAdded:Connect(function(player)
    local leaderstats = player:WaitForChild("leaderstats")
    local coins = leaderstats:WaitForChild("Coins")

    local success, currentExperience = pcall(function()
        return experienceStore:GetAsync(player.UserId.."coins")
    end)
    if success then
        coins.Value = currentExperience
        print(currentExperience)
    end
end)
function savedata(player)
    local coins = player:WaitForChild("leaderstats"):WaitForChild("Coins")
    local success, errorMessage = pcall(function()
        experienceStore:SetAsync(player.UserId.."coins", coins.Value)

    end)

    local success2, errorMessage2 = pcall(function()
        experienceStore:UpdateAsync(player.UserId.."coins", coins.Value)
    end)
    if not success2 then
        error(errorMessage2)
    end
    if not success then
        error(errorMessage)
    end
end

game.Players.PlayerRemoving:Connect(function(player)
    savedata(player)
end)

game:BintToClose(function()
    for _,v in pairs(game.Players:GetChildren()) do
        savedata(v)
    end
end)

This should work

keen cedar Jul 26, 2023, 7:01 PM

#

crisp thunder To call it?

Yea, and where are you doing that?

crisp thunder Jul 26, 2023, 7:01 PM

#

keen cedar If we are seeing the entire bottom script then you should do: ```lua game:BintTo...

Wait a sec, create a new function, and copy and paste everything under game.Players.Removing

#

oh wait

#

UNDER

#

not with the player removing

#

I copied and pasted WITH the playerRemoving function

#

while I was supposed to leave it between savedata and bindToClose

keen cedar Jul 26, 2023, 7:03 PM

#

keen cedar ```lua local DataStoreService = game:GetService("DataStoreService") local exper...

You shoud've know that this doest make any sense

crisp thunder Jul 26, 2023, 7:05 PM

#

I mean, I didn't even thought about checking it, cause u said it will work. I just didn't read it correctly, and copied and pasted the player removing func. I mean I would check if there was game:Destroy() or while true do loop, so it won't crash my game, but in cases like this, I first listen to what others say

#

And, where's the learning when I just copy and paste what others do, well if I am curious of how somthing works, or I don't understand it, I ask people

keen cedar Jul 26, 2023, 7:07 PM

#

True, but I explained as much and understandable I could and you did that ... thing

crisp thunder Jul 26, 2023, 7:08 PM

#

keen cedar True, but I explained as much and understandable I could and you did that ... th...

Yeah, cause I've mis-readen what u said, missed the ,,under" player.playerRemoving

#

And btw, tysm for helping me

#

Oh, and I think that every error is bad (almost), but is this bad? Cause when reducing/adding coins, it saves

#

Error message is the highlighted one

keen cedar Jul 26, 2023, 7:11 PM

#

Why are you using UpdateAsync? I don't think is needed there

#

Because you already use SetAsync when player leaves/game close

crisp thunder Jul 26, 2023, 7:12 PM

#

Cause I had problems with setAsync, and I saw that setAsync sets the value for the first time, and update well, updates it

#

can setAsync also update the value? without problems

keen cedar Jul 26, 2023, 7:13 PM

#

I guess... I'm using only GetAsync to get data and SetAsync to save it

#

#

So you should just use SetAsync

crisp thunder Jul 26, 2023, 7:14 PM

#

Oh ok, so I Can just delete the success2 and everything below it, not counting if not success then?

keen cedar Jul 26, 2023, 7:15 PM

#

Delete everyone that has to do with UpdateAsync

crisp thunder Jul 26, 2023, 7:15 PM

#

Ok, done

#

Now it again works, but with no errors

#

tysm once again

keen cedar Jul 26, 2023, 7:17 PM

#

Np

crisp thunder Jul 26, 2023, 7:17 PM

#

So, imma be closing this post, cya

#Why doesn't this datastoring work?