pmOS - microkernel OS for RISC-V, x86, and LoongArch | Operating System Development | Page 2

carmine nacelle Dec 18, 2024, 11:08 AM

#

twilit talon Dec 18, 2024, 11:09 AM

#

lol

#

thats with no strict mode?

carmine nacelle Dec 18, 2024, 11:09 AM

#

With both of them

twilit talon Dec 18, 2024, 11:09 AM

#

F

carmine nacelle Dec 18, 2024, 11:09 AM

#

Yeah this is a modern standby laptop

twilit talon Dec 18, 2024, 11:09 AM

#

does dmesg without strict mode still contain that error?

carmine nacelle Dec 18, 2024, 11:09 AM

#

I think some of them don't even have S3

#

This is the old dmesg https://pastebin.com/W9zrQntR

#

With default boot options on fedora

twilit talon Dec 18, 2024, 11:11 AM

#

i see

#

i still dont understand this whatsoever

#

how its not failing on that _STA call with strict mode

carmine nacelle Dec 18, 2024, 11:16 AM

#

I can't find EC chapter in ACPI spec

#

I this I need to sleep

#

I've been looking at SDM of cource I couldn't find it

#

galaxybrain

twilit talon Dec 18, 2024, 11:19 AM

#

twilit talon how its not failing on that _STA call with strict mode

ohhhh nvm

#

im retarded

#

acpica has an optimization

#

if there's no _INI it doesnt walk down that subtree

#

so it never calls that _BAT's _STA

#

ok case closed at least

carmine nacelle Dec 18, 2024, 11:20 AM

#

So a fat bug

twilit talon Dec 18, 2024, 11:21 AM

#

not a bug in this case, just a cosmetic log spam that uacpi does

#

as for the strict-mode error message, it is some ACPICA's bug

#

no one really tests the strict mode

#

i guess

carmine nacelle Dec 18, 2024, 11:23 AM

#

#

Pressing random buttons on keyboard

#

Fn

#

And the power button doesn't work

twilit talon Dec 18, 2024, 11:24 AM

#

btw try closing/opening the lid

#

and plugging/unplugging AC

carmine nacelle Dec 18, 2024, 11:24 AM

#

It spammed a bunch of stuff

twilit talon Dec 18, 2024, 11:24 AM

#

it should try to Notify(AC)

#

if it does then your thing is at least vaguely correct

carmine nacelle Dec 18, 2024, 11:25 AM

#

I'm gonna remove pritnfs

twilit talon Dec 18, 2024, 11:25 AM

#

the text is kinda unreadable at that res

carmine nacelle Dec 18, 2024, 11:26 AM

#

Yeah I need to fix scaling

twilit talon Dec 18, 2024, 11:26 AM

#

no like

#

its discord video quality

carmine nacelle Dec 18, 2024, 11:26 AM

#

But it's sending a bunch of events working from battery

twilit talon Dec 18, 2024, 11:27 AM

#

which Notify is it saying it gets

carmine nacelle Dec 18, 2024, 11:28 AM

#

#

Even connecting/disconnecting USB sends notifications

twilit talon Dec 18, 2024, 11:28 AM

#

carmine nacelle

is this for battery plugging?

#

or power rather

carmine nacelle Dec 18, 2024, 11:29 AM

#

twilit talon is this for battery plugging?

Doing nothing

twilit talon Dec 18, 2024, 11:29 AM

#

which ones do u get when u connect power

carmine nacelle Dec 18, 2024, 11:29 AM

#

Just unplugging it and leaving on battery

#

Wait a minute I'm gonna remove logs

#

Pritnfs*

#

Since it doesn't hang anymore

twilit talon Dec 18, 2024, 11:30 AM

#

sure

twilit talon Dec 18, 2024, 11:30 AM

#

carmine nacelle

yeah this is WMI memes

carmine nacelle Dec 18, 2024, 11:30 AM

#

What is this

#

Medium long story?

twilit talon Dec 18, 2024, 11:30 AM

#

Windows Management Instrumentation Device

#

Basically firmware talking to windows at runtime

#

for device specific events & configuration

carmine nacelle Dec 18, 2024, 11:31 AM

#

Fun

#

This laptop has a bunch of sensors

twilit talon Dec 18, 2024, 11:31 AM

#

https://learn.microsoft.com/en-us/windows/win32/wmisdk/wmi-start-page

Windows Management Instrumentation - Win32 apps

Windows Management Instrumentation (WMI) is the infrastructure for management data and operations on Windows-based operating systems.

carmine nacelle Dec 18, 2024, 11:31 AM

#

Like for ambient light level and presence detection

#

Could it be that?

twilit talon Dec 18, 2024, 11:32 AM

#

https://pastebin.com/BXtR7Kb5

Pastebin

Name (ITEM, Package (0x26) { Package (0x0...

Pastebin.com is the number one paste tool since 2002. Pastebin is a website where you can store text online for a set period of time.

#

some examples of what your aml has that is configurable via WMI

twilit talon Dec 18, 2024, 11:34 AM

#

carmine nacelle Could it be that?

yeah

carmine nacelle Dec 18, 2024, 11:41 AM

#

Is this normal?

twilit talon Dec 18, 2024, 11:42 AM

#

oh yeah looks correct, u get a notify for ADP0 (power adapter) status change, and the battery

carmine nacelle Dec 18, 2024, 11:43 AM

#

It's spamming a bunch of this

twilit talon Dec 18, 2024, 11:43 AM

#

carmine nacelle Is this normal?

the fact that there's no handler here is incorrect, no

carmine nacelle Dec 18, 2024, 11:43 AM

#

If I disconnect it from the wall

twilit talon Dec 18, 2024, 11:43 AM

#

WMID or battery

carmine nacelle Dec 18, 2024, 11:43 AM

#

This is what I get if I disconnect the USB hub

twilit talon Dec 18, 2024, 11:43 AM

#

yeah wait a sec

#

your firmware might be truly fucked

#

ill see where it has a stray embedded control opregion

carmine nacelle Dec 18, 2024, 11:45 AM

#

This is what i get conencting the charger

twilit talon Dec 18, 2024, 11:45 AM

#

looks correct

#

ADP0 status change and BAT0 status change

#

0x80 means status change

#

if you install notify handlers to these devices u would get them called by uacpi prompting you to re-read their status

#

btw power button does nothing? @carmine nacelle

carmine nacelle Dec 18, 2024, 11:47 AM

#

Nothing

twilit talon Dec 18, 2024, 11:47 AM

#

interesting, could be a uacpi skill issue or could be something else

#

ok so

#

your firmware is basically

#

fucked

#

or rather

carmine nacelle Dec 18, 2024, 11:47 AM

#

But I've only added the old way of power button handling I think

twilit talon Dec 18, 2024, 11:48 AM

#

the new way is hooking up a Notify handler to the power button device

#

but u dont even get that Notify

#

So basically

#

your firmware just creates an entirely new EmbeddeControl opregion

#

that has no _REG method or anything

#

and assumes its accessible if the main opregion is available

#

acpica has a special workaround for this which i've ignored because i never saw a real life example

#

but now i do lmao

carmine nacelle Dec 18, 2024, 11:50 AM

#

Will it be fixed by uACPI?

#

Or like does it have to be my OS's quirk

mellow sleet Dec 18, 2024, 11:51 AM

#

uacpi probably

twilit talon Dec 18, 2024, 11:51 AM

#

nah ill fix it ofc

mellow sleet Dec 18, 2024, 11:51 AM

#

sinec acpicia works around it

twilit talon Dec 18, 2024, 11:51 AM

#

basically yeah

#

@carmine nacelle u can fix it right now by installing the EmbeddedControl handler to root

#

instead of the EC node

carmine nacelle Dec 18, 2024, 11:53 AM

#

Meh I'll wait I guess

#

Or not...

#

address space handler?

twilit talon Dec 18, 2024, 11:54 AM

#

ohh

#

nvm

#

i was thiking of a different workaround

#

linux does this

#

        acpi_handle scope_handle = ec == first_ec ? ACPI_ROOT_OBJECT : ec->handle;

        acpi_ec_enter_noirq(ec);
        status = acpi_install_address_space_handler_no_reg(scope_handle,
                                   ACPI_ADR_SPACE_EC,
                                   &acpi_ec_space_handler,
                                   NULL, ec);

#

if its the first EC being created the handlers are installed to root

#

otherwise to EC scope

carmine nacelle Dec 18, 2024, 11:55 AM

#

So this is what I have to do?

twilit talon Dec 18, 2024, 11:55 AM

#

yup

#

i was initially thiking of this workaround:

/*******************************************************************************
 *
 * FUNCTION:    AcpiEvExecuteOrphanRegMethod
 *
 * PARAMETERS:  DeviceNode          - Namespace node for an ACPI device
 *              SpaceId             - The address space ID
 *
 * RETURN:      None
 *
 * DESCRIPTION: Execute an "orphan" _REG method that appears under an ACPI
 *              device. This is a _REG method that has no corresponding region
 *              within the device's scope. ACPI tables depending on these
 *              "orphan" _REG methods have been seen for both EC and GPIO
 *              Operation Regions. Presumably the Windows ACPI implementation
 *              always calls the _REG method independent of the presence of
 *              an actual Operation Region with the correct address space ID.
 *
 *  MUTEX:      Assumes the namespace is locked
 *
 ******************************************************************************/

static void
AcpiEvExecuteOrphanRegMethod (

carmine nacelle Dec 18, 2024, 11:55 AM

#

And it's not gonna be fixed by uACPI

twilit talon Dec 18, 2024, 11:55 AM

#

but this isnt your case

twilit talon Dec 18, 2024, 11:56 AM

#

carmine nacelle And it's not gonna be fixed by uACPI

it's not a uacpi problem really

#

i just misunderstood

carmine nacelle Dec 18, 2024, 11:56 AM

#

ok

twilit talon Dec 18, 2024, 11:56 AM

#

twilit talon i was initially thiking of this workaround: ``` /*******************************...

this will be fixed by uacpi, but this isnt your issue

#

_REG methods that are orphans

#

what linux does makes a lot of sense actually

#

if its the only EC u can handle all opregions of this type with it

#

if there are multiple all other ones will be region-local

carmine nacelle Dec 18, 2024, 11:59 AM

#

stupid question but how do I pass root to uacpi_install_address_space_handler?

twilit talon Dec 18, 2024, 11:59 AM

#

uacpi_namespace_root()

carmine nacelle Dec 18, 2024, 12:06 PM

#

#

Is UBTC USB type c?

twilit talon Dec 18, 2024, 12:06 PM

#

yup

#

works fine now i guess?

carmine nacelle Dec 18, 2024, 12:07 PM

#

Yep

twilit talon Dec 18, 2024, 12:07 PM

#

Device (UBTC)
{
    Name (_HID, EisaId ("USBC000"))  // _HID: Hardware ID
    Name (_CID, EisaId ("PNP0CA0"))  // _CID: Compatible ID
    Name (_UID, Zero)  // _UID: Unique ID
    Name (_DDN, "USB Type C")  // _DDN: DOS Device Name

#

do u get this notify when attaching something to port?

carmine nacelle Dec 18, 2024, 12:07 PM

#

Yes

#

Or a charger

#

This laptop has 3 USB C ports

#

And that's it

#

(also USB 4)

#

(and I have a thunderbolt 3 laptop)

twilit talon Dec 18, 2024, 12:08 PM

#

nice

carmine nacelle Dec 18, 2024, 12:08 PM

#

(so it could be something to try to implement)

twilit talon Dec 18, 2024, 12:08 PM

#

fuck i wannna know why power button doesnt do anything

carmine nacelle Dec 18, 2024, 12:08 PM

#

Lid also works I think

twilit talon Dec 18, 2024, 12:09 PM

#

you're supposed to be getting _Q35 but you arent for some reason

carmine nacelle Dec 18, 2024, 12:09 PM

#

LID0 KEKW

twilit talon Dec 18, 2024, 12:09 PM

#

nice, LID status change

#

at least your ec driver is good now

#

the power button thing bothers me because qookie had the exact same issue

carmine nacelle Dec 18, 2024, 12:10 PM

#

Keyboard backlight

twilit talon Dec 18, 2024, 12:10 PM

#

i wonder if firmware expects you to run some extra methods for this to work

carmine nacelle Dec 18, 2024, 12:10 PM

#

Where do I put the printfs

twilit talon Dec 18, 2024, 12:10 PM

#

wdym?

carmine nacelle Dec 18, 2024, 12:10 PM

#

To debug it

twilit talon Dec 18, 2024, 12:11 PM

#

let me see

#

like basically what happens is probably the EC has some sort of an if (should_generate_event(...))

#

that we're failing

#

idk why

#

but like it has no problem generating e.g. lid status changes

#

which is strange

#

like i would imagine maybe it checks the os version to decide, but then again uacpi responds yes to all modern windows versions

#

@carmine nacelle are your timed mutex acquires implemented correctly?

carmine nacelle Dec 18, 2024, 12:16 PM

#

I ignore timeouts

twilit talon Dec 18, 2024, 12:16 PM

#

just unconditional forever wait?

carmine nacelle Dec 18, 2024, 12:16 PM

#

Btw the image with EC driver and latest uACPI

📎 pmOS.iso

carmine nacelle Dec 18, 2024, 12:16 PM

#

twilit talon just unconditional forever wait?

Yes

twilit talon Dec 18, 2024, 12:16 PM

#

ok that should be fine then

carmine nacelle Dec 18, 2024, 12:16 PM

#

And it's the same mutex as usual

#

Which should be working

#

Or assert fail if it doesn't

twilit talon Dec 18, 2024, 12:17 PM

#

what are we fucking up hmm

#

you install after namespace initialize right?

carmine nacelle Dec 18, 2024, 12:19 PM

#

https://gitlab.com/mishakov/pmos/-/blob/main/devicesd/generic/acpi/acpi.c?ref_type=heads#L190

#

https://gitlab.com/mishakov/pmos/-/blob/main/devicesd/generic/ec.c?ref_type=heads#L458

#

I'm going to eat

twilit talon Dec 18, 2024, 12:22 PM

#

carmine nacelle https://gitlab.com/mishakov/pmos/-/blob/main/devicesd/generic/ec.c?ref_type=head...

btw

    uacpi_status result = uacpi_get_current_resources(node, &resources);
    if (result != UACPI_STATUS_OK) {
        return UACPI_ITERATION_DECISION_CONTINUE;
    }

    struct ec_init_ctx ctx = {};
    uacpi_for_each_resource(resources, find_ec_resources, &ctx);
    uacpi_free_resources(resources);

there's a uacpi_for_each_device_resource

carmine nacelle Dec 18, 2024, 12:23 PM

#

I'll look at it later

twilit talon Dec 18, 2024, 12:23 PM

#

same thing but u dont have to manually create these structs

#

and free

carmine nacelle Dec 18, 2024, 12:23 PM

#

Something might be hanging and we might not be seeing it

twilit talon Dec 18, 2024, 12:24 PM

#

carmine nacelle https://gitlab.com/mishakov/pmos/-/blob/main/devicesd/generic/ec.c?ref_type=head...

looks correct

#

i doubt its hanging because ive seen the exact same behavior on mammogram on qookies laptop

#

all notifies coming it but the power button

#

i dont fucking understand

#

skill issue, but where

#

@carmine nacelle just for funsies, can u try uacpi_uninstall_interface("Windows 2015") before loading the namespace

#

lets pretend we're windows 7 and not 10

#

who knows

carmine nacelle Dec 18, 2024, 12:31 PM

#

Does this laptop even support Windows 7

#

And it shipped with windows 11

twilit talon Dec 18, 2024, 12:31 PM

#

well aml does

carmine nacelle Dec 18, 2024, 12:31 PM

#

(I'll check it once I come back)

twilit talon Dec 18, 2024, 12:31 PM

#

it queries for all windows versions up to 10

twilit talon Dec 18, 2024, 12:31 PM

#

carmine nacelle Does this laptop even support Windows 7

carmine nacelle Dec 18, 2024, 12:39 PM

#

Linux meme

twilit talon Dec 18, 2024, 12:40 PM

#

the TLDR is every linux now responds false to it

carmine nacelle Dec 18, 2024, 12:40 PM

#

Yes

#

2006 is Vista?

twilit talon Dec 18, 2024, 12:43 PM

#

#

ye

carmine nacelle Dec 18, 2024, 12:45 PM

#

Could interrupts somehow be broken?

#

Or does EC use the same line?

twilit talon Dec 18, 2024, 12:48 PM

#

its the same line for all notifications

#

all ACPI notifications use IRQ 9

carmine nacelle Dec 18, 2024, 12:54 PM

#

twilit talon <@350748255929499649> just for funsies, can u try `uacpi_uninstall_interface("Wi...

Nothing changed

twilit talon Dec 18, 2024, 12:54 PM

#

i wonder what we're doing wrong

#

like we know the order is correct here, I've verified against linux

#

and they do react to the power button

#

right?

carmine nacelle Dec 18, 2024, 12:55 PM

#

could this be related?

carmine nacelle Dec 18, 2024, 12:56 PM

#

carmine nacelle

Linux reacts like this

#

boot log

twilit talon Dec 18, 2024, 12:56 PM

#

carmine nacelle could this be related?

nah this is printed by ACPICA as well

#

yeah all your logs are correct

carmine nacelle Dec 18, 2024, 12:57 PM

#

Some of the FN buttons are also broken

#

But maybe it's sent to PS/2

#

Like lock, calculator and some other things

#

Sound controls

#

I can try managram...

#

Could there be some other mechanism?

#

For the power button

twilit talon Dec 18, 2024, 1:00 PM

#

carmine nacelle Like lock, calculator and some other things

those are standard ps/2 keys i think

#

maybe

twilit talon Dec 18, 2024, 1:00 PM

#

carmine nacelle Could there be some other mechanism?

nah just these two

twilit talon Dec 18, 2024, 1:00 PM

#

carmine nacelle I can try managram...

nah it wont do anything differently

#

there are two possibilities

#

since you don't have any sort of power management you don't call any methods that do stuff related to that, perhaps power button is initialized as part of that
uacpi does some IO incorrectly which leads to incorrectly initialized state of something

#

if you're feeling brave u can try porting ACPICA

carmine nacelle Dec 18, 2024, 1:02 PM

#

Keyronex has acpica, right?

twilit talon Dec 18, 2024, 1:02 PM

#

and see if we can exclude case 2

#

keyronex is uacpi

carmine nacelle Dec 18, 2024, 1:02 PM

#

Who had it then

twilit talon Dec 18, 2024, 1:03 PM

#

nobody

carmine nacelle Dec 18, 2024, 1:03 PM

#

Bruh

twilit talon Dec 18, 2024, 1:03 PM

#

but u can try porting it LULW

carmine nacelle Dec 18, 2024, 1:03 PM

#

I don't want to

#

I have better things to do

twilit talon Dec 18, 2024, 1:03 PM

#

tbh its public api is similar to uacpi's so u wont struggle too much, but its very hard to port because there isnt a clear interface for stdlib

carmine nacelle Dec 18, 2024, 1:03 PM

#

Does Linux have some sort of debug mode for acpi?

twilit talon Dec 18, 2024, 1:04 PM

#

like yes but it has so many acpi-related drivers

#

its impossible to tell which one could affect this

carmine nacelle Dec 18, 2024, 1:06 PM

#

Which was the other laptop where power button wasn't working?

#

Maybe there's something in common

twilit talon Dec 18, 2024, 1:09 PM

#

carmine nacelle Which was the other laptop where power button wasn't working?

@hexed acorn pls tell us

hexed acorn Dec 18, 2024, 1:11 PM

#

i think the model goes something like hp laptop 15s-eq1124nw

#

i havent tried managarm on it recently so maybe it works now

carmine nacelle Dec 18, 2024, 1:12 PM

#

Chatgpt says this

#

The issue that I'm having is that everything works but the power button

twilit talon Dec 18, 2024, 1:17 PM

#

like u dont get any irq at all

#

so that means something isnt configured correctly

#

whos skill issue that is remains unknown

twilit talon Dec 18, 2024, 1:17 PM

#

twilit talon like u dont get any irq at all

(i mean during the power button press)

carmine nacelle Dec 18, 2024, 1:22 PM

#

How do I see AML?

hoary moat Dec 18, 2024, 1:22 PM

#

When looking at managarm code, they do register some gpe events after finalizing gpe init

#

Which sounds wrong

carmine nacelle Dec 18, 2024, 1:23 PM

#

hexed acorn i think the model goes something like hp laptop 15s-eq1124nw

Could it be some whatever Ryzen laptops firmware everyone is using weirdness?

twilit talon Dec 18, 2024, 1:23 PM

#

carmine nacelle How do I see AML?

acpidump > dump.txt && acpixtract -a dump.txt && iasl *.dat && code dsdt.dsl

#

EC init happens in _REG

#

but it's really hard to tell what it does exactly because obv its chipset specific

carmine nacelle Dec 18, 2024, 1:27 PM

#

hoary moat When looking at managarm code, they do register some gpe events after finalizing...

I also do that I think

hoary moat Dec 18, 2024, 1:27 PM

#

Might be a problem

#

I register all my GPEs before finalizing init

#

So does Linux I think

twilit talon Dec 18, 2024, 1:28 PM

#

yeah managarm only does it because uacpi didnt have thread safety

#

so it would crash during ns init

#

because it would get an irq

carmine nacelle Dec 18, 2024, 1:28 PM

#

PNP0C0C?

twilit talon Dec 18, 2024, 1:29 PM

#

carmine nacelle PNP0C0C?

thats your power button device yes

carmine nacelle Dec 18, 2024, 1:29 PM

#

Could I need to be registering it explicitly?

twilit talon Dec 18, 2024, 1:29 PM

#

if we configured EC correctly you would get a query which would result in Notify(PWRB)

twilit talon Dec 18, 2024, 1:30 PM

#

carmine nacelle Could I need to be registering it explicitly?

nah like

#

from the software standpoint you're doing everything correctly

twilit talon Dec 18, 2024, 1:30 PM

#

twilit talon 1. since you don't have any sort of power management you don't call any methods ...

obos might have a chance at getting it to work if its point 1 here

#

because he calls all power-related methods

#

or at least some of them

carmine nacelle Dec 18, 2024, 1:31 PM

#

Linux does this

static bool acpi_wakeup_gpe_init(struct acpi_device *device)
{
    static const struct acpi_device_id button_device_ids[] = {
        {"PNP0C0C", 0},                /* Power button */
        {"PNP0C0D", ACPI_AVOID_WAKE_FROM_S5},    /* Lid */
        {"PNP0C0E", ACPI_AVOID_WAKE_FROM_S5},    /* Sleep button */
        {"", 0},
    };
    struct acpi_device_wakeup *wakeup = &device->wakeup;
    const struct acpi_device_id *match;
    acpi_status status;

    wakeup->flags.notifier_present = 0;

    /* Power button, Lid switch always enable wakeup */
    match = acpi_match_acpi_device(button_device_ids, device);
    if (match) {
        if ((match->driver_data & ACPI_AVOID_WAKE_FROM_S5) &&
            wakeup->sleep_state == ACPI_STATE_S5)
            wakeup->sleep_state = ACPI_STATE_S4;
        acpi_mark_gpe_for_wake(wakeup->gpe_device, wakeup->gpe_number);
        device_set_wakeup_capable(&device->dev, true);
        return true;
    }

    status = acpi_setup_gpe_for_wake(device->handle, wakeup->gpe_device,
                     wakeup->gpe_number);
    return ACPI_SUCCESS(status);
}

hoary moat Dec 18, 2024, 1:32 PM

#

carmine nacelle Linux does this ```C static bool acpi_wakeup_gpe_init(struct acpi_device *device...

This is for a device btw

#

And is also for wake from suspend

#

Iirc

twilit talon Dec 18, 2024, 1:33 PM

#

carmine nacelle Linux does this ```C static bool acpi_wakeup_gpe_init(struct acpi_device *device...

this is for suspending

#

runtime notifications are done via EC

carmine nacelle Dec 18, 2024, 1:33 PM

#

So not what I want

twilit talon Dec 18, 2024, 1:33 PM

#

basically yeah

hoary moat Dec 18, 2024, 1:33 PM

#

Yeah

#

https://github.com/OBOS-dev/obos/blob/userspace-work/src%2Foboskrnl%2Fpower%2Fdevice.c#L87-L114

GitHub

obos/src/oboskrnl/power/device.c at userspace-work · OBOS-dev/obos

I was bored... Contribute to OBOS-dev/obos development by creating an account on GitHub.

#

Daily obos shilling

#

There is obos' code for enabling wake gpes

twilit talon Dec 18, 2024, 1:34 PM

#

like the simplest way to debug it would be trying to make an acpica driver that does the exact same thing u do with uacpi

#

if u do get a power button notifcation with it then its a uacpi bug

#

otherwise its u not calling some configuration method or ordering

carmine nacelle Dec 18, 2024, 1:35 PM

#

There are drivers for it https://www.driveridentifier.com/scan/acpi-power-button/download/964810950/4B57681D6EE24B48BBDB7C006D0C0634/*PNP0C0C

carmine nacelle Dec 18, 2024, 1:53 PM

#

The spec says this

The power button programming model can also use the generic hardware programming model. This allows the power
button to reside in any of the generic hardware address spaces (for example, the embedded controller) instead of fixed
space. If the power button is implemented using generic hardware, then the OEM needs to define the power button as
a device with an _HID object value of “PNP0C0C,” which then identifies this device as the power button to OSPM.
The AML event handler then generates a Notify command to notify OSPM that a power button event was generated.
While the system is in the working state, a power button press is a user request to transition the system into either the
sleeping (G1) or soft-off state (G2). In these cases, the power button event handler issues the Notify command with
the device specific code of 0x80. This indicates to OSPM to pass control to the power button driver (PNP0C0C) with
the knowledge that a transition out of the G0 state is being requested. Upon waking from a G1 sleeping state, the AML
event handler generates a notify command with the code of 0x2 to indicate it was responsible for waking the system.

#

https://learn.microsoft.com/en-us/windows-hardware/drivers/hid/buttons

HID Button Drivers - Windows drivers

Use the Microsoft-provided button driver for GPIO buttons; otherwise, implement your driver that injects HID data to the operating system.

#

Could it be sent by HID?

twilit talon Dec 18, 2024, 1:54 PM

#

_HID is just a string object

#

In these cases, the power button event handler issues the Notify command with
the device specific code of 0x80.

#

this is what u dont get

carmine nacelle Dec 18, 2024, 1:57 PM

#

I think I'll try to fix my PS/2 driver

#

I don't think I'm doing that

In order to hook that up you will need to:

Write an embedded controller driver
Find the EC device in the AML namespace (PNP ID "PNP0C09" or ECDT table), attach an address space handler
Find a power button object in the namespace, attach a notify handler
Detect the general purpose event number used by the embedded controller (_GPE method), install a handler for it
In the event handler, execute the QR_EC command to find out the index of the query requested by the EC
Run the requested query by executing the corresponding "EC._QXX" control method in AML
If this query was for a power button press, you will receive a notifications with value 0x80 (S0 Power Button Pressed)

#

Wait, no, I do

#

nevermind

#

Imma try managram

twilit talon Dec 18, 2024, 1:59 PM

#

try it but i doubt anything is going to change

vale hazel Dec 18, 2024, 7:59 PM

#

carmine nacelle Btw the image with EC driver and latest uACPI

HEY IM SO SORRY

#

TESTING IT NOW

twilit talon Dec 18, 2024, 8:05 PM

#

im really curious what we're doing wrong for the power button but thats currently too much work to debug

vale hazel Dec 18, 2024, 8:08 PM

#

power button works

#

just fine

#

wyall mean

twilit talon Dec 18, 2024, 8:10 PM

#

is your power button routed via EC?

#

show us the kernel output

carmine nacelle Dec 18, 2024, 8:12 PM

#

vale hazel wyall mean

It doesn't work on my laptop for no reason

vale hazel Dec 18, 2024, 8:12 PM

#

twilit talon is your power button routed via EC?

i cant show the kernel output very well

#

because its on my mani system

#

it did say some errors

#

though

twilit talon Dec 18, 2024, 8:13 PM

#

wdym

carmine nacelle Dec 18, 2024, 8:13 PM

#

If it's assert fail that's fine

twilit talon Dec 18, 2024, 8:13 PM

#

does it shutdown instantly?

carmine nacelle Dec 18, 2024, 8:13 PM

#

My shutdown has a 3 seconds timer

vale hazel Dec 18, 2024, 8:13 PM

#

power button pressed

#

shutting down in 3 seconds...

twilit talon Dec 18, 2024, 8:13 PM

#

then its a fixed event

#

not an EC query

vale hazel Dec 18, 2024, 8:13 PM

#

okay i see

twilit talon Dec 18, 2024, 8:14 PM

#

he doesnt have power button notify handlers hooked up

#

so we would see log spam

carmine nacelle Dec 18, 2024, 8:14 PM

#

I have an old macbook at home, which was also not shutting down without EC driver

#

I'm coming there this weekend and can try to test it

#

(also I finish classes this week, so disregarding exams I'll have a lot of time for osdev spun )

twilit talon Dec 18, 2024, 8:16 PM

#

macs do have ECs i think

#

albeit quirky ones

carmine nacelle Dec 18, 2024, 8:16 PM

#

It's 2012 mac so that's gonna be fun

carmine nacelle Dec 18, 2024, 8:17 PM

#

carmine nacelle I have an old macbook at home, which was also not shutting down without EC drive...

But AML was assuming it and uACPI would not initialize iirc

twilit talon Dec 18, 2024, 8:17 PM

#

i wish we could easily test acpica

#

@carmine nacelle if u could build a custom linux to run on your hw we could also add prints or trace io done by acpica or something

carmine nacelle Dec 18, 2024, 8:19 PM

#

Ok

#

What do I need to do

twilit talon Dec 18, 2024, 8:19 PM

#

build linux

#

ill tell u where to add printfs

carmine nacelle Dec 18, 2024, 8:20 PM

#

Ok

#

I might do that in a couple of hours

twilit talon Dec 18, 2024, 8:20 PM

#

nice

#

first thing we're gonna trace EC queries that it receives

carmine nacelle Dec 18, 2024, 8:20 PM

#

I need to finish some stuff

#

Still, can power button somehow be wired to keyboard or something weird?

twilit talon Dec 18, 2024, 8:21 PM

#

i have a suspicion it requires advanced platform power capabilities that are configured via _OSC

carmine nacelle Dec 18, 2024, 8:21 PM

#

I might as well implement that if it's not too difficult

twilit talon Dec 18, 2024, 8:21 PM

#

anyway we're gonna find out what it requires

#

by commenting stuff out or adding printfs

carmine nacelle Dec 18, 2024, 8:22 PM

#

Fun

#

Linux dualboot time

#

Although I think I can just boot life cd with custom kernel

twilit talon Dec 18, 2024, 8:22 PM

#

u can just make a live usb or something

#

yeah

carmine nacelle Dec 18, 2024, 8:22 PM

#

Like it's a grub option away

#

I've built lfs once...

#

Anyway

#

I could also try bsds

twilit talon Dec 18, 2024, 8:24 PM

#

https://elixir.bootlin.com/linux/v6.12.5/source/drivers/acpi/ec.c#L1155

ec.c - drivers/acpi/ec.c - Linux source code v6.12.5...

Elixir Cross Referencer - source code of Linux v6.12.5: drivers/acpi/ec.c

#

there's already this as a start

carmine nacelle Dec 18, 2024, 8:25 PM

#

I think I really need to learn about Linux internals one day...

twilit talon Dec 18, 2024, 8:25 PM

#

idk how to enable this print so its easier for us to add our own lmao

carmine nacelle Dec 18, 2024, 8:25 PM

#

Like it's just C

twilit talon Dec 18, 2024, 8:25 PM

#

probably some log level we need to set

twilit talon Dec 18, 2024, 8:28 PM

#

carmine nacelle I think I really need to learn about Linux internals one day...

bootlin is insanely good for this

#

u can go to implementation and find all users of a function

carmine nacelle Dec 18, 2024, 8:29 PM

#

I think you need to compile linux with DEBUG?

twilit talon Dec 18, 2024, 8:29 PM

#

nah

carmine nacelle Dec 18, 2024, 8:29 PM

#

Then it starts to printk

twilit talon Dec 18, 2024, 8:29 PM

#

just replace those with pr_info

carmine nacelle Dec 18, 2024, 8:29 PM

#

following the macros

twilit talon Dec 18, 2024, 8:29 PM

#

yeah but we dont care

#

we dont want all spam just this

carmine nacelle Dec 18, 2024, 8:29 PM

#

Ok I'm getting distracted

#

I need to turn a lab report in in 2 hours

twilit talon Dec 18, 2024, 8:30 PM

#

yeye

carmine nacelle Dec 18, 2024, 9:55 PM

#

Ok, time for Linux

#

@twilit talon what do I patch

twilit talon Dec 18, 2024, 10:14 PM

#

twilit talon https://elixir.bootlin.com/linux/v6.12.5/source/drivers/acpi/ec.c#L1155

replace these with pr_info

#

for starters

carmine nacelle Dec 18, 2024, 10:14 PM

#

Do I replace everything?

twilit talon Dec 18, 2024, 10:15 PM

#

no just started tbh

#

just to see if linux gets it at least

carmine nacelle Dec 18, 2024, 10:19 PM

#

What kernel options do I need

#

I can't find AMDGPU...

#

Ok i'm compiling it

#

Never compiled linux on this laptop

#

bruh

kernel/sys.c:1307:21: error: ‘LINUX_VERSION_PATCHLEVEL’ undeclared (first use in this function); did you mean ‘LINUX_VERSION_CODE’?
 1307 |                 v = LINUX_VERSION_PATCHLEVEL + 60;
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~
      |                     LINUX_VERSION_CODE

twilit talon Dec 18, 2024, 10:33 PM

#

carmine nacelle What kernel options do I need

just make olddefconfig probably

carmine nacelle Dec 18, 2024, 10:35 PM

#

I've enabled amdgpu and my wifi card

#

As built in

#

It should boot if I just use the new kernel, right?

#

Like without modules and stuff

#

(idk why it wouldn't)

twilit talon Dec 18, 2024, 10:36 PM

#

yes

carmine nacelle Dec 18, 2024, 10:37 PM

#

Why am I getting this ```
drivers/usb/core/hcd.c:115:33: error: ‘LINUX_VERSION_PATCHLEVEL’ undeclared here (not in a function); did you mean ‘LINUX_VERSION_CODE’?
115 | #define KERNEL_VER bin2bcd(LINUX_VERSION_PATCHLEVEL)

#

I've checked out to v6.13

#

It shouldn't be broken

twilit talon Dec 18, 2024, 10:39 PM

#

how do u configure it

carmine nacelle Dec 18, 2024, 10:40 PM

#

make menuconfig

twilit talon Dec 18, 2024, 10:46 PM

#

ah

#

yeah idk, linux surely doesnt have any broken commits

#

so its some skill issue on your part i believe

carmine nacelle Dec 18, 2024, 10:49 PM

#

I'll redownload it

#

Idk

#

I'm too stupid

#

How do I write linux to drive

#

(i mead dd)

#

I'm gonna try rufus again

#

because with dd windows can't read the partitions

#

skill issue ratified

twilit talon Dec 18, 2024, 11:11 PM

#

nice

carmine nacelle Dec 18, 2024, 11:29 PM

#

What am I doing wrong why does it hang after this

#

@twilit talon ?

twilit talon Dec 18, 2024, 11:34 PM

#

i dont even know what that means

#

not sure

#

this doesnt look like a dmesg

carmine nacelle Dec 18, 2024, 11:35 PM

#

It's grub

#

I'm gonna try USB 3 port...

twilit talon Dec 18, 2024, 11:35 PM

#

very strange

#

does it boot in qemu?

carmine nacelle Dec 18, 2024, 11:36 PM

#

Idk

#

I'm supposed to be using bzImage instead of vmlinuz, right?

#

I'm too tired for this

#

Huh https://forums.gentoo.org/viewtopic-p-8814070.html?sid=e99a997e93673bb79dd3a14701d666ce

twilit talon Dec 18, 2024, 11:37 PM

#

one is deprecated

#

i dont remember which one lmao

carmine nacelle Dec 18, 2024, 11:39 PM

#

This says it's kernel panic https://discourse.nixos.org/t/system-wont-boot-path-efi-stub/29212

NixOS Discourse

System won't boot path EFI stub

All of a sudden my computer doesn’t boot up successfully anymore. After selecting the NixOS generation in the boot loader menu, I get EFI stub: Loaded initrd from LINUX_EFI_INITRD_MEDIA_GUID device path EFI stub: Measured initrd data into PCR 9 Nothing seems to happen afterwards. This also happens for older NixOS generations that worked previo...

twilit talon Dec 18, 2024, 11:40 PM

#

bruh

#

linux is kinda annoying

carmine nacelle Dec 18, 2024, 11:41 PM

#

Btw I think this laptop doesn't even have CSM

#

I'll try fedora instead of Ubuntu...

#

I'm hoping Linus' favourite is gonna do better

twilit talon Dec 18, 2024, 11:49 PM

#

try it

carmine nacelle Dec 18, 2024, 11:53 PM

#

It turns off after a bit

twilit talon Dec 19, 2024, 12:00 AM

#

F

carmine nacelle Dec 19, 2024, 12:01 AM

#

Idk what am I supposed to do

#

I think I'll dualboot fedora finally

#

One small problem

twilit talon Dec 19, 2024, 1:52 AM

#

Time to get a separate nvme for linux

carmine nacelle Dec 19, 2024, 8:09 AM

#

fun

carmine nacelle Dec 19, 2024, 9:43 AM

#

I've installed fedora

#

@twilit talon this laptop can't suspend with Linux

twilit talon Dec 19, 2024, 9:44 AM

#

thats a separate bug albeit also important

#

if you want it fixed u can write an email to power management maintiners

carmine nacelle Dec 19, 2024, 9:47 AM

#

https://pastebin.com/nYHLp0Tm

Pastebin

Fedora suspend dmesg - Pastebin.com

Pastebin.com is the number one paste tool since 2002. Pastebin is a website where you can store text online for a set period of time.

#

this doesn't look out of place i'd suppose

#

anyways

#

I'm trying to compile linux again

#

Wow, this laptop flies with linux

twilit talon Dec 19, 2024, 9:48 AM

#

it says s2idle

#

thats kind of a fake suspend

#

should be using s3

carmine nacelle Dec 19, 2024, 9:52 AM

#

It's a modern standby laptop

#

So it might not have s3

twilit talon Dec 19, 2024, 9:52 AM

#

grep dmesg

carmine nacelle Dec 19, 2024, 9:52 AM

#

what do I check

#

https://wiki.archlinux.org/title/Power_management/Suspend_and_hibernate

Suspend and hibernate

twilit talon Dec 19, 2024, 9:53 AM

#

S3

#

dmesg has all available modes

carmine nacelle Dec 19, 2024, 9:53 AM

#

twilit talon S3

there's nothing

twilit talon Dec 19, 2024, 9:54 AM

#

to verify, is there s5?

carmine nacelle Dec 19, 2024, 9:55 AM

#

misha@fedora:~/linux-6.12.5$ sudo cat /sys/power/mem_sleep 
[s2idle]

twilit talon Dec 19, 2024, 9:55 AM

#

not this

#

btw

#

did u add that patch?

carmine nacelle Dec 19, 2024, 9:55 AM

#

No

#

I'm trying to install vscode

twilit talon Dec 19, 2024, 9:55 AM

#

vim

carmine nacelle Dec 19, 2024, 9:56 AM

#

meh

#

I'm not profficient enough in it

#

Idk if it's bios stupidity, but this laptop is refusing to speed up fans to decent rpm

#

With Linux

twilit talon Dec 19, 2024, 10:11 AM

#

fans are aml controlled

#

or via other drivers

carmine nacelle Dec 19, 2024, 10:47 AM

#

it's almost compiled

#

I'm booting mainline kernel...

#

Omg it worked ```
[ 70.413998] ACPI: EC: Query(0x11) started
[ 70.414243] ACPI: EC: Query(0x11) stopped
[ 70.576168] ACPI: EC: Query(0x11) started
[ 70.576375] ACPI: EC: Query(0x11) stopped
[ 71.055577] ACPI: EC: Query(0x12) started
[ 71.055719] ACPI: EC: Query(0x12) stopped
[ 71.181797] ACPI: EC: Query(0x12) started

#

@twilit talon there are no EC queries when I press power button

📎 message.txt

carmine nacelle Dec 19, 2024, 11:01 AM

#

carmine nacelle Omg it worked ``` [ 70.413998] ACPI: EC: Query(0x11) started [ 70.414243] AC...

This if from brightness buttons

twilit talon Dec 19, 2024, 11:04 AM

#

ok thats an amazing find

carmine nacelle Dec 19, 2024, 11:04 AM

#

What do we do now lol

twilit talon Dec 19, 2024, 11:04 AM

#

u get these queries as well right?

#

the ones its getting

carmine nacelle Dec 19, 2024, 11:04 AM

#

Which ones

#

I think so

twilit talon Dec 19, 2024, 11:04 AM

#

0x12 etc

carmine nacelle Dec 19, 2024, 11:05 AM

#

Like if I connect and disconnect the battery I also get a bunch queries

twilit talon Dec 19, 2024, 11:05 AM

#

no missing queries that happen for linux but not for u?

carmine nacelle Dec 19, 2024, 11:05 AM

#

It's the other way around

twilit talon Dec 19, 2024, 11:05 AM

#

wdym

carmine nacelle Dec 19, 2024, 11:06 AM

#

Like disconnecting a charger pmOS would receive a query every few seconds or so

#

And I haven't noticed that on Linux

#

Although that might be from AML

twilit talon Dec 19, 2024, 11:06 AM

#

possible because linux actually reacts to those queries and u do nothing

#

lmao

carmine nacelle Dec 19, 2024, 11:06 AM

#

But yeah in general I think I have the same

#

Stuff

#

Where could the power button be coming from then?

twilit talon Dec 19, 2024, 11:06 AM

#

carmine nacelle What do we do now lol

ok so now we find out how it notices that the power button is pressed

carmine nacelle Dec 19, 2024, 11:07 AM

#

Bruh Linux is so fucked it doesn't even turn the screen off when closing the lid

twilit talon Dec 19, 2024, 11:08 AM

#

hmm i wonder how we can find that out

#

let see

#

https://elixir.bootlin.com/linux/v6.12.5/source/drivers/acpi/button.c#L439

#

add printfs here

#

if this is called when u press the power button we'll panic to dump the backtrace

carmine nacelle Dec 19, 2024, 11:09 AM

#

Do I remove other printfs?

#

no

twilit talon Dec 19, 2024, 11:09 AM

#

keep them its fine

twilit talon Dec 19, 2024, 11:13 AM

#

carmine nacelle <@353593948523986945> there are no EC queries when I press power button

@hexed acorn apparently there's a third way to route a power button which we didnt know about

#

we added printfs to linux on his laptop

#

@carmine nacelle whats the laptop brand again

carmine nacelle Dec 19, 2024, 11:15 AM

#

acpi shouldn't be a module, right?

carmine nacelle Dec 19, 2024, 11:15 AM

#

twilit talon <@350748255929499649> whats the laptop brand again

Lenovo

twilit talon Dec 19, 2024, 11:15 AM

#

no

carmine nacelle Dec 19, 2024, 11:15 AM

#

Yoga slim 7 8th gen

#

amd

twilit talon Dec 19, 2024, 11:17 AM

#

hmm i wonder if thinkpad_acpi.c is applicable to you

carmine nacelle Dec 19, 2024, 11:18 AM

#

@twilit talon ```
[ 61.668168] ACPI: button: acpi_button_notify handle 00000000c935dbe2 event 128 device 000000004764d9ce
[ 61.668199] ACPI: button: acpi_button_notify: power

carmine nacelle Dec 19, 2024, 11:18 AM

#

twilit talon hmm i wonder if thinkpad_acpi.c is applicable to you

Is should be similar to a thinkpad I'd suppose

twilit talon Dec 19, 2024, 11:18 AM

#

carmine nacelle <@353593948523986945> ``` [ 61.668168] ACPI: button: acpi_button_notify handle...

hly shit

#

ok

#

now we need to panic

carmine nacelle Dec 19, 2024, 11:19 AM

#

I was between this laptop and a similar thinkpad when buying it

carmine nacelle Dec 19, 2024, 11:19 AM

#

twilit talon now we need to panic

why

twilit talon Dec 19, 2024, 11:19 AM

#

or actually

carmine nacelle Dec 19, 2024, 11:19 AM

#

how do I extract the stuff from handle

twilit talon Dec 19, 2024, 11:19 AM

#

u dont

#

dump_backtrace() or something

#

there should be a function like that

#

or do WARN_ON(1)

#

where u have that printf

carmine nacelle Dec 19, 2024, 11:21 AM

#

Why does it take like half an hour to compile a single c file

twilit talon Dec 19, 2024, 11:21 AM

#

lol

carmine nacelle Dec 19, 2024, 11:21 AM

#

and link the kernel

#

anyway

twilit talon Dec 19, 2024, 11:21 AM

#

we're about to find out where its called from i guess

#

becaues its definitely not the ec

#

actually we might not

#

because it will be dispatched from the work queue

carmine nacelle Dec 19, 2024, 11:23 AM

#

rebooting...

twilit talon Dec 19, 2024, 11:23 AM

#

we need to catch it when it gets scheduled

carmine nacelle Dec 19, 2024, 11:23 AM

#

maybe not yet

twilit talon Dec 19, 2024, 11:23 AM

#

well try it anyway maybe we'll see something

carmine nacelle Dec 19, 2024, 11:23 AM

#

INSTALL /boot also takes like half an hour

#

on PM971

#

anyway

twilit talon Dec 19, 2024, 11:25 AM

#

im gonna need u to do more complex hacking

carmine nacelle Dec 19, 2024, 11:25 AM

#

Bro

twilit talon Dec 19, 2024, 11:25 AM

#

lol

carmine nacelle Dec 19, 2024, 11:27 AM

#

And it's taking its time...

twilit talon Dec 19, 2024, 11:27 AM

#

@carmine nacelle u do install a fixed event handler for it right?

carmine nacelle Dec 19, 2024, 11:27 AM

#

Idr

twilit talon Dec 19, 2024, 11:27 AM

#

please dont tell me u dont

carmine nacelle Dec 19, 2024, 11:28 AM

#

carmine nacelle https://gitlab.com/mishakov/pmos/-/blob/main/devicesd/generic/acpi/acpi.c?ref_ty...

This is what I do

twilit talon Dec 19, 2024, 11:29 AM

#

ok yeah u do

carmine nacelle Dec 19, 2024, 11:29 AM

#

And it worked on linuxmaster's laptop

twilit talon Dec 19, 2024, 11:29 AM

#

add a printf on this line as well pls https://elixir.bootlin.com/linux/v6.12.5/source/drivers/acpi/button.c#L477

#

next time

#

did it finish updating?

carmine nacelle Dec 19, 2024, 11:31 AM

#

bruh it did but it booted into the wrong kernel

twilit talon Dec 19, 2024, 11:31 AM

#

carmine nacelle And it worked on linuxmaster's laptop

ah right yeah

carmine nacelle Dec 19, 2024, 11:31 AM

#

Since the update was for the kernel

#

Lol

twilit talon Dec 19, 2024, 11:32 AM

#

bruyh

carmine nacelle Dec 19, 2024, 11:33 AM

#

[   34.567108] Call Trace:
[   34.567112]  <TASK>
[   34.567115]  ? acpi_button_notify+0x28/0x140
[   34.567119]  ? __warn.cold+0x93/0xfa
[   34.567124]  ? acpi_button_notify+0x28/0x140
[   34.567134]  ? report_bug+0xff/0x140
[   34.567142]  ? handle_bug+0x58/0x90
[   34.567148]  ? exc_invalid_op+0x17/0x70
[   34.567153]  ? asm_exc_invalid_op+0x1a/0x20
[   34.567164]  ? acpi_button_notify+0x28/0x140
[   34.567170]  acpi_ev_notify_dispatch+0x48/0x80
[   34.567179]  acpi_os_execute_deferred+0x17/0x30
[   34.567184]  process_one_work+0x176/0x330
[   34.567193]  worker_thread+0x252/0x390
[   34.567201]  ? __pfx_worker_thread+0x10/0x10
[   34.567207]  kthread+0xcf/0x100
[   34.567212]  ? __pfx_kthread+0x10/0x10
[   34.567217]  ret_from_fork+0x31/0x50
[   34.567223]  ? __pfx_kthread+0x10/0x10
[   34.567228]  ret_from_fork_asm+0x1a/0x30
[   34.567239]  </TASK>
[   34.567242] ---[ end trace 0000000000000000 ]---

#

Yep it's from queue

twilit talon Dec 19, 2024, 11:33 AM

#

okay so

#

more advanced hacking

carmine nacelle Dec 19, 2024, 11:33 AM

#

printfs with if statements?

twilit talon Dec 19, 2024, 11:34 AM

#

or actually

#

we can simplify it

#

i want u do add a WARN_ON(1) to acpi_os_execute if the work is of type OSL_NOTIFY_HANDLER

#

acpi/osl.c

carmine nacelle Dec 19, 2024, 11:35 AM

#

osunixxf.c?

twilit talon Dec 19, 2024, 11:36 AM

#

acpi/osl.c

#

very curious what we're about to discover

carmine nacelle Dec 19, 2024, 11:37 AM

#

compiling...

twilit talon Dec 19, 2024, 11:37 AM

#

and will have some extra stuff because of other notifies

carmine nacelle Dec 19, 2024, 11:38 AM

#

wait, I forgor about the other printf

twilit talon Dec 19, 2024, 11:38 AM

#

its fine but u can add it if its not too late

carmine nacelle Dec 19, 2024, 11:38 AM

#

it's linking the kernel

twilit talon Dec 19, 2024, 11:39 AM

#

there may be one extra layer of abstraction but we'll see

carmine nacelle Dec 19, 2024, 11:42 AM

#

[   50.757662] Call Trace:
[   50.757665]  <TASK>
[   50.757669]  ? acpi_os_execute+0xf5/0x110
[   50.757676]  ? __warn.cold+0x93/0xfa
[   50.757682]  ? acpi_os_execute+0xf5/0x110
[   50.757699]  ? report_bug+0xff/0x140
[   50.757708]  ? handle_bug+0x58/0x90
[   50.757716]  ? exc_invalid_op+0x17/0x70
[   50.757723]  ? asm_exc_invalid_op+0x1a/0x20
[   50.757738]  ? __pfx_acpi_ev_notify_dispatch+0x10/0x10
[   50.757758]  ? __pfx_acpi_ev_notify_dispatch+0x10/0x10
[   50.757765]  ? acpi_os_execute+0xf5/0x110
[   50.757773]  acpi_ev_queue_notify_request+0xb2/0x110
[   50.757783]  acpi_ds_exec_end_op+0x19c/0x560
[   50.757791]  acpi_ps_parse_loop+0x100/0x6b0
[   50.757801]  acpi_ps_parse_aml+0x80/0x3c0
[   50.757809]  acpi_ps_execute_method+0x13f/0x270
[   50.757818]  acpi_ns_evaluate+0x13e/0x2d0
[   50.757832]  acpi_evaluate_object+0x182/0x340
[   50.757840]  acpi_execute_simple_method+0x60/0x80
[   50.757851]  acpi_gpio_irq_handler_evt+0x17/0x30
[   50.757855]  irq_thread_fn+0x20/0x60
[   50.757861]  irq_thread+0x1b0/0x2f0
[   50.757866]  ? __pfx_irq_thread_fn+0x10/0x10
[   50.757871]  ? __pfx_irq_thread_dtor+0x10/0x10
[   50.757874]  ? __pfx_irq_thread+0x10/0x10
[   50.757877]  kthread+0xcf/0x100
[   50.757881]  ? __pfx_kthread+0x10/0x10
[   50.757883]  ret_from_fork+0x31/0x50
[   50.757888]  ? __pfx_kthread+0x10/0x10
[   50.757890]  ret_from_fork_asm+0x1a/0x30
[   50.757897]  </TASK>
[   50.757899] ---[ end trace 0000000000000000 ]---

#

I think this is the right one

twilit talon Dec 19, 2024, 11:42 AM

#

jesus

#

ok we uncovered the secret

carmine nacelle Dec 19, 2024, 11:42 AM

#

gpio

twilit talon Dec 19, 2024, 11:43 AM

#

yup

carmine nacelle Dec 19, 2024, 11:43 AM

#

@hexed acorn ?

twilit talon Dec 19, 2024, 11:43 AM

#

i guess qookie's stuff is also routed via GPIO

#

let me see which driver is responsible for it

carmine nacelle Dec 19, 2024, 11:44 AM

#

do you want full dmesg?

twilit talon Dec 19, 2024, 11:44 AM

#

and fucking bootlin is 503'ing me

twilit talon Dec 19, 2024, 11:44 AM

#

carmine nacelle do you want full dmesg?

nah its fine

#

im glad its not a uacpi skill issue

carmine nacelle Dec 19, 2024, 11:45 AM

#

/**
 * acpi_gpiochip_request_interrupts() - Register isr for gpio chip ACPI events
 * @chip:      GPIO chip
 *
 * ACPI5 platforms can use GPIO signaled ACPI events. These GPIO interrupts are
 * handled by ACPI event methods which need to be called from the GPIO
 * chip's interrupt handler. acpi_gpiochip_request_interrupts() finds out which
 * GPIO pins have ACPI event methods and assigns interrupt handlers that calls
 * the ACPI event methods for those pins.
 */

twilit talon Dec 19, 2024, 11:45 AM

#

which file is this

carmine nacelle Dec 19, 2024, 11:45 AM

#

drivers/gpio/gpiolib-acpi.c:523

#

How does gpio even work on PC?

twilit talon Dec 19, 2024, 11:46 AM

#

omg i completely missed it

#

because its in SSDT20

carmine nacelle Dec 19, 2024, 11:47 AM

#

so old windows would have no power button?

twilit talon Dec 19, 2024, 11:47 AM

#

yeah

#

well we can try

#

it might

#

if u disable windows 2015 & vista

carmine nacelle Dec 19, 2024, 11:47 AM

#

https://learn.microsoft.com/en-us/windows-hardware/drivers/bringup/general-purpose-i-o--gpio- ?

General-Purpose I/O (GPIO) - Windows drivers

System on a Chip (SoC) integrated circuits make extensive use of general-purpose I/O (GPIO) pins.

twilit talon Dec 19, 2024, 11:48 AM

#

📎 message.txt

#

this is the method

#

thats called by linux on your laptop

#

Notify (\_SB.PWRB, 0x80) // Status Change

#

Name (BUF0, ResourceTemplate ()
{
    GpioInt (Edge, ActiveHigh, ExclusiveAndWake, PullDefault, 0x1388,
        "\\_SB.GPIO", 0x00, ResourceConsumer, ,
        )
        {   // Pin list
            0x0000
        }
    GpioInt (Level, ActiveHigh, ExclusiveAndWake, PullNone, 0x0000,
        "\\_SB.GPIO", 0x00, ResourceConsumer, ,
        )
        {   // Pin list
            0x003D
        }
    GpioInt (Level, ActiveHigh, ExclusiveAndWake, PullNone, 0x0000,
        "\\_SB.GPIO", 0x00, ResourceConsumer, ,
        )
        {   // Pin list
            0x003E
        }
    GpioInt (Level, ActiveHigh, ExclusiveAndWake, PullNone, 0x0000,
        "\\_SB.GPIO", 0x00, ResourceConsumer, ,
        )
        {   // Pin list
            0x003A
        }
    GpioInt (Level, ActiveHigh, ExclusiveAndWake, PullNone, 0x0000,
        "\\_SB.GPIO", 0x00, ResourceConsumer, ,
        )
        {   // Pin list
            0x003B
        }
    GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone, 0x0000,
        "\\_SB.GPIO", 0x00, ResourceConsumer, ,
        )
        {   // Pin list
            0x0012
        }
})

#

and these are the possible event indices

carmine nacelle Dec 19, 2024, 11:49 AM

#

wait

twilit talon Dec 19, 2024, 11:49 AM

#

https://uefi.org/specs/ACPI/6.5/05_ACPI_Software_Programming_Model.html#gpio-signaled-acpi-events

carmine nacelle Dec 19, 2024, 11:49 AM

#

sb is south bridge?

twilit talon Dec 19, 2024, 11:49 AM

#

system bus

carmine nacelle Dec 19, 2024, 11:50 AM

#

On Hardware-reduced ACPI platforms
definetely my laptop

twilit talon Dec 19, 2024, 11:50 AM

#

yeah thats why i didnt even consider this option

#

because its a normal x86 laptop

carmine nacelle Dec 19, 2024, 11:50 AM

#

no, it's an x86 laptop with fucked firmware

twilit talon Dec 19, 2024, 11:51 AM

#

nah just very overcomplicated modern hw

carmine nacelle Dec 19, 2024, 11:51 AM

#

Ok I'm rebootig to windows

twilit talon Dec 19, 2024, 11:51 AM

#

Device (GPIO)
{
    Name (_HID, "AMDI0030")  // _HID: Hardware ID
    Name (_CID, "AMDI0030")  // _CID: Compatible ID
    Name (_UID, 0x00)  // _UID: Unique ID
    Method (_CRS, 0, NotSerialized)  // _CRS: Current Resource Settings
    {
        Name (RBUF, ResourceTemplate ()
        {
            Interrupt (ResourceConsumer, Level, ActiveLow, Shared, ,, )
            {
                0x00000007,
            }
            Memory32Fixed (ReadWrite,
                0xFED81500,         // Address Base
                0x00000400,         // Address Length
                )
        })
        Return (RBUF) /* \_SB_.GPIO._CRS.RBUF */
    }

    Method (_STA, 0, NotSerialized)  // _STA: Status
    {
        If ((TSOS >= 0x70))
        {
            Return (0x0F)
        }
        Else
        {
            Return (0x00)
        }
    }
}

You're gonna have to write a driver for this

#

its a controller at 0xFED81500 with IRQ 7

carmine nacelle Dec 19, 2024, 11:52 AM

#

Where do I look for documentation

#

LPT1 / Unreliable "spurious" interrupt (usually)

#

(from osdev wiki)

twilit talon Dec 19, 2024, 11:52 AM

#

its an amd gpio controller

#

so i guess google amd gpio controller specification

carmine nacelle Dec 19, 2024, 11:53 AM

#

oof https://www.amd.com/en/products/specifications/embedded.html

#

no that's not what I want

twilit talon Dec 19, 2024, 11:53 AM

#

yeah no

#

you will be the first with such a driver

#

drivers/pinctrl/pinctrl-amd.c @carmine nacelle

#

its a tiny driver

carmine nacelle Dec 19, 2024, 11:54 AM

#

qookie also has AMD

twilit talon Dec 19, 2024, 11:55 AM

#

yeah

#

i would see who calls acpi_gpiochip_request_interrupts but bootlin is fucking dead

#

maybe u dont even need a special driver for this specific gpio controller

#

id have to read the acpi spec to figure out how tf this is routed

twilit talon Dec 19, 2024, 12:01 PM

#

twilit talon ``` Device (GPIO) { Name (_HID, "AMDI0030") // _HID: Hardware ID Name (...

btw this only returns "present" if OS >= Windows 10

#

otherwise it says device doesnt exist

#

lol

carmine nacelle Dec 19, 2024, 12:02 PM

#

found the spec

📎 AMD_-_BIOS_and_Kernel_Developers_Guide_BKDG_for_AMD_Family_15h_Models_70h-7Fh_Processors_-_Rev_3.09_-_June_20th_2018_55072.pdf

#

Ok I'll try to implement it

twilit talon Dec 19, 2024, 12:04 PM

#

hmm u sure thats the one?

#

gpio/gpiolib.c#L2021

#

yeah idk its a whole gpio subsystem

#

no idea how any of this works

#

you will be a pioneer here

carmine nacelle Dec 19, 2024, 12:24 PM

#

How can I know which devices I have?

twilit talon Dec 19, 2024, 12:25 PM

#

call _HID and _CID methods of every device node

#

or uacpi_namespace_node_info

carmine nacelle Dec 19, 2024, 12:26 PM

#

twilit talon hmm u sure thats the one?

twilit talon Dec 19, 2024, 12:26 PM

#

no like

#

u sure the spec refers to this

#

for your driver u can just use uacpi_find_devices("AMDI0030", ...)

#

or find_devices_at which supports multiple hids

carmine nacelle Dec 19, 2024, 12:27 PM

#

https://lore.kernel.org/all/2142688.oNeEzK9Weu@debian64/T/

twilit talon Dec 19, 2024, 12:27 PM

#

oh cool

carmine nacelle Dec 19, 2024, 12:29 PM

#

carmine nacelle found the spec

This has to be it, it appeared in 2018 edition and wasn't in 2015

twilit talon Dec 19, 2024, 12:30 PM

#

yeah

carmine nacelle Dec 19, 2024, 12:32 PM

#

what's fch

#

Oh it's amd's chipset

#

according to chatgpt

#

#

Can WDT be used as another time source? ultrameme

#

Wait does amd have a separate PIC?

#

wtf is this

twilit talon Dec 19, 2024, 12:38 PM

#

carmine nacelle wtf is this

wake from suspend

#

2.17.16.1 Interrupt GPIO
All the configuration bits (Bit[x]) used in the following steps come from GPIOx[0F8:000:step4],
GPIOx[1FC:100:step4] and GPIOx[2DC:200:step4] if the pin is used as an interrupt:
1. The driver should program the DebounceTmrOut/DebounceTmrOutUnit/DebounceCntrl bits according to
the data passed by BIOS through ASL code.
2. Configure Bit[8], Bit[9] and Bit[10] (See GPIOx[0F8:000:step4]) according to the data passed by BIOS
through ASL code.
3. Set Bit[11] = 1 and Bit[12] = 1 (See GPIOx[0F8:000:step4]) to enable interrupt delivery and interrupt status then its interrupt status is at Bit[28] when the GPIO input is asserted.
4. Configure the GPIO controller interrupt, configure as an active low, level interrupt, reference Bit[10:8]
(See GPIOx[0F8:000:step4]).
5. The driver should clear the interrupt status Bit[28] (See GPIOx[0F8:000:step4]), then set GPIOxFC[EOI]
= 1 to deassert interrupt request after acknowledging the interrupt.

#

Basically u need this

#

parse the _AEI and configure thie respective pins

#

then when u get the interrupt for the respective pin call _EVT(pin_idx)

#

In your case these:

Method (_AEI, 0, NotSerialized)  // _AEI: ACPI Event Interrupts
{
    Name (BUF0, ResourceTemplate ()
    {
        GpioInt (Edge, ActiveHigh, ExclusiveAndWake, PullDefault, 0x1388,
            "\\_SB.GPIO", 0x00, ResourceConsumer, ,
            )
            {   // Pin list
                0x0000
            }
        GpioInt (Level, ActiveHigh, ExclusiveAndWake, PullNone, 0x0000,
            "\\_SB.GPIO", 0x00, ResourceConsumer, ,
            )
            {   // Pin list
                0x003D
            }
        GpioInt (Level, ActiveHigh, ExclusiveAndWake, PullNone, 0x0000,
            "\\_SB.GPIO", 0x00, ResourceConsumer, ,
            )
            {   // Pin list
                0x003E
            }
        GpioInt (Level, ActiveHigh, ExclusiveAndWake, PullNone, 0x0000,
            "\\_SB.GPIO", 0x00, ResourceConsumer, ,
            )
            {   // Pin list
                0x003A
            }
        GpioInt (Level, ActiveHigh, ExclusiveAndWake, PullNone, 0x0000,
            "\\_SB.GPIO", 0x00, ResourceConsumer, ,
            )
            {   // Pin list
                0x003B
            }
        GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone, 0x0000,
            "\\_SB.GPIO", 0x00, ResourceConsumer, ,
            )
            {   // Pin list
                0x0012
            }
    })
    M460 ("  OEM-ASL-\\_SB.GPIO._AEI\n", 0x00, 0x00, 0x00, 0x00, 0x00, 0x00)
    Return (BUF0) /* \_SB_.GPIO._AEI.BUF0 */
}

#

uacpi_for_each_device_resource(gpio, "_AEI", do_configure_pin)

#

this is your do_configure_pin: https://elixir.bootlin.com/linux/v6.12.5/source/drivers/gpio/gpiolib-acpi.c#L406

#

it even tells u 2. Configure Bit[8], Bit[9] and Bit[10] (See GPIOx[0F8:000:step4]) according to the data passed by BIOS through ASL code.

carmine nacelle Dec 19, 2024, 12:45 PM

#

so it's not even amd specific?

twilit talon Dec 19, 2024, 12:46 PM

#

twilit talon ``` 2.17.16.1 Interrupt GPIO All the configuration bits (Bit[x]) used in the fol...

This is from your spec

carmine nacelle Dec 19, 2024, 12:46 PM

#

twilit talon this is your `do_configure_pin`: https://elixir.bootlin.com/linux/v6.12.5/source...

this code

twilit talon Dec 19, 2024, 12:46 PM

#

carmine nacelle so it's not even amd specific?

Well this code then calls into the specific driver to configure irqs

#

But technically yes

carmine nacelle Dec 19, 2024, 12:54 PM

#

Thonk This is my b550 desktop

#

Cool, I think I have 3 PCs to test this on...

twilit talon Dec 19, 2024, 12:56 PM

#

anyway should be easy to do

twilit talon Dec 19, 2024, 12:56 PM

#

carmine nacelle Cool, I think I have 3 PCs to test this on...

nice

hexed acorn Dec 19, 2024, 1:34 PM

#

twilit talon i guess qookie's stuff is also routed via GPIO

looking at the asl i only see Notify(PWRB, 0x80) in _Q28 of the EC

twilit talon Dec 19, 2024, 1:37 PM

#

hexed acorn looking at the asl i only see `Notify(PWRB, 0x80)` in `_Q28` of the EC

look in ssdts

hexed acorn Dec 19, 2024, 1:37 PM

#

i decompiled it with iasl -e ssd* -d dsdt.dat

twilit talon Dec 19, 2024, 1:38 PM

#

do i have your dump?

hexed acorn Dec 19, 2024, 1:38 PM

#

you should

twilit talon Dec 19, 2024, 1:38 PM

#

hmm

#

can u resend it

carmine nacelle Dec 19, 2024, 1:38 PM

#

How do I extract this with uACPI?

Name (RBUF, ResourceTemplate ()
{
    Interrupt (ResourceConsumer, Level, ActiveLow, Shared, ,, )
    {
        0x00000007,
    }
    Memory32Fixed (ReadWrite,
        0xFED81500,         // Address Base
        0x00000400,         // Address Length
        )
})
Return (RBUF) /* \_SB_.GPIO._CRS.RBUF */```

twilit talon Dec 19, 2024, 1:39 PM

#

carmine nacelle How do I extract this with uACPI? ``` Name (RBUF, ResourceTemplate () { Inte...

uacpi_for_each_device_resouce

hexed acorn Dec 19, 2024, 1:39 PM

#

are there any sensitive tables other than the one with the windows key

twilit talon Dec 19, 2024, 1:39 PM

#

or uacpi_get_current_resources

carmine nacelle Dec 19, 2024, 1:39 PM

#

Yes, and then

twilit talon Dec 19, 2024, 1:39 PM

#

hexed acorn are there any sensitive tables other than the one with the windows key

nah

carmine nacelle Dec 19, 2024, 1:39 PM

#

Wait

twilit talon Dec 19, 2024, 1:39 PM

#

carmine nacelle Yes, and then

for_each_resource

carmine nacelle Dec 19, 2024, 1:39 PM

#

I have similar code in interrupts routing stuff

twilit talon Dec 19, 2024, 1:39 PM

#

yes

#

and EC

#

its all the same code, just different resource types

hexed acorn Dec 19, 2024, 1:39 PM

#

@twilit talon

📎 dump.tar.xz

twilit talon Dec 19, 2024, 1:40 PM

#

lets see

carmine nacelle Dec 19, 2024, 1:40 PM

#

Fun, my PCI routing code was leaking memory

twilit talon Dec 19, 2024, 1:41 PM

#

hexed acorn <@353593948523986945>

yup its there

#

exact same thing as his pc

#

ssdt15

#

Notify (\_SB.PWRB, 0x80)

#

and u have a GPIO device with AMDI0030

#

okay nice case closed

carmine nacelle Dec 19, 2024, 1:42 PM

#

I'm trying to write the driver

twilit talon Dec 19, 2024, 1:42 PM

#

would be nice to have this driver for managarm as well

#

if u manage to get it working ill try to steal your code

carmine nacelle Dec 19, 2024, 1:42 PM

#

Oh I'm dumb I didn't read the headers

carmine nacelle Dec 19, 2024, 1:42 PM

#

twilit talon if u manage to get it working ill try to steal your code

cool

hexed acorn Dec 19, 2024, 1:43 PM

#

hexed acorn i decompiled it with `iasl -e ssd* -d dsdt.dat`

huh why didn't this work then

twilit talon Dec 19, 2024, 1:43 PM

#

never used -e

hexed acorn Dec 19, 2024, 1:44 PM

#

iasl -da dsdt.dat ssdt* also doesn't work because it cries about stuff getting redefined

twilit talon Dec 19, 2024, 1:44 PM

#

GPIO driver for managarm when

#

i just do iasl *.dat

hexed acorn Dec 19, 2024, 1:45 PM

#

yeah but that yields multiple source files right

twilit talon Dec 19, 2024, 1:45 PM

#

yeah

hexed acorn Dec 19, 2024, 1:45 PM

#

i was thinking of decompiling it such that you get one combined source file

twilit talon Dec 19, 2024, 1:45 PM

#

hexed acorn `iasl -da dsdt.dat ssdt*` also doesn't work because it cries about stuff getting...

if u want the most careful disassembly u should be passing them in correct order

#

but it doesnt really matter

#

ssdt* will incorrectly sort ssdt1 ssdt10 etc

hexed acorn Dec 19, 2024, 1:47 PM

#

true

twilit talon Dec 19, 2024, 1:47 PM

#

your gpio has two memory regions for some reason

#

Memory32Fixed (ReadWrite,
    0xFED81500,         // Address Base
    0x00000400,         // Address Length
    )
Memory32Fixed (ReadWrite,
    0xFED81200,         // Address Base
    0x00000100,         // Address Length
    )
})

hexed acorn Dec 19, 2024, 1:48 PM

#

looks like iasl goes through arguments in reverse order as well :^)

twilit talon Dec 19, 2024, 1:48 PM

#

lmao

carmine nacelle Dec 19, 2024, 1:48 PM

#

Wtf is UACPI_POLARITY_ACTIVE_BOTH?

twilit talon Dec 19, 2024, 1:49 PM

#

Some resource types allow Both

#

i didnt invent these types lol

#

https://uefi.org/specs/ACPI/6.5/19_ASL_Reference.html#gpioint-gpio-interrupt-connection-resource-descriptor-macro

#

ActiveLevel can be one of ActiveHigh, ActiveLow or ActiveBoth. ActiveBoth can be specified only if EdgeLevel is Edge. The bit field name _POL is automatically created to refer to this portion of the resource descriptor.

carmine nacelle Dec 19, 2024, 1:50 PM

#

twilit talon i didnt invent these types lol

I know

carmine nacelle Dec 19, 2024, 1:50 PM

#

twilit talon ``` Memory32Fixed (ReadWrite, 0xFED81500, // Address Base 0x0000...

Wtf am I supposed to do with this

twilit talon Dec 19, 2024, 1:50 PM

#

use it?

carmine nacelle Dec 19, 2024, 1:50 PM

#

Mine has 1

twilit talon Dec 19, 2024, 1:50 PM

#

this is qookie's

#

you dont care about that

carmine nacelle Dec 19, 2024, 1:51 PM

#

Just the first one

twilit talon Dec 19, 2024, 1:51 PM

#

yeah

carmine nacelle Dec 19, 2024, 1:51 PM

#

twilit talon this is qookie's

I want to support both

twilit talon Dec 19, 2024, 1:51 PM

#

id look how linux deals with it

hexed acorn Dec 19, 2024, 1:51 PM

#

hexed acorn `iasl -da dsdt.dat ssdt*` also doesn't work because it cries about stuff getting...

btw how does acpica on linux actually load this if iasl can't decompile it because of the redefinitions

#

i do not see any redefinition errors in dmesg

carmine nacelle Dec 19, 2024, 1:51 PM

#

My friend has a ryzen laptop

#

and my sister

twilit talon Dec 19, 2024, 1:51 PM

#

hexed acorn btw how does acpica on linux actually load this if iasl can't decompile it becau...

it gets redfinitions because stubbed IO reading garbage

carmine nacelle Dec 19, 2024, 1:51 PM

#

Maybe I can convence them to dump their aml as well

hexed acorn Dec 19, 2024, 1:52 PM

#

twilit talon it gets redfinitions because stubbed IO reading garbage

oh god

twilit talon Dec 19, 2024, 1:52 PM

#

AML often has shit like

if (REG == 123) { Device (IDK) {} }

#

so some devices are only instantiated if some platform state says they exist etc

hexed acorn Dec 19, 2024, 1:53 PM

#

iasl option to accept a log of all mmio/pio to decompile correctly when

twilit talon Dec 19, 2024, 1:54 PM

#

could be nice

#

So strange like they route a lot of things via EC but then the fucking power button requires a separate driver lmao

hexed acorn Dec 19, 2024, 1:56 PM

#

ran out of pins on the ec :^)

twilit talon Dec 19, 2024, 1:56 PM

#

lmao

#

had to dump linux backtraces to figure out how the fuck it gets that button press LULW

#

apparently all modern AMD is this way

hexed acorn Dec 19, 2024, 1:57 PM

#

okay but this is gonna be kinda annoying to handle

#

i don't really want the gpio driver in the kernel

twilit talon Dec 19, 2024, 1:57 PM

#

we dont really need the full gpio driver tbh, could just have a stub that configures interrupts

#

but yeah

#

ideally its somehow configured via userspace

#

by listening to acpi devices on mbus

carmine nacelle Dec 19, 2024, 1:58 PM

#

GPIO is mmio registers

#

What do I do with 2 memory regions?

twilit talon Dec 19, 2024, 1:58 PM

#

its the mmio address?

hexed acorn Dec 19, 2024, 1:58 PM

#

twilit talon ideally its somehow configured via userspace

yeah i was thinking a new protocol that the gpio driver would provide over mbus

carmine nacelle Dec 19, 2024, 1:58 PM

#

twilit talon ``` Memory32Fixed (ReadWrite, 0xFED81500, // Address Base 0x0000...

I mean yes

hexed acorn Dec 19, 2024, 1:58 PM

#

and the kernel would just look for the gpio device ig

twilit talon Dec 19, 2024, 1:59 PM

#

yeah maybe

hexed acorn Dec 19, 2024, 2:00 PM

#

lunix seems to ignore the second mmio region?

twilit talon Dec 19, 2024, 2:00 PM

#

did u find the code for when it checks that?

#

i cant seem to find it

carmine nacelle Dec 19, 2024, 2:00 PM

#

What does windows say in device manager?

#

About memory

hexed acorn Dec 19, 2024, 2:00 PM

#

    gpio_dev->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
    if (IS_ERR(gpio_dev->base)) {
        dev_err(&pdev->dev, "Failed to get gpio io resource.\n");
        return PTR_ERR(gpio_dev->base);
    }

#

i assume the 0 means 0-th resource

carmine nacelle Dec 19, 2024, 2:01 PM

#

Like mine is this

#

What's on my desktop though? Thonk

hexed acorn Dec 19, 2024, 2:01 PM

#

carmine nacelle What does windows say in device manager?

i could reboot into windows to see ig

#

i do still have the win10 install around

twilit talon Dec 19, 2024, 2:01 PM

#

well windows displaying that resource type doesnt mean it uses it for anything

hexed acorn Dec 19, 2024, 2:01 PM

#

that's also true

twilit talon Dec 19, 2024, 2:02 PM

#

it reserves it to prevent conflicts

twilit talon Dec 19, 2024, 2:03 PM

#

hexed acorn i assume the 0 means 0-th resource

yeah its the index

#

resource 0 is irq tho

carmine nacelle Dec 19, 2024, 2:03 PM

#

What does it mean per ACPI spec?

hexed acorn Dec 19, 2024, 2:04 PM

#

considering ioremap maybe it means first mem/port resource?

carmine nacelle Dec 19, 2024, 2:04 PM

#

Like if the device has 2 memory ranges

#

(I'm kinda talking to myself)

twilit talon Dec 19, 2024, 2:04 PM

#

these resource lists are not regulated by the spec

#

its device specific

twilit talon Dec 19, 2024, 2:04 PM

#

hexed acorn considering ioremap maybe it means first mem/port resource?

perhaps

#

i will check if bootlin loads

carmine nacelle Dec 19, 2024, 2:04 PM

#

So just throw my hands in the air and ignore it?

twilit talon Dec 19, 2024, 2:05 PM

#

carmine nacelle Like if the device has 2 memory ranges

e.g. your _SB will declare all resources used by the motherboard, which can be a hundred IO and memory ranges

#

doesnt mean you have to do anything about it

twilit talon Dec 19, 2024, 2:05 PM

#

carmine nacelle So just throw my hands in the air and ignore it?

ideally u register it as a used memory range to prevent range conflicts

carmine nacelle Dec 19, 2024, 2:05 PM

#

But what if some hardware swaps the order around

twilit talon Dec 19, 2024, 2:05 PM

#

its always the same for each device type

carmine nacelle Dec 19, 2024, 2:05 PM

#

twilit talon ideally u register it as a used memory range to prevent range conflicts

I don't have bar stuff

twilit talon Dec 19, 2024, 2:05 PM

#

so in your case u ignore it yes

carmine nacelle Dec 19, 2024, 2:05 PM

#

So doesn't matter for now I guess...

vale hazel Dec 19, 2024, 2:06 PM

#

twilit talon so in your case u ignore it yes

infy where can i learn to write aml and have something execute it

#

i wanna mess around with aml

#

language seems cool

#

af

twilit talon Dec 19, 2024, 2:07 PM

#

i mean idk look at examples

#

its pretty easy

#

U have methods, they have Local variables, and Args

#

Its like python

vale hazel Dec 19, 2024, 2:07 PM

#

ah kk

#

what about getting something to execute it tho

twilit talon Dec 19, 2024, 2:08 PM

#

u can have the uacpi test runner to execute it

vale hazel Dec 19, 2024, 2:08 PM

#

alr

carmine nacelle Dec 19, 2024, 2:08 PM

#

Btw @twilit talon does uacpi have macros for uacpi_resource_fixed_memory32::write_status bits?

twilit talon Dec 19, 2024, 2:08 PM

#

yes

vale hazel Dec 19, 2024, 2:08 PM

#

when online uacpi aml interpreter

#

meme

twilit talon Dec 19, 2024, 2:09 PM

#

carmine nacelle Btw <@353593948523986945> does uacpi have macros for uacpi_resource_fixed_memory...

// write_status
#define UACPI_NON_WRITABLE 0
#define UACPI_WRITABLE 1

twilit talon Dec 19, 2024, 2:09 PM

#

vale hazel when online uacpi aml interpreter

go for it meme

hexed acorn Dec 19, 2024, 2:09 PM

#

twilit talon perhaps

seems to be the case because the code just below does platform_get_irq with an index of 0 as well

twilit talon Dec 19, 2024, 2:10 PM

#

lets see...

hexed acorn Dec 19, 2024, 2:11 PM

#

void __iomem *
devm_platform_get_and_ioremap_resource(struct platform_device *pdev,
                unsigned int index, struct resource **res)
{
    struct resource *r;

    r = platform_get_resource(pdev, IORESOURCE_MEM, index);
    if (res)
        *res = r;
    return devm_ioremap_resource(&pdev->dev, r);
}```

twilit talon Dec 19, 2024, 2:11 PM

#

hexed acorn seems to be the case because the code just below does `platform_get_irq` with an...

platform_get_resource(pdev, IORESOURCE_MEM, index);

#

yeah ur right

#

so even the order doesnt matter

carmine nacelle Dec 19, 2024, 2:11 PM

#

twilit talon ``` // write_status #define UACPI_NON_WRITABLE 0 #define UACPI_WRITABLE 1 ```

Should I use this as bitmask?

#

Or does it only take these values

twilit talon Dec 19, 2024, 2:12 PM

#

only those

carmine nacelle Dec 19, 2024, 2:12 PM

#

I mean realistically I can assert it

hexed acorn Dec 19, 2024, 2:12 PM

#

now i want to know what the second entry is referring to, but i can't seem to find chipset docs, and ig i won't find out from linux

carmine nacelle Dec 19, 2024, 2:12 PM

#

Wth would write only resource be doing there

twilit talon Dec 19, 2024, 2:12 PM

#

static const struct uacpi_resource_convert_instruction convert_memory32[] = {
    OP(BIT_FIELD_1, AML_F(memory32, information),
                    NATIVE_F(memory32, write_status), IMM(0)),
    OP(FIELD_32, AML_F(memory32, minimum), NATIVE_F(memory32, minimum), IMM(4)),
    END(),
};

#

its very simple

#

just that bit

#

the rest is zeroed

hexed acorn Dec 19, 2024, 2:12 PM

#

hexed acorn now i want to know what the second entry is referring to, but i can't seem to fi...

wonder if the windows driver has the answer

carmine nacelle Dec 19, 2024, 2:13 PM

#

carmine nacelle found the spec

@hexed acorn

twilit talon Dec 19, 2024, 2:13 PM

#

hexed acorn wonder if the windows driver has the answer

yeah probably

carmine nacelle Dec 19, 2024, 2:13 PM

#

Everything is open source if you have IDA?

hexed acorn Dec 19, 2024, 2:15 PM

#

carmine nacelle <@183510341894930432>

hm not exactly my platform (fam17h model 60h) but the first memory resource points to gpio bank 0, and the second into the reserved space

twilit talon Dec 19, 2024, 2:15 PM

#

hexed acorn hm not exactly my platform (fam17h model 60h) but the first memory resource poin...

how do u know?

hexed acorn Dec 19, 2024, 2:16 PM

#

twilit talon Dec 19, 2024, 2:16 PM

#

which spec is this?

carmine nacelle Dec 19, 2024, 2:16 PM

#

hexed acorn hm not exactly my platform (fam17h model 60h) but the first memory resource poin...

My platform is also different but that's all I could find

hexed acorn Dec 19, 2024, 2:16 PM

#

the one mishakov linked

twilit talon Dec 19, 2024, 2:16 PM

#

ah

#

i guess yours is more modern so u have other crap there

hexed acorn Dec 19, 2024, 2:17 PM

#

i guess

#

but i really want to know what it is

carmine nacelle Dec 19, 2024, 2:17 PM

#

Mine is Zen 4

twilit talon Dec 19, 2024, 2:17 PM

#

time to find your platforms spec

carmine nacelle Dec 19, 2024, 2:17 PM

#

Like last year's

#

And it doesn't have that

hexed acorn Dec 19, 2024, 2:17 PM

#

maybe it's a register containing the seed for a bitcoin wallet with 10mil in it

carmine nacelle Dec 19, 2024, 2:17 PM

#

best place to hide that

twilit talon Dec 19, 2024, 2:17 PM

#

hexed acorn maybe it's a register containing the seed for a bitcoin wallet with 10mil in it

its 256 bytes

hexed acorn Dec 19, 2024, 2:18 PM

#

the seed is a bunch of words from a predetermined dictionary

twilit talon Dec 19, 2024, 2:18 PM

#

if there are docs for his platform only from last year surely u can find docs for yours

hexed acorn Dec 19, 2024, 2:20 PM

#

twilit talon if there are docs for his platform only from last year surely u can find docs fo...

looks like they haven't even published ones for zen 1

#

family 15h is pre-zen

twilit talon Dec 19, 2024, 2:21 PM

#

ah damn

hexed acorn Dec 19, 2024, 2:22 PM

#

if the 2 reddit posts on r/amd with a combined 11 comments hasn't pushed them to do so, i don't know what will

twilit talon Dec 19, 2024, 2:22 PM

#

well linux does work on your pc right

hexed acorn Dec 19, 2024, 2:22 PM

#

yeah

twilit talon Dec 19, 2024, 2:22 PM

#

so nothing of importance probably

hexed acorn Dec 19, 2024, 2:22 PM

#

i mean yeah that much i figured, it's just sheer curiosity at this point

twilit talon Dec 19, 2024, 2:23 PM

#

ida time

#

are you going to try to implement this for managarm btw?

hexed acorn Dec 19, 2024, 2:23 PM

#

could certainly try later yeah

#

i'll need gpio for my touchpad later anyway

twilit talon Dec 19, 2024, 2:24 PM

#

should be basically walk over the pins, configure them according to what aml wants, then call _EVT on irq if pin status is set

hexed acorn Dec 19, 2024, 2:24 PM

#

in addition to i2c

twilit talon Dec 19, 2024, 2:24 PM

#

yeah

vale hazel Dec 19, 2024, 2:26 PM

#

hexed acorn

always wondered what a smbus is

hexed acorn Dec 19, 2024, 2:26 PM

#

twilit talon ida time

lets see, i spy ```
/mnt/Windows/System32/drivers/amdgpio2.sys

twilit talon Dec 19, 2024, 2:26 PM

#

vale hazel always wondered what a smbus is

i2c controller

twilit talon Dec 19, 2024, 2:26 PM

#

hexed acorn lets see, i spy ``` /mnt/Windows/System32/drivers/amdgpio2.sys ```

nice

vale hazel Dec 19, 2024, 2:26 PM

#

twilit talon i2c controller

oh fair

hexed acorn Dec 19, 2024, 2:29 PM

#

god bless they have debug prints

twilit talon Dec 19, 2024, 2:29 PM

#

lol

hexed acorn Dec 19, 2024, 2:32 PM

#

hmm ghidra's output looks pretty fugly

carmine nacelle Dec 19, 2024, 2:49 PM

#

twilit talon In your case these: ``` Method (_AEI, 0, NotSerialized) // _AEI: ACPI Event Int...

Which type of resource is that?

hexed acorn Dec 19, 2024, 2:51 PM

#

hmmm i think amdgpio2.sys also only looks at the first memory resource

carmine nacelle Dec 19, 2024, 2:51 PM

#

I kinda have everything but this

carmine nacelle Dec 19, 2024, 2:51 PM

#

carmine nacelle Which type of resource is that?

in uacpi

#

Like I could have this driver by the end of today

hexed acorn Dec 19, 2024, 2:52 PM

#

i see a loop in which it goes through all resources (?), calls MmMapIoSpace for one type, saves another for later (and complains that no proper irq resource was found if that's missing)

twilit talon Dec 19, 2024, 2:56 PM

#

hexed acorn i see a loop in which it goes through all resources (?), calls `MmMapIoSpace` fo...

Nice

twilit talon Dec 19, 2024, 2:56 PM

#

carmine nacelle Which type of resource is that?

Fixed memory 32

hexed acorn Dec 19, 2024, 2:56 PM

#

unfortunately there's a virtual function call that i can't figure out what it is (i'm guessing it's a vtable provided by windows?)

twilit talon Dec 19, 2024, 2:56 PM

#

carmine nacelle Which type of resource is that?

Oh these

#

I dont remember, look at the enum

twilit talon Dec 19, 2024, 2:57 PM

#

hexed acorn unfortunately there's a virtual function call that i can't figure out what it is...

Is it not set by the driver?

hexed acorn Dec 19, 2024, 3:00 PM

#

if it is, i can't see where it's being set

twilit talon Dec 19, 2024, 3:01 PM

#

Hmm

carmine nacelle Dec 19, 2024, 3:04 PM

#

oh it's gpio connector...

twilit talon Dec 19, 2024, 3:08 PM

#

I can check later if you cant figure it out

hexed acorn Dec 19, 2024, 3:22 PM

#

please

#

twilit talon Dec 19, 2024, 3:24 PM

#

lol

twilit talon Dec 19, 2024, 3:25 PM

#

carmine nacelle oh it's gpio connector...

its gpio connection, yes

#

it has 3 sub-types

#

or 2 rather

#

#define UACPI_GPIO_CONNECTION_INTERRUPT 0x00
#define UACPI_GPIO_CONNECTION_IO 0x01

hexed acorn Dec 19, 2024, 3:32 PM

#

hexed acorn

okay whatever, either ghidra is trolling or i'm dumb

#

but i think it also just looks at the first memory resource

twilit talon Dec 19, 2024, 3:32 PM

#

so it ignores the second one?

hexed acorn Dec 19, 2024, 3:32 PM

#

i think so

twilit talon Dec 19, 2024, 3:32 PM

#

lol

#

is your driver also possibly too old

hexed acorn Dec 19, 2024, 3:33 PM

#

well i last booted into the install a few months ago

#

but the resources for the gpio controllers haven't changed since i got the laptop

#

(even after a bios update)

twilit talon Dec 19, 2024, 3:34 PM

#

no i mean like

#

perhaps the new driver ships with like early access windows 11

#

and yours is the stable old version

hexed acorn Dec 19, 2024, 3:34 PM

#

ah

#

hmm there is this condition in the loop ```
else if ( *(_BYTE )v15 == 3 && (((_DWORD *)(v15 + 12) - 768) & 0xFFFFFEFF) == 0 )

#

byte at v15 is the type (checks for 2 for the irq resource), v15 + 4 is the address, so what's at v15 + 12

#

hmm is it size

#

4 + 8 = 12

#

ohhhh

#

this is size == 0x400?

#

so it explicitly ignores the smaller memory resource

twilit talon Dec 19, 2024, 3:37 PM

#

ah

#

is it shown under resource manager?

#

like in windows

hexed acorn Dec 19, 2024, 3:38 PM

#

i could quickly reboot and check ig

twilit talon Dec 19, 2024, 3:38 PM

#

although that might be handled by a different subsystem

#

aka the driver doesnt decide

#

all _CRS stuff is unconditionally stored there

hexed acorn Dec 19, 2024, 3:40 PM

#

the fact that the driver has an explicit size check makes this even weirder

twilit talon Dec 19, 2024, 3:40 PM

#

just sanity checking maybe

hexed acorn Dec 19, 2024, 3:46 PM

#

windows shows both memory resources in device manager

#

and also, apparently next to all the other amd system devices, there's AMD Crash Defender

twilit talon Dec 19, 2024, 3:58 PM

#

lol

#

wtf is that

carmine nacelle Dec 19, 2024, 4:21 PM

#

ok I'm back

carmine nacelle Dec 19, 2024, 4:23 PM

#

twilit talon this is your `do_configure_pin`: https://elixir.bootlin.com/linux/v6.12.5/source...

I think bootlin is completely dead lol

twilit talon Dec 19, 2024, 4:23 PM

#

it works if u refresh enough

carmine nacelle Dec 19, 2024, 4:39 PM

#

twilit talon In your case these: ``` Method (_AEI, 0, NotSerialized) // _AEI: ACPI Event Int...

What would be pin list?

#

in uacpi_resource_gpio_connection

#

source??

twilit talon Dec 19, 2024, 4:40 PM

#

carmine nacelle What would be pin list?

u mean pin_table?

carmine nacelle Dec 19, 2024, 4:41 PM

#

// Pin list

twilit talon Dec 19, 2024, 4:41 PM

#

pin_table

carmine nacelle Dec 19, 2024, 4:41 PM

#

Yeah

#

I'm dumb

twilit talon Dec 19, 2024, 4:42 PM

#

lol

carmine nacelle Dec 19, 2024, 4:43 PM

#

huh

#

mircosoft trying to make people buy new PCs?

#

Ok, time for hardcore printf'ing

twilit talon Dec 19, 2024, 4:52 PM

#

carmine nacelle huh

thats for when u have multiple possible configuration

#

it tells u which ones are good which ones are not

carmine nacelle Dec 19, 2024, 4:54 PM

#

Idk if I'm being flat-brained, but it's not finding gpio

twilit talon Dec 19, 2024, 4:55 PM

#

show code

carmine nacelle Dec 19, 2024, 5:00 PM

#

Passing Windows 2015 doesn't show it

twilit talon Dec 19, 2024, 5:00 PM

#

show code x2

#

if u disable windows 2015 its not shown yes

#

u have to pretend to be > windows 10

carmine nacelle Dec 19, 2024, 5:06 PM

#

Brut it's passing extended irq resource

#

instead of normal irq

twilit talon Dec 19, 2024, 5:08 PM

#

looks like it

carmine nacelle Dec 19, 2024, 5:09 PM

#

I'm extra flat brained

#

I've been editing pci code instead of gpio for some reason

twilit talon Dec 19, 2024, 5:09 PM

#

lmao

carmine nacelle Dec 19, 2024, 5:15 PM

#

carmine nacelle How do I extract this with uACPI? ``` Name (RBUF, ResourceTemplate () { Inte...

Btw, my AML is passing 3 resources...

#

1, 12, 29

twilit talon Dec 19, 2024, 5:15 PM

#

29 is the end tag

#

every resource list has one

carmine nacelle Dec 19, 2024, 5:17 PM

#

Oh

#

I didn't know that

#

cool

#

Ok, I need to figure out how to get interrupts out of this thing

#

(as in which register am I supposed to be reading)

#

Linux is doing some weirdness

#

Wait what am I seeing

#pmOS - microkernel OS for RISC-V, x86, and LoongArch