You must allow lower priority threads to run while you wait for the mutex or you can deadlock
#Nyaux
thorny glen
You can do adaptive spinning where if the owner is running on another processor you spin wait for a little bit for the mutex to be released
And if not then you block
flat nymph
yeah, but spinlocks should ideally also have mechanisms to prevent that if that kind of thing can happen
thorny glen
Yes, it's called "threads don't own spinlocks, cpus do"
Generally you block preemption (if not disable interrupts entirely) while waiting for a spinlock or holding one
finite summit
^
flat nymph
in kernel
surreal path
meow
thorny glen
Spinlocks are double bad in userspace
thorny glen
You can do adaptive spinning where if the owner is running on another processor ...
Just do this
flat nymph
but they are still useful as a simple synchronization mechanism
thorny glen
For guarding stuff you cannot guard with a blocking mutex yeah
Like the scheduler itself
Or locks that have to be taken by ISRs
Otherwise they r bad
flat nymph
but for small things, spinlocks could probably still be faster
you yield if you can't take it and there's less cost than blocking/unblocking threads
thorny glen
but for small things, spinlocks could probably still be faster
Under contention a blocking mutex with adaptive spinning is basically always better
And when not contended you can make it just as fast as grabbing a spinlock
silver yarrow
I dont understand the diff between blocking and yielding
flat nymph
blocking is not letting task run untill someone explicitly unblocks it
silver yarrow
so like a waitlist
surreal path
meowmeowmeow
flat nymph
woof
surreal path
😡
flat nymph
flat nymph
Under contention a blocking mutex with adaptive spinning is basically always bet...
Ok, I've changed my opinion
(I'm a bit biased because my pthread_mutex_unlock() can fail with ENOMEM )
plush hearth
I remember the pain I went through with only 8GB of RAM on my laptop
flat nymph
what is does meowing mean?
flat nymph
I remember the pain I went through with only 8GB of RAM on my laptop
My first laptop had 512MB of RAM
flat nymph
im feeling the effects of 8gb of ram
So just don't use vscode and you'll be set
plush hearth
My first laptop had 512MB of RAM
how long ago was that?
plush hearth
At that time, I would have been an infant or maybe not even born yet
silver yarrow
vscode only uses like 500mb for me
actually that was one electron process
so that might be a lie
desert haven
laughs in 14M used by vim
finite summit
I use Kate
silver yarrow
I used to use neovim, and others
finite summit
(if you don't know what that is, it's the KDE fancy text editor)
silver yarrow
vscode has just worked for me
flat nymph
If you have ram for electron
flat nymph
(tbh I also just use vscode and haven't bothered setting up anything else)
plush hearth
I use vscode since I can't be bothered setting clion up for this project (frostyos, not what this thread is for) or trying to setup neovim
flat nymph
shut up and let me watch squid game
iPhones have a little switch on their side which mutes the notifications
(only good thing about them)
silver yarrow
(tbh I also just use vscode and haven't bothered setting up anything else)
I spent 60% of my time using neovim configuring it
skill issue on my part
surreal path
okay guys
when i reach the end of squid game thread blocking 😎
in nyaux soon
while watching squid game i was thinking of how my threadblocking function would look like
void ThreadBlock(struct thread_t *towhichqueue); // will block the current thread (remove it from the run queue, throw it into the parameter queue and scheduler yield)
void ThreadReady(struct thread_t *thread); // will ready whatever thread it got in its parameter
i think this is a good way of doign that
also my alt key
thorny glen
i see a problem
surreal path
is broken
surreal path
i see a problem
whats up
surreal path
u should tell me
thorny glen
the comment
"block the current thread (remove it from the run queue"
if its the current thread then surely its already running
and not on the run queue
surreal path
oh
ill explain this
in my scheduler design i have 2 pointers
current thread and run queue
run queue keeps a list of ready threads and whatever the current thread selects it changes its state to running
it stays in the run queue however
thats how my scheduler works
so actually the comment is correct will
thorny glen
thats slightly odd
thorny glen
obos is the paragon of design
surreal path
real
thorny glen
i think the main issue with doing that is, one you dont get the natural like fifo properties of popping threads from the head of a queue and then pushing them to the tail later
two it makes fine grained locking a bit harder
surreal path
i think the main issue with doing that is, one you dont get the natural like fif...
then maybe ill change it
to be fair
anyways ima watch squid game
😎
or well
continue to watch the episode
finite summit
obos is the paragon of design
thanks
finite summit
but i believe obos does the same
no it doesn't
surreal path
oh ok
finite summit
lol
finite summit
oh ok
what obos does is has a function to take a thread of the runqueue it is on ("block" it), and a function to put it back on a runqueue
then a layer of abstraction above that in the form of struct waitable_header, which allows for threads to wait on objects, and for threads to be signalled by other threads, if they have that object
if that makes sense
flat nymph
but i believe obos does the same
pmOS does it 
surreal path
last episode everyone
thorn bramble
last episode everyone
its shit
surreal path
wow
that was the ending
crazy
that was actually so ass
anyways
thread blocking time
and mutexes for nyaux
surreal path
tf
crazy things happening in ze scheduler lol
these functions should work wtf
sorry just realized
im stupid
no nvm
oop
surreal path
i think the main issue with doing that is, one you dont get the natural like fif...
im not gonna do this
cause im struggling hard trying to get the queueing to work
its just easier :)
bro
rigid fable
im not gonna do this
hi
surreal path
hey
surreal path
time to learn more
nvm ill js do a single circular linked list
no point in having a double linked list
nvm
fine
ill do a double circular linked list
rigid fable
time to learn more
what is this
surreal path
idfk
rigid fable
then why you leraning this
rigid fable
you got new pc or laptop ???
rigid fable
yay you fixed it
rigid fable
no i didnt fix it
then idk
surreal path
WHY CANT I GET CIRCULAR DOUBLELY LINKED LISTS RIGHT
UGH
whatever forget about it
no nvm
ill make a userspace program later
to get circular doublely linked lists right
for now im going to just take a break cause im rlly frustrated
plush hearth
what do you need a circular linked list for?
steady flume
meow :3
errant mantle
WHY CANT I GET CIRCULAR DOUBLELY LINKED LISTS RIGHT
Why dont you use linux's list.h (struct list_head)?
Its so nice to use
haughty kite
or the bsd ones?
spice yarrow
Why dont you use linux's list.h (struct list_head)?
It's gpl2
spice yarrow
Yeah, but the Linux one is gpl, that's what I was talking about
haughty kite
yes
broken depot
I have an MIT one if you want very permissive
surreal path
my bad been having a bad sleep schedule
slept til like
10pm
💀
just woke up
@kind root @finite summit whats yall opinion on this ass sleep schedule
i need to fix it
i dont know how
surreal path
I have an MIT one if you want very permissive
im good
i just need to write a userspace program, test it a bunch, put it into the kernel
like a good programmer would
even in userspace im screwing this up
💀
okokok i got it
time to impl this into kernel space
figured it out using cool double pointer
seems like it works
why is bro stuck now
funny
got it working :)
works with smp too
thread blocking time ig
surreal path
```C
void ThreadBlock(struct thread_t *towhichqueue); // will block the current ...
will i sched yield on threadready
or no
well i have the functions anyway
its time to impl a kernel mutex thing
flat nymph
I wonder if you can pass some sort of callback to the unblocking thread 
flat nymph
why
surreal path
more work
flat nymph
2 instructions
finite summit
I wonder if you can pass some sort of callback to the unblocking thread <:Thonk:...
Why
The hell would you do that
flat nymph
so when the thread is dying or something it can do work in the context of new thread
finite summit
Whatever happened to naming conventions
flat nymph
so like to free stack or something
kind root
<@353593948523986945> <@841762704766140486> whats yall opinion on this ass sleep...
nyaux is back thats all that matters
surreal path
nyaux is back thats all that matters
yesss
surreal path
damn feel like shit again
cinder plinth
time to learn more
lmfao 18 videos on that
They're short tho
I'd have done a single big video
tender gorge
damn feel like shit again
huuuuuuuuuuggggggg
surreal path
You're nyauxmaster
bru
hollow goblet
surreal path
lol
todo list for today:
impl blocking threads and kmutex
see how i can impl schedule work and wait for work completion
then we are done
is the bool acquired used for checking if it was acquired?
flat nymph
yes
idk if it's the best impl
(like it's not)
*i'm probably not the best person to be asking things about concurrency
but it should work
surreal path
who can i ask about concurrency
flat nymph
idk
surreal path
who can i ask about concurrency
@finite summit
molten grotto
what do you want to ask
surreal path
is the bool acquired used for checking if it was acquired?
like that impl is it bad?
for a kernel mutex
molten grotto
I don't think
flat nymph
it's ok but probably there are better implementations, which you probably don't really need
I've never written a futex so I might get it wrong
if you listen to me*
surreal path
I don't think
whats the better impl then
flat nymph
that's probably masters in computer engineering level of knowledge lol
molten grotto
whats the better impl then
what I meant is that its likely going to work just fine, its basically the same that I use except I have an event in place of the thread list + spinlock
surreal path
what I meant is that its likely going to work just fine, its basically the same ...
dont know what an event is but okay
molten grotto
semaphore
molten grotto
a thing that you can signal and wait until someone signals it
flat nymph
mutex is theoretically just a binary semaphore
surreal path
mutex is theoretically just a binary semaphore
fair
molten grotto
actually yeah, idk why did I do my mutex like this on top of the semaphore 
flat nymph
having semaphores allows you to implement other forms of concurrency I think
surreal path
well ima go impl my kmutex
and yeye
also
anyone got a better vscode theme
i really hate the one i have now
flat nymph
white theme
surreal path
flat nymph
So I think you lock the lock, do compare exchange on the address given by the user, if it succeeds you block the thread
molten grotto
the bool
molten grotto
one is to protect the waiter list
flat nymph
Wait, we're talking about kernel
surreal path
yea
flat nymph
not futex
surreal path
yea
flat nymph
ignore what I said
half-ignore
You take the mutex::lock, check if lock is acquired. If it isn't, you set it to true. If it is, you block the thread and push it to the list of waiters. Unblock the lock
You've said you've implemented circular lists, right?
surreal path
yea
surreal path
You take the mutex::lock, check if lock is acquired. If it isn't, you set it to ...
all atomic operations?
flat nymph
No
surreal path
oh
flat nymph
Only mutex::lock
You can remove the lock and do it with atomics
But that's more complicated
flat nymph
Yes
void take_lock(struct mutex *him) {
spinlock_lock(&him->lock);
if (!ackquired) {
acquired = true;
spinlock_unlock(&him->lock);
} else {
// Push yourself to list of blocked threads
spinlock_unlock(&him->lock);
// Switch to some other thread
}
// Lock is taken
}```Something like that
flat nymph
Yeah
surreal path
fair
surreal path
which one in the span on the last 30 days?
portuguese girl
shes very pretty :3
i love her
thorn bramble
bold thing to say as a 13 year old
thorn bramble
fake news
flat nymph
let him have fun before the adult life hits
surreal path
my birthdays in 2 months actually
@flat nymph what about releasing the lock, what exactly do u do
wake up the blocked threads?
coral dove
my birthdays in 2 months actually
i got 3 months until adulthood too imma kms
surreal path
If it isn't unlock the thread of the front
only at the front?
what about the other blocked threads
surreal path
why
surreal path
oh
flat nymph
```C
void take_lock(struct mutex *him) {
spinlock_lock(&him->lock);
if (...
You can probably change it and do while (1) here
or goto memes since it's c
flat nymph
it's up to you
surreal path
its fine
surreal path
nahh its fineeeeeeeeeeeee
flat nymph
you sched_yield in locks in userspace
surreal path
for futex yea
surreal path
kk
finite summit
"reaper(): thread killed"
surreal path
yea thats normal
finite summit
it's killing random threads?
finite summit
maybe your release function is broken?
finite summit
mutex
looks inside
spinlock
surreal path
threadready doesnt yield
finite summit
surreal path
<:trl:829316641191886888>
finite summit
threadready doesnt yield
but you should be yielding at one point, no?
have you tried: gdb
finite summit
bruh
surreal path
it hurts my stomach
finite summit
oh
surreal path
i do
finite summit
that's not how reference counting works
surreal path
what
thorn bramble
and thats not how reaping threads work
finite summit
if (!(--obj->refcount))
free(obj);```i do refcount_inc on create_kthread()
and refcount_dec on exit_thread()
finite summit
ok
surreal path
whats wrong with that
finite summit
then in refcount_dec
finite summit
```c
if (!(--obj->refcount))
free(obj);```
you would do this in refcount_dec
finite summit
wrong.
struct thread
{
//shit
atomic_size_t refcount;
};
void ref_thread(struct thread* obj)
{
obj->refcount++;
}
void unref_thread(struct thread* obj)
{
if (!(--obj->refcount))
free(obj);
}```so im supposed to free the thread in the unref thread thing?
atomic_size_t
i dont have that
like huhh
wicked loom
in any case the bsd0 freestanding headers that the template pulls by default does not have it
finite summit
either way, you can do _Atomic(size_t)
surreal path
and where can i import _Atomic
wicked loom
it's a keyword
kind root
your free() can queue the thread for reaping
finite summit
infy stop giving him bad ideas
surreal path
kind root
thread reaper thread is a good idea
finite summit
unless you mean free just schedules a DPC to actually free the thread at a lower priority
finite summit
I disagree
imo, memory is ideally released as soon as possible, unless you cannot because your IRQL/IPL/whatever is too high
finite summit
finite summit
cant til 1:10am
are you being detained?
surreal path
no its just my ed
finite summit
ed?
surreal path
eating disorder
kind root
imo, memory is ideally released as soon as possible, unless you cannot because y...
releasing various resources of a giant process can take a lot of time
and you're stealing that time without an upper bound
finite summit
then in that case, that kinda just falls into "unless you cannot because IRQL is too high"
then you can schedule a DPC to free everything
surreal path
anyways i dont think i can think anymore without food, so ima watch something til i can eat
then we can get back to work
im even struggling to type lol
finite summit
eating disorder
if you don't mind me asking, why 1:10am specifically, doctor said so or...
surreal path
if you don't mind me asking, why 1:10am specifically, doctor said so or...
because i eat every 16 hours
i eat 10:10am so
8 hours behind is 1:10am
or
2:10am
but because im feeling extra hungry today im allowing myself to eat 1:10am
cinder plinth
then in that case, that kinda just falls into "unless you cannot because IRQL is...
why would IPL be too high?
this is in a thread context
finite summit
I mean you'd probably be at dispatch level
finite summit
my exit_thread raises IRQL to dispatch
cinder plinth
your skill issue does not apply to general cases
finite summit
Once you remove a thread from a runqueue, it won't get run until it's back on a runqueue.
exit_thread removes the current thread from the runqueue
that's why I run mine at dispatch
cinder plinth
yes you can take a lock
for like
removing the thread from the list?
that's the only point where you'd have high irql that I can think of
and thats like
a few operations
finite summit
good point
cinder plinth
so I don't see what your point is
or why that would affect having a reaper thread
because a reaper thread would basically mean taking another lock (reaper queue) for a short time to add the thread to that list
instead of freeing everything directly in exit() which would incur latency
if anything you may want freeing to be a high irql operation
so doing it there would just add more latency
flat nymph
Why have a reaper thread though if you can just push zombie to ready queue?
cinder plinth
you mean doing the freeing when the scheduler encounters a zombie thread?
flat nymph
yes (?)
surreal path
im starting to feel really sick
like dizzy
is this a bad sign
i checked my weight and im starting to lose a ton of weight again
just 2 hours chat
gotta stay strong
cinder plinth
but because im feeling extra hungry today im allowing myself to eat 1:10am
what stops you from eating
surreal path
eating disorder
cinder plinth
that does not answer my question
cinder plinth
ok so you complain about feeling dizzy but you dont eat on purpose?
have you seen a doctor
surreal path
yes
they know my issues and they did get me once to eat 2k cals, but now im doing something they dont like anymore
which is eating 1k
anyways id prefer we keep on topic to nyaux
i will debug the blocking threads issue shortly
as oberrow said it might be the release function
cinder plinth
anyways id prefer we keep on topic to nyaux
you started the topic tho
surreal path
you started the topic tho <:nooo:750466870993223750>
fair
surreal path
my bad chat kinda overslept
now its working?
ok now its not working
okay
something very bad
it only works not under gdb?
oh nvm its random
ok it seems that whenever a thread has the lock the other thread dies
not fun
idk whats going on and it being rlly random makes it difficult
help
elder shoal
Real osdevs would never be in a relationship, its a distraction from osdev
edgy pilot
Real osdevs would never be in a relationship, its a distraction from osdev
is factorio a distraction from osdev too?
rigid fable
is factorio a distraction from osdev too?
yes !!!
surreal path
yea
my bad chat
was sleeping then had to talk with my gf and play with her a bit
anyways i think the kprintfs are causing the random behavior
i have an idea
okay i see
rigid fable
was sleeping then had to talk with my gf and play with her a bit
we lost you 😔
🦆😔
🦆😭
surreal path
And when you unblock you need to check that the thread has been saved
wdym
flat nymph
Wait a second
surreal path
kk
surreal path
What does your threadblock do?
okay
flat nymph
flat nymph
You need to be scheduling the next thread
And
What I was typing
CPU 1 CPU 2
ThreadBlock(stuff);
ThreadReady();
schedd(NULL):
surreal path
im not saving the context
flat nymph
Then what are you doing
surreal path
nvm i am
but
i have different cpu queues
so cpu 1 and cpu 2 dont even share the same thread
surreal path
im protecting the blocked thread queue with a spinlock
flat nymph
But if threads get pushed to ready back on the CPU they were blocked on then it should be fine
surreal path
But if threads get pushed to ready back on the CPU they were blocked on then it ...
yea it should
void acquire_kmutex(struct KMutex* mutex)
{ spinlock_lock(&mutex->protectionlock);
// kprintf("acquire_kmutex(): lock is %d\n", mutex->lock);
if (!mutex->lock) {
mutex->lock = true;
spinlock_unlock(&mutex->protectionlock);
return;
} else {
ThreadBlock(mutex->blockedthreadsqueue);
spinlock_unlock(&mutex->protectionlock);
schedd(NULL);
}
}
void release_kmutex(struct KMutex* mutex)
{
spinlock_lock(&mutex->protectionlock);
if (mutex->blockedthreadsqueue == NULL) {
mutex->lock = false;
spinlock_unlock(&mutex->protectionlock);
return;
} else {
struct thread_t *thread = pop_from_list(&mutex->blockedthreadsqueue);
ThreadReady(thread);
spinlock_unlock(&mutex->protectionlock);
}
}
2 of my kmutex functions
still dont understand why klocktest2 isnt getting unblocked
gdb not telling me anything
flat nymph
mutex->blockedthreadsqueue == NULL
Is never NULL with circular lists
Or they are not circular
surreal path
it can be null
flat nymph
Also, what is your ThreadReady
flat nymph
it can be null
Then you're doing it wrong
surreal path
Then you're doing it wrong <:trl:829316641191886888>
no its just the nyaux way
wanna die chat
flat nymph
```
CPU 1 CPU 2
ThreadBlock(stuff);
...
Then this happens
flat nymph
Think about it
surreal path
im protecting it with a spinlock tho
no 2 cpus will have the spinlock
so it SHOULD be fine
flat nymph
im protecting it with a spinlock tho
And?
flat nymph
idk how to explain it to you
surreal path
bru
flat nymph
@finite summit am I insane
flat nymph
there are gradations of insanity
flat nymph
```
CPU 1 CPU 2
ThreadBlock(stuff);
...
Could this happen with his code?
cinder plinth
why are you mixing PascalCase with snake_case btw
flat nymph
```C
void acquire_kmutex(struct KMutex* mutex)
{ spinlock_lock(&mutex->protec...
Still
ThreadBlock(mutex->queue);
spinlock_unlock(mutex->lock);
spinlock_lock(mutex->lock);
ThreadReady(thread)
spinlock_unlock(mutex->lock);
// ...
schedd() -> schedules the thread
Thread context not saved kernel crashes
schedd(NULL);
dayum how do i fix this
cinder plinth
you just reschedule
rigid fable
@surreal path is it true what you leave osdev because you have a gf and you will no more say hello to me 🦆😔
surreal path
you just reschedule
wdym
cinder plinth
reschedule when blocking the thread
surreal path
but i do
cinder plinth
so it's removed from the runqueue
cinder plinth
idk your codebase enough
rigid fable
but im fucked
flat nymph
There are various solutions
Like mark your thread as ready inside the switch_to whatever it's called function
surreal path
Like mark your thread as ready inside the switch_to whatever it's called functio...
what
also even if i solve this
i still have this issue where klocktest2 never executers
executes*
gonna cry chat
rigid fable
gonna cry chat
cry in commits too
surreal path
<@350748255929499649>
ignore the state = running i changed it to state = ready
my bad with that
surreal path
bru
surreal path
:(
rigid fable
poor nyaux... First ECDT now this
surreal path
yea i need help from someone
codes on github
just gotta hope someone will take a look
cause im out of ideas
and i just wanna work on my vfs atp
mr @finite summit has bash already
and what does nyaux have
nothing lmao
flat nymph
You're missing a degree in computer science
surreal path
bru
molten grotto
degree in computer science is literally useless
cinder plinth
degree in computer science is literally useless
I wouldnt say so
molten grotto
well for getting a job maybe but like otherwise
flat nymph
it depends
surreal path
well for getting a job maybe but like otherwise
big brain idea for you, clone nyaux from github
rigid fable
mr <@841762704766140486> has bash already
when i get stuck on some issues i try to rewrite it
surreal path
when i get stuck on some issues i try to rewrite it
used to be like that
but thats stupid
rigid fable
but thats stupid
if you rewrite it MAYBE you find a problem
surreal path
if you rewrite it MAYBE you find a problem
bru
molten grotto
big brain idea for you, clone nyaux from github <:trl:829316641191886888>
I don't feel like looking at nyaux code rn lol
flat nymph
I have difficult ass exams in 2 days <:nooo:750466870993223750>
my brain isn't functional enough to design concurrency memes for nyaux
surreal path
maybe later when u feel better?
rigid fable
I don't feel like looking at nyaux code rn lol
nyaux have anti copypaste system
you don't understand this
surreal path
maybe later when u feel better?
when u do feel better please if u can try to help, for the meantime ill try to look at the code for a little more if i can spot something
rigid fable
it will be fun if someone copypaste from nyaux
surreal path
what even is the problem
blocked thread is not running
i.e. klocktest2 is not executing anything anymore after acquire
after getting blocked
even tho all the code makes sense
no klocktest2 i have the lock
shit
flat nymph
i'm saying he has a race condition
flat nymph
(though idk if it's what's manifesting in bug)
surreal path
(though idk if it's what's manifesting in bug)
no its not
cause i solved it and bug isnt solved
surreal path
yes... that's the point?
no i mean
cinder plinth
blocked threads don't run
surreal path
blocked threads don't run
yes ik
cinder plinth
did you add it back to the list
flat nymph
<@350748255929499649>
This doesn't solve it
surreal path
This doesn't solve it
how im doing it in the scheduler
void ThreadReady(struct thread_t *thread) {
struct per_cpu_data* cpu = arch_get_per_cpu_data();
thread->state = READYING;
push_into_list(&cpu->run_queue, thread);
}
...
push_into_list(&cpu->run_queue, cpu->cur_thread);
cpu->cur_thread = pop_from_list(&cpu->run_queue);
if (cpu->cur_thread->state == READYING) {
cpu->cur_thread->state = READY;
push_into_list(&cpu->run_queue, cpu->cur_thread);
cpu->cur_thread = pop_from_list(&cpu->run_queue);
cpu->cur_thread->state = RUNNING;
return old;
}
...
bit hacky but it should
flat nymph
you need to be waiting
surreal path
what
cinder plinth
you need to be waiting.
surreal path
bru
rigid fable
you need to be waiting...
flat nymph
you set thread to reasy in schedd or wherever
molten grotto
you take the address of a parameter
surreal path
you set thread to reasy in schedd or wherever
thats what im doing
flat nymph
the function that switches the context
molten grotto
and pushing the thread to there is not going to last very long
void ThreadBlock(struct thread_t *whichqueue) {
struct per_cpu_data* cpu = arch_get_per_cpu_data();
cpu->cur_thread->state = BLOCKED;
push_into_list(&whichqueue, cpu->cur_thread);
}
after you push the registers on stack and load different stack
surreal path
and pushing the thread to there is not going to last very long
wdym
flat nymph
when loading thread, you spin wait untill it's ready
surreal path
when loading thread, you spin wait untill it's ready
wha
flat nymph
like you can't switch to a thread that's running on other CPU
flat nymph
So you either
- wait for it to not be running
- return it back to its CPU so it deals with it
surreal path
if its not on the cpus run queue
molten grotto
wdym
well here you do push_into_list(&whichqueue, cpu->cur_thread); and whichqueue is NULL so you end up doing ```c
void ThreadBlock(struct thread_t whichqueue) {
struct per_cpu_data cpu = arch_get_per_cpu_data();
cpu->cur_thread->state = BLOCKED;
// what push_into_list(&whichqueue, cpu->cur_thread); does:
whichqueue = cpu->cur_thread;
whichqueue->next = whichqueue;
whichqueue->back = whichqueue;
}
you're moving the thread to a queue of different CPU (if I understood your code correctly) one you unblock the thread
surreal path
you're moving the thread to a queue of different CPU (if I understood your code ...
to its own cpus queue
not of the queue of a different cpu?
surreal path
well here you do `push_into_list(&whichqueue, cpu->cur_thread);` and whichqueue ...
yea and whats wrong with that?
im so confused lol
flat nymph
Still
```CPU 1 CPU 2
ThreadBlock(mutex->queue);...
Look at this
flat nymph
I'm not talking about thread context
molten grotto
yea and whats wrong with that?
well how do you access the queue after that? its not stored anywhere, its the same as ```c
void ThreadBlock(struct thread_t whichqueue) {
struct per_cpu_data cpu = arch_get_per_cpu_data();
cpu->cur_thread->state = BLOCKED;
// what push_into_list(&whichqueue, cpu->cur_thread); does:
struct thread_t* dump = cpu->cur_thread;
dump->next = dump;
dump->back = dump;
}
you need to make ThreadBlock take an address of the queue not the first thing in the queue
flat nymph
When switching to a different context
flat nymph
you need to make ThreadBlock take an address of the queue not the first thing in...
He said he has circular lists
(which can be NULL for some reason)
surreal path
well how do you access the queue after that? its not stored anywhere, its the sa...
oh because im not taking a double ptr
therefore only modifying the parameter
not the actual queue
molten grotto
or just make it a proper circular list
though well doing that with threads might not be the best thing ever as then you'd have to have a dummy thread entry inside kmutex for the start
surreal path
oh because im not taking a double ptr
lemme make it a double ptr
flat nymph
make lists store addresses of the list itself?
List head
Idk
That's what my circular lists do afair
So it's still just 2 pointers
surreal path
that solved it but it kills itself
flat nymph
Yes because your circular lists are broken
surreal path
how
molten grotto
make lists store addresses of the list itself?
with the way nyaux does it where its thread* instead of some kind of general list_head/list_entry that's likely not very good idea
flat nymph
Yeah
molten grotto
as you'd need a dummy thread at the start
flat nymph
He's missing some cursed macros
surreal path
Yes because your circular lists are broken
??
flat nymph
flat nymph
circular lists are just a bit easier
surreal path
bros not answering my question
triple not answering
cinder plinth
My lists https://gitlab.com/mishakov/pmos/-/blob/main/sysroot/include/pmos/conta...
huh interesting, you define functions outside of the class in headers
flat nymph
Stop copy-pasting code and write (or steal) yourself a proper circular list
surreal path
Stop copy-pasting code and write (or steal) yourself a proper circular list
im not wtf
??????????
cinder plinth
My lists https://gitlab.com/mishakov/pmos/-/blob/main/sysroot/include/pmos/conta...
here are mine
😎
surreal path
@flat nymph im not copy pasting??????????????????????
kind root
huh interesting, you define functions outside of the class in headers
pretty smart actualy
surreal path
where did i copy paste
cinder plinth
pretty smart actualy
why?
surreal path
where did i copy paste
i wrote the circular list myself
like wtf
i did not copy paste
flat nymph
Also I have my own rb tree implementation 😎 https://gitlab.com/mishakov/pmos/-/blob/main/sysroot/include/pmos/containers/intrusive_bst.hh?ref_type=heads
(only a tiny bit cursed)
surreal path
@flat nymph where did i copy paste
kind root
you can just press the collapse button
thats just a more awkward solution
u would press collapse 50 times
surreal path
i find that very insulting
kind root
if theres 50 functions
thorn bramble
thank god this exists
molten grotto
Also I have my own rb tree implementation 😎 https://gitlab.com/mishakov/pmos/-...
I have too but its actually the frigg one just first written in a non-recursive way in c and then I ported that to c++
surreal path
i find that very insulting
bro mishakov can u answer
molten grotto
because I am too dumb to understand how it works lol
flat nymph
https://github.com/nyx-os/atlas/blob/master/include/atlas/rbtree.hpp
I store color in pointers 
cinder plinth
not a bad idea
flat nymph
bro mishakov can u answer
What your circular lists are not circular lists
surreal path
What your circular lists are not circular lists
okay but they werne't copy and pasted
cinder plinth
I implemented a hash array mapped trie which no one here has, so checkmate nerds 😎
unkempt relic
I store color in pointers <:chad:815144781842743334>
i put freebsd's tree.h rbtree into c++, possibly it even works, it does the same:
https://gist.github.com/netbsduser/56a72833649e38fe2bd81c82b28012c4
surreal path
it was my own impl
surreal path
okay but they werne't copy and pasted
can u not attempt to say that again because i find that especially insulting
cinder plinth
i put freebsd's tree.h rbtree into c++, possibly it even works, it does the same...
I mean it's not a stupid idea, but how much overhead does it have realistically? (I am coping)
kind root
i put freebsd's tree.h rbtree into c++, possibly it even works, it does the same...
why did u do that 💀
flat nymph
i put freebsd's tree.h rbtree into c++, possibly it even works, it does the same...
I want to eventually do rbtree without parent pointer though for struct Page
surreal path
can u not attempt to say that again because i find that especially insulting
like bro
surreal path
i have ze scheduler im just fucking dying
and like
i feel extremely insulted
plus kinda upset? weirdly. idk i had a bad day today
thorn bramble
take out ur anger by fixing ur code
cinder plinth
dont be so susceptible
kind root
no offense but literally every bug u encounter u instantly give up and ask other people to fix it
thorn bramble
i wouldn't agree with the 2nd statement but
the first definitely true
ur mental is so fragile when it comes to coding and bugs
cinder plinth
he's kinda right
thorn bramble
btw not tryna shit on u or whatever, legitimate remark
i know i say a bunch of mean things but this isnt meant to be one of them
kind root
im saying that because i want nyaux to succeed as well
kind root
u gotta know how to use gdb and printfs
surreal path
i do
kind root
instead of giving up
kind root
use it harder
surreal path
bro
kind root
yes
kind root
yes but why was qwinci able to debug it in like 5 mins
kind root
thats not it
kind root
no its because qwinci actually learned to solve bugs by debugging his stuff
finite summit
Debugging is not something you are born with
surreal path
thats not what i meant
finite summit
Intelligence is dictated by your willingness to learn
molten grotto
yeah you just get better at it over time
surreal path
thats not what i meant
like at all
surreal path
no cause like no 1 why did miskaov immdeitly assume i copy pasted code like wtf. no 2 yes i get it its stupid im always not figuring out the simpliest of things but again im still new to osdev and i still TRIED to debug my own stuff that still counts no 3 all of yall saying this is kinda making me feel even worse not better. i get yall are trying to give me cristism but i already had a really shitty day today and im actually starting to cry cause i feel like nothing i did even mattered and yall just did the code yourselves and i didnt do any effort or smt. im not saying yall are trying to say this but that what it feels like to me rn
i still worked hard on this project
doesnt matter if i dont have the debugging skills of qwinci or anyone, i still did try to printf i still did try to gdb and im still learning
plus as qwinci said
you get better at this over time
thorn bramble
no cause like no 1 why did miskaov immdeitly assume i copy pasted code like wtf....
im gonna ignore all of what you said and focus on no 2, you need to be good at programming, not at osdev
surreal path
but u dont get better if qwinci solves your bugs
but ur saying this on the assumpation i didnt try and havent solved my own bugs previously
cinder plinth
you tried for 5 mins and gave up is the problem
surreal path
but ur saying this on the assumpation i didnt try and havent solved my own bugs ...
to which i did
kind root
what rustc said
surreal path
you tried for 5 mins and gave up is the problem
this is an assumpation your making
kind root
i saw u try but u barely did so
thorn bramble
osdev is just like "load gdt, set up page tables" but everything else is just regular programming but with weird constraints of no os
cinder plinth
this is an assumpation your making
bro literally everytime you encounter a bug you do this
cinder plinth
osdev is just like "load gdt, set up page tables" but everything else is just re...
not really
kernel programming is advanced concurrent programming
thorn bramble
yeah but still it's not specific to osdev
kind root
just do -smp 1
thorn bramble
i might have phrased that wrong because i had a bit more background to it
but i guess this is similar to how people think "oh how do i do X with limine"
surreal path
bro literally everytime you encounter a bug you do this
that is not true
surreal path
i saw u try but u barely did so
i had a really rough day today
thorn bramble
and they dont realize that once the RIP is in their kernel limine does not do anything anymore and they are on their own
surreal path
i agree i didnt try that hard
kind root
this has been a consistent pattern
surreal path
this has been a consistent pattern
yes it has, but that doesnt mean its all the time. and im trying to do less and less of it as time goes on
remember the first bugs i encountered at the start?
remember how i reacted?
compare to how i react now
kind root
well maybe i just dont know the full picture
thorn bramble
i think the rust arc might have skewed the picture a bit lol
12 hours a day of ub and complaining
surreal path
bro
surreal path
not rlly
thorn bramble
but ur back to C and that's all that matters
flat nymph
no cause like no 1 why did miskaov immdeitly assume i copy pasted code like wtf....
I didn't mean copy-paste as taking something from someone else, but by not having a single good list implementation
surreal path
I didn't mean copy-paste as taking something from someone else, but by not havin...
ur right on that but copy and paste kinda meant something else to me, try to phrase it differently next time your trying to criticise this
also i was crying earlier and now i feel like actually awful, i dont think im gonna work on anything anymore for today for my mental health. i dont wanna get more upset atm im on the verge of crying again lol
cant believe im crying over what strangers think of my code on the internet, man i really am pathetic lol
wish i wasnt like this im not going to lie
kind root
we didnt say anything about your code tho
just your approach to working with said code
surreal path
more about my behavior yes
flat nymph
Your code is fine
Idk if I sounded too strong
But I believe that it's a good idea to just write a single good list implementation (and other containers) with C macros and not spend your time debugging it
surreal path
i get what yall are trying to say to me anyway i just need to calm down and stop crying, i havent told yall this but i have an issue with being like really sensitive which sucks ass because i cry over the smallest things
surreal path
But I believe that it's a good idea to just write a single good list implementat...
yea i get what u were trying to say
surreal path
i get what yall are trying to say to me anyway i just need to calm down and stop...
makes it difficult especially in real life
i just went back to school today and shit wasnt nice
especially with the teachers shouting at me
kind root
yeah sorry if that sounded too rough
surreal path
its fine, i just need to lie down and not think about anything rn
flat nymph
Your code is fine
Like dude you're 17 and doing osdev, which is like one of the hardest domains in programming
kind root
its fine, i just need to lie down and not think about anything rn
if it makes u feel any better i didnt know any programming until i was 18
flat nymph
You're missing a degree in computer science <:trl:829316641191886888>
This was said with irony
surreal path
i injoured my leg and arm today while coming back from the store
im in too much pain to do anything today
hopefully tmrw
finite summit
i injoured my leg and arm today while coming back from the store
Hope you get better!
surreal path
thanks!
rigid fable
i injoured my leg and arm today while coming back from the store
pls don't die
surreal path
still need to heal