ServerRpc is not triggering by any client, why? | FirstGearGames / Fish-Networking | Page 1

rocky solstice Sep 23, 2022, 10:51 PM

#

What I'm trying to do: Drag an object and sync.

Player press E, sends a RequestOwnership function and it is [ServerRpc(RequireOwnership = false)]
Server side should trigger the RequestOwnership function and then do the nob.GiveOwnership(newOwner);
All players should get public override void OnOwnershipClient(NetworkConnection newOwner) called.

Player that is also a server works fine. All other non-server clients do not work.

I've attached a unitypackage of all objects in scene and scripts (excluding the FishNet Pro).
Basically import the given unitypackage, start a new scene, delete the default camera and light, drag the "FishNet Ownership Test Scene" prefab into the scene, make build, etc. run it.

What am I doing wrong here? Why is the SimpleDragObject.cs > RequestOwnership not triggering on server side called from a client?
Using the following:
FishNet Pro 2.4.5hf0
Unity 2020.3.26f1
Half cup of coffee...

📎 DragObjectNetwork.unitypackage

subtle trail Sep 23, 2022, 10:54 PM

#

Maybe the Clients are not added to the default scene, so they are not Observers? You can run a client as editor and check the object's status easily in the inspector /w debug mode

rocky solstice Sep 23, 2022, 10:55 PM

#

Checking...

#

I'm not sure I understand. I know about debug mode in the inspector. Check the object's status -- the draggable object or the player or ? And which script to check?

#

#

This one, maybe?

#

Both player A and B have the same nob debug settings.

#

OH I see NetworkObserver script.
Both player A and B have the same settings.

#

I've included everything so that you can run it on your end and see what I did wrong.... I'm really hoping to solve this as it is an important feature for my game - Player A to be able to pick up object and then player B pick up object from A.

subtle trail Sep 23, 2022, 11:07 PM

#

As the client that can not set the RPC, you should get error when you try to make the call and you can check if the Object you're trying to call this RPC on is active for him

rocky solstice Sep 23, 2022, 11:44 PM

#

No error at all. No warning. How do I check if object is active? Assume I'm 5 years old, I'm new to networking world.

subtle trail Sep 24, 2022, 12:11 AM

#

rocky solstice No error at all. No warning. How do I check if object is active? Assume I'm 5 ye...

The GameObject would simply be de-activated/greyed out

#

https://i.imgur.com/goNAilJ.png

Imgur

#

https://i.imgur.com/qM2kfIL.png

Imgur

#

Pretend this is a NetworkObject

#

If there is a NetworkBehaviour on your, you'll see eg
https://i.imgur.com/19EIABo.png

Imgur

#

The network events not having been called.

rocky solstice Sep 24, 2022, 3:05 AM

#

The game object never got deactivated / greyed out. Have you downloaded the unity package and tested it? Maybe that would help narrow down to what I've done wrong... ?

subtle trail Sep 24, 2022, 5:10 PM

#

No, sorry having to set this up and then dig into your code myself is highly time and mental effort consuming.

Your issue sound like a simple logic error. You can look at a example transform controller character.

Now imagine you spawn this, but you want to move it with the mouse instead, then all you need to do is write the code for that and let the NetworkTransform sync it for you. Alternatively once you have solved your Spawn/IsSpawn/Active issue by comparing to a working object/setup, you can call a ServerRpc with the endDragPosition. And let the server lerp the movement for all to see.

rocky solstice Sep 24, 2022, 7:19 PM

#

Hmm. Okay since downloading and testing is time-consuming, I'll try to make it easy by sharing pics, scripts, and summarizing what I did and the result.

#

The above is a simple scene. Player(Clone) is sync thru network using NetworkTransform.
The Draggable Object (cube) has NetworkTransform and SimpleDraggableObject script.

#

The SimpleDraggableObject.cs has this:

[RequireComponent(typeof(NetworkTransform))]
public class SimpleDraggableObject : NetworkBehaviour
{
    public override void OnStartClient()
    {
        base.OnStartClient();

        if (!IsServer)
        {
            Rigidbody rigid = GetComponent<Rigidbody>();
            rigid.useGravity = false;
            rigid.isKinematic = true;
        }
    }

    // Server side calls nob.GiveOwnership(...) and then OnOwnershipClient is called, 
    // however this is triggered on server side, not clients... 
    public override void OnOwnershipClient(NetworkConnection newOwner)
    {
        base.OnOwnershipClient(newOwner);
        if (Owner == newOwner)
        {
            Debug.Log("<color=#55ff55>I'm now owning this drag object! DraggableObject</color>", gameObject); 
            SimpleDragObject.instance.PickUpObject(this);
        }
        else
        {
            Debug.Log("<color=#55ff55>I'm losing this drag object! DraggableObject</color>");
            SimpleDragObject.instance.DropObject(this);
        }
    }
}```

#

The SimpleDragObject.instance is a script that's on a player (not other players) which is this:

public class SimpleDragObject : NetworkBehaviour
{
    public static SimpleDragObject instance;
    public Transform holdParent;
    private bool init = true;
    private RaycastHit hit;
    private Transform isHoldingObject;

    public override void OnStartClient()
    {
        base.OnStartClient();
        if (!IsOwner)
        {
            Destroy(this);
            return;
        }
        instance = this;
        init = true;
    }

    private void Update()
    {
        if (!init) return;

        if (Input.GetKeyDown(KeyCode.E))
        {
            // Blah blah physics raycast, etc. deleted several lines for summary purpose
            // raycast did hit and has SimpleDraggableObject script
            Debug.Log("It has SimpleDraggableObject. Calling RequestOwnership");
            RequestOwnership(Owner, hit.collider.GetComponent<NetworkObject>());
        }
    }

    [ServerRpc(RequireOwnership = false)]
    private void RequestOwnership(NetworkConnection newOwner, NetworkObject nob)
    {
        Debug.Log("Giving ownership now...");
        nob.GiveOwnership(newOwner);
    }

    [ServerRpc(RequireOwnership = false)]
    private void ReleaseObject(NetworkObject nob)
    {
        Debug.Log("<color=#55FF55>Releasing ownership now...</color>");
        nob.GiveOwnership(null);
    }

    public void PickUpObject(SimpleDraggableObject dragObject)
    {
        dragObject.transform.SetParent(holdParent);
        isHoldingObject = dragObject.transform;
    }

    public void DropObject(SimpleDraggableObject dragObject)
    {
        // Blah blah
    }
}```

#

Specifically the part where client (player B) press E, calls RequestOwnership which is a ServerRpc with RequireOwnership = false. I'm assuming that means client tells server to run the RequestOwnership on server side, is that correct?

subtle trail Sep 24, 2022, 7:33 PM

#

rocky solstice Specifically the part where client (player B) press E, calls RequestOwnership wh...

You're destroying the NetworkBehaviour, don't do that. You're preventing any networked logic in "SimpleDragObject" from working. You're probably going to generate link errors too whenever the servers sends messages for the logic you've defined in it.

rocky solstice Sep 24, 2022, 7:34 PM

#

Ohh, that's for the draggable object. Let me remove the Destroy part. As for my question above, am I thinking that correctly?

subtle trail Sep 24, 2022, 7:35 PM

#

rocky solstice Ohh, that's for the draggable object. Let me remove the Destroy part. As for my ...

Yes ServerRpc run code on Server, it's in the name, ServerRemoteProcedureCall

rocky solstice Sep 24, 2022, 7:36 PM

#

Ok then I'm assuming that nob.GiveOwnership will send to all clients, correct?

subtle trail Sep 24, 2022, 7:36 PM

#

Oh your code will never work

#

https://i.imgur.com/up2Fyl7.png

Imgur

#

You're telling it to assign it to the existing Owner, so the owner will never cxhange

#

Remove that and leave it null, the server will get the caller auto populated, sec

rocky solstice Sep 24, 2022, 7:37 PM

#

Ohhhh interesting. Didn't know that.

subtle trail Sep 24, 2022, 7:38 PM

#

 [ServerRpc(RequireOwnership = false)]
    private void RequestOwnership(NetworkConnection caller = null)
    {
        Debug.Log($"Giving ownership of {name} to {caller.ClientId}");
        GiveOwnership(caller);
    }

#

Passing the object is a waste because this is already called on this object.
And the caller part cover who to give it to

#

Here is the relevant documentation section for this
https://fish-networking.gitbook.io/docs/manual/guides/remote-procedure-calls#serverrpc

#

You might want to do

 [ServerRpc(RequireOwnership = false)]
    private void RequestOwnership(NetworkConnection caller = null)
    {  
        if (Owner.IsValid) return;
        Debug.Log($"Giving ownership of {name} to {caller.ClientId}");
        GiveOwnership(caller);
    }

And before the Client send the RPC too.

#

Basically if the object is currently owned by a client, another client can't take it

rocky solstice Sep 24, 2022, 7:43 PM

#

So you're saying passing the NetworkObject is a waste? If so, then how would I know which object to give ownership? The script you're showing me is actually on player, not on the draggable cube object. Maybe that's why I'm confused.

subtle trail Sep 24, 2022, 7:43 PM

#

rocky solstice So you're saying passing the NetworkObject is a waste? If so, then how would I k...

Put this on the object that can be claimed

rocky solstice Sep 24, 2022, 7:43 PM

#

I should move the RequestOwnership logic over to the cube?

#

Oh yeah

#

Gotcha!

#

Let me try that.

subtle trail Sep 24, 2022, 7:44 PM

#

You dont want to allow clients to be able to pass nobs arbitrarily and the server just give it to them. Heck they could take over ownership of other client's main Player Object haha

rocky solstice Sep 24, 2022, 7:45 PM

#

I do want player B to be able to steal Player A's cube while A is holding it.

subtle trail Sep 24, 2022, 7:52 PM

#

Cool, then adapt the "if (Owner.IsValid) return;" to whatever you want. Without limit it would be weird, since Ownership could then be changed multiple time at the same frame. You'd get potentially garbled events fighting.

rocky solstice Sep 24, 2022, 7:54 PM

#

Oooo interesting. I'll adapt that and test it out - will let you know how it goes.

#

Not quite there yet. Player B press E and calls
hit.collider.GetComponent<SimpleDraggableObject>().RequestOwnership(Owner); // The script that's on the cube
The cube is the one with ServerRpc and I pass Owner. I debug the the player's Owner.ClientID and it shows 1
Then when server responded via OnOwnershipClient, the network connection returned -1
Why is that?

#

#

If server picks up object, OnOwnershipClient shows network connection client ID as 0.
If client picks up object, OnOwnershipClient shows network connection client ID as -1. Should be showing 1.
Is there a reason why client always get -1?

#

The point of this thread is that ServerRpc isn't triggering by any client. That has been resolved as fixed.
Solution:
Move this:

[ServerRpc(RequireOwnership = false)]
public void RequestOwnership(NetworkConnection caller = null)
{
    Debug.Log($"Giving ownership of {name} to {caller.ClientId}");
    GiveOwnership(caller);
}```
To the draggable object and have client call RequestOwnership(Owner) on that draggable object script.
Then all clients got the OnOwnershipClient triggered.
And few other tweaks above mentioned by Virosa.

#

Thank you very much @subtle trail! Marking this question as solved.

#ServerRpc is not triggering by any client, why?