feral willow Mar 11, 2024, 6:11 AM

#

I've never seen something like this before and I have no idea what the cause could be

#

i have of course disabled all other mods to check to see if that was the problem before posting

feral willow Mar 11, 2024, 9:05 AM

#

okay so I was on the latest dev branch of everest and bumping the version back by one update has fixed the issue

ember raptor Mar 11, 2024, 9:06 AM

#

what version?

#

"latest" doesn't tell us much because it gets frequent updates

feral willow Mar 11, 2024, 9:08 AM

#

the bug was happening on dev branch 4683

moving back to dev branch 4682 fixed the issue

ember raptor Mar 11, 2024, 9:09 AM

#

@worn steeple snip_sob

#

this is so stupid

ember raptor Mar 11, 2024, 9:10 AM

#

feral willow the bug was happening on dev branch 4683 moving back to dev branch 4682 fixed t...

in short this means strawberry jam was depending on buggy behavior

steel shard Mar 11, 2024, 9:10 AM

#

is this last nights patch?

ember raptor Mar 11, 2024, 9:10 AM

#

said buggy behavior is fixed

ember raptor Mar 11, 2024, 9:10 AM

#

steel shard is this last nights patch?

yes

steel shard Mar 11, 2024, 9:10 AM

#

lmfao

ember raptor Mar 11, 2024, 9:10 AM

#

feral willow Mar 11, 2024, 9:11 AM

#

fixing a bug broke sj? that's wild

ember raptor Mar 11, 2024, 9:12 AM

#

yeah

#

yknow whats funny

#

im working on getting cnet to build on .net 7

#

i had a cursed crash because everest accidentally replaced my DetourConfig with LegacyDetourConfig, even though i was referencing modern MonoMod

#

and it ended up trying to call a construtor that doesn't exist

worn steeple Mar 11, 2024, 9:15 AM

#

cryplant

ember raptor Mar 11, 2024, 9:15 AM

#

this should be fixed in sj

worn steeple Mar 11, 2024, 9:15 AM

#

Can someone figure out which SJ mod didn't trigger legacy relinking?

#

Should be visible in the log hopefully

ember raptor Mar 11, 2024, 9:17 AM

#

@feral willow can you send log when triggering this on 4683

feral willow Mar 11, 2024, 9:17 AM

#

uhh sure hold on

#

this is the one right?

📎 log.txt

ember raptor Mar 11, 2024, 9:21 AM

#

yup

#

@worn steeple uhh

#

funny thing

#

none are recognized are legacy i think snip_stare
i think they just didnt trigger the relinker

#

oh hold on

#

uhhhh

#

did you just reinstall 4683?

feral willow Mar 11, 2024, 9:23 AM

#

isint that what you wanted?

ember raptor Mar 11, 2024, 9:23 AM

#

uh

#

i need a log from your first 4683 boot

#

alternatively, go to Mods/Cache and delete everything inside

#

then restart everest, and be patient

#

then trigger the bug and send your log

#

i need the relinking logs

feral willow Mar 11, 2024, 9:24 AM

#

aight

#

this should be it

📎 log.txt

#

hopefully

ember raptor Mar 11, 2024, 9:33 AM

#

huh

#

am i high or is there something missing

#

it might be in verbose logs ffs

ember raptor Mar 11, 2024, 9:34 AM

#

ember raptor then restart everest, and be patient

uhhh can you edit everest-launch.txt and put --loglevel verbose at the end, then delete the cache again and do all this again

feral willow Mar 11, 2024, 9:34 AM

#

yea

#

oh god this file is a lot bigger

📎 log.txt

ember raptor Mar 11, 2024, 9:39 AM

#

yeah its supposed to be

feral willow Mar 11, 2024, 9:40 AM

#

after this i'm going to bed it's like 5 am for me

ember raptor Mar 11, 2024, 9:40 AM

#

remember to remove that --loglevel verbose to prevent your log files from being this massive

feral willow Mar 11, 2024, 9:40 AM

#

thanks for the reminder

ember raptor Mar 11, 2024, 9:49 AM

#

@worn steeple list of mods which didn't trigger legacy relininking:

Anonhelper
Batteries
CanyonHelper
CavernHelper
CherryHelper
CollabUtils (not CollabUtils2???)
ColoredLights
FactoryHelper
FlaglinesAndSuch
LuaCutscenes
memorialHelper
OutbackHelper
EmHelper
SafeRespawnCrumble
ShroomHelper
VortexHelper
FrostHelper

feral willow Mar 11, 2024, 9:49 AM

#

so like almost all of them?

ember raptor Mar 11, 2024, 9:50 AM

#

no, a small subset

#

sj and collabutils2 are correctly recognized as needing legacy relinking

worn steeple Mar 11, 2024, 9:53 AM

#

sunnyleave

ember raptor Mar 11, 2024, 9:56 AM

#

ill debug this at home

#

for now i have no clue what's going on

worn steeple Mar 11, 2024, 10:51 AM

#

ember raptor <@576710397147742209> list of mods which didn't trigger legacy relininking: - `A...

Quick followup: how many of those actually use any MonoMod classes directly? Because those were still picked up as modern on previous versions of Everest, so e.g. On. hook order still behaves like modern MonoMod

#

The only issue is if something there uses e.g. manual Hooks and those rely on exact hook ordering / etc

ember raptor Mar 11, 2024, 10:52 AM

#

i'd check rn but phone oshiregret2

worn steeple Mar 11, 2024, 10:53 AM

#

I know, this is for later laugheline

ember raptor Mar 11, 2024, 10:55 AM

#

could it be cu? (not cu2)

orchid swallow Mar 11, 2024, 3:52 PM

#

its every lobby for me not just expert

#

just booted up celeste and streaming right now lmfao im trying to play SJ but it wont let me enter a map

ember raptor Mar 11, 2024, 4:30 PM

#

orchid swallow just booted up celeste and streaming right now lmfao im trying to play SJ but it...

yeah figured

#

just go back one version

orchid swallow Mar 11, 2024, 6:47 PM

#

i also played expert contest and it had the same problem

ember raptor Mar 11, 2024, 6:47 PM

#

vefpsybjvfieubs;oafuoibeas;jiokhucajeafulvbys befiohfoiu!

#

snip_sob

orchid swallow Mar 11, 2024, 6:47 PM

#

i didnt go back one version though, i just played standalones after that

ember raptor Mar 11, 2024, 6:49 PM

#

iirc theres something wrong with xaphan helper too

#

cu2 and xaphanhelper (i think) are the only two cases that im aware of

pallid spoke Mar 11, 2024, 7:20 PM

#

i've just started getting this

#

finally getting around to playing GM

#

tried to enter the gym and got put back in the lobby lmao

#

i thought it may be some kind of sisyphus reference

#

but it is affecting every map

#

i had updated everest today too

ember raptor Mar 11, 2024, 7:22 PM

#

snip_sob

#

jfdlhskjvfgshoufesi

#

i should get around to testing this

pallid spoke Mar 11, 2024, 7:25 PM

#

do you need anything from me?

ember raptor Mar 11, 2024, 7:25 PM

#

you just have sj enabled right

#

nothing else

pallid spoke Mar 11, 2024, 7:26 PM

#

no, i have what i usually do

#

i can try with just sj

#

and it's dependencies

#

which is pretty much everything lol

ember raptor Mar 11, 2024, 7:26 PM

#

yeah i need like

#

a minimal set of mods to reproduce this

pallid spoke Mar 11, 2024, 7:26 PM

#

i'm on everest 4683

ember raptor Mar 11, 2024, 7:26 PM

#

yes, i know

pallid spoke Mar 11, 2024, 7:27 PM

#

will try now

ember raptor Mar 11, 2024, 7:27 PM

#

4683 is supposed to fix a bug which should've exploded everything

#

but didn't

#

and fixing the bug is suddenly making everything explode

#

and i fh oprvo0i fuib 3hw3 b0yufufvw3 r3qoiuq rbyr3wbiuy 3 the fucking keyboard

#

snip_sob

pallid spoke Mar 11, 2024, 7:27 PM

#

51 dependencies damnnn

#

it's still happening

#

ember raptor Mar 11, 2024, 7:29 PM

#

okay so just having sj makes it have as troke

pallid spoke Mar 11, 2024, 7:29 PM

#

it does think i'm in a map lol

ember raptor Mar 11, 2024, 7:29 PM

#

restart chapter

#

widergladeline3

#

okay @worn steeple i can try debugging this

#

what are we looking for

worn steeple Mar 11, 2024, 7:32 PM

#

Any mods which 1. use MonoMod classes directly (so On./IL. hooks don't count) 2. don't trigger legacy relinking

ember raptor Mar 11, 2024, 7:32 PM

#

ok fuck i should've cleared my cache

#

do i look into the relinked asms or the zipped ones

worn steeple Mar 11, 2024, 7:33 PM

#

We can eliminate the mods which just use hookgen because Everest never considered them to use legacy MonoMod relinking anyway, but the poisoned relinker tables meant they still got relinked even if they shouldn't be

pallid spoke Mar 11, 2024, 7:33 PM

#

is there anything else i can help troubleshoot? or any info that could be helpful?

#

if not, i'll just downgrade and get jammin

ember raptor Mar 11, 2024, 7:33 PM

#

pallid spoke is there anything else i can help troubleshoot? or any info that could be helpfu...

not atm

#

but appreciate the help

pallid spoke Mar 11, 2024, 7:33 PM

#

thumbeline

ember raptor Mar 11, 2024, 7:33 PM

#

go get some passionfruit bread spread

worn steeple Mar 11, 2024, 7:33 PM

#

ember raptor do i look into the relinked asms or the zipped ones

The log is enough to figure out for which mods the relinking doesn't trigger, and to figure out whether they use MonoMod classes you can use either asm

ember raptor Mar 11, 2024, 7:33 PM

#

ah

worn steeple Mar 11, 2024, 7:34 PM

#

Then we can look into why these mods don't rigger relinking

ember raptor Mar 11, 2024, 7:34 PM

#

okay i got the issue to reproduce myself

#

time to get to work

#

i entered mosaic garden and returned to lobby while in the lobby maddyhueh wonder how it'll handle that

pallid spoke Mar 11, 2024, 7:41 PM

#

umm okay the plot thickens

#

i just downgraded to stable

#

and ran with the same mods enabled, just SJ and the dependencies

ember raptor Mar 11, 2024, 7:41 PM

#

delete your Mods/Cache folder and try again

pallid spoke Mar 11, 2024, 7:41 PM

#

and it crashed harder than ever before

ember raptor Mar 11, 2024, 7:41 PM

#

wait wtf

pallid spoke Mar 11, 2024, 7:42 PM

#

it crashed so hard, it restarted explorer and closed all my applications

#

📎 log.txt

#

something about graphical stuff

#

Texture2D creation failed!

ember raptor Mar 11, 2024, 7:43 PM

#

Texture2D creation failed! Error Code: The GPU will not respond to more commands, most likely because some other application submitted invalid commands.
The calling application should re-create the device and continue. (0x887A0007)

#

gpu issues?

#

yeah this might've been a graphics driver crash

pallid spoke Mar 11, 2024, 7:43 PM

#

what would cause that?

#

i've never had it before

ember raptor Mar 11, 2024, 7:44 PM

#

i think the texture2d creation failed, but idk about you

pallid spoke Mar 11, 2024, 7:44 PM

#

lmao

ember raptor Mar 11, 2024, 7:44 PM

#

pallid spoke what would cause that?

running out of memory or old graphics drivers

pallid spoke Mar 11, 2024, 7:45 PM

#

i have never had any graphics problems

ember raptor Mar 11, 2024, 7:45 PM

#

does it happen again

pallid spoke Mar 11, 2024, 7:45 PM

#

i'll try

#

oh

#

no, it's worked this time lol

#

could it have been needing to flush something out from the previous install?

#

i don't really know how it all works

#

but stable is working

#

and i can enter maps

ember raptor Mar 11, 2024, 7:47 PM

#

pallid spoke could it have been needing to flush something out from the previous install?

ig

#

@worn steeple hmmmmmmmmmmmmmmmmm

#

#

is this intentional

#

utils and runtimedetour are major ver 25

worn steeple Mar 11, 2024, 7:59 PM

#

Looking into it

worn steeple Mar 11, 2024, 8:00 PM

#

ember raptor utils and runtimedetour are major ver 25

There you have your issue catplanet

ember raptor Mar 11, 2024, 8:00 PM

#

is it that?

worn steeple Mar 11, 2024, 8:01 PM

#

If any MonoMod dependency is higher than 23 (inclusive), it tells the code it's not a legacy MonoMod assembly

#

So seems like this is some weird juxtaposition where MonoMod itself is legacy but other MonoMod assemblies are reorg???

ember raptor Mar 11, 2024, 8:03 PM

#

okay anonhelper uses exactly 1 manual IL hook

#

#

this is the relinked assembly

#

since it uses monomod.utils/runtimedetour 25 it's fine?

#

how does this cause cu2 to get fucked though

fast walrus Mar 11, 2024, 8:12 PM

#

You guys got any definite clues yet which mods are the issue? Otherwise I'd say let's find a collab with a lobby that has the least dependencies catresort

ember raptor Mar 11, 2024, 8:13 PM

#

going off what popax said, those which refer to assemblies starting with MonoMod. (major version 23+) and those which manually instantiate hooks

#

@worn steeple ???

#

is this the relinker

worn steeple Mar 11, 2024, 8:29 PM

#

MonoMod.Patcher

#

Wait

ember raptor Mar 11, 2024, 8:29 PM

#

look at the versions

worn steeple Mar 11, 2024, 8:29 PM

#

3paul is Everest injecting its own assembly references here

ember raptor Mar 11, 2024, 8:29 PM

#

im referencing the relinked assembly

worn steeple Mar 11, 2024, 8:29 PM

#

But yeah, that makes sense

#

FrostHelper uses reorg MonoMod afail

#

And I assume MonoMod substitutes the exact assembly versions

ember raptor Mar 11, 2024, 8:30 PM

#

im pretty sure it does use reorg (since it depends on 4465)

#

but the version mismatch?

#

ive checked every "uses modern monomod" mod other than frosthelper

#

couldn't find any mods which manually instantiate hooks other than anonhelper doing anonhelper things

worn steeple Mar 11, 2024, 8:32 PM

#

ember raptor ive checked every "uses modern monomod" mod other than frosthelper

Do you mean that the relinker says thes use modern MonoMod with that?

ember raptor Mar 11, 2024, 8:33 PM

#

i did a ctrl+f on uses modern MonoMod (with my own logging) and looked inside each assembly looking for hooks and i couldn't find anything of substance

#

now what if

worn steeple Mar 11, 2024, 8:34 PM

#

catresort

ember raptor Mar 11, 2024, 8:34 PM

#

okay no i just doublechecked and CU2 is properly relinked

#

#

so legacy mods are fine

worn steeple Mar 11, 2024, 8:35 PM

#

sunnyleave

ember raptor Mar 11, 2024, 8:35 PM

#

(CU2 uses legacy monomod - i just did a sanity check)

#

i don't want to spend all night debugging this and up awake at 4 am so i'll probably stop here

fast walrus Mar 11, 2024, 8:54 PM

#

It's very likely that this is an issue solely with cu2, yea? thinkeline

#

I installed some random collabs with low dependency counts and the intersecting set of deps so far would be

ExtendedVariantMode
VivHelper
MaxHelpingHand
FrostHelper
CollabUtils2

Probably hard to find a collab that can work with less (other than just making a new map that only has a lobby with a chapter trigger that sends you somewhere, no deps Catstare )

ember raptor Mar 11, 2024, 8:58 PM

#

fast walrus It's very likely that this is an issue solely with cu2, yea? <:thinkeline:410534...

idek anymore tbh

#

maybe something with cu2?

fast walrus Mar 11, 2024, 9:06 PM

#

Yeah, I'm glad dad collab has such few dependencies, and both dad collab 2018 and friendCollab have the "enter map returns to lobby" issue, only mod in common is CU2 youknowicattodoittoem

#

Is @rugged onyx aware of this stuff yet? snip_embarrassed Do you have any clues what could be going wrong in CU2 with MonoMod relinking that only starts happening with the one change Popax pushed to Everest yesterday that is in 4683? blobsweatsip And seemingly affects every CU2-type lobby stuff

ember raptor Mar 11, 2024, 9:12 PM

#

it's not just cu2

#

it seems to also be related to xaphanhelper?

fast walrus Mar 11, 2024, 9:13 PM

#

Is there another issue?

ember raptor Mar 11, 2024, 9:13 PM

#

crashes on heart collect

fast walrus Mar 11, 2024, 9:13 PM

#

Ah ThinkO_O

rugged onyx Mar 11, 2024, 9:16 PM

#

Uh I didn't have a chance to look into it thinkeline

#

what happen

fast walrus Mar 11, 2024, 9:17 PM

#

Well the Everest change in question is simply this btw youknowicattodoittoem

#

And it seems with this, CU2 breaks, in any lobby that uses CU2 when you try to enter a level, you spawn back at the start of lobby, but you get the "return to lobby" in pause and such

#

And in Journal in lobbies it doesn't list any maps?

rugged onyx Mar 11, 2024, 9:18 PM

#

so it's crab but a few weeks early

fast walrus Mar 11, 2024, 9:19 PM

#

Something related to hooks is probably being rather silly

#

Crab had something similar? thonkderp

rugged onyx Mar 11, 2024, 9:19 PM

#

no actually catplant

#

uh I'll check on my CU2 test map

#

(even the test map has 15 dependencies at this point though maddyS )

#

ah right, I should update Everest too catplant

fast walrus Mar 11, 2024, 9:21 PM

#

fast walrus Yeah, I'm glad dad collab has such few dependencies, and both dad collab 2018 an...

Yea all I know is that I tried the two collabs I showed, independently just with those deps, and the only overlap is CU2 snip_downsideup Doesn't 100% confirm that there isn't something else happening with dependent mods tho shrug

#

I mean, dadbod collab has two helpers and that's it snip_embarrassed

steel shard Mar 11, 2024, 9:24 PM

#

okay i knew the names were not 100% correct, but why is the count wrong

rugged onyx Mar 11, 2024, 9:25 PM

#

nah this is correct laugheline

#

uh yeah I can replicate

steel shard Mar 11, 2024, 9:25 PM

#

lmao

rugged onyx Mar 11, 2024, 9:26 PM

#

that doesn't seem to be the only messed up thing

fast walrus Mar 11, 2024, 9:26 PM

#

Also just to confirm, going back to 4682, dadbod 2018 works again, I didn't even clear any caches at any point (should I?)

ember raptor Mar 11, 2024, 9:26 PM

#

fast walrus Also just to confirm, going back to 4682, dadbod 2018 works again, I didn't even...

they get regenerated i think

steel shard Mar 11, 2024, 9:26 PM

#

then i dont understand does that message mean, but any way ill look into the naming thing now

rugged onyx Mar 11, 2024, 9:26 PM

#

forget about it catplant

#

"my minimal reproduction setup has 31 mods in it"

steel shard Mar 11, 2024, 9:27 PM

#

a

#

catplant

#

yeah

rugged onyx Mar 11, 2024, 9:27 PM

#

sometimes I just can't communicate

steel shard Mar 11, 2024, 9:29 PM

#

relatable peaceline

fast walrus Mar 11, 2024, 9:30 PM

#

hey look it's specifically the thing that the everest change touched catpog (idk if this means anything at all)

#

But maybe it really is specifically this thing that breaks, at least for the one issue of entering "chapters" from a lobby ThinkO_O

rugged onyx Mar 11, 2024, 9:34 PM

#

oh hey that thing that predates GetStateMachineTarget() catplant

#

maybe it's time I refactor this

#

heart door dies a brutal death

#

if that's the issue, there are 2 other mods that are also using that trick that I have the source of on my hard drive: Jungle Helper and Flusheline Helper

#

I'll just assume this is fine

#

it does look fixed to me thinkeline (I'll check with a zip though, in case this is a loading order issue)

#

still looks fixed to me

#

update published, I'll give the same treatment to Jungle Helper now laugheline

fast walrus Mar 11, 2024, 11:17 PM

#

happylandeline

worn steeple Mar 11, 2024, 11:22 PM

#

I'm confused, what was the issue here? laugheline

feral willow Mar 11, 2024, 11:52 PM

#

wow this blew up while i was asleep

remote hedge Mar 12, 2024, 12:11 AM

#

ember raptor in short this means strawberry jam was depending on buggy behavior

1172

fast walrus Mar 12, 2024, 1:10 AM

#

@worn steeple Wasn't the thing you patched in Everest an intended behavior? Idk what those dicts were for but they seemed to be shared between everything on purpose, no? Since them not being shared is what broke the HookCoroutine helper code some of the mods have (if you search Everest.Relinker.SharedRelinkModuleMap on Github you'll find some more of it)

#

But idk what those Relink Map dictionaries are for or what anyone would touch them for uwuline

#

Plus, I don't even know which part of the HookCoroutine function was breaking, but I figured it would be related to the Shared Map... but SharedRelinkModuleMap by its property definition should always have "Celeste.Mod.mm" in it, even after the change, right thonk What even had broken, would be worth investigating maybe

worn steeple Mar 12, 2024, 5:54 AM

#

It was in fact not shared on purpose catresort

#

The shared map contained some relinker entries common to all mods

#

It should not be a pile all per-mod relinking values should be added to

rugged onyx Mar 12, 2024, 7:14 AM

#

Well, I only used it as a way to get an AssemblyDefinition of Celeste thinkeline the hooking itself was done using new ILHook like all other manual hooks

minor breach Mar 14, 2024, 1:49 AM

#

feel bad for necroing but since thread already exists,

#

this is still ongoing even after latest CU2 updates