Everest Core Branch 4171 Crash on Startup | Mt. Celeste Climbing Association | Page 1

idle sorrel Aug 22, 2023, 4:29 PM

#

📎 errorLog.txt

remote vale Aug 22, 2023, 4:32 PM

#

update your mods, particularly Maddie's Helping Hand

#

you can do so from olympus:

idle sorrel Aug 22, 2023, 4:33 PM

#

alright

#

still crashes

📎 errorLog.txt

remote vale Aug 22, 2023, 4:37 PM

#

thonkeline hm, i thought this was a crash related to a different cause, but i just noticed something else

#

did it work on older versions of everest?

idle sorrel Aug 22, 2023, 4:37 PM

#

yes

#

4111 is the last one that works for me

#

this is especially annoying because everest is kinda forcing me into updating because mod compatibility or sumthing

remote vale Aug 22, 2023, 4:38 PM

#

@barren field maddyplant ~~would this be related to hook ordering?~~ any idea what this could be related to?

idle sorrel Aug 22, 2023, 4:39 PM

#

i was kinda just ignoring the updates because i knew they would crash but now i cant update my mods anymore

#

and i dont like that

#

last time i got told that some IL hook ordering is bugged and will be fixed soon

remote vale Aug 22, 2023, 4:40 PM

#

that's why i pinged popax, asking if hook ordering could be related or something

#

can you send your log.txt?

idle sorrel Aug 22, 2023, 4:41 PM

#

sure

remote vale Aug 22, 2023, 4:43 PM

#

actually, idk if this could be an IL hook thing, i'll look into the source

idle sorrel Aug 22, 2023, 4:43 PM

#

im just waiting for it to crash again it takes a bit

remote vale Aug 22, 2023, 4:43 PM

#

the crash seems to happen in frogeline project's froghelper

idle sorrel Aug 22, 2023, 4:44 PM

#

just out of curiosity, where do you see that?

remote vale Aug 22, 2023, 4:44 PM

#

Susge is this a monomod crime

remote vale Aug 22, 2023, 4:45 PM

#

idle sorrel just out of curiosity, where do you see that?

i downloaded frogeline project, extracted its helper dll and opened it in dnSpy

idle sorrel Aug 22, 2023, 4:45 PM

#

ahh

remote vale Aug 22, 2023, 4:45 PM

#

   at MonoMod.RuntimeDetour.ILHook..ctor(MethodBase method, Manipulator manipulator, IDetourFactory factory, DetourConfig config, Boolean applyByDefault)
   at Celeste.Mod.Helpers.LegacyMonoMod.LegacyILHook._Refresh()
   at FrogHelper.Entities.FrogBerryShard.Load()
   at FrogHelper.FrogHelperModule.Load()

the crash seems to indicate it's FrogHelper

idle sorrel Aug 22, 2023, 4:45 PM

#

here is the log

📎 log.txt

remote vale Aug 22, 2023, 4:46 PM

#

hmm i'm no expect but that orig_Update and orig_OnCollect hooks are looking mighty suspicious Susge

idle sorrel Aug 22, 2023, 4:47 PM

#

let me disable froghelper and see if it starts

remote vale Aug 22, 2023, 4:47 PM

#

probably will

idle sorrel Aug 22, 2023, 4:48 PM

#

37 other mods depend on this mod 😬

#

oh wait thats frosthelper

#

im dumb

#

i am guessing that froghelper is included in the frogeline project

remote vale Aug 22, 2023, 4:48 PM

#

it is

idle sorrel Aug 22, 2023, 4:48 PM

#

alright well thats not so bad

remote vale Aug 22, 2023, 4:49 PM

#

idle sorrel Aug 22, 2023, 4:50 PM

#

yeah it starts now

#

ok i can live with that

#

thanks!

remote vale Aug 22, 2023, 4:51 PM

#

i wonder if this is a flaw with flp

#

not a fan of those orig_Update and orig_OnCollect hooks

barren field Aug 22, 2023, 4:59 PM

#

Ok, what's going on?

remote vale Aug 22, 2023, 4:59 PM

#

apparently flp2021 is crashing on latest core

#

4111 was the last core versionto work

remote vale Aug 22, 2023, 5:01 PM

#

remote vale <:Susge:1068190454258081864> is this a monomod crime

i think this could be a case of flp2021 doing dodgy stuff? see here?

barren field Aug 22, 2023, 5:46 PM

#

Don't think so

#

Also, uhm, I wrote that "dodgy code" 3paul

remote vale Aug 22, 2023, 5:51 PM

#

3paul oh

#

why the orig hook

tulip moss Aug 22, 2023, 6:06 PM

#

hey @idle sorrel could send the list of mods that you are using? if you are unsure you could disable all mods via Olympus and then send your blacklist.txt from your mod folder. I wana try to reproduce this locally

#

unless you already had some mods disabled in that case just send your current blacklist.txt ohnoshiro

idle sorrel Aug 22, 2023, 6:24 PM

#

📎 message.txt

tulip moss Aug 22, 2023, 6:26 PM

#

thanks

barren field Aug 22, 2023, 6:33 PM

#

At this point you're basically the debugging wizard peaceline
I have no clue how you keep figuring these issues out, so I'm gonna let you work your magic here

tulip moss Aug 22, 2023, 7:30 PM

#

laugheline

tulip moss Aug 22, 2023, 8:32 PM

#

Okay this is funny FrogHelper is having issues without any dependencies on core but on stable it works

sand jungle Aug 22, 2023, 8:47 PM

#

maybe whatever that ILContext.Manipulator thing does is broken on core

tulip moss Aug 23, 2023, 7:25 AM

#

Okay I pinpointed the issue

#

      FrogBerryShard.collectHook = new ILHook((MethodBase) typeof (Celeste.Strawberry).GetMethod("orig_OnCollect"), new ILContext.Manipulator(FrogBerryShard.CollectRoutineModifier));

tulip moss Aug 23, 2023, 7:49 AM

#

Idk what's from reading the patch it seems broken

#

no idea how it rans on non core

#

      ILCursor ilCursor2 = new ILCursor(ctx);
      ilCursor2.GotoNext((Instruction i) => i.MatchCallOrCallvirt(typeof(HashSet<Celeste.EntityID>), "Add"));
      ILLabel AfterAdd = ilCursor2.DefineLabel();
      ILLabel AfterDelegate = ilCursor2.DefineLabel();
      ilCursor2.Emit(OpCodes.Ldarg_0);
      ilCursor2.Emit(OpCodes.Isinst, typeof(FrogBerryShard));
      ilCursor2.Emit(OpCodes.Brtrue, (object)AfterAdd);
      ilCursor2.Index += 1; // skip over callvirt before pop
      ilCursor2.Emit(OpCodes.Br, (object)AfterDelegate);
      ilCursor2.MarkLabel(AfterAdd);
      ilCursor2.Emit(OpCodes.Ldarg_0);
      ilCursor2.EmitDelegate<Func<HashSet<Celeste.EntityID>, Celeste.EntityID, Celeste.Strawberry, bool>>(((set, id, berry) =>
      {
        if (set == berry.SceneAs<Celeste.Level>()?.Session.Strawberries)
          return true; // <---- due to skipping callvirt pop will pop nothing return dummy value
        set.Add(id);
        return false; // <---- due to skipping callvirt pop will pop nothing return dummy value
      }));
      ilCursor2.MarkLabel(AfterDelegate);
      // upcoming instruction is pop...

#

original IL

#

callvirt  instance bool class [System.Core]System.Collections.Generic.HashSet`1<valuetype Celeste.EntityID>::Add(!0)
IL_00AF: pop

#

adding the lines with return true / false fixed it no core gona test on stable

#

ilCursor2.GotoNext((Instruction i) => i.MatchCallOrCallvirt(typeof(HashSet<Celeste.EntityID>), "Add")); cant find "Add" on stabe maddyS

#

mb its just a bad de-compilation, @barren field do you still have accesses to the original source code of that mod?

tulip moss Aug 23, 2023, 8:17 AM

#

okay this is super cursed it's either a ~~bug in old c# runtimesthat let this issue (popping nothing?) pass as valid IL~~ (nope) or my de-compiler is going nuts and I am debugging garbage rn derpeline . I have new idea what's going on this patch shouldn't work

barren field Aug 23, 2023, 11:08 AM

#

tulip moss mb its just a bad de-compilation, <@576710397147742209> do you still have access...

I think it's OSS

#

But yeah this makes sense

#

How did this ever work 3paul

#

I assume the delegate used to return void?

tulip moss Aug 23, 2023, 11:08 AM

#

mb

#

I cant replicate it within my own mod as well

#

its realy freaky

#

btw whats OSS?

barren field Aug 23, 2023, 11:09 AM

#

Open Source Software

tulip moss Aug 23, 2023, 11:09 AM

#

ah I couldn't find it

#

Ill look again

barren field Aug 23, 2023, 11:10 AM

#

Also, I'm a bit confused rn

barren field Aug 23, 2023, 11:10 AM

#

barren field I assume the delegate used to return void?

Was this the actual case?

tulip moss Aug 23, 2023, 11:10 AM

#

not sure Ill need to look into EmitDelegate code

#

because I dont think you can dump IL patches from old monomod

barren field Aug 23, 2023, 11:13 AM

#

No, like did it use to emit a delegate which returned nothing?

tulip moss Aug 23, 2023, 11:13 AM

#

ah yes

#

That was the old delegate

#

          ilCursor2.EmitDelegate<System.Action<HashSet<Celeste.EntityID>, Celeste.EntityID, Celeste.Strawberry>>((System.Action<HashSet<Celeste.EntityID>, Celeste.EntityID, Celeste.Strawberry>) ((set, id, berry) =>
          {
            if (set == berry.SceneAs<Celeste.Level>()?.Session.Strawberries)
              return;
            set.Add(id);
          }));

barren field Aug 23, 2023, 11:15 AM

#

Yeah that's plainly just wrong

#

I wouldn't bother debugging this further and just put it up to JIT jank

tulip moss Aug 23, 2023, 11:15 AM

#

👍

tulip moss Aug 23, 2023, 11:42 AM

#

Aight I opened a PR for FrogHelper this should be fixed soon gladeline

tulip moss Aug 27, 2023, 7:52 AM

#

Anyone knows who is maintaining FrogHelper and could ping them to look at this PR baddyping

GitHub

Fixed Incompatible stack heights by nhruo123 · Pull Request #1 · l-...

This mod craches on the latest core version due to invalid IL, currently if CollectRoutineModifier creates invalid IL, due to missing value on the stack on the FrogBerryShard path. This PR fixes it...

sand jungle Aug 27, 2023, 7:54 AM

#

it's on @nimble mango 's github so probably it?

tulip moss Aug 27, 2023, 7:54 AM

#

thanks laugheline

barren field Aug 28, 2023, 6:53 AM

#

I think I have access? I wrote the code in question after all
However even then I couldn't push a new build to GB

tulip moss Aug 28, 2023, 7:16 AM

#

that's a good start but we need someone with GB acsses

nimble mango Aug 28, 2023, 1:50 PM

#

i mentioned it a while ago on the FLP server when i first tried core

#

making an FLP release is kind of intimidating though so i didn't probe much further

barren field Aug 28, 2023, 2:04 PM

#

Guess we need to do more probing

#Everest Core Branch 4171 Crash on Startup