Update Solo Corp to 2024 methods

[idle osprey]

As the video, corp solo is now 8-12 kills/h rather than the current 6-7 kills/h on the bot

https://youtu.be/b3Q0YrQqupY?si=H6XS5Opg9iLMg9lF

[sacred oracle]

Did this get updated ? 😮

[wet jasper]

nop

not afaik

[polar tusk]

needs one fr

[honest tulip]

would just adding boosts for those items be acceptable, even though it's a completely different method?

idk if adding another method just for corp makes sense, but it would probably be confusing if the bot simply checked for all these reqs to decide if it will spec corp down to a big chicken or use this method with food/blood fury

[idle osprey]

Idk I guess as long as the k/h is roughly similar it might not matter

[honest tulip]

so just buff it without adding food/blood fury usage?

[wet jasper]

probably ye

[honest tulip]

if people agree on that, it seems really easy to code, I can take a look after I'm done with the fishing rework

[idle osprey]

Fishing rework 👀
Would you add more boost items and consume food/charges or just boosts?

[honest tulip]

whatever people want, as long as magna agrees on

The problem here is that the old method doesn't use food, so we have 3 options:
1️⃣ just buff corp, adding boosts without the food/charges usage
2️⃣ add food/charges usage alongside all the boosts (this would be a nerf to people without good gear tho)
3️⃣ either add a new method to /k specifically for corp, or an invisible check for all the gear/stats/food/charges and use the method in the vid if those are satisfied, or the old slower one otherwise

personally, I think 3️⃣ makes more sense but would be harder to code, 1️⃣ I could probably code in under an hour lol whenver I get some free time

[idle osprey]

You didn't leak the fishing rework sir

[honest tulip]

I coded it to work exactly like in osrs, so I could add tick manip methods

and the skill just doesn't make sense the way it works rn, a lot of random nonsense lol

[idle osprey]

Yes current barb xp rates are in between full afk and 3t which is odd

[honest tulip]

yeah barb with my code is around 63k normal banking with barrel and 110k 3t powerfishing at lvl 99, so this is gonna be a nerf for leaping fish collectors

[honest tulip]

thoughts?

around 10 kph, idk why info doesn't show boosts for equipped gear on total boosts

blood fury gives a boost but doesn't use charges

added boosts up to the 2nd recommended items in the vid, but very small ones if not bis, with bigger boosts for the most important items that make the method possible imo

[pliant kelp]

If you use a charged item it should use charges

Also can probably group together the sufferings (and maybe pools?) With similar items to reduce clutter a bit

[idle osprey]

@midnight matrix

[midnight matrix]

Nice!

looks alot better than it currently is

[honest tulip]

You mean only give the boost for either suffering or another item?

[honest tulip]

Yeah, people didn't want charges to get used, but I think it makes sense, you can use them for a bigger boost or just use a normal fury for a smaller one, think everyone would accept that right?

I'll look into it later and compare kph without it

[pliant kelp]

i mean to use the similarItems in the bot, so you can just have suffering (i) then add (ri) as a similar item in https://github.com/oldschoolgg/oldschoolbot/blob/master/src/lib/data/similarItems.ts

obviously if you ask people if they want the boost for free, they will say yes...

[honest tulip]

Wasn't aware this existed, ty

[honest tulip]

how about this? only kept boosts for bis, pools not items so couldn't group them with that command, but they were already coded this way anyway

still 10 kph, blood fury uses 80 charges per kill

~9.2kph without the blood fury

[pliant kelp]

still slightly odd that the pools boost even though they aren't used in the method, but guess it doesn't really matter as everyone on the bot is likely to have them anyway

don't suppose you could fix the spacing with the commas while you're at it haha

[honest tulip]

I thought the same, but if I wanted to change that, I'd have to add a check for the method used, which like I said makes more sense imo, but literally no one voted for that option, and people who have the reqs for the method most likely have the pool anyway, so this way is just simpler

[honest tulip]

that bothered me too but idk where that is handled

whie I'm at it I could add boosts for other npcs tho, Scurrius comes to mind because it's 170k xp/hr in osrs and only 84k here

anything else that's absurdly far off?

[pliant kelp]

it would be a space missing when all the boost messages are joined together

https://github.com/oldschoolgg/oldschoolbot/blob/84d04b00a540f930e3617c92a55c85a7f5319207/src/mahoji/lib/abstracted_commands/minionKill.ts#L1150

you can see it's correct for owned boosts, but not available boosts

[honest tulip]

which file is that?

[pliant kelp]

what i linked

[honest tulip]

oh my brain just ignored the link above lmao

yeah I can change it

[honest tulip]

now we wait
https://github.com/oldschoolgg/oldschoolbot/pull/6011

[idle osprey]

While we wait you fix fishing?

[honest tulip]

Both already finished, we wait til magna reviews them

[idle osprey]

How good

[sturdy gull]

F I S H I N G R E W O R K

[twilit cargo]

Someone did or worked on it already.

[sturdy gull]

Ty fuhsar

But also we can we buy chaos rune packs