Getting feedback on my code quality | Together C & C++ | Page 1

hallow lindenBOT Dec 11, 2025, 3:57 PM

#

When your question is answered use !solved or the button below to mark the question as resolved.

Remember to ask specific questions, provide necessary details, and reduce your question to its simplest form. For tips on how to ask a good question use !howto ask.

rough quarry Dec 11, 2025, 3:58 PM

#

the project is https://github.com/ryanssenn/torchless

cosmic mural Dec 11, 2025, 4:54 PM

#

Better suited for #1078717238678409369

#

One thing I noticed is you consistently take nlohmann::json parameters as non-const references but only use it to read from an index. Is this a library you don't control? If not, consider adding a const indexer

#

Types can have const and non-const variants of the same member function or operator without ambiguity. The const variant will simply take priority when the object is const.

hallow lindenBOT Dec 12, 2025, 7:20 AM

#

hallow linden

Thank you and let us know if you have any more questions!

This thread is now set to auto-hide after an hour of inactivity

#Getting feedback on my code quality