Command Line Shell

[west scaffold]

https://github.com/better-ecosystem/better-shell see README.md for basic information. Some of my "friends" says the codebase is quite readable however, their opinion are quite untrustworthy according to me...

[agile tusk]

Better than other "rust" alternatives

[iron path]

Well done .
Here are some suggestion:

• write the full name of the identifier like (get_previous_commad instead of get_prev) to make your code descriptive
• Don't use prefix "m_" with data members , instead you can use "this" pointer to indicate that this is class data member
• finally read clean code book for Uncle Bob to enhance your code readability

but in general it's very good.

[austere sluice]

m_ need to show that is private most of times

underscore i mean

at the end

[iron path]

Even if it's as you say , what's the wisdom of using it?

"You also don't need to prefix member variables with m_ anymore. Your classes and functions should be small enough that you don't need them."

From clean code book

[wicked crown]

I would agree with not using Hungarian notation, or a subset of it for members.

I personally wouldn't use anything for members and in the case there's a clash, I'd do this->field = field as an example.

[west scaffold]

some clean code book also says goto is the bane of all evil

[pure spear]

based

dont read clean code

[austere sluice]

clean code book is bad anyway

[iron path]

Why?

[austere sluice]

because by java dev

[iron path]

But the logic is the same and also Java is from C family

[west scaffold]

every language nowadays is from the C family

[iron path]

Anyway That reason mentioned above isn't logical to hate the greatest clean book