Memory Allocation Issue

[tall crane]

When your question is answered use !solved to mark the question as resolved.

Remember to ask specific questions, provide necessary details, and reduce your question to its simplest form. For tips on how to ask a good question use !howto ask.

[sweet blaze]

Code please

[tough whale]

The problem is that you are declaring MOVIE_SIZE_LIST to be 32, but only have 8 movies defined, so in MovieTicketMaster::Init(), you are trying to access movie_name_list[8], which fails since there are only 8 strings in the array

Also, you're directly dereferencing a null pointer on line 240, though that is after the error above, so you haven't run into that yet

[tight fox]

but is that not wat this asks

[tough whale]

The problem is that you're looping with the assumption of having enough movies, you should only be looping up to kSize, and setting the rest to empty strings/0 instead of trying to access

[tight fox]

can u point out the line please

[tough whale]

    Movie* p_movie = nullptr;
    for(int i = 0; i < MOVIE_LIST_SIZE; i++){
        if(p_movie->get_movie_name() ==  movie)

Weird, for me that's line 238-240

[tight fox]

is that not me setting it as a nullptr?

[tough whale]

Yes, but look at the last line, without modifying p_movie, you're accessing it; or trying to at least

[tight fox]

so should add && p_movie != nullptr

but as the first condition

so p_movie != nullptr && p_movie->get_movie_name() == movie

[tough whale]

Then you still get a similar error, since nullptr++ is likely not where the first movie is located, it should be something like p_movie = movie_list, to get the first movie in the list, and loop from there

[tight fox]

what if i chnaged it to

Movie* p_movie = movie_list[0];
for(int i = 0; i < MOVIE_LIST_SIZE; i++){
if(p_movie->get_movie_name() == movie)

[tight fox]

so are u saying i have 2 for loops one ending at k size, and other going from kzsize to 32, also if so whats the point of making it 32 if i only ever need 8?

[tough whale]

Yes

Also, I think it might be better for you to go through the debugging yourself, and try to understand what is going wrong: https://onlinegdb.com/I576rG4lF (An online debugger, not the greatest, but sharable) - That way you can directly interact with your code, and see how it works behind the scenes

[tight fox]

sorry if im asking dumb questions im p new

[tough whale]

No problem, that's why I'm suggesting the debugger, since these are pretty easy to solve, and it makes more sense as to why if you see the code in action

Or at least that is how it was for me

[tight fox]

does this make sense?

[tough whale]

Not quite, movie_list[0] gives a Movie, not a Movie *

[tight fox]

sorry i meant & movie_list[0]

[tough whale]

Just FYI, &movie_list[0] == movie_list for c-style arrays (can save you some typing)

[tight fox]

whats the point of index 8-31?

[tight fox]

oh thanks

[tough whale]

No clue, it's your assignment - likely to add some padding?

Or possibly to see how you solve the issue

[tight fox]

he never says

[tall crane]

@tight fox Has your question been resolved? If so, type !solved :)

[tight fox]

!solved

[tall crane]

Thank you and let us know if you have any more questions!

This thread is now set to auto-hide after an hour of inactivity