why are some commands not yellow? | Together C & C++ | Page 1

plain dawnBOT Apr 1, 2024, 5:46 AM

#

When your question is answered use !solved to mark the question as resolved.

Remember to ask specific questions, provide necessary details, and reduce your question to its simplest form. For tips on how to ask a good question use !howto ask.

#

@coral nova

Screenshots!

Your message appears to contain screenshots but no code. Please send code and error messages in text instead of screenshots if applicable!

finite pond Apr 1, 2024, 5:48 AM

#

Do yourself a favor and make a function that can take a vector or array as a parameter, and flip the visibility of each item

#

Then you can reduce all of that down to like two lines of code

coral nova Apr 1, 2024, 5:49 AM

#

that is a very good hint. i will we write the code to loops

finite pond Apr 1, 2024, 5:50 AM

#

Do any of those functions work or does it have the same error for all of them?

coral nova Apr 1, 2024, 5:53 AM

#

no its just this part:
the OnClick code goes like this:

if (Defense.isMouseOver(window) && Defense.onlcick_name == "Defense") {
WallSmallMk1.setVisibility(!WallSmallMk1);
WallSmallMk2.setVisibility(!WallSmallMk2);
WallSmallMk3.setVisibility(!WallSmallMk3);
WallSmallMk4.setVisibility(!WallSmallMk4);
WallSmallMk5.setVisibility(!WallSmallMk5);
. . .
}

all functions work but in this case i have a problem

finite pond Apr 1, 2024, 5:55 AM

#

Are all of these objects of the same type or no?

#

And if they're different, do all of these objects have the .setVisibility() method in their class?

coral nova Apr 1, 2024, 5:56 AM

#

yess

i solved the problem btw. in the create object file was "TurretSingleMK1" that causes the problem that "Turret Mk1" doestn exist

finite pond Apr 1, 2024, 5:57 AM

#

Ah I see, nice

coral nova Apr 1, 2024, 5:57 AM

#

finite pond Do yourself a favor and make a function that can take a vector or array as a par...

can you help me to set up loops ?

finite pond Apr 1, 2024, 5:57 AM

#

I can give you an idea of what it might look like, sure

coral nova Apr 1, 2024, 5:58 AM

#

Thx

finite pond Apr 1, 2024, 5:59 AM

#

void invertVisibility(std::vector<type> &vector) {
  for (auto &item : vector) {
    item.setVisibility(!item);
  }
}

#

Something like that

#

where type is the object type

#

And then you make a vector of the objects you want to flip, call that function, and pass it in

coral nova Apr 1, 2024, 6:01 AM

#

Ok i will try

#

Ok now i have to code a loop which creates the button ....
Thats easy ...
i think

coral nova Apr 1, 2024, 6:17 AM

#

finite pond ``` void invertVisibility(std::vector<type> &vector) { for (auto &item : vecto...

Can you please help me to set up the hole script ?
I have many button which includes "Mk". I want a loop which creates all btns which have "Mk" in it.

There are 5 type: Mk1, Mk2, Mk3, Mk4

There are different objects: Wall, Gate, Turret, ....
I want to build a loop which constucs all the diferent btn objects and types. My provlem is that i dont know how to begin

finite pond Apr 1, 2024, 6:24 AM

#

I would just create those manually, unless you need to create hundreds for example. If that's the case there's probably a better way to do it

#

But for now just create them manually, add them all to a vector (you can use std::push_back(), google if it need be), and then pass that vector into the function

#

If I do all the work for you you wouldn't learn anything, I would implore you to do what you can on your own and give it a try, and then ask again if you run into issues 🙂

coral nova Apr 1, 2024, 6:26 AM

#

so you say that a loop which creates all the Mk versionen of the objects is stupid ?

#

I dont know whats incorrect here:

finite pond Apr 1, 2024, 6:46 AM

#

What does the error say?

#

I'll give you a hint, check the type of the vector compared to the type of the object you're trying to insert into it

coral nova Apr 1, 2024, 6:53 AM

#

This declaration has no storage class or type specifier.

#

i dont know which type my buttons are. think they are object class element or something like that. but i dont know hot to setup the vector correctly

fierce gyro Apr 1, 2024, 6:55 AM

#

coral nova This declaration has no storage class or type specifier.

You are trying to put a Button in a std::vector<std::string>, where std::string is the data type that the vector should hold

fierce gyro Apr 1, 2024, 6:56 AM

#

coral nova i dont know which type my buttons are. think they are object class element or so...

The Button WallSmallMk1 = … means that the type of the variables is Button (wherever that’s defined)

coral nova Apr 1, 2024, 6:57 AM

#

so it should be like:

std::vector<Button> buildDefense;

#

but the error is still there

finite pond Apr 1, 2024, 6:58 AM

#

Yes

#

What is the error now?

coral nova Apr 1, 2024, 6:58 AM

#

This declaration has no storage class or type specifier.

#

thats the error when I hover "buildDefense.push_back()"

tiny storm Apr 1, 2024, 6:59 AM

#

coral nova thats the error when I hover "buildDefense.push_back()"

Can you post the line verbatim

coral nova Apr 1, 2024, 7:00 AM

#

std::vector<Button> buildDefense;

Button WallSmallMk1 = Button("WallSmallMk1", "WallSmallMk1", 440, 25, 120, 25, "Wall Small Mk1", 15, false, wallsmallmk1Color);
Button WallSmallMk2 = Button("WallSmallMk2", "WallSmallMk2", 440, 50, 120, 25, "Wall Small Mk2", 15, false, wallsmallmk2Color);
Button WallSmallMk3 = Button("WallSmallMk3", "WallSmallMk3", 440, 75, 120, 25, "Wall Small Mk3", 15, false, wallsmallmk3Color);
Button WallSmallMk4 = Button("WallSmallMk4", "WallSmallMk4", 440, 100, 120, 25, "Wall Small Mk4", 15, false, wallsmallmk4Color);
Button WallSmallMk5 = Button("WallSmallMk5", "WallSmallMk5", 440, 125, 120, 25, "Wall Small MK5", 15, false, wallsmallmk5Color);
buildDefense.push_back(WallSmallMk1);

#

============
Like that ?

fierce gyro Apr 1, 2024, 7:01 AM

#

coral nova std::vector<Button> buildDefense; Button WallSmallMk1 = Button("WallSmallMk...

!f

plain dawnBOT Apr 1, 2024, 7:01 AM

#

fierce gyro !f

Nothing to format

fierce gyro Apr 1, 2024, 7:01 AM

#

    std::vector<Button> buildDefense;

    Button WallSmallMk1 = Button("WallSmallMk1", "WallSmallMk1", 440, 25, 120, 25, "Wall Small Mk1", 15, false, wallsmallmk1Color);
    Button WallSmallMk2 = Button("WallSmallMk2", "WallSmallMk2", 440, 50, 120, 25, "Wall Small Mk2", 15, false, wallsmallmk2Color);
    Button WallSmallMk3 = Button("WallSmallMk3", "WallSmallMk3", 440, 75, 120, 25, "Wall Small Mk3", 15, false, wallsmallmk3Color);
    Button WallSmallMk4 = Button("WallSmallMk4", "WallSmallMk4", 440, 100, 120, 25, "Wall Small Mk4", 15, false, wallsmallmk4Color);
    Button WallSmallMk5 = Button("WallSmallMk5", "WallSmallMk5", 440, 125, 120, 25, "Wall Small MK5", 15, false, wallsmallmk5Color);
    buildDefense.push_back(WallSmallMk1);

#

You likely have the copy constructor deleted for Button, and .push_back performs a copy, which will fail if the copy constructor is deleted.

What you likely need is .emplace (even if it makes error messages somewhat gnarly if used incorrectly):

    std::vector<Button> buildDefense;

    buildDefense.emplace("WallSmallMk1", "WallSmallMk1", 440, 25, 120, 25, "Wall Small Mk1", 15, false, wallsmallmk1Color);
    buildDefense.emplace("WallSmallMk2", "WallSmallMk2", 440, 50, 120, 25, "Wall Small Mk2", 15, false, wallsmallmk2Color);
    buildDefense.emplace("WallSmallMk3", "WallSmallMk3", 440, 75, 120, 25, "Wall Small Mk3", 15, false, wallsmallmk3Color);
    buildDefense.emplace("WallSmallMk4", "WallSmallMk4", 440, 100, 120, 25, "Wall Small Mk4", 15, false, wallsmallmk4Color);
    buildDefense.emplace("WallSmallMk5", "WallSmallMk5", 440, 125, 120, 25, "Wall Small MK5", 15, false, wallsmallmk5Color);

coral nova Apr 1, 2024, 7:06 AM

#

the error still exists

#

i tried:

buildDefense.emplace(WallSmallMk1);

fierce gyro Apr 1, 2024, 7:08 AM

#

coral nova the error still exists

I just realized you need .emplace_back, emplace needs an additional "where" parameter.

#

So the code would actually be:

    std::vector<Button> buildDefense;

    buildDefense.emplace_back("WallSmallMk1", "WallSmallMk1", 440, 25, 120, 25, "Wall Small Mk1", 15, false, wallsmallmk1Color);
    buildDefense.emplace_back("WallSmallMk2", "WallSmallMk2", 440, 50, 120, 25, "Wall Small Mk2", 15, false, wallsmallmk2Color);
    buildDefense.emplace_back("WallSmallMk3", "WallSmallMk3", 440, 75, 120, 25, "Wall Small Mk3", 15, false, wallsmallmk3Color);
    buildDefense.emplace_back("WallSmallMk4", "WallSmallMk4", 440, 100, 120, 25, "Wall Small Mk4", 15, false, wallsmallmk4Color);
    buildDefense.emplace_back("WallSmallMk5", "WallSmallMk5", 440, 125, 120, 25, "Wall Small MK5", 15, false, wallsmallmk5Color);

#

;compile cpp

#include <string>
#include <vector>

class Button {
public:
    Button(std::string a, std::string b, int c, int d, int e, int f, std::string g, int h, bool i) {};
};

int main(){
        std::vector<Button> buildDefense;

    buildDefense.emplace_back("WallSmallMk1", "WallSmallMk1", 440, 25, 120, 25, "Wall Small Mk1", 15, false);
    buildDefense.emplace_back("WallSmallMk2", "WallSmallMk2", 440, 50, 120, 25, "Wall Small Mk2", 15, false);
    buildDefense.emplace_back("WallSmallMk3", "WallSmallMk3", 440, 75, 120, 25, "Wall Small Mk3", 15, false);
    buildDefense.emplace_back("WallSmallMk4", "WallSmallMk4", 440, 100, 120, 25, "Wall Small Mk4", 15, false);
    buildDefense.emplace_back("WallSmallMk5", "WallSmallMk5", 440, 125, 120, 25, "Wall Small MK5", 15, false);
}

serene boughBOT Apr 1, 2024, 7:10 AM

#

Compilation successful

No output.

coral nova Apr 1, 2024, 7:10 AM

#

I tried this code lines. but even with .emplace_back the error is here

#

"This declaration has no storage class or type specifier."

there is something wrong with the vector definition

fierce gyro Apr 1, 2024, 7:12 AM

#

coral nova "This declaration has no storage class or type specifier." there is something w...

Did you add #include <vector> at the begining of the file?

coral nova Apr 1, 2024, 7:12 AM

#

yes

fierce gyro Apr 1, 2024, 7:18 AM

#

Then your Button's move constructor is likely deleted as well, which means that you need to use pointers, I would strongly suggest smart pointers, like std::unique_ptr:

#include <string>
#include <vector>
#include <memory>

class Button {
public:
    Button(std::string a, std::string b, int c, int d, int e, int f, std::string g, int h, bool i) {};

    // Delete the copy constructors, to make this behave as the OG Button likely does
    Button (const Button&) = delete;
    Button& operator= (const Button&) = delete;
};

int main(){
    std::vector<std::unique_ptr<Button>> buildDefense;

    buildDefense.emplace_back(std::make_unique<Button>("WallSmallMk1", "WallSmallMk1", 440, 25, 120, 25, "Wall Small Mk1", 15, false));
    buildDefense.emplace_back(std::make_unique<Button>("WallSmallMk2", "WallSmallMk2", 440, 50, 120, 25, "Wall Small Mk2", 15, false));
    buildDefense.emplace_back(std::make_unique<Button>("WallSmallMk3", "WallSmallMk3", 440, 75, 120, 25, "Wall Small Mk3", 15, false));
    buildDefense.emplace_back(std::make_unique<Button>("WallSmallMk4", "WallSmallMk4", 440, 100, 120, 25, "Wall Small Mk4", 15, false));
    buildDefense.emplace_back(std::make_unique<Button>("WallSmallMk5", "WallSmallMk5", 440, 125, 120, 25, "Wall Small MK5", 15, false));
}

fierce gyro Apr 1, 2024, 7:19 AM

#

fierce gyro Then your Button's move constructor is likely deleted as well, which means that ...

;compile

serene boughBOT Apr 1, 2024, 7:19 AM

#

Compilation successful

No output.

coral nova Apr 1, 2024, 7:20 AM

#

im unsure how to change the class "Button" to use this methode

fierce gyro Apr 1, 2024, 7:21 AM

#

coral nova im unsure how to change the class "Button" to use this methode

You wouldn't need to change Button, I just changed my defenition to delete the copy and move constructors, and make it more in-line with what you are seeing in your Button.

#

The std::unique_ptr handles the copy/move as only it is moved, not the Button it's pointing to

std::vector has a limitation that it needs to move objects in the underlying array if it runs out of space, thus a move constructor is needed

coral nova Apr 1, 2024, 7:25 AM

#

i chnage to line to:
std::vector<std::unique_ptr<Button>> buildDefense;

nothing changed at the "buildDefense.emplace_back" but the error ist thill there. I also wrote "#include<memory>"

fierce gyro Apr 1, 2024, 7:26 AM

#

The easiest way to construct std::unique_ptr is to call the std::make_unique function, as I did in the emplace_back (in case you overlooked that, since it is in the midst of the code)

coral nova Apr 1, 2024, 7:30 AM

#

fierce gyro Then your Button's move constructor is likely deleted as well, which means that ...

i copied your sctipt lines into my file. but that doesnt change the error message

fierce gyro Apr 1, 2024, 7:30 AM

#

Can you try running a full compile, in case you aren't, since sometimes IDEs cache error messages

coral nova Apr 1, 2024, 7:36 AM

#

done

#

i also read the error messages

#

it seems that the compiler tries to convert "Button" into a bool

#

that one of the error

fierce gyro Apr 1, 2024, 7:43 AM

#

You probably need to share some more code in that case, since it seems that is rather weird behavior for the compiler to attempt

#

Also, what gui library are you using?

coral nova Apr 1, 2024, 7:46 AM

#

SFML

#

currently im trying to correct the errors from the default code:
in this case i dont youse a vector to storage al the components.
With this setting I only have one error:
"onclick_name" is not part of the obj.

when the compiling of this methode works and the .exe file starts without any problems then i will go back and try to include the vertors

#

no way, the compiling was succssesful

#

but the .exe file closes itselfe after starting it

#

when the programm works without any problems, i will trie to include the vectors 🙂

coral nova Apr 1, 2024, 7:57 AM

#

coral nova but the .exe file closes itselfe after starting it

how do i fix this problem ?

fierce gyro Apr 1, 2024, 7:58 AM

#

coral nova how do i fix this problem ?

There are a thousand reasons it could be,
Did you run it from the command line (in case an error code like segfault)?

coral nova Apr 1, 2024, 7:59 AM

#

no, i double cliked the exe file

fierce gyro Apr 1, 2024, 7:59 AM

#

Try running from CMD/Powershell, since that gives you an error message when your program exits with a fault

coral nova Apr 1, 2024, 8:01 AM

#

what the cmd command to run a exe file ?

fierce gyro Apr 1, 2024, 8:01 AM

#

coral nova what the cmd command to run a exe file ?

.\<relative path to exe>

coral nova Apr 1, 2024, 8:01 AM

#

i did already

fierce gyro Apr 1, 2024, 8:02 AM

#

Also I just noticed, since you're in VS, you can run using the Run/Debug button, this gives even better error info, since you can step through using the debugger

coral nova Apr 1, 2024, 8:08 AM

#

done

#

I will copy the errors: cause i dont know what the errors mean:

1>ConsoleApplication1.obj : error LNK2019: Reference to unresolved external symbol ""__declspec(dllimport) public: __cdecl sf::Font::~Font(void)" (_imp??1Font@sf@@QEAA@XZ)" in function ""public: __cdecl Window::~Window(void)" (??1Window@@QEAA@XZ)".
1>ConsoleApplication1.obj : error LNK2019: Reference to unresolved external symbol ""__declspec(dllimport) public: virtual __cdecl sf::RenderWindow::~RenderWindow(void)" (_imp??1RenderWindow@sf@@UEAA@XZ)" in function ""public: __cdecl Window::~Window(void)" (??1Window@@QEAA@XZ)".
1>ConsoleApplication1.obj : error LNK2019: Reference to unresolved external symbol ""public: __cdecl Window::Window(void)" (??0Window@@QEAA@XZ)" in function "main".
1>ConsoleApplication1.obj : error LNK2019: Reference to unresolved external symbol ""public: void __cdecl Window::create_objects(void)" (?create_objects@Window@@QEAAXXZ)" in function "main".
1>C:\Users\UsersIn\Documents\Visual Studio 2022\Projects\ConsoleApp1\ConsoleApplication1\x64\Debug\ConsoleApplication1.exe : fatal error LNK1120: 4 unresolved externals
1>The creation of the project "ConsoleApplication1.vcxproj" is complete -- ERROR.
========== Build: 0 successful, 1 error, 0 current, 0 skipped ==========
========== Build completed at 10:06 and took 02:52,846 minutes ==========

fierce gyro Apr 1, 2024, 8:10 AM

#

You likely forgot to add the dll for it to link to (which includes SFML)

mystic compass Apr 1, 2024, 8:12 AM

#

@coral nova did you try turning off your pc

coral nova Apr 1, 2024, 8:12 AM

#

no

mystic compass Apr 1, 2024, 8:12 AM

#

Then look no further

fierce gyro Apr 1, 2024, 8:13 AM

#

Also, since I have to go, if it's still not running:

Run in VS (this will give you the option of both step-through using the breakpoints, as well as auto-stop when an error such as segfaults happens)
Check if your exit condition is faulty, which would make the program exit (correctly for the computer, erroneously for your interpretation)

coral nova Apr 1, 2024, 8:14 AM

#

fierce gyro You likely forgot to add the dll for it to link to (which includes SFML)

how do I dow that ?

mystic compass Apr 1, 2024, 8:14 AM

#

Also I see you’re using visual studio as your IDE I would recommend switching to Repl.it to get the full coding experience

fierce gyro Apr 1, 2024, 8:15 AM

#

coral nova how do I dow that ?

You can follow the SFML docs: https://www.sfml-dev.org/tutorials/2.6/start-vc.php

coral nova Apr 1, 2024, 8:15 AM

#

i dont want to. setting vs up ind include cmake was very confusing

#

if you mean that I should add SFMl to the environment variables of windows, then I already did that the day before yesterday

fierce gyro Apr 1, 2024, 8:19 AM

#

If you're using the templates/cmake, this should be done automatically, and the built libraries are under build/_deps/SFML-build/library

fierce gyro Apr 1, 2024, 8:20 AM

#

coral nova if you mean that I should add SFMl to the environment variables of windows, then...

The main point is to add it to the Additional Library Directories, which it links to (the step that's currently failing for you)

coral nova Apr 1, 2024, 8:20 AM

#

and i set this in the CMakeLists.txt file, right?

fierce gyro Apr 1, 2024, 8:21 AM

#

coral nova and i set this in the CMakeLists.txt file, right?

Usually yes, though it's apparently failing to find the symbols, so there may be something wrong with how you linked it

mystic compass Apr 1, 2024, 8:22 AM

#

Did you try adding this line in your cmake ?

#

Shoot wrong image

coral nova Apr 1, 2024, 8:24 AM

#

fierce gyro Usually yes, though it's apparently failing to find the symbols, so there may be...

i dont see a mistake in the CMakeLists.txt

fierce gyro Apr 1, 2024, 8:26 AM

#

Well, it's not finding the symbols, you can scroll through https://learn.microsoft.com/en-us/cpp/error-messages/tool-errors/linker-tools-error-lnk2019?view=msvc-170 to get a comprehensive list of possible causes, though it's likely you have an error in the cmake, or you are using the wrong paths to link

Linker Tools Error LNK2019

All about the Microsoft Visual Studio Linker error LNK2019 and how to diagnose and correct it in C and C++ code.

mystic compass Apr 1, 2024, 8:27 AM

#

Sorry I didn’t realize roles where switched up I thought you were trolling since I saw you were an expert 😭😭

coral nova Apr 1, 2024, 8:46 AM

#

i need a break from coding O.o

coral nova Apr 1, 2024, 12:38 PM

#

!solved

plain dawnBOT Apr 1, 2024, 12:38 PM

#

Thank you and let us know if you have any more questions!

This thread is now set to auto-hide after an hour of inactivity

#why are some commands not yellow?