Can't verify adjacent blocks to the actual one. | Together C & C++ | Page 2

reef crow Nov 30, 2023, 10:52 PM

#

All my files are in my cmake

regal monolith Nov 30, 2023, 10:52 PM

#

is largestPlayerSquare a global, and what are the files called you are trying to use it in?

reef crow Nov 30, 2023, 10:53 PM

#


int Game::getLargestSquareOfPlayer(int playerId) {
    int largestSize = 0;
    for(int i = 0; i < grid.numRows; i++) {
        for(int j = 0; j < grid.numCols; j++) {
            if(grid.grid[i][j] == playerId) {
                int size = getSquare(i, j);
                if(size > largestSize) {
                    largestSize = size;
                }
            }
        }
    }
    return largestSize;
}

int Game::getSquare(int topLeftX, int topLeftY) {
    int squareSize = 0;
    while(true){
        for(int i = topLeftX; i < grid.numCols && i < topLeftX + squareSize; i++) {
            if(grid.grid[topLeftY + squareSize][i] != playerId) {
                return squareSize;
            }
        }
        for(int j = topLeftY; j < grid.numRows && j < topLeftY + squareSize + 1; j++) {
            if(grid.grid[j][topLeftX + squareSize] != playerId) {
                return squareSize;
            }
        }
        squareSize ++;
    }
}

std::pair<int, int> Game::playerWithLargestSquare(){
    largestPlayerSquare = 0;
    playerId = 1;
    while(playerId <= numberOfPlayers) {
        int size = getLargestSquareOfPlayer(playerId);
        if(size > largestPlayerSquare) {
            largestPlayerSquare = size;
        }
        playerId += 1;
    }

    return std::pair{playerId, largestPlayerSquare};
}

my globals :

#pragma once

extern int numberOfPlayers;
extern int currentPlayer;
extern int screen;
extern int turn;
extern int playerId;
extern int largestPlayerSquare;

regal monolith Nov 30, 2023, 10:54 PM

#

okay, well where is largestPlayerSquare actually defined though? I think you may have forgot to add int largestPlayerSquare; in a cpp file

#

extern int largestPlayerSquare; just declares it, so says it exists but doesn't actually create it

#

I am pretty sure you don't need it to be a global anymore if these are the only two spots you had it, so just remove extern int largestPlayerSquare; and add int in front of largestPlayerSquare = 0; in Game::playerWithLargestSquare()

reef crow Nov 30, 2023, 11:03 PM

#

I should do the same with playerId ?

regal monolith Nov 30, 2023, 11:03 PM

#

yeah, fuck the global and make it local in the function

reef crow Nov 30, 2023, 11:04 PM

#

if I do that with playerId I have warnings in my other functions

#

undeclared identifier

regal monolith Nov 30, 2023, 11:04 PM

#

show the code and the error

reef crow Nov 30, 2023, 11:06 PM

#

regal monolith Nov 30, 2023, 11:06 PM

#

yeah so it's supposed to be an argument to the function

reef crow Nov 30, 2023, 11:08 PM

#

reef crow ```cpp int Game::getLargestSquareOfPlayer(int playerId) { int largestSize =...

So here in the first function where int size = getSquare(i, j) I should add playerId ?

regal monolith Nov 30, 2023, 11:08 PM

#

yup

reef crow Nov 30, 2023, 11:12 PM

#

so now it works but the values are not good xD

regal monolith Nov 30, 2023, 11:13 PM

#

lol, show

reef crow Nov 30, 2023, 11:14 PM

#

Normally light green won (player 1) with 4x4 but just before it said me that a player with 4x4 square won with a 2x2 square

regal monolith Nov 30, 2023, 11:14 PM

#

ok yeah I think I see the issue

regal monolith Nov 30, 2023, 11:15 PM

#

reef crow

so you know how the squareSize++ keeps incrementing it on and on right, in an infinite while-loop?

#

right now if either the bottom or right edge of the map is passed, the for-loop's condition will stop the loop, right?

reef crow Nov 30, 2023, 11:16 PM

#

yep

regal monolith Nov 30, 2023, 11:17 PM

#

the issue is that if the bottom or right edge of the map is passed, you don't want to just break the loop, but actually immediately return the squareSize, cause otherwise you're just going to continue incrementing squareSize and doing wrong shenanigans

#

see if you get that by looking at the code

reef crow Nov 30, 2023, 11:19 PM

#

it's in the if condition

#

I think

regal monolith Nov 30, 2023, 11:19 PM

#

wdym exactly with "it's"?

reef crow Nov 30, 2023, 11:19 PM

#

the condition we need

#

must be in the "if"

regal monolith Nov 30, 2023, 11:19 PM

#

yes!

#

so just move it to be inside of the if, so using the OR statement || to say that in either case you want to return

reef crow Nov 30, 2023, 11:20 PM

#

and the condition is x < grid.numCols ?

regal monolith Nov 30, 2023, 11:22 PM

#

the for-loop's job is to just increment x squareSize times, so that's the only thing you want in the for-loop's condition

reef crow Nov 30, 2023, 11:22 PM

#

so what should I put in the if ?

regal monolith Nov 30, 2023, 11:22 PM

#

what are you guessing

reef crow Nov 30, 2023, 11:22 PM

#

for me it was x < grid.numCols

regal monolith Nov 30, 2023, 11:22 PM

#

yes

#

so || x < grid.numCols in the if

#

but reversed of course, so || x >= grid.numCols

#

or just || x == grid.numCols

reef crow Nov 30, 2023, 11:24 PM

#

I'll try now

#

...

#

#

Number 3(red) has to win with a 4x4 square

regal monolith Nov 30, 2023, 11:26 PM

#

show the code again

reef crow Nov 30, 2023, 11:27 PM

#

int Game::getLargestSquareOfPlayer(int playerId) {
    int largestSize = 0;
    for(int i = 0; i < grid.numRows; i++) {
        for(int j = 0; j < grid.numCols; j++) {
            if(grid.grid[i][j] == playerId) {
                int size = getSquare(i, j, playerId);
                if(size > largestSize) {
                    largestSize = size;
                }
            }
        }
    }
    return largestSize;
}

int Game::getSquare(int topLeftX, int topLeftY, int playerId) {
    int squareSize = 0;
    while(true){
        for(int i = topLeftX; i < topLeftX + squareSize; i++) {
            if(grid.grid[topLeftY + squareSize][i] != playerId || i == grid.numCols) {
                return squareSize;
            }
        }
        for(int j = topLeftY;  j < topLeftY + squareSize + 1; j++) {
            if(grid.grid[j][topLeftX + squareSize] != playerId || j == grid.numRows ) {
                return squareSize;
            }
        }
        squareSize ++;
    }
}

std::pair<int, int> Game::playerWithLargestSquare(){
    int largestPlayerSquare = 0;
    int playerId = 1;
    while(playerId <= numberOfPlayers) {
        int size = getLargestSquareOfPlayer(playerId);
        if(size > largestPlayerSquare) {
            largestPlayerSquare = size;
        }
        playerId += 1;
    }

    return std::pair{playerId, largestPlayerSquare};
}

regal monolith Nov 30, 2023, 11:27 PM

#

thanks

reef crow Nov 30, 2023, 11:27 PM

#

np

regal monolith Nov 30, 2023, 11:28 PM

#

hmm, it could be because grid.grid[topLeftY + squareSize][i] != playerId || i == grid.numCols will actually try to read out of bounds memory in the left check before it even realizes that it's out of bounds with the right check

#

so reverse the order of checks here

#

reading out of bounds can make demons fly out of your nose, don't do it!

reef crow Nov 30, 2023, 11:30 PM

#

Okay I'll try with that

regal monolith Nov 30, 2023, 11:31 PM

#

int size = getSquare(i, j, playerId); I swear to god please change the i and j mentions to x and y cause you swapped the two because you got confused here again x)

reef crow Nov 30, 2023, 11:33 PM

#

So the 4x4 is good but not the player, it's like it's +2

regal monolith Nov 30, 2023, 11:33 PM

#

regal monolith `int size = getSquare(i, j, playerId);` I swear to god please change the `i` and...

this is why

reef crow Nov 30, 2023, 11:33 PM

#

regal monolith `int size = getSquare(i, j, playerId);` I swear to god please change the `i` and...

fck you saw it

regal monolith Nov 30, 2023, 11:34 PM

#

if you change it to x and y correctly everywhere you'll see the bug is fixed

reef crow Nov 30, 2023, 11:34 PM

#

but i'll have to change that in all my code, bcs every loop is like that, hopefull it's a square

regal monolith Nov 30, 2023, 11:36 PM

#

reef crow ```cpp int Game::getLargestSquareOfPlayer(int playerId) { int largestSize = ...

at the very very least change it in the functions you screenshot here

reef crow Nov 30, 2023, 11:36 PM

#

this time player 4 won with a 5x5

regal monolith Nov 30, 2023, 11:37 PM

#

regal monolith at the very very least change it in the functions you screenshot here

send the new code once you did this

reef crow Nov 30, 2023, 11:38 PM

#

int Game::getLargestSquareOfPlayer(int playerId) {
    int largestSize = 0;
    for(int x = 0; x < grid.numRows; x++) {
        for(int y = 0; y < grid.numCols; y++) {
            if(grid.grid[x][y] == playerId) {
                int size = getSquare(y, x, playerId);
                if(size > largestSize) {
                    largestSize = size;
                }
            }
        }
    }
    return largestSize;
}

int Game::getSquare(int topLeftX, int topLeftY, int playerId) {
    int squareSize = 0;
    while(true){
        for(int x = topLeftX; x < topLeftX + squareSize; x++) {
            if(x == grid.numCols || grid.grid[topLeftY + squareSize][x] != playerId) {
                return squareSize;
            }
        }
        for(int y = topLeftY;  y < topLeftY + squareSize + 1; y++) {
            if(y == grid.numRows || grid.grid[y][topLeftX + squareSize] != playerId) {
                return squareSize;
            }
        }
        squareSize ++;
    }
}

std::pair<int, int> Game::playerWithLargestSquare(){
    int largestPlayerSquare = 0;
    int playerId = 1;
    while(playerId <= numberOfPlayers) {
        int size = getLargestSquareOfPlayer(playerId);
        if(size > largestPlayerSquare) {
            largestPlayerSquare = size;
        }
        playerId += 1;
    }

    return std::pair{playerId, largestPlayerSquare};
}

regal monolith Nov 30, 2023, 11:39 PM

#

Thanks, so now it should be way clearer if I say this:

You do int size = getSquare(y, x, playerId);
Your function is int Game::getSquare(int topLeftX, int topLeftY, int playerId)

#

Look at the arguments

#

Hope you get why not doing x and y is so silly now :)

reef crow Nov 30, 2023, 11:41 PM

#

yep...

regal monolith Nov 30, 2023, 11:42 PM

#

if(grid.grid[x][y] == playerId) {

reef crow Nov 30, 2023, 11:42 PM

#

#

Yep that's strange

#

player 1 won with 4x4

regal monolith Nov 30, 2023, 11:43 PM

#

regal monolith `if(grid.grid[x][y] == playerId) {`

.

#

I think this is the third or maybe fourth i, j issue

reef crow Nov 30, 2023, 11:44 PM

#

yep...

#

but still player 5 wins even with that

#

I think that it always take the highest number of player +1

#

bcs it stops at the last playerId but I never take the playerId of the biggest square

regal monolith Nov 30, 2023, 11:46 PM

#

So you do

if(grid.grid[x][y] == playerId) {
  int size = getSquare(y, x, playerId);

which means you already know that it's at least a 1x1 square, right?

#

cause a tile is basically a 1x1 square

regal monolith Nov 30, 2023, 11:48 PM

#

reef crow bcs it stops at the last playerId but I never take the playerId of the biggest s...

I think the rest of the code is fine

reef crow Nov 30, 2023, 11:49 PM

#

solved it

regal monolith Nov 30, 2023, 11:49 PM

#

wondering whether you did it in the way I was about to suggest

#

tell me

reef crow Nov 30, 2023, 11:49 PM

#

std::pair<int, int> Game::playerWithLargestSquare(){
    int largestPlayerSquare = 0;
    int playerId = 1;
    int winner = 0;
    while(playerId <= numberOfPlayers) {
        int size = getLargestSquareOfPlayer(playerId);
        if(size > largestPlayerSquare) {
            largestPlayerSquare = size;
            winner = playerId;
        }
        playerId += 1;
    }

    return std::pair{winner, largestPlayerSquare};
}

regal monolith Nov 30, 2023, 11:50 PM

#

ahhh yeah you're completely correct, nice!!

regal monolith Nov 30, 2023, 11:50 PM

#

regal monolith So you do ```c++ if(grid.grid[x][y] == playerId) { int size = getSquare(y, x, ...

I missed that one actually, you have another issue here

#

see if you can find it with this hint

reef crow Nov 30, 2023, 11:50 PM

#

I was asking myself about this since the beginning of the code but wanted to see the result, bcs you never take the player with the largestSquare

regal monolith Nov 30, 2023, 11:51 PM

#

regal monolith So you do ```c++ if(grid.grid[x][y] == playerId) { int size = getSquare(y, x, ...

do you follow this?

reef crow Nov 30, 2023, 11:51 PM

#

I'd say to add +1's but not sure about that

regal monolith Nov 30, 2023, 11:52 PM

#

I haven't said where anything's wrong, I am just asking whether you get that you at least always expect that function to return 1, right?

reef crow Nov 30, 2023, 11:52 PM

#

yep

regal monolith Nov 30, 2023, 11:53 PM

#

okay, well look at what you actually do in the fn

#

the function getSquare(), that is

#

what variable are you returning from the fn?

reef crow Nov 30, 2023, 11:54 PM

#

squareSize

#

so we can put it at 1

regal monolith Nov 30, 2023, 11:54 PM

#

yes, it shouldn't be 0 at the start

#

this is I think the actual last bug fixed now if you change that 0 to a 1

reef crow Nov 30, 2023, 11:56 PM

#

Everything works as expected

regal monolith Nov 30, 2023, 11:56 PM

#

yooo

#

poggers

reef crow Nov 30, 2023, 11:56 PM

#

finally 😭

#

I'm so so so thankful, you can't imagine

regal monolith Nov 30, 2023, 11:56 PM

#

kekw so after a billion messages, I guess finally it's time for the holy ! solved?

reef crow Nov 30, 2023, 11:57 PM

#

I think it's time

regal monolith Nov 30, 2023, 11:58 PM

#

gl man, feel free to ping me if you ever need more help

#

and lmk what happens with the grade

reef crow Nov 30, 2023, 11:58 PM

#

I'll for sure !

#

Bye and good night ! (if it's night for you)

regal monolith Nov 30, 2023, 11:59 PM

#

it is, I'm Dutch so I think it's also 1 AM for you?

#

o/

reef crow Nov 30, 2023, 11:59 PM

#

Yep !

regal monolith Dec 1, 2023, 12:00 AM

#

Let's end it with !solved

reef crow Dec 1, 2023, 12:00 AM

#

!solved

plush walrusBOT Dec 1, 2023, 12:00 AM

#

Thank you and let us know if you have any more questions!

This thread is now set to auto-hide after an hour of inactivity

reef crow Dec 1, 2023, 12:00 AM

#

o/

regal monolith Dec 1, 2023, 12:00 AM

#

o/

#Can't verify adjacent blocks to the actual one.