Do you think this is an elegant way to write code?

[scenic quartz]

I just rewrote my engine 2 month ago. I started to use namespaces. Do you know there is a better approach for this ?

[honest badger]

What's the type of logsJson

[scenic quartz]

I store logs in json

logs contains :
date
message
where it came from

[honest badger]

nlohmann?

[scenic quartz]

yeah

[honest badger]

ah alright

[scenic quartz]

I already included nlohmann json like you mentioned

[honest badger]

Suggestion

move the using json = nlohmann::json inside your namespace

Also please always send full formatted code and not screenshots

[grand bolt]

How to Format Code on Discord

Markup

```cpp
int main() {}
```

Result

int main() {} ```

Note: Back-tick (`) not quotes (')

[scenic quartz]

Can it cause compiler problems if I use it outside of the namespace?

[honest badger]

No
But having it be a global typedef will mess with whoever's using your code

[scenic quartz]

also I am curious. When I include files each other like :
a.cpp

#include "b.hpp"```

b.cpp
```cpp
#include "a.hpp"```

 this approach causes compiler errors. how can I get away from it ?

[honest badger]

Instead of this

implement a c.hpp header

where what a, b need are in that c.hpp file

and so both a.hpp and b.hpp include c.hpp

but c does not include any of these

[marble finch]

Wouldn't that double include c in case a & b are needed ?

[honest badger]

If the functions both a,b are using is in c, no

it won't need to include a, b

[marble finch]

Hmm idk

[honest badger]

If they need the class names iirc they could do