help replacing strtok() into something else | Together C & C++ | Page 1

candid atlasBOT Oct 17, 2022, 6:07 AM

#

When your question is answered use !solved to mark the question as resolved.

Remember to ask specific questions, provide necessary details, and reduce your question to its simplest form. For more information use !howto ask.

neat oriole Oct 17, 2022, 6:26 AM

#

would sscanf() work

neat oriole Oct 17, 2022, 6:42 AM

#

i tried this

#

but its not the output that i want

#

this is how the output should look like

#

can anyone help

solemn dome Oct 17, 2022, 6:51 AM

#

Why are you trying to replace strtok?

#

(i mean, i know a few good reasons, just want to know yours)

neat oriole Oct 17, 2022, 6:52 AM

#

ive heard that its bad and not safe to use so i want an alternative

#

but i cant seem to solve it

#

its taking me hours and i still cant figure it out

solemn dome Oct 17, 2022, 6:56 AM

#

Hmm instead of writing your own alternative, why not use strtok_r?

neat oriole Oct 17, 2022, 6:57 AM

#

apparently its "needlessly" difficult to do so i hard sscanf() is good to use in this situation

#

would u like to take a look at the whole code?

solemn dome Oct 17, 2022, 7:00 AM

#

Dunno, i don't use C that often so I'm not sure about my advice here.

#

What strikes me as odd, why are you trying to print integers as %s?

neat oriole Oct 17, 2022, 7:02 AM

#

if ur talking about using it in strtok() bcuz the output is how i wanted it
if ur talking abt sscanf then to be honest, just trial and error

solemn dome Oct 17, 2022, 7:02 AM

#

Oh wait! I think i get what you want to do

solemn dome Oct 17, 2022, 7:03 AM

#

neat oriole if ur talking about using it in strtok() bcuz the output is how i wanted it if u...

You print integers with %d. If you enable compiler warnings it should tell you about it

#

So you want to parse a line
text more text some words 123 456
Into text part and two numbers?

neat oriole Oct 17, 2022, 7:03 AM

#

exactly

#

so what im doing is, reading a text file that has _ which is being replaced with spaces

solemn dome Oct 17, 2022, 7:04 AM

#

Hmm let me think for a minute

neat oriole Oct 17, 2022, 7:04 AM

#

solemn dome Oct 17, 2022, 7:04 AM

#

Oh wait, then it's simple!

#

Just use scanf

#

%s %d %d

#

That's all

neat oriole Oct 17, 2022, 7:05 AM

#

this is how the file is and so all what im doing is basically
Quest Name Quest Level Experience

Destroy the worms in Princess Bubblegum's basement 1 10

neat oriole Oct 17, 2022, 7:06 AM

#

solemn dome Just use scanf

please how, ive been dying

solemn dome Oct 17, 2022, 7:06 AM

#

solemn dome %s %d %d

Like that, that's all

#

Just have a buffer long enough for the string

neat oriole Oct 17, 2022, 7:06 AM

#

where do i put those

solemn dome Oct 17, 2022, 7:06 AM

#

Do you know how to use scanf?

neat oriole Oct 17, 2022, 7:06 AM

#

neat oriole i tried this

in which part of the code

neat oriole Oct 17, 2022, 7:07 AM

#

solemn dome Do you know how to use scanf?

nope thats why im asking

solemn dome Oct 17, 2022, 7:07 AM

#

Ok, then let's go back to basics :p

#

Scanf takes a "format string", that describes what kinds of values it will be parsing, and then pointers to where the parsed values will be stored

#

%s parses a single word

#

%d an integer number

neat oriole Oct 17, 2022, 7:08 AM

#

so how would i implement that

#

what about sscanf

solemn dome Oct 17, 2022, 7:09 AM

#

sscanf instead of parsing standard input, parses a string that's already in memory

neat oriole Oct 17, 2022, 7:09 AM

#

wouldnt that be better to use

solemn dome Oct 17, 2022, 7:09 AM

#

I guess if you open this file,a better solution would be to use fscanf

#

That parses a file

#

Overall what you are trying to do should be 4 lines total

neat oriole Oct 17, 2022, 7:10 AM

#

really

solemn dome Oct 17, 2022, 7:10 AM

#

Mhm

neat oriole Oct 17, 2022, 7:10 AM

#

wth how

#

i have about ~40 lines of code

#

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
//first things first, file pointer so program will keep track of file
FILE* file_to_read;
//defining variables
double quest_level,quest_experience;
int del_underscores;
char reference_of_arrays[80], *y, into_spaces;
int main() {
//open file as specfied which is in read mode
file_to_read=fopen("quests.txt","r");
//print out the name,level,xp with the appropriate spacing
printf("%-51s", "Quest Name"), printf(" Quest Level"" Experience\n\n");
//void is used so it doesnt return a value
void replace_scores_wspaces(char into_spaces[]){
//here we are replacing the underscores with spaces
for(del_underscores=1;del_underscores<strlen(into_spaces);del_underscores++){
if(into_spaces[del_underscores]=='_'){
//if there is underscores then replace it with a space
into_spaces[del_underscores]=' ';}}
}

//using function fgets() to read string from console
while((fgets(reference_of_arrays,80,file_to_read)!=0))
//read the rest of file and put the appropriate spacing
//for name
{y=strtok(reference_of_arrays," "),replace_scores_wspaces(y),printf("%-51s ",y);
//the empty spacing is to organize the output prompt as well as for strtok's arguements
//for level
y=strtok(0," "),printf("%-14s",y);
//for xp
y=strtok(0,""),printf("%-s",y);
}
/**while(fgets(reference_of_arrays,80,file_to_read))
{
int len=strlen(reference_of_arrays);
if(reference_of_arrays[len-1]=='\n')
reference_of_arrays[len-1]='\0';
sscanf(file_to_read,"%d %d\n", &quest_level, &quest_experience);
printf("%-51s %-14s %-s \n", reference_of_arrays, quest_level, quest_experience);
}*/

printf("\n");
//close file
fclose(file_to_read);
//return true when everything works as expected
return 2;
}

neat oriole Oct 17, 2022, 7:12 AM

#

neat oriole #include <stdio.h> #include <stdlib.h> #include <string.h> //first things first,...

!format

charred anchorBOT Oct 17, 2022, 7:12 AM

#

@neat oriole, your formatted code (missing deletion permissions):

📎 code.cpp

solemn dome Oct 17, 2022, 7:13 AM

#

f = fopen(...
while(fscanf("...", ...) == 3)
{
    replace_underscore(text);
    printf("...", ...);
}
fclose();

#

*scanf returns the number of correctly parsed arguments

#

so as long, as it can parse new word and two new integers, you replace the underscore in integers and print as you want

neat oriole Oct 17, 2022, 7:17 AM

#

i dont think that would work

neat oriole Oct 17, 2022, 7:17 AM

#

neat oriole

im basically just organizing this file

solemn dome Oct 17, 2022, 7:18 AM

#

I tell you that would work

neat oriole Oct 17, 2022, 7:18 AM

#

could i ask what am i putting in the ...

molten dew Oct 17, 2022, 7:18 AM

#

where is int for num

solemn dome Oct 17, 2022, 7:19 AM

#

Well i told you already... I'm on a phone and not with a lot of time

neat oriole Oct 17, 2022, 7:19 AM

#

molten dew where is int for num

neat oriole Oct 17, 2022, 7:20 AM

#

solemn dome Well i told you already... I'm on a phone and not with a lot of time

im a beginner, apologies

molten dew Oct 17, 2022, 7:20 AM

#

well, where's the problem?

neat oriole Oct 17, 2022, 7:21 AM

#

molten dew well, where's the problem?

so basically im trying to replace strtok() with something else

#

so strtok(), this is my output (which is what i want)

#

i tried an alternative and this is what im getting

#

which isnt the correct output

#

so the problem is basically trying to replace strtok()

molten dew Oct 17, 2022, 7:24 AM

#

strtok will modify the original string

solemn dome Oct 17, 2022, 7:24 AM

#

Man, I gave you a solution already. Look up how scanf works on examples and apply it

neat oriole Oct 17, 2022, 7:26 AM

#

solemn dome Man, I gave you a solution already. Look up how scanf works on examples and appl...

i looked stackoverflow and everything, i dont see how it would work in 5 lines or so

#

i give up

solemn dome Oct 17, 2022, 7:27 AM

#

It was an oversimplification. You need a separate function to replace _ with space

#

And then just put variable names into my code and be done with it

neat oriole Oct 17, 2022, 7:27 AM

#

solemn dome It was an oversimplification. You need a separate function to replace _ with spa...

thats what i did here

solemn dome Oct 17, 2022, 7:28 AM

#

That's not a valid code.. you can't define a function inside of a function

neat oriole Oct 17, 2022, 7:29 AM

#

how come it works

solemn dome Oct 17, 2022, 7:30 AM

#

A GCC extension i guess. Still not a valid C

molten dew Oct 17, 2022, 7:30 AM

#

neat oriole i tried an alternative and this is what im getting

return null by strtok

neat oriole Oct 17, 2022, 7:30 AM

#

neat oriole Oct 17, 2022, 7:31 AM

#

solemn dome A GCC extension i guess. Still not a valid C

like that?

neat oriole Oct 17, 2022, 7:31 AM

#

molten dew return null by strtok

0 is basically NULL

solemn dome Oct 17, 2022, 7:31 AM

#

God please format your code

#

If you don't know how put it here like that

charred anchorBOT Oct 17, 2022, 7:32 AM

#

How to Format Code on Discord

• type three "backticks" (not quotes/apostrophes, on QWERTY layout, left of 1-key)
• on the same line, type the file extension for that language (c or cpp)
• enter your code on a new line and put another three backticks at the end

Example Input

```cpp
int main() {
return 0;
}
```

Example Output

int main() {
    return 0;
} ```

See Also

Learn more about Discord formatting

solemn dome Oct 17, 2022, 7:32 AM

#

And then our tools will do it

neat oriole Oct 17, 2022, 7:33 AM

#

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
//first things first, file pointer so program will keep track of file
FILE* file_to_read;
//defining variables
double quest_level,quest_experience;
int del_underscores;
char reference_of_arrays[80], *y, into_spaces;
int main() {
//open file as specfied which is in read mode
file_to_read=fopen("quests.txt","r");
//print out the name,level,xp with the appropriate spacing
printf("%-51s", "Quest Name"), printf(" Quest Level"" Experience\n\n");
//void is used so it doesnt return a value
void replace_scores_wspaces(char into_spaces[]){
//here we are replacing the underscores with spaces
for(del_underscores=1;del_underscores<strlen(into_spaces);del_underscores++){
if(into_spaces[del_underscores]=='_'){
//if there is underscores then replace it with a space
into_spaces[del_underscores]=' ';}}
}

//using function fgets() to read string from console
/**while((fgets(reference_of_arrays,80,file_to_read)!=0))
//read the rest of file and put the appropriate spacing
//for name
{y=strtok(reference_of_arrays," "),replace_scores_wspaces(y),printf("%-51s ",y);
//the empty spacing is to organize the output prompt as well as for strtok's arguements
//for level
y=strtok(0," "),printf("%-14s",y);
//for xp
y=strtok(0,""),printf("%-s",y);
}*/
while(fgets(reference_of_arrays,80,file_to_read))
{
int len=strlen(reference_of_arrays);
if(reference_of_arrays[len-1]=='\n')
reference_of_arrays[len-1]='\0';
sscanf(file_to_read,"%d %d\n", &quest_level, &quest_experience);
printf("%-51s %-14s %-s \n", reference_of_arrays, quest_level, quest_experience);
}

printf("\n");
//close file
fclose(file_to_read);
//return true when everything works as expected
return 2;
}

neat oriole Oct 17, 2022, 7:33 AM

#

neat oriole #include <stdio.h> #include <stdlib.h> #include <string.h> //first things first,...

!format

charred anchorBOT Oct 17, 2022, 7:33 AM

#

@neat oriole, your formatted code (missing deletion permissions):

📎 code.cpp

molten dew Oct 17, 2022, 7:34 AM

#

why you use strlen ?

neat oriole Oct 17, 2022, 7:34 AM

#

to obtain the string

neat oriole Oct 17, 2022, 7:35 AM

#

solemn dome God please format your code

sorry bro i swear im not dumb but c makes me feel dumb

neat oriole Oct 17, 2022, 7:35 AM

#

neat oriole to obtain the string

that is in array

solemn dome Oct 17, 2022, 7:35 AM

#

I understand it, it does it to most

#

A few things: main should return 0 when everything works as expected

molten dew Oct 17, 2022, 7:36 AM

#

ret 2 ?

solemn dome Oct 17, 2022, 7:36 AM

#

0 is for successful exit, 1 for error

#

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
// first things first, file pointer so program will keep track of file
FILE* file_to_read;
// defining variables
double quest_level, quest_experience;
int del_underscores;
char reference_of_arrays[80], *y, into_spaces;
int main() {
    // open file as specfied which is in read mode
    file_to_read = fopen("quests.txt", "r");
    // print out the name,level,xp with the appropriate spacing
    printf("%-51s", "Quest Name"), printf(
                                       " Quest Level"
                                       "   Experience\n\n");
    // void is used so it doesnt return a value
    void replace_scores_wspaces(char into_spaces[]) {
        // here we are replacing the underscores with spaces
        for (del_underscores = 1; del_underscores < strlen(into_spaces);
             del_underscores++) {
            if (into_spaces[del_underscores] == '_') {
                // if there is underscores then replace it with a space
                into_spaces[del_underscores] = '  ';
            }
        }
    }

    // using function fgets() to read string from console
    /**while((fgets(reference_of_arrays,80,file_to_read)!=0))
        //read the rest of file and put the appropriate spacing
        //for name
    {y=strtok(reference_of_arrays," "),replace_scores_wspaces(y),printf("%-51s
    ",y);
        //the empty spacing is to organize the output prompt as well as for
    strtok's arguements
        //for level
    y=strtok(0,"    "),printf("%-14s",y);
        //for xp
    y=strtok(0,""),printf("%-s",y);
    }*/
    while (fgets(reference_of_arrays, 80, file_to_read)) {
        int len = strlen(reference_of_arrays);
        if (reference_of_arrays[len - 1] == '\n')
            reference_of_arrays[len - 1] = '\0';
        sscanf(file_to_read, "%d %d\n", &quest_level, &quest_experience);
        printf("%-51s %-14s %-s \n", reference_of_arrays, quest_level,
               quest_experience);
    }

    printf("\n");
    // close file
    fclose(file_to_read);
    // return true when everything works as expected
    return 2;
}

#

Uhhhh

#

Ok, so your replacing function is ok, even if strlen is kinda unnecessary

#

It should be before main

#

Then, you can remove everything you have

#

Create 3 variables, one for text two for numbers

#

Post my code

#

Put in the names of variables

#

And it will work

neat oriole Oct 17, 2022, 7:40 AM

#

do i not use the variables already created?

#

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
//first things first, file pointer so program will keep track of file
FILE* file_to_read;
//defining variables
double quest_level,quest_experience;
int del_underscores;
char reference_of_arrays[80], *y, into_spaces;
void replace_scores_wspaces(char into_spaces[]){
        //here we are replacing the underscores with spaces
for(del_underscores=1;del_underscores<strlen(into_spaces);del_underscores++){
if(into_spaces[del_underscores]=='_'){
        //if there is underscores then replace it with a space
 into_spaces[del_underscores]='  ';}}
}
int main() {
    //open file as specfied which is in read mode
file_to_read=fopen("quests.txt","r");
    //print out the name,level,xp with the appropriate spacing
printf("%-51s", "Quest Name"), printf(" Quest Level""   Experience\n\n");
    //void is used so it doesnt return a value



while(fscanf("...", ...) == 3)
{
    replace_underscore(text);
    printf("...", ...);
}
    
    
printf("\n");
    //close file
fclose(file_to_read);
    //return true when everything works as expected
return (0);
}

#

ok so here

candid atlasBOT Oct 17, 2022, 7:47 AM

#

@neat oriole Has your question been resolved? If so, run !solved :)

neat oriole Oct 17, 2022, 8:11 AM

#

fucks sake i cant get it

solemn dome Oct 17, 2022, 8:20 AM

#

Go back to hello world and get a name and age from a user

#

In one scanf

#help replacing strtok() into something else