#LG IR: Revert dedicated power commands
feral sinew
In general we should not make things worse in core because frontend has an issue
In general I agree, but its not introducing something new, it is changing existing behavior
and right now completelly breaks using the frontend button, since it will always send POWER_OFF
so we either have to fix it on the frontend, or revert it here so people can continue to use it
signal snow
The core PR looks correct and I agree with Paulus that we should not change things in core because of a UI issue
dawn agate
can you test that branch, it looks good
oh maybe I can get a demo media player going too
feral sinew
@signal snow yes, it looks good but it breaks interaction trough the frontend, since assumed state media players are not really there.
So we are introducing a somewhat breaking change, highlighting a limit on the frontend, without adding new functionality (we already provide ON/OFF button entities).
Users will not care if the issue is in frontend or core 😛
feral sinew
oh maybe I can get a demo media player going too
try one with all the media player supported features enabled, because it was already overflowing the entity card
https://github.com/home-assistant/frontend/issues/29514
but since the power button is in a different column, should be ok.
dawn agate
These are the power-on and power-off icons from MDI
The power icon is beautiful because it's both a 1 and 0 combined
nova onyx
The core PR looks correct and I agree with Paulus that we should not change thin...
But we also shouldn’t merge core changes that require a UI change until that PR is ready