#SpaceAPI Integration

1 messages · Page 1 of 1 (latest)

green saddle
#

IMO accepting this integration in the first place was a mistake. This basically tacks on a seperate application onto ours. I think this should've been implemented as a small application which can be installed next to home assistant which integrates via our API.
I don't have an strong opinion about the PR itself though. I think if we want to support spaceAPI, it makes sense to also allow for unauthenticated use if that's how it is usually used.

rough goblet
#

We recently decided on this in the arch meeting I believe and we said it was ok (if spaceapi should stay in core)

little merlin
#

yes, that's right

#

but about my question, it seems weird to only allow unauthenticated use?

rough goblet
#

I was about to say, I believe the whole idea behind this is that it should be public

little merlin
#

OK. Should I ask in the PR what the author recommends?

#

He's suggesting maybe the original author wanted authentication, but I think the integration was added long before we hade modern auth in Home Assistant.

dreamy tangle
#

I think we should be much stricter with our priorities. If an integration that only has 3 installations in analytics require us to discuss things like this, that alone is a reason to remove it.

rough goblet
#

Fair, but, its also a bit chicken and egg problem as the integration wasn't working for ages from what I recall

dreamy tangle
#

That's also a reason to remove it. If it's not working for ages, it should just be removed.

rough goblet
#

Doesn't that bring it into an impasse? Not being able to use it because it's broken, not being able to fix it because it's not used

#

(Now I agree, spaceapi has quite a limit audience, so even if it was working the amount of adoption wouldn't be big)

dreamy tangle
#

They had ages to fix it but none did. That's a reason to remove it.

rough goblet
green saddle