#Remove Integrations Procedure

1 messages · Page 1 of 1 (latest)

cloud venture
#

Wait we removed bmw completely?

vital wolf
#

I think so?

cloud venture
#

That should be similar to myq or Mazda

vital wolf
#

So we can never fully remove an old integration?

#

Myq was removed 2 years ago and still has the skeleton in our codebase.

#

I think that's a bit odd IMO

cloud venture
#

okay so my question here was more like, let's make sure BMW uses the skeleton

#

But euh, before that we just dropped it

#

YAML integrations we just drop, unless there's probably something we want the user to know I guess

#

for config flow ones we just agreed on keeping it around and having that skeleton

#

but we haven't really spoke about removing them altogether

#

I think we can after some time

vital wolf
#

I think we should discuss that and write that down somewhere.

#

Should I create a PR for BMW then? To add the repair issue?

#

Tomorrow is the release, so today or never

verbal oriole
#

The benefit of the skeleton + repair issue is that it allows us to customize the message for the user and explain what happened. This is nice. We have a default repair issue for config entries with missing integration, but that doesn't explain why the integration is gone.

#

I suggest we add a docs page for how to make the skeleton and repair issue for config entry based integrations. And how we treat YAML integrations when removing those.

vital wolf
#

I added it to next weeks Tuesday agenda so we can discuss the details there (like after how many months/years a skeleton is fine to remove). I agree, a separate docs page would be nice.

#

Pr incoming

hallow obsidian
#

If not already done, still on the train

vital wolf
#

It follows pretty closely to what myq did

verbal oriole
#

Please add the same tests as for myq. Otherwise good to go.

hallow obsidian
#

Thanks and no worries about being too fast 🤣

vital wolf
#

Done

vital wolf
verbal oriole
#

If we want to be consistent, I guess we should have a repair issue also for YAML integrations that explain the reason why the integration is gone. What do others think?

cloud venture
#

I guess that's fine