#Oh lovely, CI is broken

1 messages ยท Page 1 of 1 (latest)

vital gull
gilded blaze
vital gull
#

this seems related to aliases now having None as default value

gilded blaze
#

ah, so its broken in multiple ways

vital gull
#

@magic widget what's the reason aliases is a list of None now?

magic widget
#

You gotta watch out for that now for some time when merging things

magic widget
vital gull
#

but why

magic widget
#

because of new registry version

vital gull
#

No I mean, why a list of None, what does that None tell us

magic widget
#

None means use default generated name

gilded blaze
#

why not empty?

magic widget
#

because empty means empty

gilded blaze
#

can you provide an example?

magic widget
#
aliases: []
#

๐Ÿ˜„

#

it means no aliases

vital gull
#

duh

#

Let me change the question, what is aliases used for, why where they empty, and why is [None] now the default, and what other values would it have and how would it reflect in the entity?

#

And I am not trying to doubt the decisions made, at this point I just want to understand what this means ๐Ÿ˜‚

#

I always thought aliases was for google assistant/alexa

magic widget
#

it used to always use friendly name as an alias automatically, now it doesn't

magic widget
#

just Assist and Google Assistant

gilded blaze
magic widget
#

not sure what more information you need:
[None] - use the generated full name as an alias
[] - empty, no aliases

gilded blaze
#

what is the generated full name as an alias? Device Name + Entity Name?

magic widget
#

yes

gilded blaze
#

and the user can remove it (the None) from the alias, and add it back?

magic widget
#

once the frontend is done, yes

gilded blaze
#

why is the PR merged before the frontend is ready?

magic widget
#

frontend is done in stages, with multiple PRs, the major one was merged