#Add 'Top 200' label for core PRs

1 messages · Page 1 of 1 (latest)

onyx plank
#

<@&1476935650476560394> @halcyon scarab brought the question up if we should automatically also remove the label, when a integration does below the threshold?

haughty pecan
#

Do integrations regularly switch places in usage reports? If not, I don't think its worth it. The integration is very likely still within short distance of the top xxx.

flat heart
haughty pecan
#

I would like to see this for the small-pr label though (don't think we do it there)

onyx plank
flat heart
onyx plank
#

So the data is probably one day old

flat heart
#

hum. I think its fine then. don't really see the need to remove the label

halcyon scarab
#

One reason to consider it is that if this label is going to be used for filtering/reporting in the future, for instance, "how many issues did the top 200 integration create in 2025?", while they would have been top200 when that label was added, they might not be when the query is run.

serene silo
#

What's the idea behind that label? What does it mean for a PR to have this?

haughty pecan
#

That is an integration that is used by many people and should get priority and/or more extensive reviews.

serene silo
#

So currently roughly a 5k users threshold

potent pike
#

I'd rather word it as, making sure we spend our time wisely. Instead of bikeshedding an integration that has 3 users, as the PR queue is quite big, so we should try to balance the time towards integrations where perfection does matter more

serene silo
#

Do you know, if applied now to all open PRs, what percentage would currently be labeled ?

onyx plank
keen sun
#

We're getting SLA's on PR's now? 😎

haughty pecan
#

Oh, can we also have a label for PRs that are still awaiting their first (human) review?

#

Is that already a thing?

onyx plank
# 
Total open PRs: 615
PRs with integration labels matching top 200: 229
PRs with integration labels NOT in top 200: 335
Total PRs with any integration label: 564
Percentage of all PRs that would get "Top 200": 37.2%
Percentage of integration PRs that would get "Top 200": 40.6%
onyx plank
#

Should we also add top 50 and top 100?

image.png
potent hatch
#

I think that would make sense tbh

onyx plank
#

Should a PR of a top 50 integration just have the Top 50 label or also the label Top 100 and Top 200?

potent hatch
#

I would just do all threee

#

we can always change based on how it goes later

short token
#

It feels weird for light integration to get "TOP 200" label

onyx plank
#

It uses the same detection mechanism as for the integration label

short token
#

Yes - but I think it probably "skews" the results 🙁

#

Could it filter out Quality Scale: internal

#

Just a thought going forward...

onyx plank
#

I will mark it down and let's see how its going in general with the label. If more changes are needed I can update them all together

#

I will change the color of it as that can be done without a deployment

#

My idea would be to not set it if the label core is set. What do you think?

short token
#

light and automation do not have core label (maybe they should?)

onyx plank
short token
#

oups - then I think it's good

short token
onyx plank
potent pike
short token
serene silo
onyx plank
serene silo
#

Ah I see. The webpage filters person, automation, and the entity components (light, climate...) - although eg. "sensor" is 110520 ... about half of "bluetooth" or "mqtt" which seems awkward. "light" is 21904 which is totally unrealistic tbh

onyx plank
onyx plank
#

@potent hatch Should we also filter out some integrations like the website does? So we are aligned with the analytics on the website

potent hatch
#

I dunno man 😄

short token
#

For what it's worth, I think it should filter out.
If the 5th integration and the 7th integration are core integration, then the 102nd integration should be bumped to 100th

onyx plank
#

That would mean we will not set the label on any integration having the type entity, hardware, system and virtual. The only one I'm not sure about is the hardware one.

opal tangle
onyx plank
#

Will check why new integration got the labels.

#

Currently we are just setting these labels on PR creation also core and co will just be set on PR creation.

#

If we want that it will be updated, then a bigger refactoring is needed

opal tangle
#

The example had modified the Matter integration (top 50) besides adding a new integration.

#

It could be enough to not add the top ### labels if also adding new integration label. But I don't know if that makes it easier in the bot code.

onyx plank