#Codeowner requirements

1 messages · Page 1 of 1 (latest)

full quiver
#

I think having a pr merged us a rule of thumb

#

But there probably have been exceptions, for example when someone from a company gets added

#

Or someone else in a company picks up maintainership

#

(like, would it be cool if they are capable, yes, but when someone is leaving and handing over maintainership I don't want to require this and lose them both so to say)

#

I think there are also cases where people are just highly knowledgeable who added themselves but don't write much code

storm sonnet
#

in this case the old codeowner appears to be not active recently

#

but the proposing one also only has 1 open PR for now

full quiver
#

One cool catch

#

They don't have a proper dev env

storm sonnet
#

yeh

full quiver
storm sonnet
full quiver
#

Yes

#

Jjlawren

#

Also code owner for Sonos (but we have Pete there doing an awesome job) and Plex