#School Holiday PR

1 messages · Page 1 of 1 (latest)

round kayak
#

I think a general school holiday integration would make a lot of sense. If this integration is structured well, I don't see why not.

charred matrix
#

Oh for context, we have the holidays integration, which can show holidays for countries/areas whatnot

round kayak
#

ah

charred matrix
#

but that's also because there's a library that actually knows them

#

(but that is calculated locally, not via an API)

round kayak
#

I still think it would be nice to have, but I agree - maybe first get a library going which can be extended for various countries? So we don't have to import ~200 libraries just for this?

dusky bramble
#

I'd guess for most countries / school districts those are just available as an iCal calendar, aren't they?

late oriole
#

Let's not derail that PR by trying to make it something it's not

#

school_holiday is obviously unacceptable for something which is only supporting (some?) Dutch schools, so we should just ask them to rename it to something more narrow

charred matrix
#

But yea, when you try to narrow down there are a ton of things you can think, like nl_school_holidays, dutch_school_holidays

#

none existing integration comes to mind

late oriole
#

Yeah, just suggest one of those if the API the integration is using covers all, or at least most, Dutch schools

charred matrix
#

ye it is, but I was wondering if we have a preference here, I don't at least

late oriole
#

we have plenty of travel time integration and that sort of things, how are they named?

charred matrix
#

waze_travel_time, google_travel_time, here_travel_time

#

I mean more like, country related integrations

late oriole
#

really? there are many local ones

charred matrix
#

Like the API comes from a website called rijksoverheid, which literally is the dutch government, so making it a rijksoverheid integration is meh

charred matrix
#

they just follow the name of the company, I don't think we integrate with a country per se, always with a company that is running the vehicles

late oriole
#

We do have country/state specific stuff, there are for example three integrations for New South Wales stuff (Or maybe it's North South West Wales?)

charred matrix
#

oh right

late oriole
#

hence: dutch_school_holiday, the first of many great dutch_xxx integrations