trim meteor
In https://github.com/home-assistant/core/blob/dev/.claude/skills/integrations/SKILL.md?plain=1#L136 we currently have
Version Control: Always set VERSION = 1 and MINOR_VERSION = 1
is that an actual guideline? I'd rather not set either if not necessary as this is already defined in the base class and we usually never re-implement from the base class
pearl crow
While I do like people to know that minor version is 1 instead of 0, what everyone expects, I am not sure if explicitly defining is the way to go
granite gale
we actually already had this conversation and decided to change the docs after that. Version shouldn't be set to 1 as it's the default. I'd remove it from the skill instructions
pearl crow
we actually already had this conversation and decided to change the docs after t...
right, like I know we discussed it but I forgot the reason why we had the discussion but didn't look it up yet
warped river
I think it's much better to be explicit than relying on implicit magic
trim meteor
Meh with that logic you'd need to reintroduce everything defined in a super class
It's not really magic
Only inheritance
warped river
yes, but the problem is that starting version 1.1 is not obvious
i've seen PRs "bumping" from no version to version 1.1
However, the author of said PR obviously didn't test their PR, so maybe it's not a valid reason
pearl crow
As we require tests for migrations. Would it make sense to raise if someone creates a mock config entry where version is 0