#kelvin -> color_temp_kelvin failed for scripts

1 messages · Page 1 of 1 (latest)

pale tartan
#

How do you mean rewrote

summer pelican
#

Ah its the kelvin key, should have migrated to color_temp_kelvin

#

Is there a migration supposed to have happened?

pale tartan
#

When did it rewrite

#

because the whole service -> action rewrite happened in the frontend

#

so if you had the old yaml keys in there and you opened the automation in the frontend and you saved it, it would migrate

#

So with that in mind, I assume this would also happen in the frontend

#

If not, then @quasi canyon would know

summer pelican
#

The action stuff changed month ago no?

Actual issue is the kelvin -> color_temp_kelvin migration that didnt happen

#

Looks like it only failed on my scripts.yaml, not automations.yaml

pale tartan
summer pelican
#

kelvin -> color_temp_kelvin failed for scripts

#

Just did a find/replace on my scripts, luckiliy only a few keys needed changing. Was sat in the dark for a while there lol

red falcon
#

I don't see there was any migration for kelvin

#

are you sure it wasn't just deprecated and left for users to update?

pale tartan
#

I dont know, epenet would

#

But then I'd expect to see issues and warnings

summer pelican
#

Do we not validate automations at runtime? if they fail to run, or on load should they not flag as invalid actions?

cedar umbra
#

we can't really do that, since actions can come and go

#

we can just validate that the overall autoation structure is sane

#

We don't rewrite scripts, automations, template entities etc. when actions change, it's on users to fix

summer pelican
#

Might be my blindness to warnings (I get a lot of these from misbehaving devices or disconnections) but these really should be raising an issue/repair as well IMO

cedar umbra
#

That's a good idea for future deprecations, but I don't think we need to revert the PR which removed kelvin from the light actions?

summer pelican
#

No need to revert no

golden barn
#

Do we need to raise issues now, or are the automation already doing that

cedar umbra
#

Automations don't raise issues when actions fail

#

I think doing that would be too spammy

#

they raise issues if automations try to call an action which does not exist though

#

they also raise issue if the yaml is broken forcing the automation to be disabled

red falcon
#

You think raising an issue for explicitly actions that use deprecated values during the deprecation period be reasonable or too spammy?

summer pelican
summer pelican
cedar umbra
cedar umbra
#

This is for automations. For scripts we don't raise when attempting to call an action which doesn't exist, which is probably an oversight.

golden barn
#

Yeah my question was if we should raise issues now if we detect the old values in automations

cedar umbra
#

Yes, I think we should do that 👍

#

It was forgotten / not considered for the light deprecation