#Airthings
obsidian star
correct
unique estuary
for 1 device, and the rest does lux?
obsidian star
The internal spec is confusing 🤦♂️, so I'm not sure yet. It's at least 1 of 4 devices (Wave Plus), but most likely the rest as well
unique estuary
right
so
If a sensor has a device class it should adhere to the available UoMs
if it can't, the device class should be removed
So in this case, if only 1 device has this issue, you need to find a way to differentiate that
But the solution would be indeed to remove the device class and set the UoM to percentage
obsidian star
Let's say we have this issue for all supported devices, then I can just remove device class + change UoM to percentage?
unique estuary
yep
obsidian star
The first generation (Wave gen. 1) is old and have a very confusing spec, so I'm not sure what this actually supports yet, but I'm pretty sure it's not lux
unique estuary
If this always was the case it's technically not breaking, but if some software update once broke this it might be wise to mention
(if that's the case I will ask someone else to double check if that's needed, since the context of the entity changed)
obsidian star
If we're changing to % we need to mention that the value is different (0-255 => 0-100)
unique estuary
also for the name, if the entity is still representing illuminance of the device, I don't see a name not to name it illuminance
unique estuary
If we're changing to % we need to mention that the value is different (0-255 => ...
Right
unique estuary
also for the name, if the entity is still representing illuminance of the device...
You can use translation key references for this
(And I think I added icon translations to it last week or so, so you can also add the icon in there)
obsidian star
also for the name, if the entity is still representing illuminance of the device...
Exactly. I was afraid I had to do some migration for this, but keeping the name makes it a lot easier
unique estuary
If you are not changing the unique_id you don't need to migrate
oh and
Is the battery STILL bogus
😂
obsidian star
😆
unique estuary
I've never seen someone this passionate about battery levels
obsidian star
Haha, same. Will try to bump the framework this week so that can be CLOSED. But it can still be different from the cloud solution... Because that's just how battery voltage readings are
The main reason for not pushing it was this light sensor + actually adding tests to validate what's changed. Trying to now screw up anything 🤞
unique estuary
FYI you can close issues yourself by doing @home-assistant close
obsidian star
I know. I have closed a few, but they still popping up because some people are not happy
unique estuary
I hope you learnt something new from that lecture battery voltage 😂