#I've got a PR up for the thermostat
lofty creek
It would be cool if the thermostat card on the UI could display the exact deadband
I was looking around the Climate entity and it doesn't look like it's an attribute on there
lofty creek
I created this discussion post... I'm not particularly well suited in UI/UX so there's probably a better way to display the deadband (I'm thinking maybe the inverse of the drawing)
burnt socket
I would recommend opening an architecture issue for this because currently HA has no aweness of the deadband at all. It sounds to me like a valid addition.
As soon as you create the architecture issue (which is how we handle this kind of proposals), others will chime in to look at this from different angles and device types and hopefully the UX and frontend people also have some ideas.
lofty creek
Made a architecture discussion about it
burnt socket
thanks!
lofty creek
Seems like it’s already implemented in the nest thermostat logic
But not in climate as a whole
lofty creek
I raised the question of implementing it on the climate entity as a whole
Copy pasting the same logic doesn’t seem to make much sense
At least to me
burnt socket
To me as well, and I'm pretty sure others feel the same. If it needs to be copied, there clearly is something generic to solve is my opinion
burnt socket
Yeah, let's give it one more week and otherwise we'll just prepare a proposal in a draft PR ?
lofty creek
Sounds good, thanks for the bump
lofty creek
Gonna work on getting the climate entity PR up today
lofty creek
lofty creek
I don't think opening the PR was taken well
burnt socket
What was the general response to your architecture discussion? I felt it was heading towards a global solution but yeah, if this is only very rare then it makes more sense to just do a few integrations specific implementations.
lofty creek
idk the frenck lead guy seemed skeptical to add it and hasn't really responded at all
despite multiple integrations being able to benefit from it
burnt socket
hmm, ok, I'll check it.
lofty creek
any updates?
Changing my temp with the Matter integration is difficult because unlike the Nest version it doesn't automatically calculate the upper/lower temp
lofty creek
@burnt socket did you see this?
burnt socket
Oh sorry, I completely forgot. I' going to check this with my coworkers right away
lofty creek
Sounds good. Thank you
lofty creek
If there's anything I can do to help facilitate getting this feature in, let me know
If it means only implementing it in the Matter integration, I can make that change
@molten ferry if there's any discussion you can add here
lofty creek
You were part of the discussion and I haven't heard back in three-ish weeks
molten ferry
Sure, many try that, the only thing that will cause if me getting unwanted pings from everywhere
loosing focus
I want to ask you not to do that
lofty creek
I understand
molten ferry
you mean well, but is causes to come across demanding
so please, withhold from that
It has been discussed and I need to formulate an answer, that will happen once I get to that part on my huge list.
lofty creek
Your response came off to me as condescending. I understand you're busy by your GitHub graph alone, but I feel like you're talking down on me. I don't feel like contributing to a project when I feel like I'm being looked down upon.
Whether you agree with that or not, I felt the same way in our exchange on the pull request. I'm not trying to make things more stressful for you, but I wasn't expecting to be met with hostility for trying to implement new features.
molten ferry
Sorry, it was not meant as such
I'm not talking down, I think you should have some patience
On the PR, that was a normal review, asking to open up an arch dicussion first
this is also documented, and normal procedure (as a matter of fact, you could have saved yourself opening the PR in the first place, if the documentation was followed)
it is not personal, it is just the route to take 🤷♂️
I'm happy to add some fluff, but that doesn't change the route
nor it this (discord thread) the place to push stuff forward
the architectural discussion is open, like many others
things are discussed based on, e.g., how large the effect/audience is
The impact/affected integrations/number of users for this proposal is low. Like it or not, but that makes it a lower priority as well.
anyways: Have patience... please 🙏
I promise you'll get answers, decissions and followups
lofty creek
Yeah, let's give it one more week and otherwise we'll just prepare a proposal in...
I was following the advice given here.
This discussion is a pretty good log of what actions I've taken in order
I don't disagree on priority. But I don't have visibility into your backlog and what's taking precedence - if there's somewhere I can look at for that data outside of the PR list I wouldn't be asking for updates so often.
molten ferry
The PR isn’t relevant
As in, it can be closed actually, until the architectural discussion is resolved
As that is require before opening a pr ( as per dev documentation)
molten ferry
I was following the advice given here.
Sorry, seems like Marcel has been deviating from our regular procedures. Sorry to hear that caught you in the middle.
molten ferry
@lofty creek I've left a response on the architectural discussion here: https://github.com/home-assistant/architecture/discussions/996#discussioncomment-7819414
Which is based on the output from the architecture meeting we had where this was discussed.
We do think it is ok, and are willing to accept, but the architectural proposal is lacking technical details.
burnt socket
Hmmm, sorry I wasn't aware of doing something wrong (not a lot of experience with these procedures I guess) and was just trying to steer this thing forward. Anyways, @lofty creek looks like we need to complete the architecture proposal with some details how it would work. So, additional propertie(s) with the deadband/range so the frontend can limit the range as well.
lofty creek
I’ll take a look after work today or during my lunch
lofty creek
Got sidetracked yesterday. Hoping to comment today after work
molten ferry
No worries, no rush 👍
lofty creek
I've added my comment on there
lofty creek
Not trying to nag, but is there anything i am missing?
burnt socket
I've looked at your added proposal of the implementation and it looks good to me but let's wait for the members of the core team to jump in and give their final reply and if its approved we can move on. Like Frenck said, most of us is enjoying holidays so it will probably be january. Wish you great holidays as well.
lofty creek
Hey! I noticed the PR went stale today and was automatically closed. Has there been a chance to review the technical details I added?
burnt socket
Thanks for the reminder. Let's bump this on monday!
lofty creek
No problem, thanks guys!
lofty creek
This may have fell through the cracks again 🙂
molten ferry
No it hasn't, it is definitly on my short list
But is is on my list, that is on my desk 🙂
lofty creek
Anything new?
lofty creek
We’re getting close to 3 months now…
Is there anything I can do to help accelerate this?
molten ferry
It is on the agenda for the core meeting at 14:00 (CET) today
It looks fine, I want to sync up with others on the naming
Also, not sure if the adjustment should push the other end if the deadband is pushed or not
lofty creek
🤞
lofty creek
Also, not sure if the adjustment should push the other end if the deadband is pu...
That’s a good point, yeah after re-reading it, I don’t think enforcing the deadband should happen if the overall “gap” is getting bigger