#Tekktrik0458 I m wanting to do this

1 messages · Page 1 of 1 (latest)

wintry swift
#

Gotchya, yeah, it looks like what I plan to do (and tested) along with the change to pyproject.toml

#

The problem matchers isn't relevant but the rest of the changes are.

broken lintel
#

Ah ok

#

Yeah the setup.py patch will have to be done semi-manually

#

But I feel like the rest of that can be done with adabot

wintry swift
#

Since the pyproject.toml changes are going to have to touch release.yml and build.yml, I figured it might be easy to introduce that change when that happens.

broken lintel
#

Yeah

#

That makes sense

wintry swift
#

All the build and release workflows should be identical at that point so it'll be easy to just overwrite the files for those.

broken lintel
#

Yeah

wintry swift
#

For the setup.py, I would hate for you to go through an entire patch when I'm going to modify my script for generating pyproject.toml files from them to add this change anyway.

broken lintel
#

Ah ok

#

Yeah I have a script that can do more 'manual' patches all at once with sed so I'm fine either way

#

It's not really manual, more just automatic but with a few safeguards to make sure I don't do something dumb and break everything

wintry swift
#

Gotchya. Since this is going to have to go in my script anyway, I would hate for you to spend time on this patch when the pyproject.toml patch will inevitably fix it anyway. And since that's probably imminent ( @fresh vapor let me know when you think those few libs have been in the field long enough), it may end up being a waste of your time 😅

broken lintel
#

Ok! Yeah that makes a lot of sense!

fresh vapor
wintry swift
fresh vapor
# wintry swift 20 days ago

OK, I think that's enough of a soak test. Go ahead and do it up whenever you're ready. Best to do it when you'll be around for the week or something so you can catch any failures etc.

wintry swift
#

I'll get things prepped in the meantime, and then that week I'll jump right in