DARE (Danny's Awesome Rendering Engine) | Graphics Programming | Page 4

dawn wave Aug 4, 2023, 7:04 PM

#

i realized

#

my code doesn't even do type conversion

#

as it will auto return if it's the same type

#

which most are

#

so bleakekw

devout mesa Aug 4, 2023, 7:04 PM

#

show me the new loading code

dawn wave Aug 4, 2023, 7:04 PM

#

you would cry

#

so i won't

devout mesa Aug 4, 2023, 7:05 PM

#

I know, I will not ask you to nuke it

#

for now

dawn wave Aug 4, 2023, 7:05 PM

#

KEKW ill nuke it soon-ish after i fixed this stupid bug

#

https://github.com/DannyLeWasTaken/DARE/blob/textures/src/assets/scene/loader/gltf.rs

GitHub

DARE/src/assets/scene/loader/gltf.rs at textures · DannyLeWasTaken/...

Danny's Awesome Rendering Engine. Contribute to DannyLeWasTaken/DARE development by creating an account on GitHub.

devout mesa Aug 4, 2023, 7:15 PM

#

it's not that bad actually

dawn wave Aug 4, 2023, 7:15 PM

#

This is the best compliment I have recieved in my lifetime KEKW

devout mesa Aug 4, 2023, 7:16 PM

#

minus this garbage of course get_accessors_from_primitives

dawn wave Aug 4, 2023, 7:16 PM

#

KEKW yeah that is garbage

devout mesa Aug 4, 2023, 7:16 PM

#

This should instantly disappear but w/e

#

can't really find the bug though

#

it doesn't help that me and rust are infinitely distant bleakekw

dawn wave Aug 4, 2023, 7:17 PM

#

yeah that's the issue. my tests are passing, smaller meshes work but larger meshes bork

devout mesa Aug 4, 2023, 7:17 PM

#

try it out with the smol mesh that bork

dawn wave Aug 4, 2023, 7:17 PM

#

oh yeahh

#

maybe i'll go through it's gltf file and see what is causing it

devout mesa Aug 4, 2023, 7:18 PM

#

I mean

#

you have a debugger right?

#

use that

dawn wave Aug 4, 2023, 7:18 PM

#

yeah my debugger is saying it works well too KEKW

#

images are all loading

devout mesa Aug 4, 2023, 7:18 PM

#

Right I meant stepping in the code

dawn wave Aug 4, 2023, 7:18 PM

#

the buffer is fine so this is really ethereal

#

ohh yeah

#

ill do that

#

but like my print statements kinda did that bleakekw

devout mesa Aug 4, 2023, 7:19 PM

#

uh

#

right

#

use a debugger thanks

dawn wave Aug 4, 2023, 7:19 PM

#

LMAOO

#

okok

devout mesa Aug 4, 2023, 7:19 PM

#

I can only accept print statements inside shaders

dawn wave Aug 4, 2023, 7:32 PM

#

wait you can do that?

#

okay so i did debugging

#

and uh

#

it went normally bleakekw

devout mesa Aug 4, 2023, 7:33 PM

#

dawn wave wait you can do that?

yeah

#

It's basically the number 2 major reason why Vulkan appealed to me so much

dawn wave Aug 4, 2023, 7:33 PM

#

WAIT YOU CAN?

devout mesa Aug 4, 2023, 7:33 PM

#

the number 1 major reason was validation layers

#

yes, you can't in OpenGL though 😭

dawn wave Aug 4, 2023, 7:33 PM

#

how

#

show me the way

devout mesa Aug 4, 2023, 7:34 PM

#

GL_EXT_debug_printf

#

https://github.com/KhronosGroup/GLSL/blob/master/extensions/ext/GLSL_EXT_debug_printf.txt

dawn wave Aug 4, 2023, 7:34 PM

#

it...

#

no way

#

debugPrintfEXT

#

All hail debugPrintfEXT

#

is there a vulkan extension that needs to be enabled as well?

#

i refuse to believe

#

it's this easy

#

no way

devout mesa Aug 4, 2023, 7:38 PM

#

just debug utils

#

well

dawn wave Aug 4, 2023, 7:39 PM

#

oh KEKW phobos has abstracted this away from me

devout mesa Aug 4, 2023, 7:39 PM

#

VkValidationFeaturesEXT as well

#

but you really shouldn't use validation layers in your app

#

just use vkconfig

dawn wave Aug 4, 2023, 7:39 PM

#

what

#

ohh

#

use the built-in sdk stuff

#

oh phobos has indeed

#

hidden this away from me

#

AHHH I NEED TO STOP GETTING DISTRACTED

devout mesa Aug 4, 2023, 7:50 PM

#

mate

#

just use vkconfig

dawn wave Aug 4, 2023, 7:51 PM

#

oh Debug Output

#

i completely forgot

#

vkconfig

#

KEKW

#

thank you for reminding me of it

dawn wave Aug 4, 2023, 8:21 PM

#

so uh

#

everything works fine

#

bleakekw

#

yet my uvs

#

scream otherwise

#

I LIED THEY DO

#

Mesh index: 67379424548
[Shader] My albedo_texture ID: 0.000000 - 2955270660

Now my critical thinking brain is telling me

#

67379424548 != 2955270660

#

Hear me out

#

so the issue was

#

actually how i represented my meshes

#

🤔

devout mesa Aug 4, 2023, 8:40 PM

#

Texture ID being float is also very concerning

dawn wave Aug 4, 2023, 8:40 PM

#

kekw that is me being dumb

#

ill change it to int

#

iirc %i

#

struct ObjectDescription {
    // 0 - None
    uint64_t vertex_buffer;
    uint64_t index_buffer;
    uint64_t normal_buffer;
    uint64_t tex_buffer;
    int material;
};

#

hmmmm this should be fine?

devout mesa Aug 4, 2023, 8:42 PM

#

sure

dawn wave Aug 4, 2023, 8:42 PM

#

I just need to make sure to include the scalar block i think

devout mesa Aug 4, 2023, 8:42 PM

#

scalar block layout will save your ass every time

dawn wave Aug 4, 2023, 8:42 PM

#

yeah

#

hmmm

#

#[repr(C)]
#[derive(Clone, Copy, Hash, Eq, PartialEq, Ord, PartialOrd)]
pub struct CMesh {
    pub vertex_buffer: u64,
    pub index_buffer: u64,
    pub normal_buffer: u64,
    pub tex_buffer: u64,
    pub material: i32,
}

devout mesa Aug 4, 2023, 8:44 PM

#

unfortunately I do not read Rust spec

#

so I dunno alignment rules

#

assuming Rust is a sane language, this should be fine

dawn wave Aug 4, 2023, 8:44 PM

#

well repr(C) forces it to follow c alignment rules

devout mesa Aug 4, 2023, 8:44 PM

#

Then it is probably fine, uncertain

dawn wave Aug 4, 2023, 8:44 PM

#

so I think we should be fine?

devout mesa Aug 4, 2023, 8:44 PM

#

do you have #pragma pack(push, 4)?

dawn wave Aug 4, 2023, 8:44 PM

#

huh?

#

oh alignment?

devout mesa Aug 4, 2023, 8:45 PM

#

can you manually tell rust how to align a struct

dawn wave Aug 4, 2023, 8:45 PM

#

yeah

#

align(x)

devout mesa Aug 4, 2023, 8:45 PM

#

i.e: I want to align this to 4 bytes please

dawn wave Aug 4, 2023, 8:45 PM

#

WAIT FUCK

#

we don't

#

hehe

#

hehehe manual alignment

#

😎

#

nvm we do

#

that uh didn't fix it

#

in fact i'm starting to think this debug output

#

is faulty

#

and wrong

devout mesa Aug 4, 2023, 8:48 PM

#

that is extremely unlikely

dawn wave Aug 4, 2023, 8:49 PM

#

it's weird how it;s only outputting that however

#

like you would think it would output other things too for other primitives

#

but it only outputs that

#

also tilting my camera too far will cause it to crash bleakekw

devout mesa Aug 4, 2023, 8:50 PM

#

you may have your vkconfig set to call std::terminate on debug output

dawn wave Aug 4, 2023, 8:51 PM

#

uhh where is that?

#

oh I don't think I did so

#

if you're talking about the Break under Debug Action

devout mesa Aug 4, 2023, 8:54 PM

#

ye that's not it

#

you may have UB I guess

#

does it happen without validation on?

dawn wave Aug 4, 2023, 8:54 PM

#

no it doesn't

#

but oddly only happens with the vkconfig validation layer

#

what

#

the bug fixed itself

#

what the

#

bleakekw

#

it seems like one mesh is causing the behavior

devout mesa Aug 4, 2023, 8:59 PM

#

ah yes

#

bugs fixing itself

#

or as I like to call it

#

undefined behavior

#

or unacceptable behavior

dawn wave Aug 4, 2023, 8:59 PM

#

KEKW

#

ill uh hunt it down

#

it's weird it only happens when the validation layer is on only but the vkconfig one

#

the one phobos has doesn't crash

devout mesa Aug 4, 2023, 9:00 PM

#

just for the record

#

validation layers are one and the same

#

the ones enabled through the app and enabled through vkconfig

#

they call into the same functions and use the same parameters

dawn wave Aug 4, 2023, 9:00 PM

#

oh

#

bleakekw

#

Seems like it's the GPU base causing the crash

#

i lied it was the printf

#

debugPrintfEXT("My albedo_texture ID: \n");

I have no clue how this is even causing the crash

#

WARN  phobos::core::debug             > [VALIDATION]: UNASSIGNED-DEBUG-PRINTF (-1841738615): Validation Warning: [ UNASSIGNED-DEBUG-PRINTF ] Object 0: handle = 0x203f484d020, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x92394c89 | WARNING - Debug Printf message was truncated, likely due to a buffer size that was too small for the message

#

I thought the message size only applies to per-message

#

does it apply to the entire log?

tropic vigil Aug 4, 2023, 9:18 PM

#

btw @dawn wave you can add extensions in phobos just fine

tropic vigil Aug 4, 2023, 9:18 PM

#

dawn wave does it apply to the entire log?

i think so, it writes to a hidden global ssbo

devout mesa Aug 4, 2023, 9:18 PM

#

if you call debugPrintfEXT too many times you will overrun the buffer

dawn wave Aug 4, 2023, 9:18 PM

#

AHHHHH

#

makes sense

devout mesa Aug 4, 2023, 9:18 PM

#

you are supposed to call it once per subgroup or only in one or two invocations

#

it is not a tool to be used lightly

dawn wave Aug 4, 2023, 9:19 PM

#

hm how to have it run once

devout mesa Aug 4, 2023, 9:19 PM

#

if (all(equal(gl_LaunchIDEXT, ivec2(0))))

dawn wave Aug 4, 2023, 9:19 PM

#

gotcha thanks

devout mesa Aug 4, 2023, 9:20 PM

#

or any pixel you want

#

you can specify a range, whatever you want

dawn wave Aug 4, 2023, 9:20 PM

#

Mhm crash is no more

#

that was it thank you

#

I have unfortunate news huston

#

the addresses lineup

#

so it's not input

#

67379780100 = 67379780100

#

i need to think harder

#

the issue must be import then

#

ah i'll nuke the accessor function

#

and redo that and see if that fixes anything

#

Is there a gltf viewer that allows me to read the buffer data decoded?

#

okay so my buffer is correct so it isn;t the loader at least the accessors

#

images...

#

not images too

#

dafauq is causing it then bleakekw

#

Ahhh can someone look at my shader again

#

I'm talking the UV data from the gltf file

#

then using that directly to determine the UVs

#

yes, i have tried to invert the v component

dawn wave Aug 4, 2023, 10:26 PM

#

#

this is what happens when i flip the components around

#

it's cohrenet but f'd up

dawn wave Aug 4, 2023, 10:47 PM

#

JAHAHAHAAH

#

i found my first bug replication

#

#

#

clearly

#

something is wrong

#

#

(rotated wrong)

devout mesa Aug 4, 2023, 11:11 PM

#

barycentrics are supposed to be vec3(1 - u - v, u, v) if that helps

dawn wave Aug 4, 2023, 11:12 PM

#

hmm okok

#

#

does this look right...?

#

const vec3 barycentrics = vec3(1.0 - attribs.x - attribs.y, attribs.x, attribs.y);

#

this should be correct UVs

devout mesa Aug 4, 2023, 11:28 PM

#

I mean I doubt NVIDIA would provide you with wrong barycentrics bleakekw

dawn wave Aug 4, 2023, 11:29 PM

#

KEKW

#

hmmm

#

now it's time to trial and error

#

each gltf file

#

and find the common demoninator

#

i realized the duck models are the same KEKW

#

it's just that they have diffenet lighting

#

#

watbulb

#

#

now the average person wil say

#

"Wow, the channels seem reversed"

devout mesa Aug 4, 2023, 11:35 PM

#

Uh no

#

there are big differences that aren't related to inverted coordinates

dawn wave Aug 4, 2023, 11:35 PM

#

ya

#

maybe the indices are f'd?

#

that can't be possible however

#

if indices were f'd

#

vertices would be

#

so what

devout mesa Aug 4, 2023, 11:37 PM

#

try with even simpler meshes

#

a plane

dawn wave Aug 4, 2023, 11:37 PM

#

it works with stupid simple meshes

devout mesa Aug 4, 2023, 11:37 PM

#

or a cube

#

then something is wrong with how you stuff things into buffers

dawn wave Aug 4, 2023, 11:38 PM

#

this

#

probably

#

as simple meshes work fine

#

/// Convert a slice of bytes as another
fn cast_bytes_slice_type<
    T: 'static + num_traits::ToPrimitive + bytemuck::Pod + Sync,
    U: 'static + num_traits::NumCast + bytemuck::Pod + Send,
>(
    contents: &[u8],
) -> Vec<u8> {
    // If same type, return early
    if std::any::TypeId::of::<T>() == std::any::TypeId::of::<U>() {
        return contents.to_vec();
    }
    let from_size = std::mem::size_of::<T>();
    let target_size = std::mem::size_of::<U>();

    assert_eq!(contents.len() % from_size, 0); // Must be perfectly sliced

    // Cast contents (bytes) -> T -> Cast to U -> Reinterpret back to bytes
    let contents: Vec<U> = bytemuck::cast_slice::<u8, T>(contents)
        .par_iter()
        .map(|x| num_traits::NumCast::from(*x).unwrap())
        .collect();
    bytemuck::cast_slice::<U, u8>(contents.as_slice()).to_vec()
}

#

ah.

#

ah.

#

ah.

#

ah.

devout mesa Aug 4, 2023, 11:41 PM

#

this is all uselessly clamplicated

#

don't you have a way to memcpy all the uvs of a primitive into a vector

dawn wave Aug 4, 2023, 11:42 PM

#

i could

#

tbfh i should

devout mesa Aug 4, 2023, 11:42 PM

#

it's a oneliner in C++

devout mesa Aug 4, 2023, 11:42 PM

#

dawn wave tbfh i should

no

dawn wave Aug 4, 2023, 11:42 PM

#

i could just memcpy it all

devout mesa Aug 4, 2023, 11:42 PM

#

you must

dawn wave Aug 4, 2023, 11:42 PM

#

yeah but type conversions :(

devout mesa Aug 4, 2023, 11:43 PM

#

do you need those

#

have you actually come across a mesh where this code actually does something

#

I haven't

dawn wave Aug 4, 2023, 11:43 PM

#

yes

#

wait have i don't keep track

devout mesa Aug 4, 2023, 11:43 PM

#

well regardless

dawn wave Aug 4, 2023, 11:43 PM

#

well i mainly use it to convert my indices to u32

#

which could be done in 3 lines KEKW

devout mesa Aug 4, 2023, 11:44 PM

#

right that's one type conversion I will allow

#

sometimes models do come with u16 indices

#

but others are just useless

#

I'm not even telling you to nuke this code tbh

#

Just shelve it somewhere and use it when it is needed

#

Otherwise a memcpy will suffice

dawn wave Aug 4, 2023, 11:45 PM

#

ill quickly override it

feral trellis Aug 4, 2023, 11:46 PM

#

dawn wave ```rust /// Convert a slice of bytes as another fn cast_bytes_slice_type< T:...

Holy moly

#

Why all of this bro

#

bytemuck does it for you no?

dawn wave Aug 4, 2023, 11:47 PM

#

KEKW does it?

#

like do numeric conversion?

feral trellis Aug 4, 2023, 11:47 PM

#

Then it isn't a byte cast

#

Why is there a comment saying this is a byte cast

dawn wave Aug 4, 2023, 11:47 PM

#

ah fuck

feral trellis Aug 4, 2023, 11:47 PM

#

If you're doing numeric conversions just use as

dawn wave Aug 4, 2023, 11:47 PM

#

misinformation

dawn wave Aug 4, 2023, 11:48 PM

#

feral trellis If you're doing numeric conversions just use ``as``

kekw rust doesn't let you

#

as least with generics

devout mesa Aug 4, 2023, 11:49 PM

#

common rust L

dawn wave Aug 4, 2023, 11:49 PM

#

i had to use num_traits

#

tried adding a + Into<U>

#

complains about it being a non-primitive cast

feral trellis Aug 4, 2023, 11:50 PM

#

dawn wave as least with generics

Oh yea with generics you can't

#

Forgot to type the 't

dawn wave Aug 4, 2023, 11:51 PM

#

we live another day

feral trellis Aug 4, 2023, 11:51 PM

#

Still odd that you'd require to do something like that though

#

Where do you call cast_bytes_slice_type?

dawn wave Aug 4, 2023, 11:51 PM

#

It's so I can do this

devout mesa Aug 4, 2023, 11:51 PM

#

regardless

dawn wave Aug 4, 2023, 11:52 PM

#

cast_bytes_slice_type<u8, u32>
cast_bytes_slice_type<u16, u32>
cast_bytes_slice_type<..., u32>

devout mesa Aug 4, 2023, 11:52 PM

#

as a human being

#

i beg you

feral trellis Aug 4, 2023, 11:52 PM

#

It seems overcomplicated nyo capperinos

devout mesa Aug 4, 2023, 11:52 PM

#

do the simple thing first

#

like not even in programming

#

in life in general

dawn wave Aug 4, 2023, 11:52 PM

#

yeah but complicated thing better

devout mesa Aug 4, 2023, 11:52 PM

#

shrimple first

devout mesa Aug 4, 2023, 11:52 PM

#

dawn wave yeah but complicated thing better

no

dawn wave Aug 4, 2023, 11:52 PM

#

ok shrimple first

#

silently keeps code

devout mesa Aug 4, 2023, 11:52 PM

#

that's fine

#

just don't use it until you actually need it

dawn wave Aug 4, 2023, 11:53 PM

#

i see i see

#

see it's realistically only being used for my

#

indices

#

hmmmm

feral trellis Aug 4, 2023, 11:55 PM

#

again

make it work properly first, doesn't matter if the code is slow
refactor

devout mesa Aug 4, 2023, 11:56 PM

#

to be fair

#

it'll probably be faster bleakekw

#

but ye

#

at the cost of sounding like a broken record, KISS

#

https://en.m.wikipedia.org/wiki/KISS_principle

#

They even made a wiki page

dawn wave Aug 5, 2023, 12:00 AM

#

ok i give up

#

ill memcpy

feral trellis Aug 5, 2023, 12:01 AM

#

Yess I love kiss (KISS)

dawn wave Aug 5, 2023, 12:03 AM

#

#

that uh didn't solve it

#

devout mesa Aug 5, 2023, 12:04 AM

#

that's one less place to look at then

dawn wave Aug 5, 2023, 12:05 AM

#

hmmm mismatched accessors?

#

nope

#

Tex buffer used by: Some("V-Tech_0 0"). Index: 6. Name: Some("V-Tech_0 0 accessor Gltf(TexCoords(0)) 6")

#

🫡 ethereal bug

#

after a whole day of bug hunting

#

this bug alludes me

#

🫡

#

indices can't be wrong.

#

i know that for sure

dawn wave Aug 5, 2023, 12:49 AM

#

#

#

how do you i put it...

#

it seems wrong?

dawn wave Aug 5, 2023, 1:12 AM

#

bro i'm so done with this bug man

#

i've verified that my buffers are indeed the same

#

wtf do i do

#

is it because the gltf package is importing things wrong?

devout mesa Aug 5, 2023, 9:14 AM

#

this is just sRGB vs non sRGB

dawn wave Aug 5, 2023, 10:03 AM

#

Ahhhh i haven’t learnt much of that yet

dawn wave Aug 5, 2023, 11:19 AM

#

IH NY GOD

#

IS IT BECAUSE OF SRGB

#

NO WAY

#

OH MY FUCKING GOD

#

IS IT BECAUSE OF THAT?

#

NO WAY

devout mesa Aug 5, 2023, 11:22 AM

#

srgb won't make a chunk of sponza have 0 uvs

dawn wave Aug 5, 2023, 11:23 AM

#

oh 😢

#

yeah srgb really shouldn't affect anything

devout mesa Aug 5, 2023, 11:23 AM

#

my reference sponza image is srgb btw

dawn wave Aug 5, 2023, 11:24 AM

#

devout mesa Aug 5, 2023, 11:26 AM

#

looks correct now

dawn wave Aug 5, 2023, 11:26 AM

#

oh that was your iamge KEKW

#

i just repasted it so i don't have to scroll up

devout mesa Aug 5, 2023, 11:26 AM

#

epic

dawn wave Aug 5, 2023, 11:26 AM

#

i'm crying rn this bug is a menace

#

0.012300 29.703600 i:40 id:37

#

🤔

#

it seems fucked

devout mesa Aug 5, 2023, 11:28 AM

#

this be the uv?

dawn wave Aug 5, 2023, 11:28 AM

#

yeah

#

of the red wall in that image

devout mesa Aug 5, 2023, 11:28 AM

#

definitely fucked yes

dawn wave Aug 5, 2023, 11:28 AM

#

hmm possible unintentional offset?

#

i'll try something stupid

devout mesa Aug 5, 2023, 11:29 AM

#

it actually looks like the x and y components are swapped

dawn wave Aug 5, 2023, 11:29 AM

#

i tried doing that

#

but it ends up fucked

#

ill play around with it

#

shifting does not help

#

ill try to reverse uit

#

0.012300 14.850000 i:62 id:37

#

uh

#

this seems wrong

#

swapping did not work

dawn wave Aug 5, 2023, 12:20 PM

#

hyh

#

so it is swapped

#

14.85, 0.0123000145,

#

wait is it...

dawn wave Aug 5, 2023, 12:45 PM

#

there is an offset

#

i can't figure out why

#

it seems to be -1.000

#

meaning UB

#

Buffer [0.6061, 0.9925]
vs
Shader -1.000000 0.606090

#

like it's obvious what the data is supposed to be

devout mesa Aug 5, 2023, 12:46 PM

#

what are you comparing

dawn wave Aug 5, 2023, 12:46 PM

#

data in the buffer itself

devout mesa Aug 5, 2023, 12:46 PM

#

versus?

#

which is which

dawn wave Aug 5, 2023, 12:47 PM

#

wdym?

devout mesa Aug 5, 2023, 12:47 PM

#

Ah there it is

#

very much wrong indeed

dawn wave Aug 5, 2023, 12:47 PM

#

yeah it seems to be a shift

devout mesa Aug 5, 2023, 12:47 PM

#

at least you have a lead

dawn wave Aug 5, 2023, 12:47 PM

#

idfk how that -1 is ending up there

#

as my buffer views are correct

devout mesa Aug 5, 2023, 12:48 PM

#

-1.0 is 0xbf800000

#

if that helps

dawn wave Aug 5, 2023, 12:49 PM

#

hmm

layout(buffer_reference, scalar) buffer TexCoords { vec2 v[]; }; // TexCoords

I believe this is fine for Vec2_F32

#

layout(buffer_reference, scalar) buffer Indices {ivec3 i[]; }; // Triangle indices

HMMMMM

#

all my indices should be uint

#

that fixed nothing

#

bleakekw

#

a shift that randomly appears...

devout mesa Aug 5, 2023, 12:57 PM

#

I really don't think the issue is in the shader

#

as a quick test you could try displaying gl_PrimitiveID

dawn wave Aug 5, 2023, 12:57 PM

#

Well my buffer says everything is perfectly fine

#

hmm ill try

#

but I doubt that is the issue

devout mesa Aug 5, 2023, 12:57 PM

#

ye, it's how you memcpy it into the phobos buffer

#

if there is a mismatch between what the GPU sees and what the CPU sees

dawn wave Aug 5, 2023, 12:58 PM

#

I checked already on the GPU

devout mesa Aug 5, 2023, 12:58 PM

#

then the vkCmdCopyBuffer or the memcpy(buffer.mapped, ...) is wrong

dawn wave Aug 5, 2023, 12:58 PM

#

there wasn't any issues

#

bleakekw

#

it is pulling a -1.000 out of it's arse

#

maybe i'm calculating my offsets wrong?

#

see shifting it back

#

by 4 bytes

#

reproduces it

#

uh i'm a bit stupid

#

how would I convert a bufferview's vkaddress (962140119452) into an index usable by nsight?

devout mesa Aug 5, 2023, 1:07 PM

#

KEKW

dawn wave Aug 5, 2023, 1:08 PM

#

bleakekw

devout mesa Aug 5, 2023, 1:08 PM

#

you don't KEKW

#

ye BDA tooling is sad

dawn wave Aug 5, 2023, 1:08 PM

#

wtf am i supposed to do then

devout mesa Aug 5, 2023, 1:08 PM

#

go into the device memory tool and find the buffer

dawn wave Aug 5, 2023, 1:09 PM

#

i uh found it

#

zero clue how to convert it though

devout mesa Aug 5, 2023, 1:10 PM

#

wym convert

dawn wave Aug 5, 2023, 1:10 PM

#

take the address given and find the index

devout mesa Aug 5, 2023, 1:11 PM

#

yeah no that's not how addresses work

dawn wave Aug 5, 2023, 1:11 PM

#

pain

devout mesa Aug 5, 2023, 1:11 PM

#

GPUs too use virtual memory

dawn wave Aug 5, 2023, 1:12 PM

#

this is a problem i cant seem to fix bleakekw i got zero clue what is causing this
My buffers on cpu are fine

#

gpu seem fine

#

but that assumes the offsets are right which i assume they would be

#

maybe this is some fukery related to alignment?

#

But buffers aren't subjected to those same rules

devout mesa Aug 5, 2023, 1:15 PM

#

I can't compile your shit

#


error[E0560]: struct `phobos::image::ImageCreateInfo` has no field named `memory_type`
   --> src\assets\scene\loader\gltf.rs:769:21
    |
769 |                     memory_type: phobos::MemoryType::GpuOnly,
    |                     ^^^^^^^^^^^ `phobos::image::ImageCreateInfo` does not have this field
    |
    = note: available fields are: `width`, `height`, `depth`, `usage`, `format` ... and 3 others

dawn wave Aug 5, 2023, 1:15 PM

#

oh KEKW i haven't updated it

#

my changes to the git

devout mesa Aug 5, 2023, 1:16 PM

#

this man making me write rust

#

smh

dawn wave Aug 5, 2023, 1:16 PM

#

LMAOO you don't need to 😭

#

it's fine i'll uh mald through this

devout mesa Aug 5, 2023, 1:16 PM

#

match image_data.format {
    Format::R8 | Format::R16 => vk::Format::R8G8B8A8_UNORM,
    Format::R8G8 | Format::R16G16 => vk::Format::R8G8B8A8_UNORM,
    Format::R8G8B8 | Format::R16G16B16 | Format::R32G32B32FLOAT => {
        vk::Format::R8G8B8A8_UNORM
    }
    Format::R8G8B8A8 | Format::R16G16B16A16 | Format::R32G32B32A32FLOAT => {
        vk::Format::R8G8B8A8_UNORM
    }
}``` also wtf is this

dawn wave Aug 5, 2023, 1:16 PM

#

shhh

devout mesa Aug 5, 2023, 1:16 PM

#

you return the same thing all the time

dawn wave Aug 5, 2023, 1:16 PM

#

yeah i know

#

it's old cod-

devout mesa Aug 5, 2023, 1:17 PM

#

epic

#

just push

#

something that I can compile

dawn wave Aug 5, 2023, 1:17 PM

#

will it even work on your system bleakekw

#

main.rs 102 is where you indicate file location to load assets

devout mesa Aug 5, 2023, 1:18 PM

#

not an issue

#

unless you use SER i can run anything

dawn wave Aug 5, 2023, 1:18 PM

#

SER?

devout mesa Aug 5, 2023, 1:18 PM

#

shader execution reordering

dawn wave Aug 5, 2023, 1:18 PM

#

oh heard that new tech was really good for having a shit ton of shaders

#

also changes pushed

devout mesa Aug 5, 2023, 1:19 PM

#

"use of unstable library feature" what

dawn wave Aug 5, 2023, 1:19 PM

#

what

#

oh fuck you need to switch over to unstable branch of rust

devout mesa Aug 5, 2023, 1:20 PM

#

how do I do that

dawn wave Aug 5, 2023, 1:20 PM

#

rustup install nightly
rustup override set nightly

#

do in the project directory

#

oh yeah ignore anything to do with transition layout KEKW

#

it was blindly copy pasting it from older code

#

so it's gonna produce errors

#

oh yeah scroll wheel to increase camera speed

devout mesa Aug 5, 2023, 1:25 PM

#

damn it's unbearably slow

dawn wave Aug 5, 2023, 1:25 PM

#

yeah ik that's because the uh

#

printf thingy

#

if i disable it, it becomes way faster

devout mesa Aug 5, 2023, 1:26 PM

#

no, the loading

dawn wave Aug 5, 2023, 1:26 PM

#

oh yeah it's shitte

#

i made it all single threaded

#

cuz i became paranoid it was misordering of stuff

devout mesa Aug 5, 2023, 1:27 PM

#

nah, singlethreaded is good

#

I can load bistro in less than a second, singlethreaded

dawn wave Aug 5, 2023, 1:27 PM

#

oh then it's doodoo architecture

#

or the gltf importing

#

i'm using the default one by the package KEKW

#

that might also be why

#

ill try to add padding and see if that fixes it

#

istg if this was padding issues this whole time

#

@devout mesa IT WAS PADDING

#

LMAOOOOO

#

IT WAS FUCKING PADDING

#

devout mesa Aug 5, 2023, 1:31 PM

#

this man managed to get a padding issue with scalar block layout

dawn wave Aug 5, 2023, 1:32 PM

#

idfk how i did it too

#

all my types are multiples of 4

#

oh no

#

problem still exists

#

bleakekw manual padding

#

you know

#

i think you were right

#

in the idea of making giant f32 vecs

#

dealing with the mess that this is

#

oml

dawn wave Aug 5, 2023, 2:01 PM

#

It isn't that bad nvm

#

I compacted all my buffers into one vector which is why i got alignment issues. I didn't align them

#

#

tears in my eyes

#

i need mip mapping

devout mesa Aug 5, 2023, 2:16 PM

#

was it padding?

dawn wave Aug 5, 2023, 2:16 PM

#

yeah

#

So I was storing it all into one monlithic buffer

#

but storing it as bytes

#

so I could just throw it all into it

#

and I forgor padding

#

it was a simple fix. alignment - (offset % alignment) where alignment is size of dimension * component_size

devout mesa Aug 5, 2023, 2:18 PM

#

epic

devout mesa Aug 5, 2023, 2:18 PM

#

dawn wave i need mip mapping

now about that

#

KEKW

#

good luck my boy

dawn wave Aug 5, 2023, 2:18 PM

#

🫡

#

it can't be as bad as the padding issue

#

that's all i know

devout mesa Aug 5, 2023, 2:18 PM

#

KEKW

#

sure KEKW

dawn wave Aug 5, 2023, 2:18 PM

#

i'm gonna settle of linear mip maps and no more none of that fancy compute shader stuff with like trilinear or smth whatever penguin did

devout mesa Aug 5, 2023, 2:19 PM

#

I'm afraid, but mipmaps are a sort of fever dream with RT

#

it's not as easy as enabling them

dawn wave Aug 5, 2023, 2:19 PM

#

bleakekw

#

wdym

devout mesa Aug 5, 2023, 2:19 PM

#

well go ahead and try different things

dawn wave Aug 5, 2023, 2:19 PM

#

oh no

#

Could you uh

#

not use distance from origin to hit to determine the mip map level?

#

or am I beyond brain dead

devout mesa Aug 5, 2023, 2:20 PM

#

no

#

do you know how mips work with regular rendering

dawn wave Aug 5, 2023, 2:21 PM

#

not really bleakekw I know that they're smaller compressed versions of their original textures which are then selected depending on their distance

devout mesa Aug 5, 2023, 2:21 PM

#

I'm strictly speaking about selecting a mip btw

#

and no, they are not selected based on distance

#

when you call texture the hw will compute a gradient for your uvs and compute partial derivatives

#

these derivatives are used in the formula 1 + floor(log2(max(dudx/dudy, dvdx/dvdy)))

dawn wave Aug 5, 2023, 2:24 PM

#

mhm

devout mesa Aug 5, 2023, 2:24 PM

#

this ain't possible with RT

#

because you don't have triangles from neighboring invocations to take derivatives from

#

you have rays

#

and rays can intersect any triangle of the scene

#

so you get ridiculous numbers

dawn wave Aug 5, 2023, 2:26 PM

#

mhm

devout mesa Aug 5, 2023, 2:26 PM

#

therefore

#

I present to you two solutions

#

https://media.contentapi.ea.com/content/dam/ea/seed/presentations/2019-ray-tracing-gems-chapter-20-akenine-moller-et-al.pdf

#

https://graphics.stanford.edu/papers/trd/

#

The second one is easier than the first one, but exponentially more expensive

dawn wave Aug 5, 2023, 2:27 PM

#

ray cones

#

:D

#

so this mayber

#

is worse

#

bleakekw

#

this looks like hell

#

so does a ray cone

#

basically simulate what we want from the pixel quad?

devout mesa Aug 5, 2023, 2:30 PM

#

uh

#

disclaimer

#

I don't understand either of these techniques bleakekw

dawn wave Aug 5, 2023, 2:30 PM

#

Oh bleakekw

devout mesa Aug 5, 2023, 2:30 PM

#

so good luck

dawn wave Aug 5, 2023, 2:30 PM

#

LVSTRI i'm gonna join you in radiance only

#

textures are for nerds

#

oh

#

they have code

#

thank god

#

okay we're safe

#

oh

#

it isn't that bad

#

huh

#

I think I understand it?

#

Oh it makes sense

#

#

https://tenor.com/view/ah-shit-here-we-go-gif-15190379

Tenor

dawn wave Aug 5, 2023, 5:37 PM

#

ah fuck this

#

let's do actual ray tracing

#

i'll get punctual lights working

#

then it's off to the rays

#

i wanna pretty lights not mf debugging

devout mesa Aug 5, 2023, 5:40 PM

#

one piece of advice

#

iteration >>> recursion

#

do not even consider recursion where possible

dawn wave Aug 5, 2023, 5:40 PM

#

yeah i've learnt that from the nvidia

#

recursion -> oh no

#

me when my shader exponentially recursively grows

#

ahh i need to restudy raytracing theory and all i completely forgor it all

devout mesa Aug 5, 2023, 5:42 PM

#

I'll tell you raytracing theory

#

random

dawn wave Aug 5, 2023, 5:42 PM

#

KEKW

devout mesa Aug 5, 2023, 5:42 PM

#

just random

dawn wave Aug 5, 2023, 5:42 PM

#

Integration -> Sum

devout mesa Aug 5, 2023, 5:43 PM

#

now go trace light

#

with randomness

dawn wave Aug 5, 2023, 5:43 PM

#

but pdfs :(

#

those are scary

#

i've never understood them

devout mesa Aug 5, 2023, 5:43 PM

#

random

#

everything is a normal distribution

#

do random

#

think later

#

random first

dawn wave Aug 5, 2023, 5:44 PM

#

bleakekw

#

random

#

shoot random

#

oh wait brdf

#

eh lambertian

devout mesa Aug 5, 2023, 5:56 PM

#

bro legit just do

for (bounce = 0; bounce < N; ++bounce) {
    trace_ray();
    if (hit) {
        ray_color *= hit.material.color;
        incoming_light += hit.material.emissive_strength * hit.material.emissive_color * ray_color;
        ray.origin = ray.origin + ray.t * ray.direction;
        ray.direction = random_lmao();
    } else {
        break;
    }
}
imageStore(output, gl_LaunchIDEXT.xy, incoming_light);

dawn wave Aug 5, 2023, 5:56 PM

#

start shrimple ok

dawn wave Aug 5, 2023, 8:14 PM

#

AHHHHHHHHHHHHHHHHHHHHHHHHHHHH

#

alignment

#

once again

#

/// Represents the material c-struct for use in shaders
#[repr(C, align(16))]
#[derive(Copy, Clone, PartialOrd, PartialEq)]
pub struct CMaterial {
    pub albedo_texture: i32,
    pub albedo_color: [f32; 3],
    pub normal_texture: i32,
    pub emissive_texture: i32,
    pub emissive_factor: [f32; 3],
}

#

bleakekw

#

this still doesn't work

devout mesa Aug 5, 2023, 8:17 PM

#

why the hell align 16

#

do you hate yourself

#

align 4

dawn wave Aug 5, 2023, 8:17 PM

#

yeah but it's complaining about the stride not be a multiple of 16

devout mesa Aug 5, 2023, 8:17 PM

#

who's bitching

dawn wave Aug 5, 2023, 8:17 PM

#

the validation layer

#

and it crashes

#

 ERROR phobos::core::debug             > [VALIDATION]: VUID-VkShaderModuleCreateInfo-pCode-01379 (706474367): Validation Error: [ VUID-VkShaderModuleCreateInfo-pCode-01379 ] Object 0: handle = 0x2283e778f30, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x2a1bf17f | SPIR-V module not valid: Structure id 40 decorated as Block for variable in StorageBuffer storage class must follow relaxed storage buffer layout rules: member 0 contains an array with stride 36 not satisfying alignment to 16

#

Do I just bite the bullet

#

and add padding into the struct itself?

devout mesa Aug 5, 2023, 8:18 PM

#

do you use scalar block layout

#

for that ssbo

dawn wave Aug 5, 2023, 8:18 PM

#

yes

devout mesa Aug 5, 2023, 8:19 PM

#

are you sure

dawn wave Aug 5, 2023, 8:19 PM

#

layout (set = 1, binding = 2, scalar) buffer MaterialDescription_ {
    MaterialDescription m[];
} MaterialDescriptionArray;

Seems very scalar to me

#

also alignment issues somehow still exist bleakekw

#

/// Describes the material properties of the object
struct MaterialDescription {
    // -1 - None
    int albedo_texture;
    vec3 albedo_factor;
    int normal_texture;
    int emissive_texture;
    vec3 emissive_factor;
};

#

ahhh ill bite the bullet

#

and just throw junk data for padding

dawn wave Aug 5, 2023, 8:40 PM

#

AHHH

#

i don't get it dawg

#

i'm so lost why it is complaining about this

devout mesa Aug 5, 2023, 8:42 PM

#

btw

#

I use vec3's all the time with scalar block layout

#

And there has never been any complaint, so there must be something wrong

#

did you recompile your shaders

dawn wave Aug 5, 2023, 8:42 PM

#

yes hmmm

#

ahh ill play it safe

#

convert my structs to bytes

#

then upload it

devout mesa Aug 5, 2023, 8:43 PM

#

wat

dawn wave Aug 5, 2023, 8:43 PM

#

i don't get it either

devout mesa Aug 5, 2023, 8:44 PM

#

you weren't doing that?

dawn wave Aug 5, 2023, 8:44 PM

#

no i was letting phobos do it

#

it was probably tightly packing all of it

#

which is possibly why it borked

devout mesa Aug 5, 2023, 8:44 PM

#

which is good actually

#

you want everything contiguous, zero padding

dawn wave Aug 5, 2023, 8:45 PM

#

yeah and i end up with alignment issues with me textures

#

it's how i ended up getting a normal texture of a flower to show up

#

100% certain

#

#

this is the same behavior

#

of misaligned (these are supposed to be normals)

devout mesa Aug 5, 2023, 8:52 PM

#

dawn wave convert my structs to bytes

Does this work

#

remember to align(4)

dawn wave Aug 5, 2023, 8:53 PM

#

no :(

#

it didn't fix it

devout mesa Aug 5, 2023, 8:55 PM

#

uh

#

I dunno what kind of issue this is tbh

#

it could be a skill issue

#

or a Rust issue

#

or a phobos issue bleakekw

dawn wave Aug 5, 2023, 8:55 PM

#

https://tenor.com/view/skillissue-skill-issue-gif-22125481

Tenor

tropic vigil Aug 5, 2023, 8:59 PM

#

devout mesa or a phobos issue <:bleakekw:1082598350303539240>

I hope not

#

bleakekw

dawn wave Aug 5, 2023, 8:59 PM

#

no way phobos

#

mfw the normals give me the tangent

#

this is a certified alignment moment

devout mesa Aug 5, 2023, 9:02 PM

#

scalar block layout was supposed to save you from alignment

#

at least it did for me bleakekw

dawn wave Aug 5, 2023, 9:02 PM

#

it betrayed me

#

f32, int

#

shouldn't cause issues

#

why

#

WHAT DOES THIS

#

EVEN MEAN ANYMORE

#

 ERROR phobos::core::debug             > [VALIDATION]: UNASSIGNED-Debug-Printf (-1804403757): Validation Error: [ UNASSIGNED-Debug-Printf ] Object 0: handle = 0x1b44e54a300, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x9472fbd3 | Error during shader instrumentation: line 176: Structure id 40 decorated as Block for variable in StorageBuffer storage class must follow relaxed storage buffer layout rules: member 0 contains an array with stride 36 not satisfying alignment to 16```

tropic vigil Aug 5, 2023, 9:15 PM

#

array elements must align to 16 bytes

dawn wave Aug 5, 2023, 9:15 PM

#

they are bleakekw

devout mesa Aug 5, 2023, 9:15 PM

#

there is no array in the material struct

tropic vigil Aug 5, 2023, 9:15 PM

#

was

devout mesa Aug 5, 2023, 9:15 PM

#

also what the hell is that rule, never heard of it lol

dawn wave Aug 5, 2023, 9:16 PM

#

do I just change my struct to align(16)?

tropic vigil Aug 5, 2023, 9:16 PM

#

devout mesa also what the hell is that rule, never heard of it lol

it also holds for non scalar

devout mesa Aug 5, 2023, 9:16 PM

#

I mean

tropic vigil Aug 5, 2023, 9:16 PM

#

dawn wave do I just change my struct to align(16)?

your MaterialDescription struct is 36 bytes

#

just pad it manually to 48

#

imo

dawn wave Aug 5, 2023, 9:18 PM

#

ahh junk data

#

bet

devout mesa Aug 5, 2023, 9:18 PM

#

I have structs that have odd byte sizes btw

#

never had vulkan complain lol

dawn wave Aug 5, 2023, 9:19 PM

#

well my vulkan is built different

tropic vigil Aug 5, 2023, 9:19 PM

#

lol

dawn wave Aug 5, 2023, 9:22 PM

#

hmmm

devout mesa Aug 5, 2023, 9:23 PM

#

I have a buffer that's 1584365 bytes in size

dawn wave Aug 5, 2023, 9:23 PM

#

so i figured it out

#

it seems to think

#

wait

#

it's a shift

#

again

#

oh my god

#

no i refuse to deal with this

#

if i pretend the issue does not exist

#

it doesn't exist 😏

tropic vigil Aug 5, 2023, 9:32 PM

#

devout mesa I have a buffer that's 1584365 bytes in size

watbulb

#

why

dawn wave Aug 5, 2023, 9:34 PM

#

ah. it's 100% an alignment issue

#

i can't figure out what would be causing it

tropic vigil Aug 5, 2023, 9:35 PM

#

its tricky to track down

#

i just never use vec3s tbh

dawn wave Aug 5, 2023, 9:35 PM

#

it's obvious as

this does not affect smaller meshes
this does affect larger meshes
it's a small shift of 1-2 indices

#

kowalski analysis

tropic vigil Aug 5, 2023, 9:36 PM

#

struct MaterialDescription {
    // -1 - None
    vec4 albedo; // xyz is factor, w is texture (cast to int)
    vec4 emissive; // same
    int4 normal; // x used, yzw unused
};

#

this is what i would use

dawn wave Aug 5, 2023, 9:36 PM

#

OHHHHHHHHHH

#

cook

#

wait what about tangents?

tropic vigil Aug 5, 2023, 9:37 PM

#

what about them

dawn wave Aug 5, 2023, 9:37 PM

#

nvm i'm stupid

#

KEKW

tropic vigil Aug 5, 2023, 9:37 PM

#

bleakekw

dawn wave Aug 5, 2023, 9:37 PM

#

i'll yoink and twist that

#

this wouldn't be align to 16 bytes however

#

wait i'm brain dead

#

please ignore me

tropic vigil Aug 5, 2023, 9:39 PM

#

it does KEKW

dawn wave Aug 5, 2023, 9:39 PM

#

4*4

#

i literally forgor

#

Praige

#

no work :(

#

WAIT

#

THIS WAS BETRAYAL BY MY ASSET SYSTEM

#

plot twist of the century

tropic vigil Aug 5, 2023, 9:56 PM

#

lmao

dawn wave Aug 5, 2023, 9:57 PM

#

i was an idiot

#

i used my texture

devout mesa Aug 5, 2023, 9:57 PM

#

tropic vigil why

well you see, uint8

dawn wave Aug 5, 2023, 9:57 PM

#

to determine the index of the image and not my image

#

#

hehehe

#

now uh how do i make an image that i can use to average out my results

#

i forgor

tropic vigil Aug 5, 2023, 10:01 PM

#

make storage image

#

if (pc.frame_id > 0) {
        vec3 old_color = imageLoad(old_image_in, ivec2(gl_LaunchIDEXT.xy)).xyz;
        // Calculate contribution ratio of this frame's color data
        float a = 1.0f / float(pc.frame_id + 1);
        // Mix the old and new colors together
        vec3 final_color = mix(old_color, hit_value, a);
        // Store to the image
        imageStore(rt_out, ivec2(gl_LaunchIDEXT.xy), vec4(final_color, 1.0));
    } else {
        // This is the first frame rendering this scene, we don't need to do any 
        // accumulation, simply store the value
        imageStore(rt_out, ivec2(gl_LaunchIDEXT.xy), vec4(hit_value, 1.0));
    }

#

increment frame_id and reset when anything changes

dawn wave Aug 5, 2023, 10:02 PM

#

hmm okokok

devout mesa Aug 5, 2023, 10:03 PM

#

why do you want to average results you don't have

#

first you get results

#

then you average

tropic vigil Aug 5, 2023, 10:03 PM

#

bleakekw

#

real

dawn wave Aug 5, 2023, 10:03 PM

#

you're not wrong

devout mesa Aug 5, 2023, 10:03 PM

#

I will not allow you to write averaging code until I see a noisy image

dawn wave Aug 5, 2023, 10:03 PM

#

okok

#

let me get results first

#

uh skybox

#

= blue

#

:)

dawn wave Aug 5, 2023, 10:28 PM

#

fuck how do you generate

#

random ahh directions

devout mesa Aug 5, 2023, 10:32 PM

#

generate 3 random numbers with a normal distribution

#

normalize the result

#

a normal distribution is spherically symmetrical

tropic vigil Aug 5, 2023, 10:39 PM

#

Im not sure if that’s uniform

dawn wave Aug 5, 2023, 10:39 PM

#

uniform?

#

oh the same probability all around

#

i don't think it would be

devout mesa Aug 5, 2023, 10:40 PM

#

it's uniformly distributed on a unit sphere

tropic vigil Aug 5, 2023, 10:41 PM

#

Alright

#

Ill believe it

devout mesa Aug 5, 2023, 10:42 PM

#

lemme get the source

dawn wave Aug 5, 2023, 10:42 PM

#

how to uh generate normal distribution of random number

#

fuck nvm,

devout mesa Aug 5, 2023, 10:43 PM

#

https://stats.stackexchange.com/questions/7977/how-to-generate-uniformly-distributed-points-on-the-surface-of-the-3-d-unit-sphe

dawn wave Aug 5, 2023, 10:56 PM

#

uh how would I calculate the final color

devout mesa Aug 5, 2023, 10:58 PM

#

devout mesa bro legit just do ```glsl for (bounce = 0; bounce < N; ++bounce) { trace_ray...

see here

dawn wave Aug 5, 2023, 10:59 PM

#

maybe I'm stupid but how is ray_color relevant then?

devout mesa Aug 5, 2023, 10:59 PM

#

I forgor to mul it by the inc light

dawn wave Aug 5, 2023, 10:59 PM

#

lmaoo okok it makes sense

devout mesa Aug 5, 2023, 10:59 PM

#

there

dawn wave Aug 5, 2023, 11:02 PM

#

ah fuck i forgot

#

in emissive textures

#

R channel is the only one you only care about yeah

#

no im stupid

#

#

i am begging

#

can i finally average :D

#

pls

devout mesa Aug 5, 2023, 11:08 PM

#

good, you may average

dawn wave Aug 5, 2023, 11:10 PM

#

aw fuck

#

it's too late i'm addicted to staring at sponza

#

it's joever

devout mesa Aug 5, 2023, 11:11 PM

#

Ah yes

#

I have experienced that as well

dawn wave Aug 5, 2023, 11:11 PM

#

i wonder what bistro is like

#

did you have emissives in your model you sent to me

devout mesa Aug 5, 2023, 11:13 PM

#

probably I dunno

#

just do sunlight

dawn wave Aug 5, 2023, 11:13 PM

#

ik one doesn't have it

devout mesa Aug 5, 2023, 11:14 PM

#

sun

#

make the sun illuminate le sponza

dawn wave Aug 5, 2023, 11:14 PM

#

no :(

devout mesa Aug 5, 2023, 11:14 PM

#

yes

dawn wave Aug 5, 2023, 11:15 PM

#

nuh yh

devout mesa Aug 5, 2023, 11:15 PM

#

the sun is epic

#

#1090390868449558618 message

#

look how gud the sun is

dawn wave Aug 5, 2023, 11:15 PM

#

ok fine

#

🫡 goodbye pc

#

there has to be a better way of formatting my images

#

it takes up 90% of my loading time

#

for doing something relatively minor

devout mesa Aug 5, 2023, 11:16 PM

#

I have never had to poke an image's format btw

dawn wave Aug 5, 2023, 11:16 PM

#

kekw

#

wtf how did you get

#

r8g8b8 to work then

#

what format did you use?

devout mesa Aug 5, 2023, 11:17 PM

#

I did not

#

I always use rgba8

dawn wave Aug 5, 2023, 11:17 PM

#

o-

devout mesa Aug 5, 2023, 11:17 PM

#

I just don't care about it

dawn wave Aug 5, 2023, 11:17 PM

#

wtf

#

i try to do that

#

then crash

devout mesa Aug 5, 2023, 11:17 PM

#

either rgba8 srgb or unorm depending on the texture

dawn wave Aug 5, 2023, 11:17 PM

#

yeah i try setting my format to r8g8b8

#

then it crashes

#

and say it's unsupported

devout mesa Aug 5, 2023, 11:18 PM

#

right, no one supports rgb8

dawn wave Aug 5, 2023, 11:18 PM

#

ya

#

maybe i'm doing this wrong then KEKW

devout mesa Aug 5, 2023, 11:18 PM

#

just use rgba

dawn wave Aug 5, 2023, 11:18 PM

#

yeah but that means i have to go through each pixel and add an A channel

devout mesa Aug 5, 2023, 11:18 PM

#

what kind of textures require you to do that

dawn wave Aug 5, 2023, 11:19 PM

#

huh i assumed you had to add the a channel

devout mesa Aug 5, 2023, 11:19 PM

#

no I mean

dawn wave Aug 5, 2023, 11:19 PM

#

or else it would end up taking the next pixel's R channel

devout mesa Aug 5, 2023, 11:19 PM

#

usually you can load base color and normal textures as rgba just fine

#

I recall

#

hmm

#

yes you mentioned your gltf library being dumb and stupid

dawn wave Aug 5, 2023, 11:21 PM

#

yeah

#

it doesn't automatically format the images i import in

#

as rgba

#

nono it insist

#

i take the rgb

#

because uh

#

KEKW

#

I'll probably find another image import crate

#

that can do that for me

devout mesa Aug 5, 2023, 11:22 PM

#

yes

dawn wave Aug 5, 2023, 11:22 PM

#

anyways

#

#

🫘 stro

devout mesa Aug 5, 2023, 11:23 PM

#

sun

dawn wave Aug 5, 2023, 11:23 PM

#

#

i dimmed it

devout mesa Aug 5, 2023, 11:23 PM

#

I want a sun right now

#

right this instant

#

you have 5 picoseconds

dawn wave Aug 5, 2023, 11:23 PM

#

oh fuck

#

how to generate sun

#

i need like shit tons of hydrogen

devout mesa Aug 5, 2023, 11:24 PM

#

I'll leave that as an exercise

#

hint: you don't make a sun by making a literal flaming ball of death

dawn wave Aug 5, 2023, 11:24 PM

#

devout mesa Aug 5, 2023, 11:24 PM

#

you use good ol math

dawn wave Aug 5, 2023, 11:24 PM

#

probably but rn i should focus more on getting my entire engine polished

#

shrimple then refine

devout mesa Aug 5, 2023, 11:25 PM

#

no

#

I'm willing to make an exception for pretty graphics

dawn wave Aug 5, 2023, 11:25 PM

#

KEKW

devout mesa Aug 5, 2023, 11:25 PM

#

pretty graphics rule

dawn wave Aug 5, 2023, 11:25 PM

#

ReSTIR any%

devout mesa Aug 5, 2023, 11:26 PM

#

anyway

#

make sun

#

with mathematique

dawn wave Aug 5, 2023, 11:26 PM

#

KEKW

devout mesa Aug 5, 2023, 11:26 PM

#

think, what is a sun ray

dawn wave Aug 5, 2023, 11:26 PM

#

let me add averaging

devout mesa Aug 5, 2023, 11:26 PM

#

no sun is easier

#

do sun first

dawn wave Aug 5, 2023, 11:26 PM

#

think

#

a sphere

devout mesa Aug 5, 2023, 11:26 PM

#

a sun ray is a sphere?

dawn wave Aug 5, 2023, 11:26 PM

#

but realistically a circle

#

oh a ray

#

KEKW

devout mesa Aug 5, 2023, 11:27 PM

#

what direction do sun rays have

dawn wave Aug 5, 2023, 11:27 PM

#

1

#

usually uniform

devout mesa Aug 5, 2023, 11:27 PM

#

what the hell do you mean 1

#

magnitude?

dawn wave Aug 5, 2023, 11:27 PM

#

im so lost

#

like general direction or like direction direction

devout mesa Aug 5, 2023, 11:28 PM

#

think about the sun irl

dawn wave Aug 5, 2023, 11:28 PM

#

oh

#

infinite?

devout mesa Aug 5, 2023, 11:28 PM

#

yes

#

well 150 million km away but we can consider that infinite distance bleakekw

#

so we can think about sun rays being always in the same direction

#

ie parallel to each other

#

now how do you trace a sun ray

dawn wave Aug 5, 2023, 11:30 PM

#

you just point that ray in the direction to the sun

devout mesa Aug 5, 2023, 11:30 PM

#

yes

dawn wave Aug 5, 2023, 11:30 PM

#

wait how would i add this nicely

#

without having to do a seperate ray trace

#

for the sun for each bounce

devout mesa Aug 5, 2023, 11:30 PM

#

what happens then

dawn wave Aug 5, 2023, 11:30 PM

#

if it misses, then it's in the sunlgiht therefore sun

devout mesa Aug 5, 2023, 11:32 PM

#

wrong

#

not for each bounce

dawn wave Aug 5, 2023, 11:32 PM

#

the final bounce?

devout mesa Aug 5, 2023, 11:32 PM

#

yes

dawn wave Aug 5, 2023, 11:32 PM

#

hmhmhm okok

#

you know

#

what is a virtual resource

devout mesa Aug 5, 2023, 11:41 PM

#

wat

#

where did this come from

dawn wave Aug 5, 2023, 11:41 PM

#

it's phobos thingy

devout mesa Aug 5, 2023, 11:41 PM

#

ah

#

no idea KEKW

dawn wave Aug 5, 2023, 11:43 PM

#

hmmmm

#

does this resource last

#

or is it just a per-frame thing

#

judging by how it's being refreshed every frame

#

i assume so?

devout mesa Aug 5, 2023, 11:50 PM

#

where sun

dawn wave Aug 5, 2023, 11:50 PM

#

sun :D

#

🌞

#

i forgor how to make another shader

#

and tell it explicitly to use that shader

devout mesa Aug 5, 2023, 11:52 PM

#

you don't need it for the sun me mate

#

make sun

dawn wave Aug 5, 2023, 11:52 PM

#

but i get pissed off

#

if i have to do some fuckery

#

and make a monolithic shader

devout mesa Aug 5, 2023, 11:56 PM

#

uber shaders are the best

#

DOOM eternal uses exclusively uber shaders

dawn wave Aug 5, 2023, 11:57 PM

#

ah fuck

#

doom

#

now i have to agree they're good

devout mesa Aug 5, 2023, 11:57 PM

#

they are the best solution to an impossible problem

dawn wave Aug 5, 2023, 11:57 PM

#

what about that new out order shader execution thingy

devout mesa Aug 5, 2023, 11:57 PM

#

only available on 40 series

#

stop getting distracted and make a sun

dawn wave Aug 5, 2023, 11:58 PM

#

then i;ll target only for 40 series

devout mesa Aug 5, 2023, 11:58 PM

#

you don't even have a 40 series card

dawn wave Aug 5, 2023, 11:58 PM

#

mhm

#

huston

#

we have a problem

#

i am stupid

#

tf do i make the direction

devout mesa Aug 6, 2023, 12:02 AM

#

I dunno

#

normalize(vec3(0.25, 0.75, 0.25))

#

sounds like a good direction to me

dawn wave Aug 6, 2023, 12:03 AM

#

okok

#

bro

#

it's pitch black KEKW

devout mesa Aug 6, 2023, 12:04 AM

#

amazing

dawn wave Aug 6, 2023, 12:04 AM

#

ill uh

#

fix it

#

let there be ligt

#

guys

#

i think i fucked up the entire shader

devout mesa Aug 6, 2023, 12:07 AM

#

unfuck it then

dawn wave Aug 6, 2023, 12:08 AM

#

#

what did you make me do

devout mesa Aug 6, 2023, 12:10 AM

#

doesn't look like sun to me

dawn wave Aug 6, 2023, 12:10 AM

#

no looks like we're about to enter it

#

#

idfk

#

what is happening here

devout mesa Aug 6, 2023, 12:14 AM

#

ight

#

now you may average

dawn wave Aug 6, 2023, 1:45 AM

#

ah fyck

#

how do i account for cosine distributed hemisphere

dawn wave Aug 6, 2023, 2:26 AM

#

Uhh

#

How do I create another push constant...

#

it isn't working for me KEKW

#

.push_constant(vk::ShaderStageFlags::RAYGEN_KHR, 0, &view)
                    .push_constant(vk::ShaderStageFlags::RAYGEN_KHR, 64, &projection)
                    .push_constant(vk::ShaderStageFlags::RAYGEN_KHR, 128, &self.frame_id)

#DARE (Danny's Awesome Rendering Engine)