Andromeda - Terrain/Landscape editor using Vulkan and Rust | Graphics Programming | Page 2

shadow trench Mar 30, 2023, 3:08 PM

#

that color map was bad i got rid of it

#

next up ill get some shadows going mayhaps

shadow trench Mar 30, 2023, 9:30 PM

#

its time for another round of refactors

#

because this is just evil

hot yarrow Mar 30, 2023, 9:36 PM

#

needs more self

shadow trench Mar 30, 2023, 9:36 PM

#

kek

#

needs less parameters being passed around everywhere

hot yarrow Mar 30, 2023, 9:36 PM

#

yeah 🙂

shadow trench Mar 30, 2023, 10:53 PM

#

I am cooking up a new abstraction

#

This should answer one problem ive been having

#

I had a World and FutureWorld before but it was honestly not great

shadow trench Mar 31, 2023, 2:08 PM

#

shadow trench its time for another round of refactors

Much better

livid geode Mar 31, 2023, 3:22 PM

#

backend developers avoiding refactors for 3 commits challenge (impossible)

wispy ore Mar 31, 2023, 3:24 PM

#

livid geode backend developers avoiding refactors for 3 commits challenge (impossible)

frontend devs trying to create something without 600 frameworks challenge (impossible)

#

KEKW

#

But yes refactoring is some kind of drug KEKW

livid geode Mar 31, 2023, 3:26 PM

#

just one more... i swear i can stop whenever i want...

shadow trench Mar 31, 2023, 3:47 PM

#

shush kekw

shadow trench Apr 2, 2023, 2:39 PM

#

just fixed like 200 clippy warnings

#

SCtired

livid geode Apr 2, 2023, 2:50 PM

#

bleakekw

shadow trench Apr 2, 2023, 2:52 PM

#

a lot of it was &thing where thing is already a reference

hot yarrow Apr 2, 2023, 5:13 PM

#

#showcase message

shadow trench Apr 2, 2023, 5:15 PM

#

👀

#

that looks like egui

#

another rust user spotted

hot yarrow Apr 2, 2023, 5:17 PM

#

potentially more people you could join forces with

shadow trench Apr 2, 2023, 5:17 PM

#

😔

hot yarrow Apr 2, 2023, 5:17 PM

#

to exchange brainworms or else

shadow trench Apr 2, 2023, 5:17 PM

#

That is true

#

brainworm exchange is always good

hot yarrow Apr 2, 2023, 5:17 PM

#

GL > VK

#

always has been

shadow trench Apr 2, 2023, 5:17 PM

#

hot yarrow Apr 2, 2023, 5:17 PM

#

😄

shadow trench Apr 2, 2023, 5:18 PM

#

did they change the discord background?

#

that used to be seamless

#

wtf

hot yarrow Apr 2, 2023, 5:18 PM

#

no idea tbh

#

im using themes preview

shadow trench Apr 2, 2023, 5:18 PM

#

using some extension I presume 😄

hot yarrow Apr 2, 2023, 5:18 PM

#

no

#

its built in, in beta am

shadow trench Apr 2, 2023, 5:19 PM

#

oh wait right

#

there are people who pay for expensive nitro

#

i stick to the cheap one

hot yarrow Apr 2, 2023, 5:19 PM

#

shadow trench Apr 2, 2023, 5:20 PM

#

I saw the preview but they locked it behind the expensive plan sadly

hot yarrow Apr 2, 2023, 5:21 PM

#

i didnt know there were multiple "plans" of nitro now

shadow trench Apr 2, 2023, 5:22 PM

#

at some point they split it into "classic" and just regular nitro

#

with regular nitro getting all the cool stuff

hot yarrow Apr 2, 2023, 5:22 PM

#

hmm

shadow trench Apr 2, 2023, 5:22 PM

#

and then not too long ago they deprecated classic and replaced it with basic

#

which is just emotes and stickers

hot yarrow Apr 2, 2023, 5:22 PM

#

i have the full thing, whatever its called

shadow trench Apr 2, 2023, 5:23 PM

#

and uploads i guess

hot yarrow Apr 2, 2023, 5:23 PM

#

ah

shadow trench Apr 2, 2023, 5:23 PM

#

emotes and bigger file uploads for 3 eur/month i can live with, but 10 is a bit much for me rn

hot yarrow Apr 2, 2023, 5:24 PM

#

maybe i should also just let it run out and not extend

shadow trench Apr 2, 2023, 5:25 PM

#

i got too used to emotes to go without tbh lol

hot yarrow Apr 2, 2023, 5:27 PM

#

: )

hot yarrow Apr 3, 2023, 5:22 PM

#

https://github.com/weigert/SimpleHydrology ill just leave this one here, i hope the others see it too 🙂

GitHub

GitHub - weigert/SimpleHydrology: Procedural Hydrology / River / La...

Procedural Hydrology / River / Lake Simulation. Contribute to weigert/SimpleHydrology development by creating an account on GitHub.

#

mayhaps helpful for you(r) terrain builder builders

shadow trench Apr 3, 2023, 5:35 PM

#

That looks very useful frogapprove

#

Thank froge

wispy ore Apr 3, 2023, 6:44 PM

#

hot yarrow https://github.com/weigert/SimpleHydrology ill just leave this one here, i hope ...

This is something I definitely want to implement as well

#

multiple types of erosion

#

it was already starred by me lmfao

hot yarrow Apr 3, 2023, 7:22 PM

#

: )

livid geode Apr 4, 2023, 11:22 AM

#

@shadow trench You forgot to make version v0.6.0 latest on gh releases

#

https://github.com/NotAPenguin0/phobos-rs/releases/tag/v0.6.0

GitHub

Release v0.6.0 · NotAPenguin0/phobos-rs

Support for storage images
All cloneable caches and vulkan types now have their Arc> internalized
Fix clippy warnings around codebase

Note that this is v0.6.1 on crates.io

#

Note that this is v0.6.1 on crates.io
Bruh

shadow trench Apr 4, 2023, 11:22 AM

#

kek

#

I forgot to merge some changes

shadow trench Apr 4, 2023, 11:23 AM

#

livid geode https://github.com/NotAPenguin0/phobos-rs/releases/tag/v0.6.0

fixed, ty

#

ill change the tag to 0.6.1

livid geode Apr 4, 2023, 11:24 AM

#

you can jank 0.6.0

shadow trench Apr 4, 2023, 11:24 AM

#

yeah i should do that

shadow trench Apr 4, 2023, 3:23 PM

#

im thinking of just yeeting netcdf support for loading heightmap data

#

its what some real world data uses but loading it uses a library which takes literally 5 minutes to build somehow

wispy ore Apr 4, 2023, 3:27 PM

#

shadow trench im thinking of just yeeting netcdf support for loading heightmap data

geotiff seems common

shadow trench Apr 4, 2023, 3:27 PM

#

might look into that

#

that said real world data is ass KEKW

#

the resolution is kinda bad

wispy ore Apr 4, 2023, 3:27 PM

#

It's hard to find good DEMs

#

The netherlands have good ones

#

0.5m res of the entire nation

shadow trench Apr 4, 2023, 3:28 PM

#

damn

#

thats good

wispy ore Apr 4, 2023, 3:28 PM

#

iirc. even free

#

but would need to find them again

shadow trench Apr 4, 2023, 3:28 PM

#

too bad its almost flat kek

wispy ore Apr 4, 2023, 3:28 PM

#

KEKW

#

think 1-2m for most of norway

#

arctic regions suffer a bit tho lmao

shadow trench Apr 4, 2023, 3:29 PM

#

yeah the one i found of iceland was 200m dread_cat

wispy ore Apr 4, 2023, 3:31 PM

#

https://polargeospatialcenter.github.io/stac-browser/#/external/pgc-opendata-dems.s3.us-west-2.amazonaws.com/arcticdem/strips/s2s041/2m.json

#

10m most of arctic

#

but projection is tricky

shadow trench Apr 4, 2023, 3:33 PM

#

hmm yeah

#

ill see

#

the focus is creating your own terrain anyway

wispy ore Apr 4, 2023, 3:34 PM

#

using real terrain as a base is neat tho

shadow trench Apr 4, 2023, 3:34 PM

#

True

#

Id like to support it somehow

wispy ore Apr 4, 2023, 3:34 PM

#

then erode, add some noise etc. erode again

shadow trench Apr 4, 2023, 3:34 PM

#

Yeah

#

Combine with some brush tools

wispy ore Apr 4, 2023, 3:34 PM

#

exactly

#

coastlines are hard with real data

#

you lack depth info

shadow trench Apr 4, 2023, 3:36 PM

#

some datasets have depth

#

but not all

wispy ore Apr 4, 2023, 3:40 PM

#

shadow trench some datasets have depth

my experience is you have separate datasets

#

due to differences in how it's measured

shadow trench Apr 4, 2023, 3:41 PM

#

the one i found from iceland had depth data, was kinda cool

#

but bad resolution so eh

wispy ore Apr 4, 2023, 3:41 PM

#

ocean data gets measured with sonar and similar mostly

#

which.. doesn't work anywhere else KEKW

shadow trench Apr 4, 2023, 3:42 PM

#

yeah fair enough KEKW

#

I guess they stitched it together somehow

wispy ore Apr 4, 2023, 3:42 PM

#

yeah

#

I need to ask my uni for access to geospatial data lmao

shadow trench Apr 4, 2023, 3:43 PM

#

kek

#

would be cool if you got it

wispy ore Apr 4, 2023, 3:44 PM

#

aktschually

#

I have access to ArcGIS with my uni

wispy ore Apr 5, 2023, 3:27 PM

#

WHY the fuck are geotiff files completely white when you open them in gimp KEKW

#

Do I really need to use a dedicated GIS program just to load and convert them

shadow trench Apr 5, 2023, 3:34 PM

#

KEKW

#

i installed a random 15 year old java app to load netcdf files

shadow trench Apr 5, 2023, 8:20 PM

#

time to work through some of these

shadow trench Apr 7, 2023, 6:21 PM

#

tf

#

I implemented pipeline query support in my vk abstraction

#

// Record some commands, then obtain a finished command buffer to submit
let cmd = cmd
    .write_timestamp(&mut timestamps, PipelineStage::TOP_OF_PIPE)?
    .begin_query(&stats, query)
    .bind_compute_pipeline("compute")?
    .bind_storage_buffer(0, 0, &self.buffer.view_full())?
    .push_constant(vk::ShaderStageFlags::COMPUTE, 0, &multiplier)
    .dispatch(1024, 1, 1)?
    .end_query(&stats, query)
    .write_timestamp(&mut timestamps, PipelineStage::COMPUTE_SHADER)?
    .finish()?;

this little command buffer takes ~4k nanoseconds without pipeline queries and ~10k with

#

weird

shadow trench Apr 8, 2023, 10:45 AM

#

CatStare

#

thats not where i put that breakpoint

hot yarrow Apr 8, 2023, 10:46 AM

#

without reading what the actual code is, but just seeing all the rustisms is odd

#

its basically just "self" "mut" and "pub fn" what i see 😄

shadow trench Apr 8, 2023, 10:47 AM

#

yeah it is a weird lang if u never wrote it KEKW

#

a bit like kotlin for me

hot yarrow Apr 8, 2023, 10:47 AM

#

kotlin is super neat, thats what java should have been from the start

#

hehe dont mean to start a language war 🙂

shadow trench Apr 8, 2023, 10:47 AM

#

its cool but when I see private inline operator suspend fun <reified T> nervous

hot yarrow Apr 8, 2023, 10:47 AM

#

xD

shadow trench Apr 8, 2023, 10:47 AM

#

but yeah, 10x better than java for sure

#

Im doing a group assignment in kotlin right now, its neat

hot yarrow Apr 8, 2023, 10:48 AM

#

that "self" thing riggers me the most i think

#

are those methods extensions/mixins of some kind?

shadow trench Apr 8, 2023, 10:48 AM

#

its just this in C++

hot yarrow Apr 8, 2023, 10:48 AM

#

yeah

#

but why

shadow trench Apr 8, 2023, 10:48 AM

#

methods without self are like static, with is a member function

hot yarrow Apr 8, 2023, 10:48 AM

#

ah

#

aaah

#

like a hacky oopified c basically

shadow trench Apr 8, 2023, 10:49 AM

#

kind of :P

hot yarrow Apr 8, 2023, 10:49 AM

#

oki im quiet again

shadow trench Apr 8, 2023, 10:49 AM

#

its so you can more expressively add mutability and lifetimes to it

#

kek

hot yarrow Apr 8, 2023, 10:49 AM

#

to answer your question though, does that happen if you have out of date builds?

shadow trench Apr 8, 2023, 10:49 AM

#

not too sure

#

i cleaned my build and it was fixed

#

🤷

hot yarrow Apr 8, 2023, 10:49 AM

#

ah

wispy ore Apr 8, 2023, 10:49 AM

#

meanwhile new C++ convention: KEKW

template <class Self>
auto foo(this Self&& self) {
  // ...
}

hot yarrow Apr 8, 2023, 10:49 AM

#

dead skellingtons in the basemend

shadow trench Apr 8, 2023, 10:49 AM

#

no idea why it didnt rebuild in the first place 🤷

#

All working nicely finally

#

Using timestamp queries every 60th frame to get some timing data

#

Wireframe is about 5 times slower NanaStare

shadow trench Apr 8, 2023, 1:09 PM

#

ok i have a problem

hot yarrow Apr 8, 2023, 1:19 PM

#

: o

shadow trench Apr 8, 2023, 1:38 PM

#

could just be a rust debug perf moment

hot yarrow Apr 8, 2023, 1:38 PM

#

mayhaps build as release and check if it makes any difference?

shadow trench Apr 8, 2023, 1:41 PM

#

truly a rust debug performance moment indeed

#

ill do a quick profile in debug and see whats so slow though

hot yarrow Apr 8, 2023, 1:42 PM

#

ah hehe, mayhaps collect samples over time

#

or how do you collect this kind of data?

shadow trench Apr 8, 2023, 1:42 PM

#

frametime is just the classic this_frame - last_frame every frame

hot yarrow Apr 8, 2023, 1:43 PM

#

ah

shadow trench Apr 8, 2023, 1:43 PM

#

the others are collected using timestamp VkQueryPools every N frames

#

(because they add some perf overhead so I dont do it every frame)

hot yarrow Apr 8, 2023, 1:43 PM

#

so, normal stuf

shadow trench Apr 8, 2023, 1:43 PM

#

Yeah

#

actually debug perf isnt that bad without a debugger attached

#

like 5ms

#

except the occasional spike for some reason

#

kek i only profiled for 20s thats an interesting number

#

i guess it added the times for each thread or something

#

ok i should only profile the main thread for this

#

That is not fun to look at

#

I assume vkNegotiateLoaderLayerInterfaceVersion is because of the validation layers

#

But memcpy CatStare

#

not that bad though

#

huh

#

what is going on

#

ok well i wont bother looking too much at windowing stuff

short surge Apr 8, 2023, 1:52 PM

#

what are you using to profile in Rust?

shadow trench Apr 8, 2023, 1:52 PM

#

very sleepy

hot yarrow Apr 8, 2023, 1:52 PM

#

erminds me of ProcessExplorer for some reason

shadow trench Apr 8, 2023, 1:52 PM

#

its a very simple profiler that should work for any compiled lang

#

if it has debug symbols

#

hot yarrow Apr 8, 2023, 1:53 PM

#

ah this one

short surge Apr 8, 2023, 1:53 PM

#

cool, thank you 🙂

shadow trench Apr 8, 2023, 1:54 PM

#

cargo flamegraph is also good but doesnt seem to work for me for some reason

short surge Apr 8, 2023, 1:54 PM

#

ill check them both out

shadow trench Apr 8, 2023, 1:57 PM

#

rendering the gui is the most intensive pass on the cpu nervous

#

thats fine tbh

hot yarrow Apr 8, 2023, 2:02 PM

#

an open world mmo dragon jrpg fps doesnt need no gui anyway

shadow trench Apr 8, 2023, 2:04 PM

#

who even makes games smh

wispy ore Apr 8, 2023, 2:13 PM

#

shadow trench rendering the gui is the most intensive pass on the cpu <:nervous:83693516643788...

isn't that always the case

shadow trench Apr 8, 2023, 2:13 PM

#

yeah

#

i could do some optimizations instead of trying to bind a new descriptor set for every draw and going through the whole cache lookup

#

but its not a big deal yet

wispy ore Apr 8, 2023, 2:15 PM

#

could do mixed retained/immediate mode

shadow trench Apr 8, 2023, 2:15 PM

#

whats that

wispy ore Apr 8, 2023, 2:16 PM

#

First of all are you using some gui library you have little control over

shadow trench Apr 8, 2023, 2:16 PM

#

unfortunately yes :P

#

imgui but rust

wispy ore Apr 8, 2023, 2:16 PM

#

well this settles the question KEKW

shadow trench Apr 8, 2023, 2:16 PM

#

KEKW

#

fair enough

wispy ore Apr 8, 2023, 2:17 PM

#

basically imagine a mix of imgui and the retained paradigm for some things

shadow trench Apr 8, 2023, 2:17 PM

#

i see

wispy ore Apr 8, 2023, 2:17 PM

#

it would make stuff like layouting much easier

#

you would be able to do "right align element" etc.

shadow trench Apr 8, 2023, 2:17 PM

#

yeah

#

i have a hacky right align

#

but it requires pushing elements in the opposite order

wispy ore Apr 8, 2023, 2:18 PM

#

yeah

#

stuff like that wouldn't be needed in mixed or pure retained KEKW

shadow trench Apr 8, 2023, 2:18 PM

#

yeah

wispy ore Apr 8, 2023, 2:19 PM

#

could call it "deferred" lol

shadow trench Apr 8, 2023, 2:20 PM

#

NOTED

livid geode Apr 8, 2023, 4:28 PM

#

shadow trench actually debug perf isnt that bad without a debugger attached

yeah adding a debugger completely kills the performance, no idea why´

#

maybe its just the sheer number of debug symbols and functions called in debug

#

e.g. all iterators

shadow trench Apr 8, 2023, 4:47 PM

#

Yeah probably

#

Its still usable so it’s fine

shadow trench Apr 8, 2023, 7:33 PM

#

wrote my first higher ranked trait bound

#

pub trait PassExecutor<D: ExecutionDomain, U, A: Allocator> {
    fn execute<'q>(&mut self, cmd: IncompleteCommandBuffer<'q, D>, ifc: &mut InFlightContext<A>, bindings: &PhysicalResourceBindings, user_data: &mut U) -> PassFnResult<'q, D>;
}

impl<D, U, A, F> PassExecutor<D, U, A> for F
    where
        D: ExecutionDomain,
        A: Allocator,
        F: for <'q> FnMut(IncompleteCommandBuffer<'q, D>, &mut InFlightContext<A>, &PhysicalResourceBindings, &mut U) -> PassFnResult<'q, D> {

    fn execute<'q>(&mut self, cmd: IncompleteCommandBuffer<'q, D>, ifc: &mut InFlightContext<A>, bindings: &PhysicalResourceBindings, user_data: &mut U) -> PassFnResult<'q, D> {
        self.call_mut((cmd, ifc, bindings, user_data))
    }
}

#

for <'q>

livid geode Apr 8, 2023, 8:16 PM

#

awww

#

everything ive had to use higher ranked trait bounds for ive had to rewrite out at some point

shadow trench Apr 8, 2023, 8:18 PM

#

in this case it actually simplifies things a little

#

because now 'q is no longer a lifetime parameter of the pass callback

livid geode Apr 8, 2023, 8:21 PM

#

true

shadow trench Apr 9, 2023, 9:14 AM

#

@potent quest if youre serious about trying out rust I have a vuk-like (but much simpler atm) lib that I use myself, https://github.com/notapenguin0/phobos-rs / https://crates.io/crates/phobos

potent quest Apr 9, 2023, 9:14 AM

#

bro sneaked in a classic phobos banger

shadow trench Apr 9, 2023, 9:15 AM

#

ElmoFire

potent quest Apr 9, 2023, 9:27 AM

#

wow phobos is

#

like vuk

#

but rust

#

instant banger

shadow trench Apr 9, 2023, 9:30 AM

#

thats the goal

#

its a bit less fancy

#

im using it in my terrain project and its been working nicely so far

potent quest Apr 9, 2023, 9:45 AM

#

nah kinda like it when there's less

#

means when i code the stuff i need i can at least understand it KEKW

#

why i waned from unreal since it was so much

shadow trench Apr 9, 2023, 9:47 AM

#

Yeah game engines are overwhelming kek

#

Hm if I add rt support I’ll have to work on adding it to the rust spirv-cross too

#

Oh well I had to do that anyway

#

Shouldn’t be too hard

potent quest Apr 9, 2023, 9:48 AM

#

Moments caught before disaster

shadow trench Apr 9, 2023, 9:48 AM

#

kek

#

Its just editing the bindgen config I think

potent quest Apr 9, 2023, 9:49 AM

#

bindgen?

shadow trench Apr 9, 2023, 9:50 AM

#

Its a rust library that automatically generates rust bindings for c/c++ libraries

potent quest Apr 9, 2023, 9:51 AM

#

ohh

#

wait what

#

i thought ash did that

shadow trench Apr 9, 2023, 9:51 AM

#

ash is a little different

#

ash just has vulkan bindings for rust

#

It actually loads the function pointers itself and doesn’t interface with the SDK headers

potent quest Apr 9, 2023, 9:52 AM

#

oh

shadow trench Apr 9, 2023, 9:52 AM

#

its generated from vk.xml directly

potent quest Apr 9, 2023, 9:52 AM

#

so its up to you to interface with the sdk?

shadow trench Apr 9, 2023, 9:52 AM

#

Also adds some builders for convenience but they’re all optional

#

you don’t need to include the SDK directly using rust

#

Depends though, if you choose the linked feature it links to vulkan.lib, otherwise it dynamically loads the pointers

#

(With LoadLibrary etc)

potent quest Apr 9, 2023, 9:54 AM

#

ohh i see

shadow trench Apr 9, 2023, 9:54 AM

#

Its a bit like a replacement for vulkan.h

potent quest Apr 9, 2023, 9:58 AM

#

ohh winit is the glfw

shadow trench Apr 9, 2023, 9:58 AM

#

Yep

#

Its a bit more invasive but works reasonably well

potent quest Apr 9, 2023, 9:58 AM

#

i forgor that rust has no classes

shadow trench Apr 9, 2023, 9:58 AM

#

structs are basically classes though

potent quest Apr 9, 2023, 9:58 AM

#

ohh impl

shadow trench Apr 9, 2023, 9:59 AM

#

Yeah

potent quest Apr 9, 2023, 9:59 AM

#

i guess that gives methods

shadow trench Apr 9, 2023, 9:59 AM

#

Yep

#

And there’s also impl Trait for Struct

potent quest Apr 9, 2023, 9:59 AM

#

Trait?

shadow trench Apr 9, 2023, 9:59 AM

#

Traits are epic

#

Concepts on steroids

potent quest Apr 9, 2023, 10:00 AM

#

uhh concepts?

#

ohh C++20

shadow trench Apr 9, 2023, 10:00 AM

#

Yep

potent quest Apr 9, 2023, 10:02 AM

#

ive had a brief skim through concepts

#

i dont really get why

#

but that is a skim

shadow trench Apr 9, 2023, 10:02 AM

#

Traits define some methods but don’t implement them

#

Then each struct can provide implementations for those traits in an impl block

#

And you can constrain generic things on a trait

potent quest Apr 9, 2023, 10:03 AM

#

OHHHH so like templates but for classes

#

scaffolding?

shadow trench Apr 9, 2023, 10:04 AM

#

trait Bar {
    fn bar(&self);
}

fn foo<T: Bar>(value: T) {
    value.bar();
}

#

foo() takes any T that implements Bar, and calls its implementation of that function

potent quest Apr 9, 2023, 10:06 AM

#

ohhh

#

thats cool

#

ill get to rust one day

shadow trench Apr 9, 2023, 10:07 AM

#

Aye

potent quest Apr 10, 2023, 3:42 AM

#

Yo pengiun if you ever add ray tracing support lmk

shadow trench Apr 10, 2023, 7:55 AM

#

Ill work on it

#

Gotta do it anyway

#

Do you need rt pipelines too

shadow trench Apr 10, 2023, 10:12 AM

#

potent quest Yo pengiun if you ever add ray tracing support lmk

WIP

potent quest Apr 10, 2023, 10:29 AM

#

Waiaia don’t feel pressured to do it

#

I haven’t even started rust yet 🗿

shadow trench Apr 10, 2023, 10:31 AM

#

lmao

#

I was planning to add it anyway

#

Current version is just a very thin wrapper anyway so it’s not a lot of work

spare bay Apr 10, 2023, 12:11 PM

#

do you plan to add easter egg about gregtech in the code ?

hot yarrow Apr 10, 2023, 12:17 PM

#

gr-egg-tech

shadow trench Apr 10, 2023, 12:44 PM

#

spare bay do you plan to add easter egg about gregtech in the code ?

kekw

#

ill make it just as tedious

#

Every object needs to be created using circuit objects

potent quest Apr 10, 2023, 3:37 PM

#

I tried running from Gregtech but once again I stare at it’s endless pit

shadow trench Apr 10, 2023, 3:41 PM

#

There is no escape

potent quest Apr 10, 2023, 4:57 PM

#

So rt is pretty much the vulkan api

shadow trench Apr 10, 2023, 4:59 PM

#

Yeah until I figure out a good way to flexibly wrap it

#

But I need to actually use it for a bit to know

#

Obviously it’ll integrate with the rest of the lib

shadow trench Apr 10, 2023, 10:21 PM

#

found a gem in my old code

potent quest Apr 10, 2023, 10:34 PM

#

probably agood idea

#

to remove it

#

or add warning of some sort upon usage

shadow trench Apr 10, 2023, 10:48 PM

#

Well I would do that if I still maintained this

shadow trench Apr 11, 2023, 2:55 PM

#

That is an acceleration structure

#

API could still be cleaned up a little tbh

#

@potent quest https://github.com/NotAPenguin0/phobos-rs/blob/feature/raytracing/examples/03_raytracing/main.rs lmk what you think the painpoints are if you spot any obvious ones

shadow trench Apr 11, 2023, 3:42 PM

#

you sure get long type names with raytracing

#

QueryPool<AccelerationStructureCompactedSizeQuery>

#

AccelerationStructureGeometryTrianglesData

shadow trench Apr 11, 2023, 3:57 PM

#

pub fn alignment() -> u64 {
    256
}

easy

#

thats a big difference lol

potent quest Apr 11, 2023, 4:48 PM

#

oml you reminded me i need to add compacting for my blas

shadow trench Apr 11, 2023, 4:49 PM

#

I found on average it uses about 40-50% less memory

potent quest Apr 11, 2023, 5:19 PM

#

i looked through it

#

seems way nicer to use

#

god i cannot wait to use this

#

seems like command buffer is handled at a lower level compared to vuk?

shadow trench Apr 11, 2023, 5:24 PM

#

there are some quality of life abstractions of course

#

but in general theres no full dynamic state like in vuk

potent quest Apr 11, 2023, 5:26 PM

#

nono its fine

#

i like it

shadow trench Apr 11, 2023, 5:28 PM

#

Yeah it is intentional 😄

#

I have no plans of going that far

potent quest Apr 11, 2023, 5:42 PM

#

also wdym dynamic state?

#

im not getitng what that means

shadow trench Apr 11, 2023, 5:43 PM

#

like setting the vertex format in the command buffer and all that

#

iirc vuks pipelines are very minimal and all other state can be set through the command buffer

shadow trench Apr 11, 2023, 5:58 PM

#

i got the sample to create a BLAS with a single triangle and a TLAS with one instance

#

solid progress for now

#

I still have to add rt pipelines but apart from shader binding table nonsense that should be easy

potent quest Apr 11, 2023, 6:04 PM

#

oh yeah how tf did you get nsight to profile the as?

shadow trench Apr 11, 2023, 6:06 PM

#

It just shows it in the resources tab

#

#

potent quest Apr 11, 2023, 6:07 PM

#

oh no i am doing something wrong with mines then 💀

shadow trench Apr 11, 2023, 6:07 PM

#

then you can double click to show details

shadow trench Apr 11, 2023, 7:55 PM

#

raytracing going well

#

im confused where this is coming from

#

since i really am adding the corresponding feature struct to my pnext chain

#

ok thats fixed i was missing an extension

#

still good old device lost though

#

aaaand i completely crashed my driver

#

oops

shadow trench Apr 11, 2023, 8:33 PM

#

// walmart raygen shader
void main() {
    // Apply inverse of view and projection to find camera direction
    // This gives us the origin and direction of the ray
    vec4 origin = inverse(pc.view) * vec4(0, 0, 0, 1);
    vec4 target = inverse(pc.projection) * vec4(UV.x, UV.y, 1, 1);
    vec4 direction = inverse(pc.view) * vec4(normalize(target.xyz), 0);
    FragColor = vec4(intersect(direction.xyz));
}

good first comment yes?

livid geode Apr 11, 2023, 8:55 PM

#

lmfao

shadow trench Apr 11, 2023, 8:56 PM

#

i am bringing down my entire graphics driver

#

thisisfine

potent quest Apr 11, 2023, 9:05 PM

#

bros bringing his graphics driver down with him

#

the captain sinks with his ship

shadow trench Apr 11, 2023, 9:07 PM

#

o7

livid geode Apr 11, 2023, 9:12 PM

#

🫡

potent quest Apr 12, 2023, 1:33 AM

#

@shadow trench Sorry for pinging, when you looked into your second AS did it also have the same mesh?

#

I'm running into an issue which it seems like my TLAS? isn't showing anything in nsight

shadow trench Apr 12, 2023, 9:08 AM

#

potent quest <@190522027440865280> Sorry for pinging, when you looked into your second AS did...

Yeah it is showing

#

I have a big bug somewhere but I don’t know where yet

#

My driver crashes when calling rayQueryProceedEXT lol

shadow trench Apr 12, 2023, 11:02 AM

#

CatStare

#

it doesnt crash if i enable aftermath

wispy ore Apr 12, 2023, 11:15 AM

#

shadow trench it doesnt crash if i enable aftermath

lmao

#

my first thought was TDR but aftermath shouldn't disable those

shadow trench Apr 12, 2023, 11:16 AM

#

yeah i considered that too

#

but it crashes pretty much instantly

#

like i hear a buzzing sound in my headphones even kekw

shadow trench Apr 12, 2023, 12:12 PM

#

it is fixed

#

missing barrier moment

livid geode Apr 12, 2023, 12:35 PM

#

shadow trench like i hear a buzzing sound in my headphones even <:kekw:754090061141639189>

motherboard short via software speedrun any%

shadow trench Apr 12, 2023, 12:35 PM

#

kek

shadow trench Apr 12, 2023, 12:53 PM

#

I dont get it

#

float intersect(vec3 origin, vec3 direction) {
    rayQueryEXT ray;
    origin = vec3(0, 0, 0);
    direction = vec3(0, 0, 1);

    rayQueryInitializeEXT(ray, as, gl_RayFlagsTerminateOnFirstHitEXT, 0xFF, origin, 0.001, direction, 10.0);

    rayQueryProceedEXT(ray);

    if (rayQueryGetIntersectionTypeEXT(ray, true) != gl_RayQueryCommittedIntersectionNoneEXT) {
        return 1.0;
    }
    else return 0.0;
}

I have an AS with a triangle at z = 1

#

How is this not hitting

livid geode Apr 12, 2023, 12:54 PM

#

skill issue

shadow trench Apr 12, 2023, 12:54 PM

#

probably

shadow trench Apr 12, 2023, 8:10 PM

#

segfault in the driver after 10 ish frames with no feedback

#

nervous

#

what in satans name is my program doing

shadow trench Apr 12, 2023, 8:28 PM

#

runs sample without vkconfig on

potent quest Apr 12, 2023, 8:28 PM

#

https://tenor.com/view/woody-woody-toy-story-sora-kh3-kh-gif-27223516

Tenor

shadow trench Apr 12, 2023, 8:28 PM

#

rerun with vkconfig

#

bleakkekw

potent quest Apr 12, 2023, 8:29 PM

#

what is vkconfig

shadow trench Apr 12, 2023, 8:29 PM

#

vulkan configurator

#

to enable a buttload of validation layers and stuff

potent quest Apr 12, 2023, 8:36 PM

#

code without the validation layer 😎

shadow trench Apr 12, 2023, 10:40 PM

#

MOTHER FUCKER

#

how long has that been in here

#

and of course it still crashes randomly inside the driver

#

dread_cat

shadow trench Apr 12, 2023, 11:04 PM

#

btw @potent quest if you want a stable rust api youre too early kek

potent quest Apr 12, 2023, 11:04 PM

#

NOOOOO

shadow trench Apr 12, 2023, 11:04 PM

#

things are somewhat settling but im still breaking stuff every now and then

#

its not too bad anymore I think

#

But no stability guarantees yet

potent quest Apr 12, 2023, 11:05 PM

#

shadow trench how long has that been in here

wait why?

shadow trench Apr 12, 2023, 11:05 PM

#

its setting both the build and update scratch size to the update size

#

idk how this ever showed up right in nsight

#

because im allocating like 128 bytes of scratch memory when 1500 are needed

#

im wondering how this hasnt blown up all this time

potent quest Apr 12, 2023, 11:06 PM

#

OH

#

lmaooo

shadow trench Apr 12, 2023, 11:07 PM

#

but yeah stability is somewhat better now but ill definitely still be breaking some stuff

potent quest Apr 12, 2023, 11:08 PM

#

bro ive tried some very basic rust

#

holy shit

#

borrow checker

#

is saving my ass

shadow trench Apr 12, 2023, 11:08 PM

#

it is really nice

#

also a pain in the ass sometimes kek

#

but generally a great tool

potent quest Apr 12, 2023, 11:08 PM

#

yeah but you won't be able to leak 9.5tb of ram because you forgot to do some case checking

shadow trench Apr 12, 2023, 11:09 PM

#

or blow up your program by reading from a moved-from struct

#

kek

#

At this point I’ll just go to bed and hope it fixes itself tomorrow

potent quest Apr 12, 2023, 11:31 PM

#

💀

#

I thought game dev debugging was bad

#

that was when i met GPU debugging

#

Program crashes
Boy oh boy do I sure hope useful indicators are gi-
here is this random ahh memory address LMAOOOO have fun in the debugger doing "work"

shadow trench Apr 12, 2023, 11:37 PM

#

KEKW

#

Yeahh

#

I don’t have much hope for this being a driver issue sadly

#

I ran it on gfs pc and it crashed too, and she’s obviously not using vk beta drivers but stable ones

#

Its not even crashing on the first frame but on like frame 10 or so

potent quest Apr 13, 2023, 1:16 AM

#

bro wtf

#

nah those bugs are wacked

shadow trench Apr 13, 2023, 9:17 AM

#

oh ffs

#

its not happening if i run outside clion

#

dread_cat

potent quest Apr 13, 2023, 12:11 PM

#

🗿

#

bro wtf is that bug?

#

might be a clion config?

shadow trench Apr 13, 2023, 12:51 PM

#

nah

#

its just weird

#

probably some UB

livid geode Apr 13, 2023, 12:51 PM

#

valgrind moment

shadow trench Apr 13, 2023, 12:59 PM

#

except valgrind doesnt run on windows but my program doesnt run on my linux laptop because no rt kekw

livid geode Apr 13, 2023, 1:43 PM

#

TIL https://docs.rs/katex-doc/latest/katex_doc/

katex_doc - Rust

API documentation for the Rust katex_doc crate.

#

might interest you

shadow trench Apr 13, 2023, 2:06 PM

#

huh thats kinda cool

wispy ore Apr 13, 2023, 2:36 PM

#

what exactly is the difference between KaTeX and LaTeX

#

also why does this docpage taunt me with the Fourier transform

#

Also @shadow trench you are hijacking your own thread with a different project? KEKW

shadow trench Apr 13, 2023, 2:38 PM

#

in a way kekw

#

the different project is my vk abstraction lib

#

but i also use that for the terrain thing

#

so it works together

wispy ore Apr 13, 2023, 2:38 PM

#

fair enough

livid geode Apr 13, 2023, 2:51 PM

#

wispy ore what exactly is the difference between KaTeX and LaTeX

katex seems to be a small subset

#

kinda like mathjax

shadow trench Apr 13, 2023, 11:06 PM

#

ok ifs just not happening at all if i run it outside my debugger now

#

dread_cat

shadow trench Apr 15, 2023, 8:01 AM

#

God dammit I had an idea of what I could fix in a dream

#

But I forgot what it was

shadow trench Apr 15, 2023, 8:48 AM

#

i remember

#

i thought my u24 struct could be borked

#

but i wrote some tests and i think its fine

livid geode Apr 15, 2023, 10:20 AM

#

U24?

#

What do you need that for?

shadow trench Apr 15, 2023, 10:22 AM

#

// Provided by VK_KHR_acceleration_structure
typedef struct VkAccelerationStructureInstanceKHR {
    VkTransformMatrixKHR          transform;
    uint32_t                      instanceCustomIndex:24;
    uint32_t                      mask:8;
    uint32_t                      instanceShaderBindingTableRecordOffset:24;
    VkGeometryInstanceFlagsKHR    flags:8;
    uint64_t                      accelerationStructureReference;
} VkAccelerationStructureInstanceKHR;

this vk struct

livid geode Apr 15, 2023, 10:22 AM

#

oof

shadow trench Apr 15, 2023, 10:23 AM

#

#[derive(Default, Copy, Clone, Debug)]
#[allow(non_camel_case_types)]
#[repr(transparent)]
pub struct u24([u8; 3]);

impl u24 {
    const MIN: Self = Self::from_ne_bytes([0, 0, 0]);
    const MAX: Self = Self::from_ne_bytes([255, 255, 255]);

    pub const fn from_ne_bytes(bytes: [u8; 3]) -> Self {
        Self(bytes)
    }

    pub fn into_bytes(self) -> [u8; 3] {
        self.0
    }
}

impl From<u24> for u32 {
    fn from(value: u24) -> Self {
        let u24([a, b, c]) = value;
        #[cfg(target_endian = "little")]
        return u32::from_le_bytes([a, b, c, 0]);
        #[cfg(target_endian = "big")]
        return u32::from_be_bytes([0, a, b, c]);
    }
}

impl TryFrom<u32> for u24 {
    type Error = anyhow::Error;

    fn try_from(value: u32) -> Result<Self> {
        let [a, b, c, d] = value.to_ne_bytes();
        #[cfg(target_endian = "little")]
        return if d == 0 { Ok(u24([a, b, c])) } else { Err(anyhow!("u32 did not fit in u24")) };
        #[cfg(target_endian = "big")]
        return if a == 0 { Ok(u24([b, c, d])) } else { Err(anyhow!("u32 did not fit in u24")) };
    }
}

not too hard to write tho

livid geode Apr 15, 2023, 10:23 AM

#

but why should you need to worry about that, aren't you using ash

shadow trench Apr 15, 2023, 10:24 AM

#

ash defines it too actually I forgot about that

livid geode Apr 15, 2023, 10:24 AM

#

bruh

shadow trench Apr 15, 2023, 10:24 AM

#

it does this instead

livid geode Apr 15, 2023, 10:24 AM

#

i would rely on ash

#

instead of doing your own structs

shadow trench Apr 15, 2023, 10:24 AM

#

yeah this seems somewhat better

livid geode Apr 15, 2023, 10:25 AM

#

cause that layout is 999% for sure wrong

shadow trench Apr 15, 2023, 10:25 AM

#

shows up fine in nsight but who knows yeah

#

ill try the ash one

shadow trench Apr 15, 2023, 10:56 AM

#

still crashes sadly

livid geode Apr 15, 2023, 11:25 AM

#

https://tenor.com/view/nascar-bruh-meme-crash-drift-gif-22583370

Tenor

shadow trench Apr 16, 2023, 8:20 PM

#

okay back to debugging

#

time to dig through apitrace

#

a 900 line trace of the acceleration structure creation

#

i will inspect every line

shadow trench Apr 16, 2023, 8:50 PM

#

this is some serious crazy work

#

im going over every line in the trace and crossreferencing with the spec for possible invalid api usage

hot yarrow Apr 16, 2023, 8:51 PM

#

mayhaps write a tool which can analyse the stuff somehow?

shadow trench Apr 16, 2023, 8:51 PM

#

i was actually thinking about that

hot yarrow Apr 16, 2023, 8:51 PM

#

900isms sounds like a lot

shadow trench Apr 16, 2023, 8:51 PM

#

a small gui tool to examine the output of the vulkan api dump

#

its pretty readable luckily

hot yarrow Apr 16, 2023, 8:51 PM

#

oof

shadow trench Apr 16, 2023, 8:51 PM

#

but stuff to easily collapse it, filter commands, maybe name addresses, etc

#

thatd be nice

#

something for my side projects list

hot yarrow Apr 16, 2023, 8:52 PM

#

is that written in some yml/yaml/toml variant?

shadow trench Apr 16, 2023, 8:52 PM

#

just plaintext

#

i think it can output json too

hot yarrow Apr 16, 2023, 8:52 PM

#

: (

#

ah

#

if json then its easier to access elements

shadow trench Apr 16, 2023, 8:52 PM

#

yeah true

#

i might write something like that

#

could be useful

#

like a baby renderdoc kek

hot yarrow Apr 16, 2023, 8:54 PM

#

would be kewl if renderdoc could replay apitrace trace files too

#

apitrace's ui is ass

shadow trench Apr 16, 2023, 8:54 PM

#

yeah mayhaps

#

heh I didnt know this

#

When writing my old rt stuff I just immediately used a big scratch buffer and suballocated it for every AS build

#

Turns out thats required

shadow trench Apr 16, 2023, 9:10 PM

#

TIL vkGetAccelerationStructureDeviceAddressKHR just returns the device address of the underlying buffer on my gpu

shadow trench Apr 16, 2023, 10:29 PM

#

im forwarding this to nvidia dev forums

#

it be not happening on amd

#

okDoge

shadow trench Apr 17, 2023, 8:52 PM

#

it got restored luckily

#

but uh, this exception im getting is usually associated with missing dlls

#

the fuck is going on

shadow trench Apr 17, 2023, 11:55 PM

#

nervous

#

i have no validation layers

#

what

#

where did it go

#

ok reinstalling the sdk worked

#

unfortunately still silently crashing in the driver

shadow trench Apr 19, 2023, 11:22 AM

#

@potent quest ill rewrite the sample to see if i didnt miss anything, if it still happens ill add rt pipeline support and assume driver bug for now

#

until i get a reply from nv

shadow trench Apr 19, 2023, 12:36 PM

#

another AMD gpu runs it fine, I think ill just assume driver bug

potent quest Apr 19, 2023, 3:57 PM

#

Rewriting oh god

#

🫡

shadow trench Apr 19, 2023, 3:59 PM

#

just the sample code

#

i fixed one bug in it but with no success

shadow trench Apr 19, 2023, 5:01 PM

#

wtf was i smoking

#

why is it called closest hit shader

shadow trench Apr 19, 2023, 8:17 PM

#

ok the same code for building AS does not crash when using RT pipelines

#

theres definitely something wrong in the driver when using ray queries

#

Anyway @potent quest check it out

#

RT pipelines more or less done

#

I just have to fix the sample to actually face the camera the right way

#

ladies and gentlemen

#

a raytraced quad

#

https://github.com/NotAPenguin0/phobos-rs/releases/tag/v0.7.0 even wrote some actual release notes

livid geode Apr 19, 2023, 9:23 PM

#

what was wrong then?

shadow trench Apr 19, 2023, 9:28 PM

#

nothing on my end I suspect

#

ray queries crash the driver, rt pipelines work fine with exactly the same code for creating the acceleration structure

#

also works fine on amd

livid geode Apr 19, 2023, 9:29 PM

#

novidia

shadow trench Apr 19, 2023, 9:29 PM

#

true

#

my next gpu is probably amd

livid geode Apr 19, 2023, 9:30 PM

#

i have an amd gpu and have never had to worry about driver issues

shadow trench Apr 19, 2023, 9:30 PM

#

this is the second time for me

livid geode Apr 19, 2023, 9:30 PM

#

idk why people say that nvidia drivers are much better

shadow trench Apr 19, 2023, 9:31 PM

#

first time was confirmed a bug, this probably is but im not totally sure

shadow trench Apr 19, 2023, 10:25 PM

#

Every time I fix a sync bug in my render graph I wonder how it worked before

potent quest Apr 19, 2023, 10:48 PM

#

the urge to switch

shadow trench Apr 19, 2023, 10:58 PM

#

Would be good to have a user beside myself KEKW

shadow trench Apr 19, 2023, 11:38 PM

#

potent quest the urge to switch

I suggest reading through https://github.com/NotAPenguin0/phobos-rs/blob/master/examples/03_raytracing/main.rs to see what you think

#

(Also API feedback is obviously welcome)

potent quest Apr 19, 2023, 11:39 PM

#

Ok()?

shadow trench Apr 19, 2023, 11:40 PM

#

Its one of the values of Result<T, E>

#

Basically a result either is Ok(value) or Err(error)

#

(Like a union)

#

Its the standard way of error handling in rust

#

If you have a function that returns a Result, and you have a x_result which is a value inside a Result, you can write ```rs
let value = x_result?;

#

To grab the value inside if it’s Ok(), and return the Err() case otherwise

potent quest Apr 19, 2023, 11:51 PM

#

ohh ok?

#

this does make sense

#

Confused on alignment however

#

How is it ensuring that the buffer is aligned 256 bytes?

shadow trench Apr 20, 2023, 7:07 AM

#

The allocator does that

#

It knows the required alignment for given usage flags

shadow trench Apr 20, 2023, 9:49 AM

#

potent quest How is it ensuring that the buffer is aligned 256 bytes?

it grabs the memory requirements for the buffer, which returns the required alignment

#

If you are storing multiple ASes in one buffer, you do need to manually align each size to 256 bytes, but get_build_sizes() already does this so it shouldnt be an issue

shadow trench Apr 20, 2023, 10:22 AM

#

I pushed some fixes to a 0.7.1 release

#

Next up is adding missing docs for everything that i added since the last round

potent quest Apr 20, 2023, 4:30 PM

#

Ohhh i see

#

See I wanna learn rust so I can use this, but I’m also worried that:

this project may just fizzle out since no one else is using it
I should probably understand cpp first so I can have a better grasp of the basics rather than throwing it to rust

shadow trench Apr 20, 2023, 5:30 PM

#

Im also using this library myself so it’s not like I’ll stop working on it

#

Rust has different things to learn than cpp, but the compiler helps you a bit more

livid geode Apr 20, 2023, 6:46 PM

#

yup and instead you will fight it instead of fighting yourself

shadow trench Apr 20, 2023, 7:11 PM

#

imo rust is considerably easier to learn than c++

short surge Apr 20, 2023, 7:17 PM

#

and you get an easier to work with ecosystem 🙂 no more linking errors, libraries are super easy to grab

wispy ore Apr 20, 2023, 7:30 PM

#

shadow trench imo rust is considerably easier to learn than c++

that's only because you already knew c++ I think KEKW

#

I'd never recommend anyone to learn Rust as their first language

shadow trench Apr 20, 2023, 7:30 PM

#

it might be related

#

still though, the compiler is much more helpful in fixing your errors and theres a lot less basic things to worry about

wispy ore Apr 20, 2023, 7:31 PM

#

definitely

#

but the concepts that rust introduces are probably a bit harsh for beginners KEKW

shadow trench Apr 20, 2023, 8:00 PM

#

yeah but if you have some c++ experience they should be fairly easy to pick up

shadow trench Apr 20, 2023, 10:40 PM

#

@potent quest how do you feel about create info struct vs different constructors with different parameters

#

Im currently considering switching some over to create infos, especially buffers and images since they have many combinations of input parameters

potent quest Apr 20, 2023, 10:41 PM

#

wdym?

#

ohh create info structs

#

like how vulkan does it

#

or a function that has multiple parameter

shadow trench Apr 20, 2023, 10:41 PM

#

Yeah

potent quest Apr 20, 2023, 10:42 PM

#

hmm. personally, i like multiple parameters, but doing raytracing i've come to like structs more

shadow trench Apr 20, 2023, 10:42 PM

#

Mostly also many different constructor functions like new_with_alignment etc

#

Remember rust has no overloads so they all need unique names

potent quest Apr 20, 2023, 10:43 PM

#

honestly i think structs are better?

#

but it really depends

shadow trench Apr 20, 2023, 10:43 PM

#

Yeah for this they probably are

potent quest Apr 20, 2023, 10:43 PM

#

in rt, they def are

shadow trench Apr 20, 2023, 10:43 PM

#

for few parameters I can keep it as a function

potent quest Apr 20, 2023, 10:43 PM

#

i think some yeah are better off as functions

shadow trench Apr 20, 2023, 10:43 PM

#

All rt input data is structs that match the vk ones almost 1:1

#

with some convenience builders and stuff

potent quest Apr 20, 2023, 10:44 PM

#

tbh worse case, you can just do

func({

});

shadow trench Apr 20, 2023, 10:44 PM

#

Yeah

potent quest Apr 20, 2023, 10:44 PM

#

yeah create info structs sound a lot better

shadow trench Apr 20, 2023, 10:44 PM

#

Ill do this for buffers and images at least

#

Because it’s a bit problematic there

#

In rust you can write ```rs
let x = Foo {
bar: 0,
baz: "hi",
..Default::default()
};

#

To initialise only bar and baz and give all other fields a default value

#

So you can kinda optional parameters this way

potent quest Apr 20, 2023, 10:53 PM

#

ohhh

#

i see

short surge Apr 20, 2023, 11:00 PM

#

i like CreateInfo structs too, like you say having default fields is akin to having default parameters

#

so it depends if you want them or not

shadow trench Apr 20, 2023, 11:19 PM

#

~~so when are you switching over~~ kek

shadow trench Apr 21, 2023, 8:19 AM

#

i promise your vulkan backend will be 10x more compact :)

short surge Apr 21, 2023, 8:34 AM

#

if I ever get too frustrated I’ll see 😉

shadow trench Apr 21, 2023, 10:10 AM

#

ill take it :)

shadow trench Apr 21, 2023, 10:11 AM

#

short surge if I ever get too frustrated I’ll see 😉

just imagine how much code this actually hides 😄

short surge Apr 21, 2023, 10:12 AM

#

i know but I want to do all that 😄

shadow trench Apr 21, 2023, 10:12 AM

#

thats entirely fair yeah lmao

#

im like that too

#

thats why i wrote this instead of using vulkano or something

short surge Apr 21, 2023, 10:14 AM

#

yeah, it's really cool but I'm enjoying NIH at the moment

shadow trench Apr 21, 2023, 10:14 AM

#

the GP curse is real

short surge Apr 21, 2023, 10:14 AM

#

yep, took me a year of messing around with Vulkan to start actually progressing a bit more with it recently

shadow trench Apr 21, 2023, 10:15 AM

#

yeah ive been through a ton of refactors and iterations kek

#

i think i started learning vk like 3 years ago now

short surge Apr 21, 2023, 10:15 AM

#

it is nice when you look back and see how you have progressed. little do you know there's a mountain to climb right in front of you

#

nice, did you do much GP beforehand

shadow trench Apr 21, 2023, 10:16 AM

#

I wrote a small opengl engine

#

shadows, basic lighting, etc

short surge Apr 21, 2023, 10:17 AM

#

that's about how far I got with OpenGL too. then I decided to become a masochist

shadow trench Apr 21, 2023, 10:21 AM

#

good choice

#

i actually think opengl is more masochistic

#

its painful to use and debug and makes no sense

short surge Apr 21, 2023, 10:25 AM

#

yeah, i tried starting a project with it myself and I hated interfacing with it, especially after I had tried Vulkan

#

in university our lecturer had an OpenGL framework/engine so I never made anything with it completely from scratch

shadow trench Apr 21, 2023, 10:26 AM

#

most opengl frameworks also suffer from the same issues as opengl sadly

#

fwog is nice but its still opengl

short surge Apr 21, 2023, 10:27 AM

#

it was still raw opengl tbh but he just abstracted EVERYTHING into classes

shadow trench Apr 21, 2023, 10:27 AM

#

eh thats not great imo

short surge Apr 21, 2023, 10:27 AM

#

so we only really had to think about the actual draw calls and stuff, he had done all the setup

shadow trench Apr 21, 2023, 10:27 AM

#

the problem with classes in opengl imo comes from a lot of implicit behaviour

short surge Apr 21, 2023, 10:27 AM

#

yeah, looking back at the repo is painful

shadow trench Apr 21, 2023, 10:28 AM

#

e.g. constructing a Texture class might change some global state

#

without you knowing about it

#

A while ago I tried solving this problem with a bind_guard that would glBind... in the constructor and glBind...(previous_object) in the destructor but it really didnt work well

short surge Apr 21, 2023, 10:29 AM

#

yep, my friend says he thinks it made it easier to learn(having everything in classes) but i think it led me to stupid designs that ignore what's actually happening

shadow trench Apr 21, 2023, 10:29 AM

#

yeah

short surge Apr 21, 2023, 10:30 AM

#

he did send me a version of his framework that was in Vulkan but he wasn't sure whether to teach it yet or not

#

that was also all in classes

shadow trench Apr 21, 2023, 10:31 AM

#

in vk it works a bit better but theres still a lot of issues with "just use classes for every vk object lol"

short surge Apr 21, 2023, 10:33 AM

#

yeah, it just ended up being a really brittle design

#

when are you gunna post more updates on the terrain editor

shadow trench Apr 21, 2023, 10:34 AM

#

im going to finish off the docs for the current version of my vk thingy, add the create infos we talked about and then go back to work on it

short surge Apr 21, 2023, 10:34 AM

#

i'm interested to see, i've done some erosion simulation in the past

#

nice, can't wait for the updates

shadow trench Apr 21, 2023, 10:35 AM

#

erosion is definitely on the list frogapprove

haughty valley Apr 21, 2023, 10:36 AM

#

@shadow trench i take it this one is the fred?

shadow trench Apr 21, 2023, 10:37 AM

#

this is the fred yes

#

ive ran my code on some amd gpus and it worked fine there

#

but for some reason its crashing in a driver thread on nvidia

haughty valley Apr 21, 2023, 10:37 AM

#

if I had to guess I'd say compiler bug

shadow trench Apr 21, 2023, 10:38 AM

#

oh i havent considered that

haughty valley Apr 21, 2023, 10:38 AM

#

this is probably also why it doesn't crash with aftermath

#

aftermath adding shader instrumentation -> something is different in shader -> no crash

shadow trench Apr 21, 2023, 10:38 AM

#

i used glslc to compile the shader, maybe its bogus when compiling ray queries

#

makes sense

haughty valley Apr 21, 2023, 10:38 AM

#

not necessarily

#

if you want to be sure run spirv-val on it

#

if no output then you're good and you can bonk nvidia compiler people

shadow trench Apr 21, 2023, 10:39 AM

#

gotcha

#

spriv-val is giving me nothing

haughty valley Apr 21, 2023, 10:40 AM

#

bonk it is then

shadow trench Apr 21, 2023, 10:40 AM

#

ah wait i have to make sure it has the rayquery enabled

#

yeh it is

haughty valley Apr 21, 2023, 10:41 AM

#

as for why it does the compile in a bg thread, no idea, maybe a remnant from the OGLder days

shadow trench Apr 21, 2023, 10:41 AM

#

possibly

#

ive made a fred on nvidia forums, i can wait a bit for a reply there

#

its a bit weird to me that it doesnt crash on frame 0

#

usually after like 7-8 frames

haughty valley Apr 21, 2023, 10:44 AM

#

yeah, maybe they do some opts after the shader has run for a bit or similar cursed stuff

shadow trench Apr 21, 2023, 10:44 AM

#

thats possible

haughty valley Apr 21, 2023, 10:44 AM

#

you'd need to ask apache if there's anything like that in the driver codebase :^)

shadow trench Apr 21, 2023, 10:44 AM

#

another person to go bother :)

haughty valley Apr 21, 2023, 10:45 AM

#

wasn't really serious, apache has a leaked version of the driver code so not sure if you'll want to have anything to do with that

shadow trench Apr 21, 2023, 10:46 AM

#

oh kekw

#

Yeah maybe not

#

thank for the info though, this is useful insight to have 🙏

shadow trench Apr 21, 2023, 11:25 AM

#

@potent quest docs for 0.7 are finished i think

#

https://docs.rs/phobos/latest/phobos/

potent quest Apr 21, 2023, 6:09 PM

#

time to rust (soon i should study for exams)

#

but who needs exams. my midterms are through and unis only look at that KEKW

shadow trench Apr 21, 2023, 6:24 PM

#

kekw i wish it was that way here

#

if you have any questions you can always ping me here

shadow trench Apr 21, 2023, 6:53 PM

#

ok now i should have 100% doc coverage if i did it right

#

i added a compiler check that will yell if a public item isnt documented

livid geode Apr 21, 2023, 6:56 PM

#

ye thats good

#

i have that set for rs-tiled as well

shadow trench Apr 21, 2023, 6:56 PM

#

easy to miss things

livid geode Apr 21, 2023, 6:56 PM

#

ggez has it set so that it fails compilation lmao

shadow trench Apr 21, 2023, 6:56 PM

#

docs.rs build queue is crazy rn

#

120 crates in queue

livid geode Apr 21, 2023, 6:57 PM

#

wtf

#

why

shadow trench Apr 21, 2023, 6:57 PM

#

idk lol

#

friday evening i guess

livid geode Apr 21, 2023, 6:58 PM

#

ppl jumping into the rust bandwagon after seeing the funny release number

shadow trench Apr 21, 2023, 6:58 PM

#

kekw

#

True

short surge Apr 21, 2023, 8:07 PM

#

out of curiosity, how much do you use interior mutability with things like RefCell

shadow trench Apr 21, 2023, 8:13 PM

#

I don’t use refcell at all

#

Only RwLock and Mutex

#

I need my lib to be thread safe my default

livid geode Apr 21, 2023, 8:15 PM

#

then you have my chad renderer which uses a global to keep track of the device and context

#

frOK

shadow trench Apr 21, 2023, 8:16 PM

#

💀

livid geode Apr 21, 2023, 8:17 PM

#

in my defense it's threadsafe and caters to my needs also simplifies things a lot

shadow trench Apr 21, 2023, 8:17 PM

#

Tbf for a regular application it’s fine

short surge Apr 21, 2023, 8:21 PM

#

cool, just curious. i'm not sure if I'm fighting using interior mutability too much, but some of the stuff I'm doing at the moment is frustrating to design around taking exclusive references. had a look at wgpu and it seems it has a lot of just &self references when using the device

shadow trench Apr 21, 2023, 8:21 PM

#

Same for the device for me

#

The thing is

#

The device is cloneable

#

pub struct Device(Arc<DeviceInner>) or Arc<Mutex<XXXInner>> where applicable is what I do

short surge Apr 21, 2023, 8:26 PM

#

yeah, that's what I think would be handy for me to do. but my device does have a bit of state, so I think I need to make it interior mutable to be able to use it in an Arc as I won't be able to acces &mut references

#

have you had any problems with having it wrapped up like that>

shadow trench Apr 21, 2023, 8:27 PM

#

I think its better

#

I used to return an Arc<Device> from new and pass that around but thats kind of not done usually

#

So I moved the arc and/or mutex inside and its much cleaner now

short surge Apr 21, 2023, 8:28 PM

#

Cool, I might give something like that a go. Cheers 🙂

shadow trench Apr 21, 2023, 8:28 PM

#

Its pretty nice :)

#

I think the stuff thats done like that for me is uh

#

Device, Allocator (but this is a bit different, the allocator trait just requires Clone), PipelineCache, DescriptorCache and ExecutionManager

shadow trench Apr 22, 2023, 4:53 PM

#

@young oar engine dev is busy but

#

https://play.rust-lang.org/?version=nightly&mode=debug&edition=2021&gist=2b09ff374dc567a45b3e393d7b95cea6

Rust Playground

A browser interface to the Rust compiler to experiment with the language

#

it works

#

and its incredibly cursed

#

https://play.rust-lang.org/?version=nightly&mode=debug&edition=2021&gist=247ba39075e47ebc717646c4884d2f9b small improvement

young oar Apr 22, 2023, 4:57 PM

#

Normally you won't even need unsafe on line 35

#

Just do .as_any().downcast_ref::<R>()

#

Or well

#

That's how it's possible using normal boxes

#

First time hearing about thinbox

shadow trench Apr 22, 2023, 4:57 PM

#

Doesnt work with regular boxes I think

#

Because the size of Box<T> depends on T

#

I tried but I couldn’t find a way to get a Box<dyn Any> from a Box<T> without UB or compiler error

#

ThinBox always has the same size so this isn’t a problem

#

And you can transmute

#

But it’s unstable

young oar Apr 22, 2023, 4:59 PM

#

// assuming "value" implements "Any" (aka it's sized and 'static)
let boxed: Box<dyn Any> = Box::new(value);

#

That should work

shadow trench Apr 22, 2023, 5:00 PM

#

Oh hm yeah maybe that’s doable

young oar Apr 22, 2023, 5:01 PM

#

https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=8c5e9a80bd4942bde5b9afb9149f447a

Rust Playground

A browser interface to the Rust compiler to experiment with the language

#

Yea it works

shadow trench Apr 22, 2023, 5:01 PM

#

Ah but I think casting that to dyn Foo is UB

young oar Apr 22, 2023, 5:01 PM

#

As long as T is 'static (Any is automatically implemented for all types that are 'static)

shadow trench Apr 22, 2023, 5:01 PM

#

Because different vtable stuff

young oar Apr 22, 2023, 5:01 PM

#

Most probably lul

#

Yea no it is

shadow trench Apr 22, 2023, 5:02 PM

#

I ran something like that through miri

shadow trench Apr 22, 2023, 7:42 PM

#

struct Registry {
    dyn_items: HashMap<TypeId, ThinBox<dyn Any>>,
    items: HashMap<TypeId, Box<dyn Any>>,
}

impl Registry {
    pub fn new() -> Self {
        Self {
            dyn_items: HashMap::default(),
            items: HashMap::default(),
        }
    }
    
    fn put_dyn_boxed<T: ?Sized + 'static>(&mut self, item: ThinBox<T>) {
        // SAFETY: ThinBox always has the same size regardless of the type inside, 
        // so we can transmute this to a different pointer until we cast it back to
        // T in get()
        let any = unsafe { std::mem::transmute::<_, ThinBox<dyn Any>>(item) };
        self.dyn_items.insert(TypeId::of::<T>(), any);
    }
    
    pub fn put<T: 'static>(&mut self, item: T) {
        self.items.insert(TypeId::of::<T>(), Box::new(item));
    }

    pub fn put_dyn<T: ?Sized + 'static>(&mut self, item: impl Unsize<T> + 'static) {
        self.put_dyn_boxed::<T>(ThinBox::new_unsize(item));
    }
    
    pub fn get<T: 'static>(&self) -> Option<&T> {
        let any = self.items.get(&TypeId::of::<T>());
        any.map(|value| value.downcast_ref::<T>().unwrap())
    }
    
    pub fn get_dyn<T: ?Sized + 'static>(&self) -> Option<&T> {
        let any = self.dyn_items.get(&TypeId::of::<T>());
        any.map(|any| unsafe { std::mem::transmute::<_, &ThinBox<T>>(any) }.deref() )
    }
}

alright this is kinda getting somewhere actually lmao

#

usage:

trait MyTrait {
    fn call(&self);
}

struct Foo;

struct Bar {
    pub value: String,
}

impl MyTrait for Foo {
    fn call(&self) {
        println!("meow");
    }
}

impl MyTrait for Bar {
    fn call(&self) {
        println!("woof: {}", self.value);
    }
}

fn main() {
    let mut reg = Registry::new();
    // Register an instance of Foo as our implementation of MyTrait
    reg.put_dyn::<dyn MyTrait>(Foo);
    // We can also put Sized types in the registry
    
    reg.put(Bar { value: "Bar".to_owned() }); 
    // Will call Foo::call()
    reg.get_dyn::<dyn MyTrait>().unwrap().call();
    // Will call Bar::call()
    reg.get::<Bar>().unwrap().call();
    // We did not explicitly register Foo, so this will be None
    // even though there is a Foo in the registry (this is only known as dyn MyTrait)
    assert!(reg.get::<Foo>().is_none())
}

#

would be nice to make get and get_dyn both be the same function but its tricky

#

Putting Sized types inside a ThinBox<dyn Any> is UB as I found out so that doesnt work

#

specialization could fix this

young oar Apr 24, 2023, 2:32 AM

#

shadow trench ```rs struct Registry { dyn_items: HashMap<TypeId, ThinBox<dyn Any>>, it...

Yea honestly that's pretty much how my resource handling system gets handled kek

#

Other than the *_dyn methods since I never used/needed to use ThinBox

young oar Apr 24, 2023, 2:33 AM

#

shadow trench Putting `Sized` types inside a `ThinBox<dyn Any>` is UB as I found out so that d...

Hm that's interesting

shadow trench Apr 24, 2023, 9:25 AM

#

I might use this

shadow trench Apr 24, 2023, 4:40 PM

#

struct MySystem {
    pub value: i32,
}

struct MyEvent;
struct OtherEvent;

impl Event for MyEvent {}
impl Event for OtherEvent {}

fn handle(state: &mut MySystem, _event: &MyEvent) -> Result<()> {
    println!("Hello {}", state.value);
    Ok(())
}

fn handle_other(state: &mut MySystem, _event: &OtherEvent) -> Result<()> {
    println!("Other event!");
    Ok(())
}

impl System for MySystem {
    fn register_handlers(registry: &mut SystemRegistry, system: &StoredSystem<Self>) {
        registry.register_handler(system, handle);
        registry.register_handler(system, handle_other);
    }
}

#[test]
fn test_system_registry() -> Result<()> {
    let mut registry = SystemRegistry::new();
    registry.register_system(MySystem { value: 5 });
    registry.trigger(&OtherEvent)?;
    registry.trigger(&MyEvent)?;
    Ok(())
}

we gaming

#

that took a while to figure out

#

i really didnt want to have a fixed set of event types

#

Strictly speaking the event trait is not needed but for completeness I added it in

hot yarrow Apr 24, 2023, 4:56 PM

#

registry is the wrong name

#

but thats just me 🙂

shadow trench Apr 24, 2023, 4:56 PM

#

i am open to suggestions :)

hot yarrow Apr 24, 2023, 4:56 PM

#

EventBus or MessageBus you Subscribe to

shadow trench Apr 24, 2023, 4:57 PM

#

hmm yeah that may be a better name

hot yarrow Apr 24, 2023, 4:57 PM

#

and EventBus/MessageBus also has Publish where you send the messages

shadow trench Apr 24, 2023, 4:57 PM

#

I was considering splitting off the EventBus part to a different struct

hot yarrow Apr 24, 2023, 4:57 PM

#

or you split it into Subscriber and Publisher

shadow trench Apr 24, 2023, 4:57 PM

#

I do like subscribe though

hot yarrow Apr 24, 2023, 4:57 PM

#

yeah

shadow trench Apr 24, 2023, 4:57 PM

#

a lot better than register_handler

hot yarrow Apr 24, 2023, 4:57 PM

#

otherwise Mediator is an alternative

#

but thats the pattern behind all that and not really a good name for the thing

shadow trench Apr 24, 2023, 4:58 PM

#

yeah

#

How would you call the method that does all the subscribing on init

#

impl System for MySystem {
    fn register_handlers(registry: &mut EventBus, system: &StoredSystem<Self>) {
        registry.subscribe(system, handle);
        registry.subscribe(system, handle_other);
    }
}

this one

#

initialize is fine

hot yarrow Apr 24, 2023, 5:30 PM

#

hmm it depends

#

if you inject the eventbus into where it needs to register, you can do that in the ctor already

#

no need to call initialize somewhere in some specific order possibly

#

lets say your Window class

#

where you use glfw

shadow trench Apr 24, 2023, 5:32 PM

#

the problem is that the current system only allows subscribing from a StoredSystem<S>

hot yarrow Apr 24, 2023, 5:33 PM

#

// window
public Window(EventBus eventBus)
{
    glfwInit
    glfwSetXXXCallback(_window, handleXXX);
    glfwSetYYYCallback...
}

private void handleXXX()
{
    eventBus.Publish(WindowMovedEvent(x, y));
}

// somewhere else
public SomethingReactingToWindowResize(EventBus eventBus)
{
    eventBus.Subscribe(WindowSizedEvent, OnWindowSized);
}

private void OnWindowSized(x, y)
{
}

shadow trench Apr 24, 2023, 5:34 PM

#

shadow trench the problem is that the current system only allows subscribing from a `StoredSys...

pub struct StoredSystemInner<S> {
    state: S,
    handlers: Registry,
}

#

Registry is just some Vec<Any> but wrapped

#

I might need a better name for it

hot yarrow Apr 24, 2023, 5:35 PM

#

hmm

#

name does not tell me anything

#

therefore this type is not necessary

#

but mayhaps its the way you code in rust

shadow trench Apr 24, 2023, 5:35 PM

#

this registry thing isnt part of the public api

#

but i use it in a few places so its still useful

#

it basically allows me to do type erasure in rust

hot yarrow Apr 24, 2023, 5:36 PM

#

registry is a bad name

shadow trench Apr 24, 2023, 5:36 PM

#

probably

hot yarrow Apr 24, 2023, 5:36 PM

#

name it what it is

#

eventbus/messagebus/PublishSubscriberIsm/PubSubThing/Mediator

shadow trench Apr 24, 2023, 5:37 PM

#

Registry something equivalent to ArrayList<Object> in java

hot yarrow Apr 24, 2023, 5:37 PM

#

from best to worst

shadow trench Apr 24, 2023, 5:37 PM

#

but with some utilities to get<T> and put<T>

hot yarrow Apr 24, 2023, 5:37 PM

#

yeah in essence its just a list of callbacks

shadow trench Apr 24, 2023, 5:37 PM

#

yeah but the generic case isnt necessarily a list of callbacks

hot yarrow Apr 24, 2023, 5:38 PM

#

or a dictionary<Message, List<callback>>

#

the generic case is a bus

shadow trench Apr 24, 2023, 5:38 PM

#

well the event bus is already EventBus

hot yarrow Apr 24, 2023, 5:38 PM

#

or EventHandlerRegistry at least

shadow trench Apr 24, 2023, 5:38 PM

#

this registry has nothing to do with the event system thingy

hot yarrow Apr 24, 2023, 5:38 PM

#

ah

#

its a different registry now?

shadow trench Apr 24, 2023, 5:38 PM

#

its even in a different repo :P

hot yarrow Apr 24, 2023, 5:39 PM

#

thought we talk about te same thing 😛

shadow trench Apr 24, 2023, 5:39 PM

#

pub struct Registry {
    items: HashMap<TypeId, Box<dyn Any>>,
}

impl Registry {

    pub fn put<T>(&mut self, item: T) {
        
    }

pub fn get<T>(&self) -> Option<&T> {

    }
}

#

simplified the rust isms

#

but its just a way to store any type and retrieve it later

hot yarrow Apr 24, 2023, 5:40 PM

#

im still confused

#

is Registry the callback holder or not

#

or something different now

shadow trench Apr 24, 2023, 5:40 PM

#

it stores the callbacks but it doesnt have to

#

it also stores the event buses for each event type

hot yarrow Apr 24, 2023, 5:41 PM

#

make a distinct type for the event nonsense

#

there is most likely no other use case for Registry in this instance

shadow trench Apr 24, 2023, 5:41 PM

#

I do use it in one other place

hot yarrow Apr 24, 2023, 5:41 PM

#

like?

shadow trench Apr 24, 2023, 5:41 PM

#

pub struct EventBus {
    buses: Registry,
}

hot yarrow Apr 24, 2023, 5:42 PM

#

buses is wrong

shadow trench Apr 24, 2023, 5:42 PM

#

Because I need a list of ```rs
pub struct TypedEventBus<E: Event> {
systems: Vec<Box<dyn Caller<E>>>,
}

#

type erasure in rust is tricky :P

hot yarrow Apr 24, 2023, 5:42 PM

#

sounds like a shit language 😛

shadow trench Apr 24, 2023, 5:42 PM

#

kek

#

Well this isnt something its great at admittedly

hot yarrow Apr 24, 2023, 5:42 PM

#

obviously i do not know any rust, and im just talking out of my salty ass

shadow trench Apr 24, 2023, 5:43 PM

#

kekw

#

naming is somewhat universal though

#

Registry is not a great name though

hot yarrow Apr 24, 2023, 5:46 PM

#

hehe

#

well mayhaps naming is not so important

#

make the thing work first

shadow trench Apr 24, 2023, 5:46 PM

#

yeah true, renaming is easy

hot yarrow Apr 24, 2023, 6:30 PM

#

https://www.youtube.com/watch?v=A_MsXney3EU heh just saw this one

YouTube

C++ Weekly With Jason Turner

C++ Weekly - Ep 373 - Design Patterns in "Modern" C++ (2023)

☟☟ Upcoming Conference Workshops (Swag, links and more) ☟☟

C++ Best Practices Workshop, Sept 18, 19, Norway: https://ndctechtown.com/workshops/c-best-practices/abf61aa1ff65

T-SHIRTS AVAILABLE!

► The best C++ T-Shirts anywhere! https://my-store-d16a2f.creator-spring.com/

WANT MORE JASON?

► My Training Classes: http://emptycrate.com/training...

▶ Play video

shadow trench Apr 24, 2023, 7:14 PM

#

ooo

shadow trench Apr 24, 2023, 10:36 PM

#

@young oar does splitting your source up into multiple crates have any noticable impact on build times

#

i checked out your repo to figure out the events thing

young oar Apr 24, 2023, 10:38 PM

#

shadow trench <@463353335269818368> does splitting your source up into multiple crates have an...

YES

shadow trench Apr 24, 2023, 10:39 PM

#

probably worth doing then

young oar Apr 24, 2023, 10:39 PM

#

Well if you edit the source code for like, the asset manager (a crate used by many more crates) its still pretty slow

shadow trench Apr 24, 2023, 10:39 PM

#

link time is getting pretty bad for me kek

#

Yeah

young oar Apr 24, 2023, 10:39 PM

#

shadow trench link time is getting pretty bad for me <:kek:939553745417695256>

How many seconds per clean run?

shadow trench Apr 24, 2023, 10:39 PM

#

lemme try

#

ah wait

#

a clean build takes a couple minutes

young oar Apr 24, 2023, 10:40 PM

#

Yeaaa that's pretty long

shadow trench Apr 24, 2023, 10:40 PM

#

because its compiling netcdf-sys and hdf5 which are both giant C libraries apparently

#

thats the biggest time sink

#

I should probably just yeet support for netcdf

young oar Apr 24, 2023, 10:41 PM

#

Tf is netcdf?

#

Never heard of it

shadow trench Apr 24, 2023, 10:41 PM

#

some format

#

for uh

#

its some structured data format

young oar Apr 24, 2023, 10:41 PM

#

Ahh I see

shadow trench Apr 24, 2023, 10:41 PM

#

real world heightmap data sometimes uses it

young oar Apr 24, 2023, 10:41 PM

#

Ohhh yea

#

Fair fair

shadow trench Apr 24, 2023, 10:41 PM

#

but its not great to compile those giant crates

young oar Apr 24, 2023, 10:42 PM

#

Yeaa

shadow trench Apr 24, 2023, 10:42 PM

#

maybe i should write a very lightweight parser instead

young oar Apr 24, 2023, 10:42 PM

#

I mean that's per clean run

shadow trench Apr 24, 2023, 10:42 PM

#

Yeah true

#

im running cargo build --timings rn so we will see

#

WAITING

young oar Apr 24, 2023, 10:43 PM

#

Ouchhh

shadow trench Apr 24, 2023, 10:43 PM

#

i think ill spend some time writing that parser soon

#

should be easy, i think the format is quite simple

young oar Apr 24, 2023, 10:45 PM

#

Yep

#

Good luck

shadow trench Apr 24, 2023, 10:47 PM

#

yeah lol this is ridiculous

livid geode Apr 24, 2023, 10:57 PM

#

mold pls

young oar Apr 24, 2023, 10:59 PM

#

Yea that too

#

Or lld if you're on windows

#

Sux that mold isn't on windows

shadow trench Apr 24, 2023, 11:00 PM

#

Im already using lld I think

#

But that won’t help with compiling hundreds of C files

#

Might just yeet netcdf support altogether

#

I can’t find a clear spec

#

Just “use our c bindings lol”

shadow trench Apr 25, 2023, 9:12 AM

#

I have introduced an easy way to deadlock my app

#

But its probably fine

#

fn handle(system: &mut MySystem, event: &Event, context: &mut EventContext) {
  context.publish(event);
}

hot yarrow Apr 25, 2023, 10:40 AM

#

features: deprecated

#

https://tenor.com/view/noice-nice-click-gif-8843762

Tenor

shadow trench Apr 25, 2023, 10:40 AM

#

always fun

livid geode Apr 25, 2023, 11:48 AM

#

shadow trench ```rs fn handle(system: &mut MySystem, event: &Event, context: &mut EventContext...

lmao

shadow trench Apr 25, 2023, 11:49 AM

#

yeah its silly but itll deadlock lol

#

just publishing the same event type recursively

#

fn handle_input_event(
    camera: &mut Camera,
    event: &InputEvent,
    ctx: &mut EventContext<DI>,
) -> Result<()> {
    let mut state = camera.write().unwrap();
    let input = ctx.read().unwrap().get::<Input>().unwrap();
    state.handle_event(event, input)
}

refactoring progress

#

I can live with this for event handlers I think

young oar Apr 25, 2023, 1:25 PM

#

One problem that comes with passing resources as arguments is that you can request for reading/writing to a resource afterwards

shadow trench Apr 25, 2023, 1:25 PM

#

is that an issue

young oar Apr 25, 2023, 1:25 PM

#

So material systems might be a bitch to implement since they require modular resources

shadow trench Apr 25, 2023, 1:25 PM

#

my engine has a very fixed renderer because i only render terrains

young oar Apr 25, 2023, 1:26 PM

#

Ah then you're good

shadow trench Apr 25, 2023, 1:26 PM

#

so it doesnt need to be extremely flexible when it comes to material systems

potent quest Apr 25, 2023, 5:31 PM

#

wtf

#

16 as vk::DeviceSize

#

is this seriously how you type cast in rust

#

no way

livid geode Apr 25, 2023, 5:47 PM

#

yes

#

and thats just for primitives

#

so unless that devicesize is an alias, that will not compile

shadow trench Apr 25, 2023, 5:50 PM

#

its u64

#

you can just write 16u64 too

wise viper Apr 25, 2023, 5:55 PM

#

i love rust syntax

#

froge

shadow trench Apr 25, 2023, 5:58 PM

#

it has some quirks :P

#

I dont really like the foo::<T>() syntax

wise viper Apr 25, 2023, 6:01 PM

#

true

potent quest Apr 25, 2023, 8:08 PM

#

use std::io;

fn main() {
    println!("Guess the number!");
    println!("Please input your guess.");

    let mut guess = String::new();
    io::stdin()
        .read_line(&mut guess)
        .expect("Failed to read line");

    println!("You guessed: {guess}");
}

rust is so much cleaner wtf

#

also im learning rust now

#

im gonna phobo'ing soon

short surge Apr 25, 2023, 8:12 PM

#

welcome 😈

potent quest Apr 25, 2023, 8:13 PM

#

LMAOO

#

there's no going back* (i have exams and should study but it's only 1 exam)

#

WHAT

#

rust has in-built documentation

#

bruh

shadow trench Apr 25, 2023, 8:37 PM

#

potent quest im gonna phobo'ing soon

LETSFUCKINGGO

shadow trench Apr 25, 2023, 8:38 PM

#

potent quest rust has in-built documentation

rustdoc is great

#

i recommend intellij with the rust plugin if youre not using that already

hot yarrow Apr 25, 2023, 8:41 PM

#

lol

#

you guys sound like cavemen coming out of the cave in 2023

shadow trench Apr 25, 2023, 8:42 PM

#

kekw thats what its like leaving C++

hot yarrow Apr 25, 2023, 8:42 PM

#

c# had all that 20 years ago 😄

#

ok lets be fair, 13 years ago

shadow trench Apr 25, 2023, 8:43 PM

#

13 years ago c++ didnt have move semantics

potent quest Apr 25, 2023, 8:48 PM

#

crates.io my beloved ❤️

#

matching is so clean

#

oml

potent quest Apr 25, 2023, 8:48 PM

#

hot yarrow you guys sound like cavemen coming out of the cave in 2023

because i am one

shadow trench Apr 25, 2023, 8:48 PM

#

aye

#

its great

potent quest Apr 25, 2023, 8:49 PM

#

i love that rust complains if you don't handle results given

shadow trench Apr 25, 2023, 8:49 PM

#

yep

potent quest Apr 25, 2023, 8:52 PM

#

shadowing is weird though to me feels wrong

#

also sheesh clion has a cleaner look

#

more vscodified KEKW

shadow trench Apr 25, 2023, 8:58 PM

#

its nice

#

i use it too

potent quest Apr 25, 2023, 8:58 PM

#

yea feels more approachable

#

oh teag

#Andromeda - Terrain/Landscape editor using Vulkan and Rust