(plasmatm) Custom item as the trade input? | Denizen and Citizens | Page 1

lament nova Nov 18, 2023, 10:30 AM

#

Hey, I have some code that creates a simple villager trade shop, based on config.

If I set the input as any vanilla item, such as charcoal, it works perfectly as the first image shows. It shows up, I can trade no problem.

But if I change JUST the config "input" for the trade to test_item, it works visually but I cannot trade. Pictures added for clarity.

Config before (working with charcoal):

config:
    type: data
    main_shop:
        one:
            result: diamond
            result_amount: 3
            input: charcoal
            input_cost: 5

Config after (not working with test_item, but shows the correct item visually I just cannot trade):

config:
    type: data
    main_shop:
        one:
            result: diamond
            result_amount: 3
            input: test_item
            input_cost: 5

Also, here is the code used to generate the trade from the config:

get_config:
    type: procedure
    definitions: key
    script:
        - determine <script[config].data_key[<[key]>]>

test_shop:
    type: task
    definitions: player
    script:
        - define config_trades <map[<proc[get_config].context[main_shop]>]>
        - define trades <list>
        - foreach <[config_trades]> key:key as:trade_info:
            - define trades:->:<trade[trade[result=<[trade_info].get[result]>[quantity=<[trade_info].get[result_amount]>];max_uses=999;inputs=<[trade_info].get[input]>[quantity=<[trade_info].get[input_cost]>]]]>
        - opentrades players:<[player]> <[trades]>

Any ideas?

marble pilotBOT Nov 18, 2023, 10:30 AM

#

(plasmatm) Custom item as the trade input?

marble pilotBOT Nov 18, 2023, 10:30 AM

#

lament nova Hey, I have some code that creates a simple villager trade shop, based on config...

#

Hi I'm AutoThreadBot! Don't mind me, I'll just be adding the helper team to this thread so they can see it. A human will get to you soon.

lost bobcat Nov 18, 2023, 12:04 PM

#

!debug

weary burrowBOT Nov 18, 2023, 12:04 PM

#

lost bobcat !debug

Info: debug

If you need help with a script issue, one of the most powerful tools Denizen has to offer is full debug output. This is displaying in your console whenever scripts are running until you turn debug off. To share a debug log quickly and easily with helpers, simply run the command /denizen debug -r in-game to begin recording, then run through the part of the script you need help with, then run the command /denizen submit. This will give you a link to a paste of the debug log, which you can then copy/paste back to us!

lost bobcat Nov 18, 2023, 12:04 PM

#

Can you provide a debug of that script please?

lament nova Nov 18, 2023, 12:27 PM

#

lost bobcat Can you provide a debug of that script please?

https://paste.denizenscript.com/View/117705

Denizen Debug Logs From <#f76a3b>S<#f77a3b>o<#f78a3b>l<#f79a3b>a<#f...

Content of Server Log Paste #117705: Denizen Debug Logs From <#f76a3b>S<#f77a3b>o<#f78a3b>l<#f79a3b>a<#f8ab3a>c<#f8bb3a>e<#f8cb3a>M<#f8db3a>C... pasted 2023/11/18 04:26:11 UTC-08:00, Paste length: 15003 characters across 123 lines, Content: Java Version: 17.0.9Up-time: 9h 25m

lament nova Nov 18, 2023, 1:06 PM

#

The debug shows nothing wrong, and the item appears visually so i just can't understand why the trade doesn't work

pallid sundial Nov 18, 2023, 1:49 PM

#

I just tried this with your exact code and it's working as expected

#

!logcheck https://paste.denizenscript.com/View/117705

Denizen Debug Logs From <#f76a3b>S<#f77a3b>o<#f78a3b>l<#f79a3b>a<#f...

Content of Server Log Paste #117705: Denizen Debug Logs From <#f76a3b>S<#f77a3b>o<#f78a3b>l<#f79a3b>a<#f8ab3a>c<#f8bb3a>e<#f8cb3a>M<#f8db3a>C... pasted 2023/11/18 04:26:11 UTC-08:00, Paste length: 15003 characters across 123 lines, Content: Java Version: 17.0.9Up-time: 9h 25m

weary burrowBOT Nov 18, 2023, 1:49 PM

#

pallid sundial !logcheck https://paste.denizenscript.com/View/117705

Log Check Results

Server Version

Paper version git-Paper-176 (MC: 1.20.1)-- (:warning: Outdated build, behind by 116... Current build is 292)

Plugin Version(s)

Citizens: 2.0.32-SNAPSHOT (build 3147) -- (:warning:Outdated build, behind by 119)
Denizen: 1.2.8-SNAPSHOT (build 1797-REL) -- (Outdated build, behind by 2)
Depenizen: 2.1.0 (build 840) -- (Outdated build, behind by 10)
dDiscordBot: 0.7 (build 293) -- (Outdated build, behind by 2)

Checked For

@pallid sundial

Online/Offline

Offline, but proxied.

UUID Version

4 (:white_check_mark: Online)

Java Version

17.0.9 :white_check_mark:

Other Noteworthy Plugin(s)

WorldGuard: 7.0.9+5934e49, MythicMobs: 5.4.1-${CI_COMMIT_SHORT_SHA}, ProtocolLib: 5.1.0, Quests: 4.8.3-b423

Problematic Plugin(s)

PlugManX: 2.3.3 - :warning: Plugin Managers are dangerous and will cause unpredictable issues. Remove it.

Possibly Relevant Plugin(s)

TAB: 4.0.3 - This plugin adds Below_Name scoreboards to NPCs.
ViaVersion: 4.8.1 - Mixed client vs server versions can sometimes cause packet-related issues.
HeadDatabase: 4.18.0 - HeadDatabase has been known to cause issues with skins.
ModelEngine: R4.0.2 - ModelEngine has Citizens support, but that support is known to be buggy. Issues related to NPCs that use ModelEngine should be reported to ModelEngine support, not Citizens.
FastAsyncWorldEdit: 2.8.2-SNAPSHOT-585;37161f9 - This plugin has been known to break the plugin load order on many servers, due to usage of the 'loadbefore' directive in its 'plugin.yml'.
GSit

pallid sundial Nov 18, 2023, 1:50 PM

#

!update paper denizen

weary burrowBOT Nov 18, 2023, 1:50 PM

#

pallid sundial !update paper denizen

Update Paper

Paper is a higher-performance alternative to Spigot that is 100% compatible with the equivalent Spigot version. It's much easier to update than Spigot itself, and carries a lot of performance and quality-of-life benefits.

Latest Paper builds are at https://papermc.io/downloads/paper.

(If you would prefer to use a Spigot build, refer to !update spigot).

#

Update Denizen

Latest Denizen stable release builds are at https://ci.citizensnpcs.co/job/Denizen/. Most users should download the stable release build.

Latest Denizen dev builds are at https://ci.citizensnpcs.co/job/Denizen_Developmental/. Dev builds are for usually for test servers only.

Spigot resource page for Denizen is at https://www.spigotmc.org/resources/denizen.21039/ (do NOT download builds from Spigot).

pallid sundial Nov 18, 2023, 1:50 PM

#

try updating

#

Also, your code looks very much over complicated

#

config:
    type: data
    main_shop:
        1:
            result: diamond[quantity=3]
            input: iron_ingot[quantity=5]
        2:
            result: emerald[quantity=3]
            input: gold_ingot[quantity=5]

test_shop:
    type: task
    script:

    - define trade_config <script[config].data_key[main_shop]>
    - foreach <[trade_config]> as:trade:
      - define trade <trade[trade[result=<[trade.result]>;inputs=<[trade.input]>;max_uses=999]]>
      - define trades:->:<[trade]>
    - opentrades <[trades]>```
This does the exact same thing

lament nova Nov 18, 2023, 3:11 PM

#

pallid sundial try updating

How will that help?

lament nova Nov 18, 2023, 3:11 PM

#

pallid sundial ```yaml config: type: data main_shop: 1: result: dia...

Some neat tricks in here, ty

lament nova Nov 18, 2023, 3:17 PM

#

pallid sundial I just tried this with your exact code and it's working as expected

Just to verify, you're actually able to buy the diamonds with the test items?

lament nova Nov 18, 2023, 3:43 PM

#

pallid sundial try updating

Okay updating was a disaster

Did you try this with a custom item? as that's what my question was about but your new suggested code doesn't mention 1, and even on the latest versions it isn't working for me

pallid sundial Nov 18, 2023, 4:24 PM

#

Yes custom works as well

pallid sundial Nov 18, 2023, 4:26 PM

#

lament nova How will that help?

It's always recommended to be on the latest version

#

!patchversion

weary burrowBOT Nov 18, 2023, 4:26 PM

#

pallid sundial !patchversion

Info: patchversion

We support only the latest patch-version of Minecraft for any recent main version (and Mojang, Spigot, Paper, etc. all generally also follow the same rule).

"Patch version" means the last number in a version label, for example in 1.18.2, the main version is 1.18, and the patch version is .2.
So if 1.18.2 is the latest patch version, then 1.18.1, and 1.18(.0) are all outdated patch versions, and therefore are unsupported.

Note that we do still support recent older main versions (such as 1.17 and 1.16) so long as you are on the latest patch-version of those main versions (like 1.17.1 and 1.16.5).

pallid sundial Nov 18, 2023, 4:44 PM

#

lament nova Nov 18, 2023, 9:27 PM

#

pallid sundial

okay so idk why but it's clear after a ton of testing that the test_item I get from the shop is different to the test_item i get with "/ex give test_item", and I cannot think of a reason why

i can only get your code to work if i buy tokens, then use them to buy other stuff. the tokens from this shop do not seem stackable with the /ex give ones, even with your exact code

steep sun Nov 18, 2023, 9:30 PM

#

lament nova okay so idk why but it's clear after a ton of testing that the test_item I get f...

Perhaps the nbt tags are different on the one you get from the shop and the one you /give
Use /data get entity @s SelectedItem on both the items. It should return the nbt tags

#

It might tell you something about their differences

lament nova Nov 18, 2023, 9:32 PM

#

steep sun Perhaps the nbt tags are different on the one you get from the shop and the one ...

yeah it must be that, what am i putting instead of "SelectedItem" here? how would i do the item in my hand for example

steep sun Nov 18, 2023, 9:32 PM

#

I believe you just keep SelectedItem there. It should get the item in your hand if Im not mistaken

#

otherwise, throw the item onto the ground and use /data get entity @e[type=item,limit=1,sort=nearest]

lament nova Nov 18, 2023, 9:34 PM

#

ah yes, so the item from /ex give is:

#

and the item i get from the trade gui is:

#

hard to really see the difference but, they're clearly different somehow

lament nova Nov 18, 2023, 9:35 PM

#

steep sun I believe you just keep SelectedItem there. It should get the item in your hand ...

yeah that worked ty

steep sun Nov 18, 2023, 9:37 PM

#

Alright so yeah that's a pretty huge difference

#

Where do you define the item you get from the trade gui?

#

As in, where do you specify all those parameters

lament nova Nov 18, 2023, 9:39 PM

#

i am just putting "test_item" in a config value for the "result" part of a trade tag, and then the test_item in the code is very simple

test_item:
    type: item
    material: sugar
    display name: <&gradient[from=<&color[#0276FD]>;to=<&color[#ADF3FD]>]><&l>Test Item
    enchantments:
    - luck_of_the_sea:1
    mechanisms:
        hides: all

lament nova Nov 18, 2023, 9:43 PM

#

steep sun Where do you define the item you get from the trade gui?

it's as if they're the same item but for some reason the trade gui is changing how it stores the same information, it converts the nesting style into a list, idk if it's maybe to do with how i write my items?

#

okay so, changing display name to just "<&6>Test Item" has it now working

#

so it's something to do with the gradient and bold? is this a bug?

#

yep, it's the gradient

#

for some reason, the gradient breaks it

#

should i report this somewhere?

cerulean isle Nov 18, 2023, 10:00 PM

#

After trading an item with a gradient through a trading GUI it doesn't match the original item anymore?

steep sun Nov 18, 2023, 10:01 PM

#

What mc version is this?

#

ok yeah no Im lost. Good luck 😕

cerulean isle Nov 18, 2023, 10:13 PM

#

Well first of all the last debug you posted was on an outdated version, so should post an updated one

lament nova Nov 20, 2023, 4:03 PM

#

cerulean isle Well first of all the last debug you posted was on an outdated version, so shoul...

I don't have a test environment on the latest version, and when i tried to update it a) it still didn't work and b) the update broke 1000 other things so we rolled it back.

Are you able to confirm it works for you, and if so what versions?

flint vapor Dec 1, 2023, 3:56 PM

#

!logcheck https://paste.denizenscript.com/View/118094

Denizen Debug Logs From A Minecraft Server | Paste #118094 | Denize...

Content of Server Log Paste #118094: Denizen Debug Logs From A Minecraft Server... pasted 2023/12/01 07:55:50 UTC-08:00, Paste length: 1777 characters across 22 lines, Content: Java Version: 17.0.6Up-time: 1h 20m

weary burrowBOT Dec 1, 2023, 3:56 PM

#

flint vapor !logcheck https://paste.denizenscript.com/View/118094

Log Check Results

Server Version

Paper version git-Paper-309 (MC: 1.20.2)-- (Current build :white_check_mark:)

Plugin Version(s)

Citizens: 2.0.33-SNAPSHOT (build 3275) -- (Current build :white_check_mark:)
Denizen: 1.2.9-SNAPSHOT (build 6936-DEV) -- (Current build :white_check_mark:)
Depenizen: 2.1.0 (build 850) -- (Current build :white_check_mark:)
Sentinel: 2.8.1-SNAPSHOT (build 513) -- (Current build :white_check_mark:)
dDiscordBot: 0.7 (build 295) -- (Current build :white_check_mark:)

Checked For

@flint vapor

Online/Offline

Offline, but proxied.

UUID Version

4 (:white_check_mark: Online)

Java Version

17.0.6 :white_check_mark:

flint vapor Dec 1, 2023, 3:56 PM

#

works fine on current version

#

!update

weary burrowBOT Dec 1, 2023, 3:56 PM

#

flint vapor !update

Update Denizen

Latest Denizen stable release builds are at https://ci.citizensnpcs.co/job/Denizen/. Most users should download the stable release build.

Latest Denizen dev builds are at https://ci.citizensnpcs.co/job/Denizen_Developmental/. Dev builds are for usually for test servers only.

Spigot resource page for Denizen is at https://www.spigotmc.org/resources/denizen.21039/ (do NOT download builds from Spigot).

#

Update Paper

Paper is a higher-performance alternative to Spigot that is 100% compatible with the equivalent Spigot version. It's much easier to update than Spigot itself, and carries a lot of performance and quality-of-life benefits.

Latest Paper builds are at https://papermc.io/downloads/paper.

(If you would prefer to use a Spigot build, refer to !update spigot).

lucid lavaBOT Dec 1, 2023, 3:56 PM

#

Thread Closing Reminder

Has your issue been resolved, or your question been answered?
If so, please use the </resolved:1028673926114594866> command to close your thread.
Or </invalid:1028673926898909185> if it's not possible to resolve.

If not yet resolved, please reply below to tell us what you still need.

(Note that if there is no reply for a few days, this thread will eventually close itself.)

#

@lament nova

lament nova Dec 1, 2023, 4:07 PM

#

flint vapor works fine on current version

This doesn't help though unfortunately, updating isnt an option. Do you know what version this bug was fixed, or a workaround?

flint vapor Dec 1, 2023, 4:10 PM

#

lament nova This doesn't help though unfortunately, updating isnt an option. Do you know wha...

if it's a valid bug, it cannot be resolved on outdated or unsupported versions, no

#

we can help you update though, that's a common misunderstanding that you are infact able to remain persistent in maintaining your server properly

lament nova Dec 1, 2023, 4:15 PM

#

Can I update Denizen and not paper? Updating Paper is going to be a huge task that I cannot do before I need the above code to work

flint vapor Dec 1, 2023, 4:16 PM

#

probably not, but you can rest assured it's just like waking up on a hard Monday - you'll be happy when it's done, over with, and working great again. we're here to support you clappy

cerulean isle Dec 3, 2023, 4:58 PM

#

lament nova Can I update Denizen and not paper? Updating Paper is going to be a huge task th...

What's the reason updating Paper is hard for you? it's usually as simple as:

stop server
update all relevant jars
start server

#

We're happy to help if you can provide more info on why can't you update, otherwise we can't really fix issues on outdated versions (epecially ones that already got fixed)

lucid lavaBOT Dec 3, 2023, 4:59 PM

#

Thread Closing Reminder

Has your issue been resolved, or your question been answered?
If so, please use the </resolved:1028673926114594866> command to close your thread.
Or </invalid:1028673926898909185> if it's not possible to resolve.

If not yet resolved, please reply below to tell us what you still need.

(Note that if there is no reply for a few days, this thread will eventually close itself.)

#

@lament nova

lament nova Dec 3, 2023, 5:27 PM

#

cerulean isle What's the reason updating Paper is hard for you? it's usually as simple as: 1. ...

caused a ton of issues with other plugins, just infeasible on a live server without some planning

#(plasmatm) Custom item as the trade input?