(udnek) tipped arrow color | Denizen and Citizens | Page 1

pseudo lava Oct 19, 2023, 10:22 PM

#

Is it possible to get tipped arrow color?

lucid domeBOT Oct 19, 2023, 10:22 PM

#

(udnek) tipped arrow color

lucid domeBOT Oct 19, 2023, 10:22 PM

#

pseudo lava Is it possible to get tipped arrow color?

#

Hi I'm AutoThreadBot! Don't mind me, I'll just be adding the helper team to this thread so they can see it. A human will get to you soon.

drifting sage Oct 19, 2023, 10:27 PM

#

!t itemtag.color

solar moatBOT Oct 19, 2023, 10:27 PM

#

drifting sage !t itemtag.color

Tag: <ItemTag.color>

Returns the color of the leather armor item, potion item, or filled map item.

Group

properties

Returns

ColorTag

Mechanism

ItemTag.color

drifting sage Oct 19, 2023, 10:27 PM

#

Have you tried this ^

pseudo lava Oct 19, 2023, 10:28 PM

#

yes, does not work

neat cedar Oct 19, 2023, 10:28 PM

#

Did you tried it with an entity or item in inventory?

pseudo lava Oct 19, 2023, 10:29 PM

#

item

drifting sage Oct 19, 2023, 10:29 PM

#

https://hub.spigotmc.org/javadocs/spigot/org/bukkit/entity/Arrow.html#getColor()

Arrow (Spigot-API 1.20.2-R0.1-SNAPSHOT API)

declaration: package: org.bukkit.entity, interface: Arrow

#

Looks like it’s a method, not in denizen tho i think

pseudo lava Oct 19, 2023, 10:30 PM

#

As I see, it returns null

drifting sage Oct 19, 2023, 10:31 PM

#

uhhh no

#

it’s just not in denizen it needs to be added i think

cerulean sandBOT Oct 19, 2023, 10:34 PM

#

Changed to Feature

Thread is now a Feature thread. This indicates a request for a new feature to the plugin, that both (A) does not already exist and (B) reasonably can be added. If you are unsure whether this applies, use </helpthread:1028674284870180883> to change back to a normal help thread.

drifting sage Oct 19, 2023, 10:37 PM

#

drifting sage https://hub.spigotmc.org/javadocs/spigot/org/bukkit/entity/Arrow.html#getColor()

this is for a physical entity, not sure where this method is for an item

#

looks like tipped arrows implement PotionMeta which means we can use getColor() from there

PotionMeta (Spigot-API 1.20.2-R0.1-SNAPSHOT API)

declaration: package: org.bukkit.inventory.meta, interface: PotionMeta

crude chasm Oct 19, 2023, 11:18 PM

#

it's already in denizen https://github.com/DenizenScript/Denizen/blob/dev/plugin/src/main/java/com/denizenscript/denizen/objects/properties/entity/EntityColor.java#L245

GitHub

Denizen/plugin/src/main/java/com/denizenscript/denizen/objects/prop...

NPC and general Spigot scripting, using the Denizen Scripting Language! - DenizenScript/Denizen

#

it should should work as far as i can see. if i'm wrong, then it can be added

#

can you please send a debug?

#

!debug

solar moatBOT Oct 19, 2023, 11:18 PM

#

crude chasm !debug

Info: debug

If you need help with a script issue, one of the most powerful tools Denizen has to offer is full debug output. This is displaying in your console whenever scripts are running until you turn debug off. To share a debug log quickly and easily with helpers, simply run the command /denizen debug -r in-game to begin recording, then run through the part of the script you need help with, then run the command /denizen submit. This will give you a link to a paste of the debug log, which you can then copy/paste back to us!

drifting sage Oct 19, 2023, 11:21 PM

#

that’s for the arrow entity

#

they want the color of the inventory item

crude chasm Oct 19, 2023, 11:22 PM

#

oh i see

#

sorry, i misunderstood

#

thanks for letting me know

drifting sage Oct 20, 2023, 6:27 PM

#

@plain talon this can probably get the easy PR tag

plain talon Oct 20, 2023, 7:02 PM

#

Yeah probably

#

For anyone thinking about doing this - I believe it should be as simple as updating ItemColor to modern property format and convert it's checks to instanceof the ItemMeta instead of direct material checks? it seems to already use PotionMeta internally

drifting sage Nov 20, 2023, 6:50 PM

#

@oak wagon hey mr PR man you should do this one

oak wagon Nov 20, 2023, 7:00 PM

#

perchance

pure osprey Dec 12, 2023, 6:45 PM

#

isn't implemented yet?

oak wagon Dec 12, 2023, 6:55 PM

#

pr is open, just haven't yet gotten around to fixing all of the review comments

oak wagon Dec 12, 2023, 8:00 PM

#

well, there's only one that needs to really be addressed, not sure if anything else will be commented after i commit the change

oak wagon Apr 11, 2024, 12:30 PM

#

added ref: #commit-log message

@pseudo lava

cerulean sandBOT May 11, 2024, 6:26 PM

#

Thread Closing Reminder

Has your issue been resolved, or your question been answered?
If so, please use the </resolved:1028673926114594866> command to close your thread.
Or </invalid:1028673926898909185> if it's not possible to resolve.

If not yet resolved, please reply below to tell us what you still need.

(Note that if there is no reply for a few days, this thread will eventually close itself.)

#

@pseudo lava

#(udnek) tipped arrow color